Rob Bradford
cc4422d58b
vm-device: bus: Fix incorrect partial_cmp implementation
...
warning: incorrect implementation of `partial_cmp` on an `Ord` type
--> vm-device/src/bus.rs:86:1
|
86 | / impl PartialOrd for BusRange {
87 | | fn partial_cmp(&self, other: &BusRange) -> Option<Ordering> {
| | _________________________________________________________________-
88 | || self.base.partial_cmp(&other.base)
89 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
90 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
= note: `#[warn(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2023-08-22 12:01:54 +01:00
Rob Bradford
89e658d9ff
misc: Update for beta clippy failures on x86-64
...
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2023-05-30 07:18:17 -07:00
Rob Bradford
5e52729453
misc: Automatically fix cargo clippy issues added in 1.65 (stable)
...
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2022-12-14 14:27:19 +00:00
Rob Bradford
2716bc3311
build: Fix beta clippy issue (derive_partial_eq_without_eq)
...
warning: you are deriving `PartialEq` and can implement `Eq`
--> vmm/src/serial_manager.rs:59:30
|
59 | #[derive(Debug, Clone, Copy, PartialEq)]
| ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2022-06-30 20:50:45 +01:00
Wei Liu
d4eaf746b5
vm-device: bus: drop the interrupt function
...
It is not used anywhere.
Signed-off-by: Wei Liu <liuwe@microsoft.com >
2021-04-13 14:18:14 +01:00
Rob Bradford
a8643dc523
vm-device, vmm: Wait for barrier if one is returned
...
Wait for the barrier if one is provided by the result of the MMIO and
PIO write.
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2020-12-17 11:23:53 +00:00
Rob Bradford
1fc6d50f3e
misc: Make Bus::write() return an Option<Arc<Barrier>>
...
This can be uses to indicate to the caller that it should wait on the
barrier before returning as there is some asynchronous activity
triggered by the write which requires the KVM exit to block until it's
completed.
This is useful for having vCPU thread wait for the VMM thread to proceed
to activate the virtio devices.
See #1863
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2020-12-17 11:23:53 +00:00
Rob Bradford
74fe032827
vm-device: bus: Fix clippy issues inside tests
...
Found by: cargo clippy --all-features --all --tests
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2020-11-26 09:32:46 +01:00
Rob Bradford
9fc2613b41
vm-device: bus: Remove unwrap() when upgrading weak reference
...
Rather return the None to the caller to handle instead. This removes the
source of a potential panic.
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2020-11-25 01:27:26 +01:00
Rob Bradford
15025d71b1
devices, vm-device: Move BusDevice and Bus into vm-device
...
This removes the dependency of the pci crate on the devices crate which
now only contains the device implementations themselves.
Signed-off-by: Rob Bradford <robert.bradford@intel.com >
2020-09-10 09:35:38 +01:00
