Philipp Schuster
363273111a
build: treewide: fmt for edition 2024
...
`cargo +nightly fmt`
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de >
On-behalf-of: SAP philipp.schuster@sap.com
2025-09-10 18:35:38 +00:00
Philipp Schuster
061351d82d
build: upgrade whole* workspace to Rust edition 2024
...
This upgrades the Cargo workspace to Rust edition 2024 to keep the
code base clean and up to date.
The commit only contains the adjustments to the Cargo.toml files and
basic compiler error fixes. Also, this commit includes new SAFETY
comments as discussed in [1]. The changes were not automatically
fixed by `cargo fix --edition` but needed manual adjustments.
Apart from that, all formatting and clippy adjustments follow in
subsequent commits.
*
As only exception, workspace member net_gen sticks to edition 2021
for now as discussed in [0].
[0] https://github.com/cloud-hypervisor/cloud-hypervisor/pull/7295#discussion_r2310851041
[1] https://github.com/cloud-hypervisor/cloud-hypervisor/pull/7256#issuecomment-3271888674
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de >
On-behalf-of: SAP philipp.schuster@sap.com
2025-09-10 18:35:38 +00:00
Oliver Anderson
8c136041cb
build: Use workspace dependencies
...
Many of the workspace members in the Cloud-hypervisor workspace share
common dependencies. Making these workspace dependencies reduces
duplication and improves maintainability.
Signed-off-by: Oliver Anderson <oliver.anderson@cyberus-technology.de >
On-behalf-of: SAP oliver.anderson@sap.com
2025-07-28 20:19:27 +00:00
Wei Liu
5716af09a5
vhost_user_block: Use Mutex::get_mut() where possible
...
Signed-off-by: Wei Liu <liuwe@microsoft.com >
2025-07-17 19:20:59 +00:00
Songqian Li
e32fa593e5
build: clean up unused dependencies
...
Signed-off-by: Songqian Li <sionli@tencent.com >
2025-07-15 07:16:36 +00:00
Maximilian Güntner
6ba949d741
build: consolidate env_logger to workspace, update to 0.11.8
...
Signed-off-by: Maximilian Güntner <code@mguentner.de >
2025-07-10 16:36:54 +00:00
Philipp Schuster
ed63b352d1
misc: vhost_user_block: streamline error Display::fmt()
...
The changes were mostly automatically applied using the Python
script mentioned in the first commit of this series.
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de >
On-behalf-of: SAP philipp.schuster@sap.com
2025-06-13 19:55:54 +00:00
Philipp Schuster
20296e909a
misc: streamline thiserror cargo dep
...
As almost every sub crate depends on thiserror, lets upgrade it to a
workspace dependency.
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de >
On-behalf-of: SAP philipp.schuster@sap.com
2025-05-28 17:24:34 +00:00
Philipp Schuster
eb0b14f70e
misc: vhost_user_block: streamline #[source] and Error
...
This streamlines the code base to follow best practices for
error handling in Rust: Each error struct implements
std::error::Error (most due via thiserror::Error derive macro)
and sets its source accordingly.
This allows future work that nicely prints the error chains,
for example.
So far, the convention is that each error prints its
sub error as part of its Display::fmt() impl.
Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de >
On-behalf-of: SAP philipp.schuster@sap.com
2025-05-21 09:09:30 +00:00
Jinank Jain
ea4693a091
misc: Fix clippy error from beta compiler
...
Rust has a new way of constructing other error and clippy complains if
we are still using the older way to construct error message. Thus,
migrate to the new approach suggested by the clippy.
Warning from beta compiler:
error: this can be `std::io::Error::other(_)`
--> block/src/vhdx/mod.rs:142:17
|
| / std::io::Error::new(
| | std::io::ErrorKind::Other,
| | format!("Failed to update VHDx header: {e}"),
| | )
| |_________________^
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
std::io::Error::other(
format!("Failed to update VHDx header: {e}"),
Signed-off-by: Jinank Jain <jinankjain@microsoft.com >
2025-04-03 13:11:49 +00:00
Rob Bradford
21f05ebb4f
vhost_user_block: Automatically fix operator precedence clippy warning
...
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2025-01-07 17:44:41 +00:00
dependabot[bot]
30cf1eed5e
build: Bump libc from 0.2.158 to 0.2.167
...
Bumps [libc](https://github.com/rust-lang/libc ) from 0.2.158 to 0.2.167.
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.167/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.158...0.2.167 )
---
updated-dependencies:
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-12-03 01:15:36 +00:00
Ruoqing He
894a4dee6e
build: Centralize vhost-user-backend to workspace
...
`vhost-user-backend` is left behind in #6764 , move it to root workspace.
Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn >
2024-11-02 08:08:51 +00:00
Ruoqing He
61e57e1cb1
misc: Further improve imports styling
...
By introducing `imports_granularity="Module"` format strategy,
effectively groups imports from the same module into one line or block,
improving maintainability and readability.
Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn >
2024-09-29 16:13:48 +00:00
Rob Bradford
88a9f79944
misc: Adapt consistent import style formatting
...
Historically the Cloud Hypervisor coding style has been to ensure that
all imports are ordered and placed in a single group. Unfortunately
cargo fmt has no support for ensuring that all imports are in a single
group so if whitespace lines were added as part of the import statements
then they would only be odered correctly in the group.
By adopting "group_imports="StdExternalCrate" we can enforce a style
where imports are placed in at most three groups for std, external
crates and the crate itself. Choosing a style enforceable by the tooling
reduces the reviewer burden.
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-09-29 13:08:12 +01:00
Ruoqing He
5a70d7ec69
build: Centralize rust-vmm crates to workspace
...
Modify `Cargo.toml` in each member crate to follow the dependencies
specified in root `Cargo.toml` file.
Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn >
2024-09-27 15:58:21 +00:00
Rob Bradford
d90fa96bb7
build: Bulk update vm-memory and related dependencies
...
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-09-26 12:31:25 +00:00
dependabot[bot]
68468b8519
build: Bump libc from 0.2.155 to 0.2.158
...
Bumps [libc](https://github.com/rust-lang/libc ) from 0.2.155 to 0.2.158.
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.158/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.155...0.2.158 )
---
updated-dependencies:
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-06 00:04:34 +00:00
dependabot[bot]
5f814308d6
build: Bump clap from 4.5.4 to 4.5.13
...
Bumps [clap](https://github.com/clap-rs/clap ) from 4.5.4 to 4.5.13.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.5.4...clap_complete-v4.5.13 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-20 00:02:25 +00:00
dependabot[bot]
fee769bed4
build: Bump libc from 0.2.153 to 0.2.155
...
Bumps [libc](https://github.com/rust-lang/libc ) from 0.2.153 to 0.2.155.
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.153...0.2.155 )
---
updated-dependencies:
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-10 00:43:15 +00:00
dependabot[bot]
dec4a82058
build: Bump log from 0.4.21 to 0.4.22
...
Bumps [log](https://github.com/rust-lang/log ) from 0.4.21 to 0.4.22.
- [Release notes](https://github.com/rust-lang/log/releases )
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/log/compare/0.4.21...0.4.22 )
---
updated-dependencies:
- dependency-name: log
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-16 06:20:32 +00:00
Changyuan Lyu
bc6acb842f
block: fix status value size
...
As per VirtIO spec 1.2 section 5.2.6, the `status` field is a byte, not
u32. cloud-hypervisor writes an `u32` to guest memory, which
accidentally zeros out the following 3 bytes, and may corrupt guest OS
internal state.
Signed-off-by: Changyuan Lyu <changyuanl@google.com >
2024-07-14 19:23:06 +00:00
Rob Bradford
08cf983d42
build: Fix Cargo.toml formatting
...
In 42e9632c53 a fix was made to address a
typo in the taplo configuration file. Fixing this typo indicated that
many Cargo.toml files were no longer adhering to the formatting rules.
Fix the formatting by running `taplo fmt`.
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-06-18 16:19:12 +00:00
Rob Bradford
3f8cd52ffd
build: Format Cargo.toml files using taplo
...
Run the taplo formatter with the newly added configuration file
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-05-08 21:46:13 +00:00
Rob Bradford
d10f20eb71
build: Bump vhost-user-backend, vhost, and virtio-queue
...
Update the vhost-user-backend crate version used along with related
crates (vhost and virtio-queue.) This requires minor changes to the
types used for the memory in the backends with the use of the
BitmapMmapRegion type for the Bitmap implementation.
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-05-01 18:29:36 +00:00
dependabot[bot]
533710f0cd
build: Bump env_logger from 0.10.2 to 0.11.3
...
Bumps [env_logger](https://github.com/rust-cli/env_logger ) from 0.10.2 to 0.11.3.
- [Release notes](https://github.com/rust-cli/env_logger/releases )
- [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-cli/env_logger/compare/v0.10.2...v0.11.3 )
---
updated-dependencies:
- dependency-name: env_logger
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-18 00:29:58 +00:00
Rob Bradford
7966925c1c
build: Bulk update dependencies
...
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-04-06 09:48:25 +00:00
dependabot[bot]
fa7a000dbe
build: Bump vm-memory from 0.14.0 to 0.14.1
...
Bumps [vm-memory](https://github.com/rust-vmm/vm-memory ) from 0.14.0 to 0.14.1.
- [Release notes](https://github.com/rust-vmm/vm-memory/releases )
- [Changelog](https://github.com/rust-vmm/vm-memory/blob/v0.14.1/CHANGELOG.md )
- [Commits](https://github.com/rust-vmm/vm-memory/compare/v0.14.0...v0.14.1 )
---
updated-dependencies:
- dependency-name: vm-memory
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-03 07:19:10 +00:00
dependabot[bot]
d3fade85a7
build: Bump clap from 4.4.7 to 4.5.1
...
Bumps [clap](https://github.com/clap-rs/clap ) from 4.4.7 to 4.5.1.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/clap_complete-v4.4.7...clap_complete-v4.5.1 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-01 07:25:13 +00:00
Chris Webb
0310c5726f
main: Show help text when run without arguments
...
cloud-hypervisor, ch-remote, vhost-user-block and vhost-user-net all
need at least one argument to do anything useful, so printing command
help is helpful when they are run without arguments or a subcommand.
Use clap::Command::arg_required_else_help(true) to do this.
Signed-off-by: Chris Webb <chris@arachsys.com >
2024-02-24 09:35:37 +00:00
Rob Bradford
adb318f4cd
misc: Remove redundant "use" imports
...
With the nightly toolchain (2024-02-18) cargo check will flag up
redundant imports either because they are pulled in by the prelude on
earlier match.
Remove those redundant imports.
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-02-19 17:54:30 +00:00
dependabot[bot]
5641e3a283
build: Bump libc from 0.2.151 to 0.2.153
...
Bumps [libc](https://github.com/rust-lang/libc ) from 0.2.151 to 0.2.153.
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.151...0.2.153 )
---
updated-dependencies:
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-08 09:51:55 +00:00
Rob Bradford
107f4bdc12
vhost_user_block: Allow dead_code for embedded error
...
The embedded error in the enum will be read on debug output of the
error.
Fixes beta clippy issue:
warning: field `0` is never read
--> vhost_user_block/src/lib.rs:64:23
|
64 | CreateKillEventFd(io::Error),
| ----------------- ^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
64 | CreateKillEventFd(()),
| ~~
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2024-02-07 09:25:40 +00:00
Bo Chen
3ce0fef7fd
build: Bump vmm-sys-util crate and its consumers
...
This patch bumps the following crates, including `kvm-bindings@0.7.0`*,
`kvm-ioctls@0.16 .0`**, `linux-loader@0.11 .0`, `versionize@0.2.0`,
`versionize_derive@0.1.6`***, `vhost@0.10 .0`,
`vhost-user-backend@0.13 .1`, `virtio-queue@0.11 .0`, `vm-memory@0.14 .0`,
`vmm-sys-util@0.12 .1`, and the latest of `vfio-bindings`, `vfio-ioctls`,
`mshv-bindings`,`mshv-ioctls`, and `vfio-user`.
* A fork of the `kvm-bindings` crate is being used to support
serialization of various structs for migration [1]. Also, code changes
are made to accommodate the updated `struct xsave` from the Linux
kernel. Note: these changes related to `struct xsave` break
live-upgrade.
** The new `kvm-ioctls` crate introduced breaking changes for
the `get/set_one_reg` API on `aarch64` [2], so code changes are made to
the new APIs.
*** A fork of the `versionize_derive` crate is being used to support
versionize on packed structs [3].
[1] https://github.com/cloud-hypervisor/kvm-bindings/tree/ch-v0.7.0
[2] https://github.com/rust-vmm/kvm-ioctls/pull/223
[3] https://github.com/cloud-hypervisor/versionize_derive/tree/ch-0.1.6
Fixes : #6072
Signed-off-by: Bo Chen <chen.bo@intel.com >
2024-01-25 10:14:54 +00:00
dependabot[bot]
82a3664139
build: Bump env_logger from 0.10.0 to 0.10.1
...
Bumps [env_logger](https://github.com/rust-cli/env_logger ) from 0.10.0 to 0.10.1.
- [Release notes](https://github.com/rust-cli/env_logger/releases )
- [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-cli/env_logger/compare/v0.10.0...v0.10.1 )
---
updated-dependencies:
- dependency-name: env_logger
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-15 17:46:09 +00:00
dependabot[bot]
81b30bf390
build: Bump log from 0.4.17 to 0.4.20
...
Bumps [log](https://github.com/rust-lang/log ) from 0.4.17 to 0.4.20.
- [Release notes](https://github.com/rust-lang/log/releases )
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/log/compare/0.4.17...0.4.20 )
---
updated-dependencies:
- dependency-name: log
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-24 08:47:05 +00:00
Bo Chen
4d7a4c598a
build: Upgrade vm-memory crates and its consumers
...
Signed-off-by: Bo Chen <chen.bo@intel.com >
2023-11-14 09:17:42 +00:00
dependabot[bot]
815c7f45c4
build: Bump clap from 4.3.11 to 4.4.7
...
Bumps [clap](https://github.com/clap-rs/clap ) from 4.3.11 to 4.4.7.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v4.3.11...v4.4.7 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-08 17:01:37 -08:00
Ravi kumar Veeramally
f160ba41b5
vhost_user_blk: switch to clap
...
Signed-off-by: Ravi kumar Veeramally <ravikumar.veeramally@intel.com >
2023-10-20 11:44:28 -07:00
Thomas Barrett
c4e8e653ac
block: Add support for user specified ID_SERIAL
...
Signed-off-by: Thomas Barrett <tbarrett@crusoeenergy.com >
2023-09-11 12:50:41 +01:00
Rob Bradford
07d1208dd5
build: Bump vm-memory and its consumers
...
Update to the latest vm-memory and all the crates that also depend upon
it.
Fix some deprecation warnings.
Signed-off-by: Rob Bradford <rbradford@rivosinc.com >
2023-09-07 11:34:51 -07:00
dependabot[bot]
2571e59438
build: Bump libc from 0.2.144 to 0.2.147
...
Bumps [libc](https://github.com/rust-lang/libc ) from 0.2.144 to 0.2.147.
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.144...0.2.147 )
---
updated-dependencies:
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-15 00:53:20 +00:00
Yu Li
447cad3861
block: merge qcow, vhdx and block_util into block crate
...
This commit merges crates `qcow`, `vhdx` and `block_util` into the
crate `block`, which can allow `qcow` to use functions from `block_util`
without introducing a circular crate dependency.
This commit is based on crosvm implementation:
f2eecc4152
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com >
2023-07-19 13:52:43 +01:00
dependabot[bot]
aa13ede316
build: Bump epoll from 4.3.1 to 4.3.3
...
Bumps [epoll](https://github.com/nathansizemore/epoll ) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/nathansizemore/epoll/releases )
- [Commits](https://github.com/nathansizemore/epoll/compare/4.3.1...4.3.3 )
---
updated-dependencies:
- dependency-name: epoll
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-05 09:23:19 +01:00
Bo Chen
3b39c41a01
build: Bulk update rust-vmm dependencies
...
Bump to the latest rust-vmm crates, including vm-memory, vfio,
vfio-bindings, vfio-user, virtio-bindings, virtio-queue, linux-loader,
vhost, and vhost-user-backend,
Signed-off-by: Bo Chen <chen.bo@intel.com >
2023-06-08 13:15:25 +01:00
Omer Faruk Bayram
59012ccc6e
build: rename BUILT_VERSION to BUILD_VERSION
...
Signed-off-by: Omer Faruk Bayram <omer.faruk@sartura.hr >
2023-04-14 12:13:46 -07:00
dependabot[bot]
04ee1efa70
build: Bump virtio-queue from 0.7.0 to 0.7.1
...
Bumps [virtio-queue](https://github.com/rust-vmm/vm-virtio ) from 0.7.0 to 0.7.1.
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases )
- [Commits](https://github.com/rust-vmm/vm-virtio/compare/virtio-queue-v0.7.0...virtio-queue-v0.7.1 )
---
updated-dependencies:
- dependency-name: virtio-queue
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-01 00:37:27 +00:00
dependabot[bot]
1d55de9c74
build: Bump virtio-bindings from 0.1.0 to 0.2.0
...
Bumps [virtio-bindings](https://github.com/rust-vmm/vm-virtio ) from 0.1.0 to 0.2.0.
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases )
- [Commits](https://github.com/rust-vmm/vm-virtio/compare/virtio-queue-v0.1.0...virtio-bindings-v0.2.0 )
---
updated-dependencies:
- dependency-name: virtio-bindings
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-23 00:59:32 +00:00
Wei Liu
b0a2ce0598
vhost_user_block: add --version
...
Signed-off-by: Wei Liu <liuwe@microsoft.com >
2023-01-16 16:39:03 +00:00
Wei Liu
54e9ed9932
vhost_user_blk: switch to argh
...
Signed-off-by: Wei Liu <liuwe@microsoft.com >
2023-01-16 16:39:03 +00:00