// Copyright © 2021 Intel Corporation // // SPDX-License-Identifier: Apache-2.0 use std::collections::VecDeque; use std::fs::File; use std::os::fd::AsRawFd; use std::sync::{Arc, Mutex}; use vmm_sys_util::eventfd::EventFd; use crate::async_io::{ AsyncIo, AsyncIoError, AsyncIoResult, BorrowedDiskFd, DiskFile, DiskFileError, DiskFileResult, }; use crate::vhdx::{Result as VhdxResult, Vhdx}; use crate::{AsyncAdaptor, BlockBackend, Error}; pub struct VhdxDiskSync { // FIXME: The Mutex serializes all VHDX I/O operations across queues, which // is necessary for correctness but eliminates any parallelism benefit from // multiqueue. Vhdx::clone() shares the underlying file description across // threads, so concurrent I/O from multiple queues races on the file offset // causing data corruption. // // A proper fix would require restructuring the VHDX I/O path so that data // operations can proceed in parallel with independent file descriptors. vhdx_file: Arc>, } impl VhdxDiskSync { pub fn new(f: File) -> VhdxResult { Ok(VhdxDiskSync { vhdx_file: Arc::new(Mutex::new(Vhdx::new(f)?)), }) } } impl DiskFile for VhdxDiskSync { fn logical_size(&mut self) -> DiskFileResult { Ok(self.vhdx_file.lock().unwrap().virtual_disk_size()) } fn physical_size(&mut self) -> DiskFileResult { self.vhdx_file.lock().unwrap().physical_size().map_err(|e| { let io_inner = match e { Error::GetFileMetadata(e) => e, _ => unreachable!(), }; DiskFileError::Size(io_inner) }) } fn new_async_io(&self, _ring_depth: u32) -> DiskFileResult> { Ok(Box::new(VhdxSync::new(Arc::clone(&self.vhdx_file))) as Box) } fn fd(&mut self) -> BorrowedDiskFd<'_> { BorrowedDiskFd::new(self.vhdx_file.lock().unwrap().as_raw_fd()) } } pub struct VhdxSync { vhdx_file: Arc>, eventfd: EventFd, completion_list: VecDeque<(u64, i32)>, } impl VhdxSync { pub fn new(vhdx_file: Arc>) -> Self { VhdxSync { vhdx_file, eventfd: EventFd::new(libc::EFD_NONBLOCK) .expect("Failed creating EventFd for VhdxSync"), completion_list: VecDeque::new(), } } } impl AsyncAdaptor for Vhdx {} impl AsyncIo for VhdxSync { fn notifier(&self) -> &EventFd { &self.eventfd } fn read_vectored( &mut self, offset: libc::off_t, iovecs: &[libc::iovec], user_data: u64, ) -> AsyncIoResult<()> { self.vhdx_file.lock().unwrap().read_vectored_sync( offset, iovecs, user_data, &self.eventfd, &mut self.completion_list, ) } fn write_vectored( &mut self, offset: libc::off_t, iovecs: &[libc::iovec], user_data: u64, ) -> AsyncIoResult<()> { self.vhdx_file.lock().unwrap().write_vectored_sync( offset, iovecs, user_data, &self.eventfd, &mut self.completion_list, ) } fn fsync(&mut self, user_data: Option) -> AsyncIoResult<()> { self.vhdx_file.lock().unwrap().fsync_sync( user_data, &self.eventfd, &mut self.completion_list, ) } fn next_completed_request(&mut self) -> Option<(u64, i32)> { self.completion_list.pop_front() } fn punch_hole(&mut self, _offset: u64, _length: u64, _user_data: u64) -> AsyncIoResult<()> { Err(AsyncIoError::PunchHole(std::io::Error::other( "punch_hole not supported for VHDX", ))) } fn write_zeroes(&mut self, _offset: u64, _length: u64, _user_data: u64) -> AsyncIoResult<()> { Err(AsyncIoError::WriteZeroes(std::io::Error::other( "write_zeroes not supported for VHDX", ))) } }