Daniel Verkamp 494c30be19 block: Avoid unsafe Vec construction in detect_image_type() ...

The `read_aligned_block_size()` function used `Vec::from_raw_parts()`
incorrectly, causing undefined behavior when deallocating the `Vec<u8>`.

One of the safety invariants of `Vec::from_raw_parts()` is that the
provided pointer must be allocated with the exact same alignment as `T`
(`u8` in this case), but this is clearly not true: `align_of::<u8>()` is
1, but the pointer was allocated with aligment of `blocksize` (typically
512 or greater).

Fix this by using the existing `AlignedFile` helper to read the header
block when probing the image type. This is slightly less efficient than
using `AlignedBuffer` directly, but since this is only called once per
disk image at startup, the difference is probably not worth the extra
verbosity.

Signed-off-by: Daniel Verkamp <drv@meta.com>

2026-06-29 23:26:17 +00:00

..

src

block: Avoid unsafe Vec construction in detect_image_type()

2026-06-29 23:26:17 +00:00

Cargo.toml

performance-metrics: Switch to QcowDisk

2026-06-08 13:19:32 +00:00