mirror of
https://github.com/cloud-hypervisor/cloud-hypervisor.git
synced 2026-08-05 02:19:16 +00:00
Request::execute and Request::execute_async checked each data descriptor against `disk_nsectors` using the request's fixed start sector. With sector = disk_nsectors-1 and N descriptors of 512 bytes each, every descriptor passed (top = disk_nsectors) but the vectored I/O collectively read/wrote N*512 bytes starting at the last sector — N-1 sectors past EOF. For the io_uring/aio raw backends this lets the guest extend the host disk image beyond its provisioned size, exhausting the host filesystem. For fixed-VHD images (footer at end of file) the same chain overwrites the footer with guest-controlled bytes, corrupting the disk image. Replace the per-descriptor check with a chain-wide check_data_bounds(). Pre-validating the entire request before beginning the operation avoids having to unroll a partial submit. Signed-off-by: Dylan Reid <dgreid@fb.com>
608 lines
24 KiB
Rust
608 lines
24 KiB
Rust
// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
|
|
//
|
|
// Portions Copyright 2017 The Chromium OS Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE-BSD-3-Clause file.
|
|
//
|
|
// Copyright © 2020 Intel Corporation
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0 AND BSD-3-Clause
|
|
|
|
use std::alloc::{Layout, alloc_zeroed, dealloc};
|
|
use std::io::{Read, Seek, SeekFrom, Write};
|
|
use std::mem;
|
|
use std::time::Instant;
|
|
|
|
use log::{error, warn};
|
|
use smallvec::SmallVec;
|
|
use virtio_bindings::virtio_blk::{
|
|
VIRTIO_BLK_T_DISCARD, VIRTIO_BLK_T_WRITE_ZEROES, VIRTIO_BLK_WRITE_ZEROES_FLAG_UNMAP,
|
|
virtio_blk_discard_write_zeroes,
|
|
};
|
|
use virtio_queue::DescriptorChain;
|
|
use vm_memory::bitmap::Bitmap;
|
|
use vm_memory::{
|
|
Address as _, Bytes as _, GuestAddress, GuestMemory as _, GuestMemoryError,
|
|
GuestMemoryLoadGuard,
|
|
};
|
|
use vm_virtio::{AccessPlatform, Translatable as _};
|
|
|
|
use crate::async_io::AsyncIo;
|
|
use crate::{Error, ExecuteError, request_type, sector};
|
|
|
|
const SECTOR_SHIFT: u8 = 9;
|
|
pub const SECTOR_SIZE: u64 = 0x01 << SECTOR_SHIFT;
|
|
|
|
/// Maximum number of segments per DISCARD or WRITE_ZEROES request.
|
|
pub const MAX_DISCARD_WRITE_ZEROES_SEG: u32 = 1;
|
|
/// Size and field offsets within `struct virtio_blk_discard_write_zeroes`.
|
|
const DISCARD_WZ_SEG_SIZE: u32 = mem::size_of::<virtio_blk_discard_write_zeroes>() as u32;
|
|
const DISCARD_WZ_MAX_PAYLOAD: u32 = DISCARD_WZ_SEG_SIZE * MAX_DISCARD_WRITE_ZEROES_SEG;
|
|
const DISCARD_WZ_SECTOR_OFFSET: u64 =
|
|
mem::offset_of!(virtio_blk_discard_write_zeroes, sector) as u64;
|
|
const DISCARD_WZ_NUM_SECTORS_OFFSET: u64 =
|
|
mem::offset_of!(virtio_blk_discard_write_zeroes, num_sectors) as u64;
|
|
const DISCARD_WZ_FLAGS_OFFSET: u64 = mem::offset_of!(virtio_blk_discard_write_zeroes, flags) as u64;
|
|
#[derive(Debug)]
|
|
pub struct AlignedOperation {
|
|
origin_ptr: u64,
|
|
aligned_ptr: u64,
|
|
size: usize,
|
|
layout: Layout,
|
|
}
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
|
|
pub enum RequestType {
|
|
In,
|
|
Out,
|
|
Flush,
|
|
GetDeviceId,
|
|
Discard,
|
|
WriteZeroes,
|
|
Unsupported(u32),
|
|
}
|
|
|
|
pub const DEFAULT_DESCRIPTOR_VEC_SIZE: usize = 32;
|
|
pub struct BatchRequest {
|
|
pub offset: libc::off_t,
|
|
pub iovecs: SmallVec<[libc::iovec; DEFAULT_DESCRIPTOR_VEC_SIZE]>,
|
|
pub user_data: u64,
|
|
pub request_type: RequestType,
|
|
}
|
|
|
|
pub struct ExecuteAsync {
|
|
// `true` if the execution will complete asynchronously
|
|
pub async_complete: bool,
|
|
// request need to be batched for submission if any
|
|
pub batch_request: Option<BatchRequest>,
|
|
}
|
|
|
|
#[derive(Debug)]
|
|
pub struct Request {
|
|
request_type: RequestType,
|
|
sector: u64,
|
|
data_descriptors: SmallVec<[(GuestAddress, u32); DEFAULT_DESCRIPTOR_VEC_SIZE]>,
|
|
status_addr: GuestAddress,
|
|
pub writeback: bool,
|
|
aligned_operations: SmallVec<[AlignedOperation; DEFAULT_DESCRIPTOR_VEC_SIZE]>,
|
|
start: Instant,
|
|
}
|
|
|
|
impl Request {
|
|
pub fn parse<B: Bitmap + 'static>(
|
|
desc_chain: &mut DescriptorChain<GuestMemoryLoadGuard<vm_memory::GuestMemoryMmap<B>>>,
|
|
access_platform: Option<&dyn AccessPlatform>,
|
|
) -> Result<Request, Error> {
|
|
let hdr_desc = desc_chain
|
|
.next()
|
|
.ok_or(Error::DescriptorChainTooShort)
|
|
.inspect_err(|_| {
|
|
error!("Missing head descriptor");
|
|
})?;
|
|
|
|
// The head contains the request type which MUST be readable.
|
|
if hdr_desc.is_write_only() {
|
|
return Err(Error::UnexpectedWriteOnlyDescriptor);
|
|
}
|
|
|
|
let hdr_desc_addr = hdr_desc
|
|
.addr()
|
|
.translate_gva(access_platform, hdr_desc.len() as usize)
|
|
.map_err(|e| Error::GuestMemory(GuestMemoryError::IOError(e)))?;
|
|
|
|
let mut req = Request {
|
|
request_type: request_type(desc_chain.memory(), hdr_desc_addr)?,
|
|
sector: sector(desc_chain.memory(), hdr_desc_addr)?,
|
|
data_descriptors: SmallVec::with_capacity(DEFAULT_DESCRIPTOR_VEC_SIZE),
|
|
status_addr: GuestAddress(0),
|
|
writeback: true,
|
|
aligned_operations: SmallVec::with_capacity(DEFAULT_DESCRIPTOR_VEC_SIZE),
|
|
start: Instant::now(),
|
|
};
|
|
|
|
let status_desc;
|
|
let mut desc = desc_chain
|
|
.next()
|
|
.ok_or(Error::DescriptorChainTooShort)
|
|
.inspect_err(|_| {
|
|
error!("Only head descriptor present: request = {req:?}");
|
|
})?;
|
|
|
|
if desc.has_next() {
|
|
req.data_descriptors.reserve_exact(1);
|
|
while desc.has_next() {
|
|
if desc.is_write_only() && req.request_type == RequestType::Out {
|
|
return Err(Error::UnexpectedWriteOnlyDescriptor);
|
|
}
|
|
if desc.is_write_only() && req.request_type == RequestType::Discard {
|
|
return Err(Error::UnexpectedWriteOnlyDescriptor);
|
|
}
|
|
if desc.is_write_only() && req.request_type == RequestType::WriteZeroes {
|
|
return Err(Error::UnexpectedWriteOnlyDescriptor);
|
|
}
|
|
if !desc.is_write_only() && req.request_type == RequestType::In {
|
|
return Err(Error::UnexpectedReadOnlyDescriptor);
|
|
}
|
|
if !desc.is_write_only() && req.request_type == RequestType::GetDeviceId {
|
|
return Err(Error::UnexpectedReadOnlyDescriptor);
|
|
}
|
|
|
|
req.data_descriptors.push((
|
|
desc.addr()
|
|
.translate_gva(access_platform, desc.len() as usize)
|
|
.map_err(|e| Error::GuestMemory(GuestMemoryError::IOError(e)))?,
|
|
desc.len(),
|
|
));
|
|
desc = desc_chain
|
|
.next()
|
|
.ok_or(Error::DescriptorChainTooShort)
|
|
.inspect_err(|_| {
|
|
error!("DescriptorChain corrupted: request = {req:?}");
|
|
})?;
|
|
}
|
|
status_desc = desc;
|
|
} else {
|
|
status_desc = desc;
|
|
// Only flush requests are allowed to skip the data descriptor.
|
|
if req.request_type != RequestType::Flush {
|
|
error!("Need a data descriptor: request = {req:?}");
|
|
return Err(Error::DescriptorChainTooShort);
|
|
}
|
|
}
|
|
|
|
// The status MUST always be writable.
|
|
if !status_desc.is_write_only() {
|
|
return Err(Error::UnexpectedReadOnlyDescriptor);
|
|
}
|
|
|
|
if status_desc.len() < 1 {
|
|
return Err(Error::DescriptorLengthTooSmall);
|
|
}
|
|
|
|
req.status_addr = status_desc
|
|
.addr()
|
|
.translate_gva(access_platform, status_desc.len() as usize)
|
|
.map_err(|e| Error::GuestMemory(GuestMemoryError::IOError(e)))?;
|
|
|
|
Ok(req)
|
|
}
|
|
|
|
pub fn execute<T: Seek + Read + Write, B: Bitmap + 'static>(
|
|
&self,
|
|
disk: &mut T,
|
|
disk_nsectors: u64,
|
|
mem: &vm_memory::GuestMemoryMmap<B>,
|
|
serial: &[u8],
|
|
) -> Result<u32, ExecuteError> {
|
|
self.check_data_bounds(disk_nsectors)?;
|
|
|
|
disk.seek(SeekFrom::Start(self.sector << SECTOR_SHIFT))
|
|
.map_err(ExecuteError::Seek)?;
|
|
let mut len = 0;
|
|
for (data_addr, data_len) in &self.data_descriptors {
|
|
match self.request_type {
|
|
RequestType::In => {
|
|
let mut buf = vec![0u8; *data_len as usize];
|
|
disk.read_exact(&mut buf).map_err(ExecuteError::ReadExact)?;
|
|
mem.read_exact_volatile_from(
|
|
*data_addr,
|
|
&mut buf.as_slice(),
|
|
*data_len as usize,
|
|
)
|
|
.map_err(ExecuteError::Read)?;
|
|
len += data_len;
|
|
}
|
|
RequestType::Out => {
|
|
let mut buf: Vec<u8> = Vec::new();
|
|
mem.write_all_volatile_to(*data_addr, &mut buf, *data_len as usize)
|
|
.map_err(ExecuteError::Write)?;
|
|
disk.write_all(&buf).map_err(ExecuteError::WriteAll)?;
|
|
if !self.writeback {
|
|
disk.flush().map_err(ExecuteError::Flush)?;
|
|
}
|
|
}
|
|
RequestType::Flush => disk.flush().map_err(ExecuteError::Flush)?,
|
|
RequestType::GetDeviceId => {
|
|
if (*data_len as usize) < serial.len() {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
mem.write_slice(serial, *data_addr)
|
|
.map_err(ExecuteError::Write)?;
|
|
}
|
|
RequestType::Discard => {
|
|
return Err(ExecuteError::Unsupported(VIRTIO_BLK_T_DISCARD));
|
|
}
|
|
RequestType::WriteZeroes => {
|
|
return Err(ExecuteError::Unsupported(VIRTIO_BLK_T_WRITE_ZEROES));
|
|
}
|
|
RequestType::Unsupported(t) => return Err(ExecuteError::Unsupported(t)),
|
|
}
|
|
}
|
|
Ok(len)
|
|
}
|
|
|
|
pub fn execute_async<B: Bitmap + 'static>(
|
|
&mut self,
|
|
mem: &vm_memory::GuestMemoryMmap<B>,
|
|
disk_nsectors: u64,
|
|
disk_image: &mut dyn AsyncIo,
|
|
serial: &[u8],
|
|
disable_sector0_writes: bool,
|
|
user_data: u64,
|
|
) -> Result<ExecuteAsync, ExecuteError> {
|
|
let sector = self.sector;
|
|
let request_type = self.request_type;
|
|
let offset = (sector << SECTOR_SHIFT) as libc::off_t;
|
|
let alignment = disk_image.alignment();
|
|
|
|
self.check_data_bounds(disk_nsectors)?;
|
|
|
|
let mut iovecs: SmallVec<[libc::iovec; DEFAULT_DESCRIPTOR_VEC_SIZE]> =
|
|
SmallVec::with_capacity(self.data_descriptors.len());
|
|
for &(data_addr, data_len) in &self.data_descriptors {
|
|
let _: u32 = data_len; // compiler-checked documentation
|
|
const _: () = assert!(
|
|
core::mem::size_of::<u32>() <= core::mem::size_of::<usize>(),
|
|
"unsupported platform"
|
|
);
|
|
if data_len == 0 {
|
|
continue;
|
|
}
|
|
let data_len = data_len as usize;
|
|
|
|
let origin_ptr = mem
|
|
.get_slice(data_addr, data_len)
|
|
.map_err(ExecuteError::GetHostAddress)?;
|
|
assert!(origin_ptr.len() >= data_len);
|
|
let origin_ptr = origin_ptr.ptr_guard_mut();
|
|
|
|
// O_DIRECT requires buffer addresses to be aligned to the
|
|
// backend device's logical block size. In case it's not properly
|
|
// aligned, an intermediate buffer is created with the correct
|
|
// alignment, and a copy from/to the origin buffer is performed,
|
|
// depending on the type of operation.
|
|
let iov_base = if (origin_ptr.as_ptr() as u64).is_multiple_of(alignment) {
|
|
origin_ptr.as_ptr().cast()
|
|
} else {
|
|
let layout = Layout::from_size_align(data_len, alignment as usize).unwrap();
|
|
// SAFETY: layout has non-zero size
|
|
let aligned_ptr = unsafe { alloc_zeroed(layout) };
|
|
if aligned_ptr.is_null() {
|
|
return Err(ExecuteError::TemporaryBufferAllocation(
|
|
std::io::Error::last_os_error(),
|
|
));
|
|
}
|
|
|
|
// We need to perform the copy beforehand in case we're writing
|
|
// data out.
|
|
if request_type == RequestType::Out {
|
|
// SAFETY: destination buffer has been allocated with
|
|
// the proper size.
|
|
unsafe { std::ptr::copy(origin_ptr.as_ptr(), aligned_ptr, data_len) };
|
|
}
|
|
|
|
// Store both origin and aligned pointers for complete_async()
|
|
// to process them.
|
|
self.aligned_operations.push(AlignedOperation {
|
|
origin_ptr: origin_ptr.as_ptr() as u64,
|
|
aligned_ptr: aligned_ptr as u64,
|
|
size: data_len,
|
|
layout,
|
|
});
|
|
|
|
aligned_ptr.cast()
|
|
};
|
|
|
|
let iovec = libc::iovec {
|
|
iov_base,
|
|
iov_len: data_len as libc::size_t,
|
|
};
|
|
iovecs.push(iovec);
|
|
}
|
|
|
|
let mut ret = ExecuteAsync {
|
|
async_complete: true,
|
|
batch_request: None,
|
|
};
|
|
// Queue operations expected to be submitted.
|
|
match request_type {
|
|
RequestType::In => {
|
|
for (data_addr, data_len) in &self.data_descriptors {
|
|
mem.get_slice(*data_addr, *data_len as usize)
|
|
.map_err(ExecuteError::GetHostAddress)?
|
|
.bitmap()
|
|
.mark_dirty(0, *data_len as usize);
|
|
}
|
|
if disk_image.batch_requests_enabled() {
|
|
ret.batch_request = Some(BatchRequest {
|
|
offset,
|
|
iovecs,
|
|
user_data,
|
|
request_type,
|
|
});
|
|
} else {
|
|
disk_image
|
|
.read_vectored(offset, &iovecs, user_data)
|
|
.map_err(ExecuteError::AsyncRead)?;
|
|
}
|
|
}
|
|
RequestType::Out => {
|
|
if disk_image.batch_requests_enabled() {
|
|
ret.batch_request = Some(BatchRequest {
|
|
offset,
|
|
iovecs,
|
|
user_data,
|
|
request_type,
|
|
});
|
|
} else {
|
|
disk_image
|
|
.write_vectored(offset, &iovecs, user_data)
|
|
.map_err(ExecuteError::AsyncWrite)?;
|
|
}
|
|
}
|
|
RequestType::Flush => {
|
|
disk_image
|
|
.fsync(Some(user_data))
|
|
.map_err(ExecuteError::AsyncFlush)?;
|
|
}
|
|
RequestType::GetDeviceId => {
|
|
let (data_addr, data_len) = if self.data_descriptors.len() == 1 {
|
|
(self.data_descriptors[0].0, self.data_descriptors[0].1)
|
|
} else {
|
|
return Err(ExecuteError::BadRequest(Error::TooManyDescriptors));
|
|
};
|
|
if (data_len as usize) < serial.len() {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
mem.write_slice(serial, data_addr)
|
|
.map_err(ExecuteError::Write)?;
|
|
ret.async_complete = false;
|
|
return Ok(ret);
|
|
}
|
|
RequestType::Discard => {
|
|
let (data_addr, data_len) = if self.data_descriptors.len() == 1 {
|
|
(self.data_descriptors[0].0, self.data_descriptors[0].1)
|
|
} else {
|
|
return Err(ExecuteError::BadRequest(Error::TooManyDescriptors));
|
|
};
|
|
|
|
if data_len < DISCARD_WZ_SEG_SIZE {
|
|
return Err(ExecuteError::BadRequest(Error::DescriptorLengthTooSmall));
|
|
}
|
|
if data_len > DISCARD_WZ_MAX_PAYLOAD {
|
|
return Err(ExecuteError::BadRequest(Error::TooManySegments(
|
|
data_len.div_ceil(DISCARD_WZ_SEG_SIZE),
|
|
)));
|
|
}
|
|
|
|
let mut discard_sector = [0u8; 8];
|
|
let mut discard_num_sectors = [0u8; 4];
|
|
let mut discard_flags = [0u8; 4];
|
|
|
|
let sector_addr = data_addr.checked_add(DISCARD_WZ_SECTOR_OFFSET).unwrap();
|
|
mem.read_slice(&mut discard_sector, sector_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let num_sectors_addr = data_addr
|
|
.checked_add(DISCARD_WZ_NUM_SECTORS_OFFSET)
|
|
.unwrap();
|
|
mem.read_slice(&mut discard_num_sectors, num_sectors_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let flags_addr = data_addr.checked_add(DISCARD_WZ_FLAGS_OFFSET).unwrap();
|
|
mem.read_slice(&mut discard_flags, flags_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let discard_flags = u32::from_le_bytes(discard_flags);
|
|
// Per virtio spec v1.2 reject discard if any flag is set, including unmap.
|
|
if discard_flags != 0 {
|
|
warn!("Unsupported flags {discard_flags:#x} in discard request");
|
|
return Err(ExecuteError::UnsupportedFlags {
|
|
request_type: VIRTIO_BLK_T_DISCARD,
|
|
flags: discard_flags,
|
|
});
|
|
}
|
|
|
|
let discard_sector = u64::from_le_bytes(discard_sector);
|
|
|
|
if discard_sector == 0 && disable_sector0_writes {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
|
|
let discard_num_sectors = u32::from_le_bytes(discard_num_sectors);
|
|
|
|
let top = discard_sector
|
|
.checked_add(discard_num_sectors as u64)
|
|
.ok_or(ExecuteError::BadRequest(Error::InvalidOffset))?;
|
|
if top > disk_nsectors {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
|
|
let discard_offset = discard_sector * SECTOR_SIZE;
|
|
let discard_length = (discard_num_sectors as u64) * SECTOR_SIZE;
|
|
|
|
disk_image
|
|
.punch_hole(discard_offset, discard_length, user_data)
|
|
.map_err(ExecuteError::AsyncPunchHole)?;
|
|
}
|
|
RequestType::WriteZeroes => {
|
|
let (data_addr, data_len) = if self.data_descriptors.len() == 1 {
|
|
(self.data_descriptors[0].0, self.data_descriptors[0].1)
|
|
} else {
|
|
return Err(ExecuteError::BadRequest(Error::TooManyDescriptors));
|
|
};
|
|
|
|
if data_len < DISCARD_WZ_SEG_SIZE {
|
|
return Err(ExecuteError::BadRequest(Error::DescriptorLengthTooSmall));
|
|
}
|
|
if data_len > DISCARD_WZ_MAX_PAYLOAD {
|
|
return Err(ExecuteError::BadRequest(Error::TooManySegments(
|
|
data_len.div_ceil(DISCARD_WZ_SEG_SIZE),
|
|
)));
|
|
}
|
|
|
|
let mut wz_sector = [0u8; 8];
|
|
let mut wz_num_sectors = [0u8; 4];
|
|
let mut wz_flags = [0u8; 4];
|
|
|
|
let sector_addr = data_addr.checked_add(DISCARD_WZ_SECTOR_OFFSET).unwrap();
|
|
mem.read_slice(&mut wz_sector, sector_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let num_sectors_addr = data_addr
|
|
.checked_add(DISCARD_WZ_NUM_SECTORS_OFFSET)
|
|
.unwrap();
|
|
mem.read_slice(&mut wz_num_sectors, num_sectors_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let flags_addr = data_addr.checked_add(DISCARD_WZ_FLAGS_OFFSET).unwrap();
|
|
mem.read_slice(&mut wz_flags, flags_addr)
|
|
.map_err(ExecuteError::Read)?;
|
|
|
|
let wz_sector = u64::from_le_bytes(wz_sector);
|
|
let wz_num_sectors = u32::from_le_bytes(wz_num_sectors);
|
|
|
|
let wz_flags = u32::from_le_bytes(wz_flags);
|
|
// Per virtio spec v1.2 reject write zeroes if any unknown flag is set.
|
|
if (wz_flags & !VIRTIO_BLK_WRITE_ZEROES_FLAG_UNMAP) != 0 {
|
|
warn!("Unsupported flags {wz_flags:#x} in write zeroes request");
|
|
return Err(ExecuteError::UnsupportedFlags {
|
|
request_type: VIRTIO_BLK_T_WRITE_ZEROES,
|
|
flags: wz_flags,
|
|
});
|
|
}
|
|
|
|
let wz_offset = wz_sector * SECTOR_SIZE;
|
|
if wz_offset == 0 && disable_sector0_writes {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
|
|
let top = wz_sector
|
|
.checked_add(wz_num_sectors as u64)
|
|
.ok_or(ExecuteError::BadRequest(Error::InvalidOffset))?;
|
|
if top > disk_nsectors {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
|
|
let wz_length = (wz_num_sectors as u64) * SECTOR_SIZE;
|
|
|
|
if wz_flags & VIRTIO_BLK_WRITE_ZEROES_FLAG_UNMAP != 0 {
|
|
disk_image
|
|
.punch_hole(wz_offset, wz_length, user_data)
|
|
.map_err(ExecuteError::AsyncPunchHole)?;
|
|
} else {
|
|
disk_image
|
|
.write_zeroes(wz_offset, wz_length, user_data)
|
|
.map_err(ExecuteError::AsyncWriteZeroes)?;
|
|
}
|
|
}
|
|
RequestType::Unsupported(t) => return Err(ExecuteError::Unsupported(t)),
|
|
}
|
|
|
|
Ok(ret)
|
|
}
|
|
|
|
pub fn complete_async(&mut self) -> Result<(), Error> {
|
|
for aligned_operation in self.aligned_operations.drain(..) {
|
|
// We need to perform the copy after the data has been read inside
|
|
// the aligned buffer in case we're reading data in.
|
|
if self.request_type == RequestType::In {
|
|
// SAFETY: origin buffer has been allocated with the
|
|
// proper size.
|
|
unsafe {
|
|
std::ptr::copy(
|
|
aligned_operation.aligned_ptr as *const u8,
|
|
aligned_operation.origin_ptr as *mut u8,
|
|
aligned_operation.size,
|
|
);
|
|
};
|
|
}
|
|
|
|
// Free the temporary aligned buffer.
|
|
// SAFETY: aligned_ptr was allocated by alloc_zeroed with the same
|
|
// layout
|
|
unsafe {
|
|
dealloc(
|
|
aligned_operation.aligned_ptr as *mut u8,
|
|
aligned_operation.layout,
|
|
);
|
|
};
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[inline]
|
|
pub fn data_descriptors(
|
|
&self,
|
|
) -> &SmallVec<[(GuestAddress, u32); DEFAULT_DESCRIPTOR_VEC_SIZE]> {
|
|
&self.data_descriptors
|
|
}
|
|
|
|
#[inline]
|
|
pub fn status_addr(&self) -> GuestAddress {
|
|
self.status_addr
|
|
}
|
|
|
|
#[inline]
|
|
pub fn start(&self) -> Instant {
|
|
self.start
|
|
}
|
|
|
|
#[inline]
|
|
pub fn sector(&self) -> u64 {
|
|
self.sector
|
|
}
|
|
|
|
#[inline]
|
|
pub fn request_type(&self) -> RequestType {
|
|
self.request_type
|
|
}
|
|
|
|
/// For In and Out requests, checks that the descriptors collectively fit in a backing disk of
|
|
/// the given size. Returns `Ok(())` if they fit, or `ExecuteError::BadRequest` otherwise.
|
|
fn check_data_bounds(&self, disk_nsectors: u64) -> Result<(), ExecuteError> {
|
|
if !matches!(self.request_type, RequestType::In | RequestType::Out) {
|
|
return Ok(());
|
|
}
|
|
let mut total_bytes: u64 = 0;
|
|
for (_, data_len) in &self.data_descriptors {
|
|
total_bytes = total_bytes
|
|
.checked_add(u64::from(*data_len))
|
|
.ok_or(ExecuteError::BadRequest(Error::InvalidOffset))?;
|
|
}
|
|
if total_bytes == 0 {
|
|
return Ok(());
|
|
}
|
|
let total_sectors = total_bytes.div_ceil(SECTOR_SIZE);
|
|
let end_sector = self
|
|
.sector
|
|
.checked_add(total_sectors)
|
|
.ok_or(ExecuteError::BadRequest(Error::InvalidOffset))?;
|
|
if end_sector > disk_nsectors {
|
|
return Err(ExecuteError::BadRequest(Error::InvalidOffset));
|
|
}
|
|
Ok(())
|
|
}
|
|
}
|