Daniel Verkamp 494c30be19 block: Avoid unsafe Vec construction in detect_image_type() ...

The `read_aligned_block_size()` function used `Vec::from_raw_parts()`
incorrectly, causing undefined behavior when deallocating the `Vec<u8>`.

One of the safety invariants of `Vec::from_raw_parts()` is that the
provided pointer must be allocated with the exact same alignment as `T`
(`u8` in this case), but this is clearly not true: `align_of::<u8>()` is
1, but the pointer was allocated with aligment of `blocksize` (typically
512 or greater).

Fix this by using the existing `AlignedFile` helper to read the header
block when probing the image type. This is slightly less efficient than
using `AlignedBuffer` directly, but since this is only called once per
disk image at startup, the difference is probably not worth the extra
verbosity.

Signed-off-by: Daniel Verkamp <drv@meta.com>

2026-06-29 23:26:17 +00:00

..

formats

block: Add unit tests for qcow raw file positional access

2026-06-29 21:55:08 +00:00

io

misc: use prelude size_of

2026-06-25 16:54:35 +00:00

aligned_buffer.rs

block: qcow: Drop own O_DIRECT alignment handling

2026-06-20 11:46:17 +00:00

aligned_file.rs

block: Remove redundant BlockBackend trait

2026-06-24 01:26:12 +00:00

disk_file.rs

block: Remove DiskBackend dispatch enum

2026-04-22 18:04:16 +00:00

error.rs

block: qcow: Remove From<qcow::Error> for BlockError

2026-03-20 22:21:24 +00:00

factory.rs

block: vhd: Enable O_DIRECT for fixed VHD images

2026-06-20 11:46:17 +00:00

lib.rs

block: Avoid unsafe Vec construction in detect_image_type()

2026-06-29 23:26:17 +00:00

sparse.rs

block: use BLKDISCARD/BLKZEROOUT ioctls for block devices

2026-05-14 22:35:02 +00:00