feat!: Indexes for nodes in the AST (#414)

Indexes allow associating extra data with nodes in the AST
using an array and then quickly looking up the array to fetch
the extra data.

- Index eidx for expressions
- Index sidx for statements
- Index qidx for queries.

AST nodes are not cloneable. Therefore once a module is created,
it is not possible to accidentally create two nodes with the same
index inadvertently via clone.

Also added IndexChecker in debug builds. When a module is parsed,
it will assert that indexes have been constructed correctly.

AST Cleanup
- Make literal expressions (null, val, number, string etc) also structs
  to match all other expressions
- Merge True and False nodes into a single Bool node.

Also update dependencies.

Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
This commit is contained in:
Anand Krishnamoorthi
2025-06-20 15:09:07 -05:00
committed by GitHub
parent 620f8a4547
commit 444b2970a1
35 changed files with 2015 additions and 586 deletions
+12 -1
View File
@@ -6,6 +6,9 @@ cases:
rego: |
package test
add(x, y) := 5 sub(x, y) = 5
num_expressions: 9
num_statements: 0
num_queries: 0
package: --skip--
imports:
policy:
@@ -16,14 +19,18 @@ cases:
span: add(x, y) := 5
refr:
var: add
eidx: 1
args:
- var: x
eidx: 2
- var: y
eidx: 3
assign:
span: := 5
op: :=
value:
number: 5
eidx: 4
bodies: []
- spec:
span: sub(x, y) = 5
@@ -32,13 +39,17 @@ cases:
span: sub(x, y) = 5
refr:
var: sub
eidx: 5
args:
- var: x
eidx: 6
- var: y
eidx: 7
assign:
span: = 5
op: =
value:
number: 5
eidx: 8
bodies: []
+95 -12
View File
@@ -12,6 +12,9 @@ cases:
error: unexpected keyword `else`
- note: no-query
num_expressions: 5
num_statements: 2
num_queries: 2
rego: |
package test
@@ -26,21 +29,29 @@ cases:
compr:
refr:
var: x
eidx: 1
assign:
op: "="
value:
number: 10
eidx: 2
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
false
bool: false
eidx: 3
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 4
sidx: 1
- note: no-else
rego: |
@@ -51,27 +62,38 @@ cases:
} {
true
}
num_expressions: 5
num_statements: 2
num_queries: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 1
assign:
op: "="
value:
number: 10
eidx: 2
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
false
bool: false
eidx: 3
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 4
sidx: 1
- note: if-no-else
rego: |
@@ -83,27 +105,38 @@ cases:
} {
true
}
num_expressions: 8
num_statements: 2
num_queries: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 4
assign:
op: "="
value:
number: 10
eidx: 5
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
false
bool: false
eidx: 6
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 7
sidx: 1
- note: rule-named-if
rego: |
@@ -114,33 +147,45 @@ cases:
} {
true
}
num_expressions: 6
num_statements: 2
num_queries: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 1
assign:
op: "="
value:
number: 10
eidx: 2
bodies: []
- spec:
head:
compr:
refr:
var: if
eidx: 3
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
false
bool: false
eidx: 4
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 5
sidx: 1
- note: query-else
rego: |
@@ -151,27 +196,38 @@ cases:
} else {
true
}
num_expressions: 5
num_queries: 2
num_statements: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 1
assign:
op: "="
value:
number: 10
eidx: 2
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
false
bool: false
eidx: 3
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 4
sidx: 1
- note: if-literal-else
rego: |
@@ -181,18 +237,24 @@ cases:
x = 10 if 1 < 0 else {
true
}
num_expressions: 10
num_statements: 2
num_queries: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 4
assign:
op: "="
value:
number: 10
eidx: 5
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
@@ -200,13 +262,20 @@ cases:
op: "<"
lhs:
number: 1
eidx: 6
rhs:
number: 0
eidx: 7
eidx: 8
sidx: 0
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 9
sidx: 1
- note: if-literal-else-assign
rego: |
@@ -217,18 +286,24 @@ cases:
x = 10 if 1 < 0 else := 20 {
true
}
num_expressions: 11
num_statements: 2
num_queries: 2
policy:
- spec:
head:
compr:
refr:
var: x
eidx: 4
assign:
op: "="
value:
number: 10
eidx: 5
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
@@ -236,17 +311,25 @@ cases:
op: "<"
lhs:
number: 1
eidx: 6
rhs:
number: 0
eidx: 7
eidx: 8
sidx: 0
- assign:
op: ":="
value:
number: 20
eidx: 9
query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 10
sidx: 1
- note: contains-else-error
rego: |
+55 -12
View File
@@ -8,6 +8,9 @@ cases:
import future.keywords
deny.a contains 0, "bar" in ["bar1"] if true
num_expressions: 11
num_statements: 1
num_queries: 1
policy:
- spec:
head:
@@ -16,27 +19,37 @@ cases:
refdot:
refr:
var: deny
eidx: 3
field: a
eidx: 4
key:
inexpr:
key:
number: 0
eidx: 5
value:
string: bar
eidx: 6
collection:
array:
- string: bar1
eidx: 7
eidx: 8
eidx: 9
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
true
bool: true
eidx: 10
sidx: 0
- note: old-syntax
rego: |
package test
import future.keywords.if
# The following are not sets
x1 if true
x2 { true }
@@ -48,31 +61,41 @@ cases:
# The following are not sets
z.a if { true }
z["b"] if { true }
num_expressions: 21
num_statements: 6
num_queries: 6
policy:
- spec:
head:
compr:
refr:
var: x1
eidx: 4
bodies:
- query:
qidx: 0
stmts:
- literal:
expr:
true
bool: true
eidx: 5
sidx: 0
- spec:
head:
compr:
refr:
var: x2
eidx: 6
bodies:
- query:
qidx: 1
stmts:
- literal:
expr:
true
bool: true
eidx: 7
sidx: 1
- spec:
head:
set:
@@ -80,27 +103,37 @@ cases:
refdot:
refr:
var: y
eidx: 8
field: a
eidx: 9
bodies:
- query:
qidx: 2
stmts:
- literal:
expr:
true
bool: true
eidx: 10
sidx: 2
- spec:
head:
set:
refr:
var: y
eidx: 11
key:
string: b
eidx: 12
bodies:
- query:
qidx: 3
stmts:
- literal:
expr:
true
bool: true
eidx: 13
sidx: 3
- spec:
head:
@@ -109,13 +142,18 @@ cases:
refdot:
refr:
var: z
eidx: 14
field: a
eidx: 15
bodies:
- query:
qidx: 4
stmts:
- literal:
expr:
true
bool: true
eidx: 16
sidx: 4
- spec:
head:
@@ -124,12 +162,17 @@ cases:
refbrack:
refr:
var: z
eidx: 17
index:
string: b
eidx: 18
eidx: 19
bodies:
- query:
qidx: 5
stmts:
- literal:
expr:
true
bool: true
eidx: 20
sidx: 5