mirror of
https://github.com/microsoft/regorus.git
synced 2026-08-05 02:16:11 +00:00
feat: add multi-threaded evaluation benchmark suite with comprehensive C# implementation (#457)
This commit introduces a complete multi-threaded evaluation benchmark suite for both Rust and C# implementations of Regorus. - Implemented engine evaluation benchmark with input and engine cloning strategies - Implemented compiled policy evaluation benchmark with input cloning and shared compiled policy strategies. - Created EngineEvaluationBenchmark.cs and CompiledPolicyEvaluationBenchmark.cs with time-based execution (3s warmup + 3s evaluation) - Implemented configuration options matching Rust implementation (useClonedEngines, useSharedPolicies parameters) - Created markdown analysis documentation with cross-platform performance analysis - C# seems to achieve 58-89% of Rust performance on test machine. Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
This commit is contained in:
committed by
GitHub
parent
a53c7c8192
commit
d561531613
@@ -0,0 +1,228 @@
|
||||
use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
|
||||
use regorus::{Engine, Value};
|
||||
use std::collections::HashMap;
|
||||
use std::hint::black_box;
|
||||
use std::sync::{Arc, Barrier, Mutex};
|
||||
use std::thread;
|
||||
use std::time::Duration;
|
||||
|
||||
mod policy_data;
|
||||
|
||||
fn multi_threaded_eval(
|
||||
num_threads: usize,
|
||||
evals_per_thread: usize,
|
||||
use_cloned_engines: bool,
|
||||
use_cloned_inputs: bool,
|
||||
) -> (std::time::Duration, HashMap<String, usize>, usize) {
|
||||
// Complex policies with multiple valid inputs for each
|
||||
let policies_with_inputs = policy_data::policies_with_inputs();
|
||||
|
||||
// Policy names for tracking
|
||||
let policy_names = policy_data::policy_names()
|
||||
.into_iter()
|
||||
.map(|s| s.to_string())
|
||||
.collect::<Vec<_>>();
|
||||
|
||||
// Initialize policy evaluation counters
|
||||
let policy_counters = Arc::new(Mutex::new(HashMap::new()));
|
||||
for policy_name in &policy_names {
|
||||
policy_counters
|
||||
.lock()
|
||||
.unwrap()
|
||||
.insert(policy_name.to_string(), 0);
|
||||
}
|
||||
|
||||
let barrier = Arc::new(Barrier::new(num_threads));
|
||||
let mut handles = Vec::with_capacity(num_threads);
|
||||
|
||||
let total_evals = Arc::new(Mutex::new(0usize));
|
||||
for thread_id in 0..num_threads {
|
||||
let barrier = barrier.clone();
|
||||
let policies_with_inputs = policies_with_inputs.clone();
|
||||
let policy_names = policy_names.clone();
|
||||
let policy_counters = policy_counters.clone();
|
||||
let total_evals = total_evals.clone();
|
||||
|
||||
handles.push(thread::spawn(move || {
|
||||
let mut elapsed = std::time::Duration::ZERO;
|
||||
|
||||
// Pre-create engines if using cloned engines
|
||||
let engines = if use_cloned_engines {
|
||||
Some(
|
||||
policies_with_inputs
|
||||
.iter()
|
||||
.map(|(policy, _)| {
|
||||
let mut engine = Engine::new();
|
||||
engine
|
||||
.add_policy("policy.rego".to_string(), policy.to_string())
|
||||
.unwrap();
|
||||
{
|
||||
// Warm up the engine to ensure it's fully prepared for evaluation.
|
||||
// This prevents each cloned engine from repeating preparation work.
|
||||
engine.set_input(Value::new_object());
|
||||
let _ = engine.eval_rule("data.bench.allow".to_string());
|
||||
}
|
||||
engine
|
||||
})
|
||||
.collect::<Vec<_>>(),
|
||||
)
|
||||
} else {
|
||||
None
|
||||
};
|
||||
|
||||
// Pre-parse inputs if using cloned inputs
|
||||
let parsed_inputs = if use_cloned_inputs {
|
||||
Some(
|
||||
policies_with_inputs
|
||||
.iter()
|
||||
.map(|(_, inputs)| {
|
||||
inputs
|
||||
.iter()
|
||||
.map(|input_str| regorus::Value::from_json_str(input_str).unwrap())
|
||||
.collect::<Vec<_>>()
|
||||
})
|
||||
.collect::<Vec<_>>(),
|
||||
)
|
||||
} else {
|
||||
None
|
||||
};
|
||||
|
||||
barrier.wait();
|
||||
for i in 0..evals_per_thread {
|
||||
// Use different policy for each iteration - thread_id ensures different threads
|
||||
// start with different policies for better load distribution
|
||||
let policy_idx = (thread_id + i) % policies_with_inputs.len();
|
||||
let (policy, inputs) = &policies_with_inputs[policy_idx];
|
||||
|
||||
// Use different input for the same policy based on iteration - thread_id ensures
|
||||
// different threads start with different inputs for better load distribution
|
||||
let input_idx = (thread_id + i) % inputs.len();
|
||||
let input = &inputs[input_idx];
|
||||
|
||||
let start = std::time::Instant::now();
|
||||
|
||||
let result = {
|
||||
let mut engine = if use_cloned_engines {
|
||||
engines.as_ref().unwrap()[policy_idx].clone()
|
||||
} else {
|
||||
let mut engine = Engine::new();
|
||||
engine
|
||||
.add_policy("policy.rego".to_string(), policy.to_string())
|
||||
.unwrap();
|
||||
engine
|
||||
};
|
||||
|
||||
let input_value = if use_cloned_inputs {
|
||||
parsed_inputs.as_ref().unwrap()[policy_idx][input_idx].clone()
|
||||
} else {
|
||||
regorus::Value::from_json_str(input).unwrap()
|
||||
};
|
||||
|
||||
engine.set_input(input_value);
|
||||
|
||||
engine.eval_rule("data.bench.allow".to_string())
|
||||
|
||||
// Engine cleanup/drop time is included in measurement to reflect
|
||||
// real-world total cost of policy evaluation lifecycle
|
||||
};
|
||||
elapsed += start.elapsed();
|
||||
|
||||
// Track total and successful evaluations
|
||||
{
|
||||
let mut total = total_evals.lock().unwrap();
|
||||
*total += 1;
|
||||
}
|
||||
if result.is_ok() {
|
||||
if let Some(policy_name) = policy_names.get(policy_idx) {
|
||||
let mut counters = policy_counters.lock().unwrap();
|
||||
*counters.entry(policy_name.to_string()).or_insert(0) += 1;
|
||||
}
|
||||
}
|
||||
}
|
||||
elapsed
|
||||
}));
|
||||
}
|
||||
|
||||
let mut total = std::time::Duration::ZERO;
|
||||
for handle in handles {
|
||||
total += handle.join().unwrap();
|
||||
}
|
||||
|
||||
let final_counters = policy_counters.lock().unwrap().clone();
|
||||
let total_evals = *total_evals.lock().unwrap();
|
||||
(total, final_counters, total_evals)
|
||||
}
|
||||
|
||||
fn criterion_benchmark(c: &mut Criterion) {
|
||||
let max_threads = num_cpus::get() * 2;
|
||||
println!("Running benchmark with max_threads: {}", max_threads);
|
||||
|
||||
let evals_per_thread = 1000;
|
||||
|
||||
// Benchmark all combinations of cloned engines and inputs
|
||||
for use_cloned_engines in [true, false] {
|
||||
for use_cloned_inputs in [true, false] {
|
||||
let group_name = match (use_cloned_engines, use_cloned_inputs) {
|
||||
(true, true) => "cloned_engines , cloned_inputs ",
|
||||
(true, false) => "cloned_engines , fresh_inputs ",
|
||||
(false, true) => "fresh_engines , cloned_inputs ",
|
||||
(false, false) => "fresh_engines , fresh_inputs ",
|
||||
};
|
||||
|
||||
let mut group = c.benchmark_group(group_name);
|
||||
group.measurement_time(Duration::from_secs(5));
|
||||
|
||||
// Test specific thread counts: powers of 2 + some intermediate values
|
||||
let thread_counts: Vec<usize> = (1..=max_threads)
|
||||
.filter(|&n| {
|
||||
n == 1 || // Always test single-threaded
|
||||
n % 2 == 0 || // Always test even threads
|
||||
n == max_threads // Maximum threads
|
||||
})
|
||||
.collect();
|
||||
|
||||
for threads in thread_counts {
|
||||
let total_evals = threads * evals_per_thread;
|
||||
group.throughput(Throughput::Elements(total_evals as u64));
|
||||
group.bench_with_input(
|
||||
BenchmarkId::new("eval", format!(" {threads} threads")),
|
||||
&threads,
|
||||
|b, &threads| {
|
||||
b.iter_custom(|iters| {
|
||||
let evals_per_thread = evals_per_thread * (iters as usize);
|
||||
|
||||
let (duration, policy_counters, total_evals_aggregated) = multi_threaded_eval(
|
||||
black_box(threads),
|
||||
black_box(evals_per_thread),
|
||||
black_box(use_cloned_engines),
|
||||
black_box(use_cloned_inputs),
|
||||
);
|
||||
|
||||
|
||||
// Sanity check: Ensure the expected number of evaluations matches the actual number performed per iteration batch.
|
||||
// total_evals is the expected number for this batch, total_evals_aggregated is the sum over all iters.
|
||||
assert_eq!(total_evals, total_evals_aggregated/iters as usize);
|
||||
|
||||
// On one iteration, print policy evaluation statistics
|
||||
if iters == 1 {
|
||||
// println!("\nPolicy Evaluation Statistics:");
|
||||
for (policy_name, count) in &policy_counters {
|
||||
// println!(" {}: {} evaluations", policy_name, count);
|
||||
if *count == 0 {
|
||||
println!("\x1b[31mERROR: Policy '{}' was never evaluated successfully!\x1b[0m", policy_name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
duration
|
||||
});
|
||||
},
|
||||
);
|
||||
}
|
||||
group.finish();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
criterion_group!(benches, criterion_benchmark);
|
||||
criterion_main!(benches);
|
||||
Reference in New Issue
Block a user