Commit Graph

10 Commits

Author SHA1 Message Date
Andreea Florescu
6fbd7c7355 fix test commit format
The newer versions of git are checking the ownership of directories.
Since the `/workdir` is a shared directory with ownership of buildkite,
we need to add an exception for it.

Signed-off-by: Andreea Florescu <fandree@amazon.com>
2022-08-26 19:48:52 +03:00
Mathieu Poirier
99fe2eb2e0 Relax 50/72 rule for more descriptive titles
Expand the title and changelog description lines to 60 and 75
respectively.  That is in line with what other projects do and
allows for better narratives.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
2022-02-22 10:06:54 +02:00
Catalin Dumitru
ae7db2d98a Rename master to main
Updated occurrences of "master" with "main".

Signed-off-by: Catalin Dumitru <catdum@amazon.com>
2021-09-02 12:33:44 +03:00
Catalin Dumitru
cc6ed996a0 Format integration tests code
Split lines that were too long, adjusted intendation and fixed typos.

Signed-off-by: Catalin Dumitru <catdum@amazon.com>
2021-08-25 16:25:48 +03:00
Catalin Dumitru
7693628035 Update commit format test to work locally
Set default values for the remote name and
base branch when the test is run locally and
the Buildkite variables are not available and
the variables BASE_BRANCH and REMOTE are not set.

Signed-off-by: Catalin Dumitru <catdum@amazon.com>
2021-07-21 15:59:49 +03:00
Keiichi Watanabe
9f7b0d9069 check commit authors for each commit
Although we check commit authors in test_commit_format.py to skip tests
for dependabot's commits, the current code only checks the author of the
head commit.
This PR make it check each commit's author so that we can test branches
where both a dependabot's commit and other commits exist.

Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
2021-06-22 11:18:24 +03:00
Andreea Florescu
ebc701641f exclude dependabot from the 50/72 commit rule
When dependabot updates the rust-vmm-ci submodule, the git commit
sumamry is over 50 chars. To be able to merge PR, exclude the dependabot
user from this checks.

Fixes: https://github.com/rust-vmm/rust-vmm-ci/issues/61

Signed-off-by: Andreea Florescu <fandree@amazon.com>
2021-02-23 12:50:55 +02:00
Laura Loghin
3ea5f2b1f1 improve a bit error messages for commit test
Made the messages for some error cases clearer.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
2020-10-08 15:18:08 +03:00
Laura Loghin
35beb918b7 Fix commit message test
The test that was checking the commit message format
was not comparing the PR's HEAD to the right master,
even though `origin` was set to the pipeline repository.
Fixed this by fetching that repo. This way, `FETCH_HEAD`
points to the latest upstream master.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
2020-07-29 12:05:33 +03:00
Laura Loghin
abd2c90d9f Add test for commit message format
Added test that checks if commits follow the 50/72 git
commit rule and if they are signed (git commit -s).
Fixes: #9, #14.

Signed-off-by: Laura Loghin <lauralg@amazon.com>
2020-07-23 15:27:39 +03:00