From 02a0d12988c43886943a26d3617b8f9422e6171a Mon Sep 17 00:00:00 2001
From: Joern Siglen <siglen@de.ibm.com>
Date: Wed, 16 Feb 2022 11:55:55 +0100
Subject: [PATCH] dbginfo.sh: (re)group commands by block/scsi
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This change will group the commands executed for block and scsi devices
into a section with a comment.
By grouping, we intend to enhance the handling in our runtime.out file
and help to understand the purpose of command groups.

In addition we did get feedback for promoting some commands to the top.

Signed-off-by: Joern Siglen <siglen@de.ibm.com>
Reviewed-by: Sa Liu <saliu@de.ibm.com>
Reviewed-by: Mario Held <mario.held@de.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
---
 scripts/dbginfo.sh | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/scripts/dbginfo.sh b/scripts/dbginfo.sh
index e1b2ba04..4e458b3c 100755
--- a/scripts/dbginfo.sh
+++ b/scripts/dbginfo.sh
@@ -447,18 +447,18 @@ CMDS="${CMDS}\
   :smc_dbg\
   "
 
+# block device and other scsi device commands (in non alphabetical order)
+#   command groups itself have an intentional topical grouping and order
 CMDS="${CMDS}\
+  :lsdasd\
+  :lsdasd -u\
+  :lvdisplay\
+  :pvpath -qa\
   :dmsetup ls\
   :dmsetup ls --tree\
   :dmsetup table\
   :dmsetup table --target multipath\
   :dmsetup status\
-  :lsdasd\
-  :lsdasd -u\
-  :lsscsi\
-  :lszfcp\
-  :lszfcp -D\
-  :lszfcp -V\
   :multipathd -k'show config'\
   :multipathd -k'show maps'\
   :multipathd -k'show topo'\
@@ -472,9 +472,11 @@ CMDS="${CMDS}\
   :multipath -v6 -ll\
   :multipath -d\
   :multipath -t\
-  :pvpath -qa\
-  :lvdisplay\
+  :lszfcp\
+  :lszfcp -D\
+  :lszfcp -V\
   :ziorep_config -ADM\
+  :lsscsi\
   "
 
 # crypto specific commands