From 0c78add815d4573f7ccc6a79a9efe54501f9e749 Mon Sep 17 00:00:00 2001 From: Steffen Maier Date: Thu, 21 Feb 2019 19:06:44 +0100 Subject: [PATCH] lszfcp: add new output marker for non-good SCSI devices (luns) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Shows potential issues with zfcp-attached SCSI devices at one glance. Example: $ lszfcp -De 0.0.5000/0x500507680b2181fa/0x027d000000000000 1:0:1:637 NotRunning $ lszfcp -DeV /sys/devices/css0/0.0.0223/0.0.5000/0x500507680b2181fa/0x027d000000000000 /sys/bus/ccw/drivers/zfcp/0.0.5000/host1/rport-1:0-1/target1:0:1/1:0:1:637 NotRunning /sys/block/sdm /sys/class/scsi_generic/sg12 Signed-off-by: Steffen Maier Reviewed-by: Fedor Loshakov Reviewed-by: Jens Remus Signed-off-by: Jan Höppner --- zconf/lszfcp | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/zconf/lszfcp b/zconf/lszfcp index 0322db89..a8700653 100755 --- a/zconf/lszfcp +++ b/zconf/lszfcp @@ -340,11 +340,21 @@ show_devices() [ $WWPN != ${PAR_WWPN:-$WWPN} ] && continue [ $ADAPTER != ${PAR_BUSID:-$ADAPTER} ] && continue + ZFCP_UNIT_PATH=$SYSFS/devices/css[0-9]*/[0-9d]*/$ADAPTER/$WWPN/$LUN + SDEVMARKER="" + if $SHOW_EXTENDED; then + [ -d $ZFCP_UNIT_PATH ] || SDEVMARKER="$SDEVMARKER auto" + [ -r $SCSI_DEVICE_PATH/state ] \ + && read SDEVSTATE < $SCSI_DEVICE_PATH/state + [ "$SDEVSTATE" != "running" ] \ + && SDEVMARKER="$SDEVMARKER NotRunning" + fi + if [ $VERBOSITY -eq 0 ]; then - echo "$ADAPTER/$WWPN/$LUN `basename $SCSI_DEVICE_PATH`" + echo "$ADAPTER/$WWPN/$LUN `basename $SCSI_DEVICE_PATH`$SDEVMARKER" else - echo "`ls -d $SYSFS/devices/css0/*/$ADAPTER`/$WWPN/$LUN" - echo ${SCSI_DEVICE_PATH%*/} # without trailing slash + echo "`ls -d $SYSFS/devices/css0/[0-9d]*/$ADAPTER`/$WWPN/$LUN" + echo ${SCSI_DEVICE_PATH%*/}$SDEVMARKER # without trailing slash # On live systems, there are links to the block and # generic devices. In a dbginfo archive, these links