From 229cd6d194ecfbec5d457c80c5d29f97388f31a6 Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Thu, 7 Apr 2022 11:29:17 +0200 Subject: [PATCH] zdump: don't modify passed program header in `pt_load_add()` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There should be no problem with this change since the changed value was never used. Therefore, let's remove the assignment and declare the parameter as const to prevent such a behavior in the future. Signed-off-by: Marc Hartmayer Reviewed-by: Alexander Egorenkov Signed-off-by: Jan Höppner --- zdump/dfi_elf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/zdump/dfi_elf.c b/zdump/dfi_elf.c index 0067984d..a2c31807 100644 --- a/zdump/dfi_elf.c +++ b/zdump/dfi_elf.c @@ -40,7 +40,7 @@ static void dfi_elf_mem_chunk_read_fn(struct dfi_mem_chunk *mem_chunk, u64 off, /* * Add load (memory chunk) to DFI dump */ -static int pt_load_add(Elf64_Phdr *phdr) +static int pt_load_add(const Elf64_Phdr *phdr) { u64 *off_ptr; @@ -50,7 +50,6 @@ static int pt_load_add(Elf64_Phdr *phdr) phdr->p_filesz, phdr->p_memsz); if (phdr->p_paddr != phdr->p_vaddr) { - phdr->p_paddr = phdr->p_vaddr; STDERR("Dump file \"%s\" is a user space core dump\n", g.opts.device); return -EINVAL;