From 2677a4182db0303ae6c90b727b09fafb52f8a46d Mon Sep 17 00:00:00 2001
From: Joern Siglen <siglen@de.ibm.com>
Date: Mon, 14 Feb 2022 13:39:22 +0100
Subject: [PATCH] dbginfo.sh: (re)group commands by system state
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This change will group the commands executed for overall state into a
first section with a comment.
By grouping, we intend to enhance the handling in our runtime.out file
and help to understand the purpose of command groups.

In addition we did get feedback for promoting some commands to the top.

Signed-off-by: Joern Siglen <siglen@de.ibm.com>
Reviewed-by: Sa Liu <saliu@de.ibm.com>
Reviewed-by: Mario Held <mario.held@de.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
---
 scripts/dbginfo.sh | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/scripts/dbginfo.sh b/scripts/dbginfo.sh
index fa357ae3..98e8a3ed 100755
--- a/scripts/dbginfo.sh
+++ b/scripts/dbginfo.sh
@@ -410,37 +410,48 @@ CONFIGFILES="\
   "
 
 ########################################
+# system state commands (non alphabetical order here)
 CMDS="uname -a\
   :uptime\
   :timedatectl\
+  :last\
+  :lscpu -ae\
+  :lscpu -ye\
+  :lsmem\
+  :lsmod\
+  :lsshut\
   :runlevel\
+  :sysctl -a\
+  :systemctl --all --no-pager show\
+  :systemctl --all --no-pager list-units\
+  :systemctl --all --no-pager list-unit-files\
+  :systemd-delta\
   :ulimit -a\
   :env\
+  :find /boot -print0 | sort -z | xargs -0 -n 10 ls -ld\
+  :find /var/crash -print0 | sort -z | xargs -0 -n 10 ls -ld\
   :df -h\
   :df -i\
+  :mount\
+  "
+
+CMDS="${CMDS}\
   :dmsetup ls\
   :dmsetup ls --tree\
   :dmsetup table\
   :dmsetup table --target multipath\
   :dmsetup status\
-  :last\
   :lschp\
-  :lscpu -ae\
-  :lscpu -ye\
   :lscss\
-  :lsmem\
   :lsdasd\
   :lsdasd -u\
-  :lsmod\
   :lspci -vv\
   :lsscsi\
-  :lsshut\
   :lstape\
   :lszdev\
   :lszfcp\
   :lszfcp -D\
   :lszfcp -V\
-  :mount\
   :multipathd -k'show config'\
   :multipathd -k'show maps'\
   :multipathd -k'show topo'\
@@ -455,15 +466,8 @@ CMDS="uname -a\
   :multipath -d\
   :multipath -t\
   :pvpath -qa\
-  :find /boot -print0 | sort -z | xargs -0 -n 10 ls -ld\
   :find /dev -print0 | sort -z | xargs -0 -n 10 ls -ld\
-  :find /var/crash -print0 | sort -z | xargs -0 -n 10 ls -ld\
   :smc_dbg\
-  :sysctl -a\
-  :systemctl --all --no-pager show\
-  :systemctl --all --no-pager list-units\
-  :systemctl --all --no-pager list-unit-files\
-  :systemd-delta\
   :lvdisplay\
   :ziorep_config -ADM\
   "