From 4e5afb9b711b6024e2fcd667d1b6ec4857276e47 Mon Sep 17 00:00:00 2001 From: Jens Remus Date: Tue, 5 Sep 2017 20:52:27 +0200 Subject: [PATCH] cmsfs-fuse: do not check if unsigned is less than zero MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only check if size is zero and not if equal or less than zero. This is safe, as size is only decremented by rlen, which is either less than or equal to size. So size may never overflow. Resolves Cppcheck style warning: [cmsfs-fuse/cmsfs-fuse.c:3746]: (style) Checking if unsigned variable 'size' is less than zero. Cc: Gerald Schaefer Signed-off-by: Jens Remus Reviewed-by: Jan Höppner Signed-off-by: Jan Höppner --- cmsfs-fuse/cmsfs-fuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmsfs-fuse/cmsfs-fuse.c b/cmsfs-fuse/cmsfs-fuse.c index 3b501f8e..59af7d26 100644 --- a/cmsfs-fuse/cmsfs-fuse.c +++ b/cmsfs-fuse/cmsfs-fuse.c @@ -3741,7 +3741,7 @@ static int extend_block_variable(struct file *f, const char *buf, int len, } DEBUG("%s: wrote %d record bytes\n", __func__, rlen); - if (size <= 0) + if (size == 0) return copied; }