From 538bc7b4e8098fcc92a6e51faaf18a0880e5dfa8 Mon Sep 17 00:00:00 2001 From: Jan Polensky Date: Mon, 15 Sep 2025 14:57:35 +0200 Subject: [PATCH] dasdinfo/dasdinfo.c: Replace buffer size magic number with anonymous enum MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use a local anonymous enum to define the buffer size constant, replacing the hardcoded magic number and improving readability. Reviewed-by: Jan Höppner Reviewed-by: Juergen Christ Signed-off-by: Jan Polensky Signed-off-by: Jan Höppner --- dasdinfo/dasdinfo.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dasdinfo/dasdinfo.c b/dasdinfo/dasdinfo.c index c3797bf9..4189b5af 100644 --- a/dasdinfo/dasdinfo.c +++ b/dasdinfo/dasdinfo.c @@ -373,8 +373,9 @@ static int dinfo_is_busiddir(const char *fpath, const struct stat *UNUSED(sb), int tflag, struct FTW *ftwbuf) { + enum { LINK_DIR_SIZE = 128 }; + char linkdir[LINK_DIR_SIZE]; char *tempdir; - char linkdir[128]; ssize_t i; if (tflag != FTW_D || (strncmp((fpath + ftwbuf->base), searchbusid, @@ -387,9 +388,9 @@ dinfo_is_busiddir(const char *fpath, const struct stat *UNUSED(sb), */ if (asprintf(&tempdir, "%s/driver", fpath) < 0) return -1; - i = readlink(tempdir, linkdir, 128); + i = readlink(tempdir, linkdir, LINK_DIR_SIZE); free(tempdir); - if ((i < 0) || (i >= 128)) + if (i < 0 || i >= LINK_DIR_SIZE) return -1; /* append '\0' because readlink returns non zero terminated string */ tempdir[i + 1] = '\0';