From 76a0401deb1f45eb86c2c616dbba14c586df671f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20H=C3=B6ppner?= Date: Wed, 15 Oct 2025 13:11:00 +0200 Subject: [PATCH] common.mak: Remove NO_PIE_CFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The definition NO_PIE_CFLAGS has only two users and specifies only a single compiler flag. There is no point having this definition anymore. Remove the definition and specify -fno-pie directly for the two users. Reviewed-by: Marc Hartmayer Signed-off-by: Jan Höppner --- common.mak | 2 -- rust/pvimg/boot/Makefile | 2 +- zipl/boot/Makefile | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common.mak b/common.mak index 359032d3..69ac7efe 100644 --- a/common.mak +++ b/common.mak @@ -340,8 +340,6 @@ endif export INSTALL CFLAGS CXXFLAGS \ LDFLAGS CPPFLAGS ALL_CFLAGS ALL_CXXFLAGS ALL_LDFLAGS ALL_CPPFLAGS -NO_PIE_CFLAGS := -fno-pie - # Overwrite implicit makefile rules for having nice compile output %.o: %.c ifeq ("${C}","1") diff --git a/rust/pvimg/boot/Makefile b/rust/pvimg/boot/Makefile index ad00371a..d6f30480 100644 --- a/rust/pvimg/boot/Makefile +++ b/rust/pvimg/boot/Makefile @@ -12,7 +12,7 @@ PVIMG_PKGDATADIR ?= $(TOOLS_DATADIR)/pvimg INCLUDE_PATHS := $(ZIPL_BOOT_DIR) $(ZIPL_DIR)/include $(rootdir)/include INCLUDE_PARMS := $(addprefix -I,$(INCLUDE_PATHS)) -ALL_CFLAGS := $(NO_PIE_CFLAGS) -Os -g \ +ALL_CFLAGS := -fno-pie -Os -g \ $(INCLUDE_PARMS) \ -DENABLE_SCLP_ASCII=1 \ -DS390_TOOLS_RELEASE=$(S390_TOOLS_RELEASE) \ diff --git a/zipl/boot/Makefile b/zipl/boot/Makefile index 4ca0708a..61e00475 100644 --- a/zipl/boot/Makefile +++ b/zipl/boot/Makefile @@ -25,7 +25,7 @@ ifeq ($(HOST_ARCH),s390x) INCLUDE_PATHS := $(rootdir)/zipl/include $(rootdir)/include INCLUDE_PARMS := $(addprefix -I,$(INCLUDE_PATHS)) -ALL_CFLAGS = $(NO_PIE_CFLAGS) -Os -g $(INCLUDE_PARMS) \ +ALL_CFLAGS = -fno-pie -Os -g $(INCLUDE_PARMS) \ -DS390_TOOLS_RELEASE=$(S390_TOOLS_RELEASE) \ -fno-builtin -ffreestanding -fno-asynchronous-unwind-tables \ -fno-delete-null-pointer-checks -fno-stack-protector \