From 7ee51182bf3afd1d410818a0b7d9b792bb43e99e Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Wed, 24 Aug 2022 07:56:24 +0000 Subject: [PATCH] zdump: fix memory leak of `path` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ==660622== 385 bytes in 7 blocks are definitely lost in loss record 30 of 37 ==660622== at 0x484417C: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-s390x-linux.so) ==660622== by 0x4E93BD7: strdup (strdup.c:42) ==660622== by 0x11249F: zg_strdup (zg.c:115) ==660622== by 0x11249F: zg_open (zg.c:164) ==660622== by 0x114FBF: dfi_dump_open (dfi.c:750) ==660622== by 0x114FBF: dfi_init (dfi.c:772) ==660622== by 0x111465: do_copy (zgetdump.c:192) ==660622== by 0x111465: main (zgetdump.c:216) Signed-off-by: Marc Hartmayer Reviewed-by: Alexander Egorenkov Signed-off-by: Jan Höppner --- zdump/zg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/zdump/zg.c b/zdump/zg.c index 082167fa..c7eeb254 100644 --- a/zdump/zg.c +++ b/zdump/zg.c @@ -183,6 +183,7 @@ fail: void zg_close(struct zg_fh *zg_fh) { close(zg_fh->fh); + free((void *)zg_fh->path); free(zg_fh); }