From 895a88b2f8d775e45ab1251f0b4bb275efd44a64 Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Wed, 11 Nov 2020 22:30:12 +0100 Subject: [PATCH] genprotimg: require argument for 'ramdisk' and 'parmfile' options MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A argument is required for the optional options 'ramdisk' and 'parmfile'. Fixes: 65b9fc442c1a ("genprotimg: introduce new tool for the creation of PV images") Reviewed-by: Bjoern Walk Signed-off-by: Marc Hartmayer Signed-off-by: Jan Höppner --- genprotimg/src/pv/pv_args.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/genprotimg/src/pv/pv_args.c b/genprotimg/src/pv/pv_args.c index 9fb7298b..4bb78b55 100644 --- a/genprotimg/src/pv/pv_args.c +++ b/genprotimg/src/pv/pv_args.c @@ -227,7 +227,7 @@ gint pv_args_parse_options(PvArgs *args, gint *argc, gchar **argv[], .arg_description = _("IMAGE") }, { .long_name = "ramdisk", .short_name = 'r', - .flags = G_OPTION_FLAG_OPTIONAL_ARG | G_OPTION_FLAG_FILENAME, + .flags = G_OPTION_FLAG_FILENAME, .arg = G_OPTION_ARG_CALLBACK, .arg_data = cb_add_component, .description = _("Use RAMDISK as the initial RAM disk\n" INDENT @@ -235,7 +235,7 @@ gint pv_args_parse_options(PvArgs *args, gint *argc, gchar **argv[], .arg_description = _("RAMDISK") }, { .long_name = "parmfile", .short_name = 'p', - .flags = G_OPTION_FLAG_OPTIONAL_ARG | G_OPTION_FLAG_FILENAME, + .flags = G_OPTION_FLAG_FILENAME, .arg = G_OPTION_ARG_CALLBACK, .arg_data = cb_add_component, .description = _("Use the kernel parameters stored in PARMFILE\n" INDENT