From 8b38bf37b06ad81d932f3545330c3daa64695bbe Mon Sep 17 00:00:00 2001 From: Niklas Schnelle Date: Thu, 30 Apr 2026 17:13:16 +0200 Subject: [PATCH] opticsmon: Fix wrong size check for OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code accesses OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET so the size needs to be one larger for the LOS to be accessible. Fixes: c34adb9cabee ("opticsmon: Introduce opticsmon tool") Reviewed-by: Jan Höppner Signed-off-by: Niklas Schnelle Signed-off-by: Jan Höppner --- opticsmon/optics_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opticsmon/optics_info.c b/opticsmon/optics_info.c index fc041da3..00d8d723 100644 --- a/opticsmon/optics_info.c +++ b/opticsmon/optics_info.c @@ -66,7 +66,7 @@ bool optics_los_implemented(struct optics *oi) } else if (type == OPTICS_TYPE_QSFP28) { if (oi->size < OPTICS_QSFP28_LOS_OFFSET + 1) return false; - if (oi->size < OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET) + if (oi->size < OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET + 1) return false; implemented = oi->raw[OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET]; /*