From 9cc74839b0a65d9391652c6d2d73cf10860ab111 Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Thu, 26 Aug 2021 08:54:32 +0000 Subject: [PATCH] zgetdump: initalize sigact to 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This fixes the following Valgrind finding: ==28040== Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s) ==28040== at 0x48C98B0: __libc_sigaction (sigaction.c:58) ==28040== by 0x10D507: sig_handler_init (zgetdump.c:58) ==28040== by 0x10D507: main (zgetdump.c:179) ==28040== Address 0x1ffefffc84 is on thread 1's stack ==28040== in frame #0, created by __libc_sigaction (sigaction.c:43) Reviewed-by: Alexander Egorenkov Signed-off-by: Marc Hartmayer Signed-off-by: Jan Höppner --- zdump/zgetdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zdump/zgetdump.c b/zdump/zgetdump.c index 33dcd3c9..70e58c98 100644 --- a/zdump/zgetdump.c +++ b/zdump/zgetdump.c @@ -49,7 +49,7 @@ static void sig_exit(int sig) */ static void sig_handler_init(void) { - struct sigaction sigact; + struct sigaction sigact = { 0 }; /* Ignore signals SIGUSR1 and SIGUSR2 */ if (sigemptyset(&sigact.sa_mask) < 0)