From bc0d40c5803d4c5426b17b6d59aa0f1e46a2aacc Mon Sep 17 00:00:00 2001 From: Niklas Schnelle Date: Wed, 5 Feb 2020 10:43:55 +0100 Subject: [PATCH] zpcictl: Initiate recover after reset MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After a zpcitctl --reset the PCI function is currently left in an error state. This seems unexpected, so follow the SCLP reset with an OS level recovery using /sys/bus/devices//recover. Signed-off-by: Niklas Schnelle Reviewed-by: Jan Hoeppner Signed-off-by: Jan Höppner --- zpcictl/zpcictl.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/zpcictl/zpcictl.c b/zpcictl/zpcictl.c index 1c13ae01..92bbd0b2 100644 --- a/zpcictl/zpcictl.c +++ b/zpcictl/zpcictl.c @@ -163,6 +163,26 @@ static unsigned int sysfs_read_value(struct zpci_device *pdev, const char *attr) return val; } +static void sysfs_write_value(struct zpci_device *pdev, const char *attr, + unsigned int val) +{ + char *path; + FILE *fp; + + path = util_path_sysfs("bus/pci/devices/%s/%s", pdev->slot, attr); + fp = fopen(path, "w"); + if (!fp) + fopen_err(path); + if (fprintf(fp, "%x", val) < 0) { + fclose(fp); + warnx("Could not write to file %s: %s", path, strerror(errno)); + free(path); + exit(EXIT_FAILURE); + } + fclose(fp); + free(path); +} + static void sysfs_write_data(struct zpci_report_error *report, char *slot) { size_t r_size; @@ -297,6 +317,7 @@ static void sclp_issue_action(struct zpci_device *pdev, int action) static void sclp_reset_device(struct zpci_device *pdev) { sclp_issue_action(pdev, SCLP_ERRNOTIFY_AQ_RESET); + sysfs_write_value(pdev, "recover", 1); } /*