From bc8a14895ad500350ed0bdd2ab6c46a5111fbbec Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Wed, 28 Jun 2023 12:37:55 +0000 Subject: [PATCH] genprotimg: improve the `--comm-key` description MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the future, this key will be used for additional things than the guest dump encryption. Reviewed-by: Steffen Eiden Signed-off-by: Marc Hartmayer Signed-off-by: Jan Höppner --- genprotimg/man/genprotimg.1 | 7 ++++--- genprotimg/src/pv/pv_args.c | 5 ++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/genprotimg/man/genprotimg.1 b/genprotimg/man/genprotimg.1 index 3d8f3aa1..cf8bfcc1 100644 --- a/genprotimg/man/genprotimg.1 +++ b/genprotimg/man/genprotimg.1 @@ -97,11 +97,12 @@ Do not use for a production image unless you verified the host-key document before. Optional. .TP \fB\-\-comm\-key\fR=\fI\,FILE\/\fR -Specifies the encryption key you want to use for the PV guest dump. Use a -secure, random, plaintext AES-256 GCM key. Optional. +Specifies the customer communication key (CCK). This key is used among +other things for the PV guest dump encryption. Use a secure, random, +plaintext AES-256 GCM key. Optional. .TP \fB\-\-enable\-dump\fR -Enable PV guest dumps. Requires the \fB\-\-comm-key\fR option. Optional. +Enable PV guest dumps. Requires the \fB\-\-comm\-key\fR option. Optional. .TP \fB\-\-disable\-dump\fR Disable PV guest dumps. This is the default. diff --git a/genprotimg/src/pv/pv_args.c b/genprotimg/src/pv/pv_args.c index 661ff57b..b5b945d0 100644 --- a/genprotimg/src/pv/pv_args.c +++ b/genprotimg/src/pv/pv_args.c @@ -339,9 +339,8 @@ gint pv_args_parse_options(PvArgs *args, gint *argc, gchar **argv[], .arg = G_OPTION_ARG_CALLBACK, .arg_data = cb_set_string_option, .description = _( - "FILE contains the key with which you encrypt\n" INDENT - "the PV guest dump (optional). Required by\n" INDENT - "the '--enable-dump' option."), + "FILE contains the customer communication key\n" INDENT + "(CCK) (optional)."), .arg_description = _("FILE") }, { .long_name = "crl", .short_name = 0,