From bca8fa3f9c8bc7032763c7c150c60acd63195bc6 Mon Sep 17 00:00:00 2001 From: Fedor Loshakov Date: Mon, 5 Dec 2022 11:02:36 +0100 Subject: [PATCH] ziomon: fix Makefile install step chown warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since coreutils v9.1 commit 8f31074cb ("chown: warn about USER.GROUP") chown utility now warns about using of wrong separator for USER and GROUP options. This leads to warnings during intall step in ziomon: $ make install INSTALL ziomon SED ziomon/install chown: warning: '.' should be ':': ‘root.root’ SED ziomon/install chown: warning: '.' should be ':': ‘root.root’ SED ziomon/install chown: warning: '.' should be ':': ‘root.root’ To fix those warnings use ':' as separator instead of '.'. With this patch applied those warnings are no longer present. Signed-off-by: Fedor Loshakov Reviewed-by: Steffen Maier Signed-off-by: Steffen Eiden --- ziomon/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ziomon/Makefile b/ziomon/Makefile index 214fcff0..c85c89ce 100644 --- a/ziomon/Makefile +++ b/ziomon/Makefile @@ -43,17 +43,17 @@ ziorep_utilization: ziorep_utilization.o ziorep_framer.o ziorep_frameset.o \ install: all $(SED) -e 's/%S390_TOOLS_VERSION%/$(S390_TOOLS_RELEASE)/' \ < ziomon > $(DESTDIR)$(USRSBINDIR)/ziomon; - chown $(OWNER).$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziomon; + chown $(OWNER):$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziomon; chmod 755 $(DESTDIR)$(USRSBINDIR)/ziomon; $(SED) -e \ 's/%S390_TOOLS_VERSION%/$(S390_TOOLS_RELEASE)/' \ < ziomon_fcpconf > $(DESTDIR)$(USRSBINDIR)/ziomon_fcpconf; - chown $(OWNER).$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziomon_fcpconf; + chown $(OWNER):$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziomon_fcpconf; chmod 755 $(DESTDIR)$(USRSBINDIR)/ziomon_fcpconf; $(SED) -e \ 's/%S390_TOOLS_VERSION%/$(S390_TOOLS_RELEASE)/' \ < ziorep_config > $(DESTDIR)$(USRSBINDIR)/ziorep_config; - chown $(OWNER).$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziorep_config; + chown $(OWNER):$(GROUP) $(DESTDIR)$(USRSBINDIR)/ziorep_config; chmod 755 $(DESTDIR)$(USRSBINDIR)/ziorep_config; $(INSTALL) -g $(GROUP) -o $(OWNER) -m 644 ziomon.8 \ $(DESTDIR)$(MANDIR)/man8