diff --git a/rust/pv_core/src/lib.rs b/rust/pv_core/src/lib.rs index 0088af41..1310f54e 100644 --- a/rust/pv_core/src/lib.rs +++ b/rust/pv_core/src/lib.rs @@ -2,7 +2,6 @@ // // Copyright IBM Corp. 2023, 2024 #![deny(missing_docs)] -#![allow(unused)] #![doc = include_str!("../README.md")] mod error; mod macros; diff --git a/rust/pv_core/src/uvdevice/ffi.rs b/rust/pv_core/src/uvdevice/ffi.rs index 0b4a8514..81219e51 100644 --- a/rust/pv_core/src/uvdevice/ffi.rs +++ b/rust/pv_core/src/uvdevice/ffi.rs @@ -9,6 +9,8 @@ pub const UVIO_ATT_ARCB_MAX_LEN: usize = 0x100000; pub const UVIO_ATT_MEASUREMENT_MAX_LEN: usize = 0x8000; pub const UVIO_ATT_ADDITIONAL_MAX_LEN: usize = 0x8000; pub const UVIO_ADD_SECRET_MAX_LEN: usize = 0x100000; +#[allow(unused)] +// here for completeness pub const UVIO_LIST_SECRETS_LEN: usize = 0x1000; // equal to ascii 'u' diff --git a/rust/pv_core/src/uvdevice/secret.rs b/rust/pv_core/src/uvdevice/secret.rs index 235a39a2..227b87ae 100644 --- a/rust/pv_core/src/uvdevice/secret.rs +++ b/rust/pv_core/src/uvdevice/secret.rs @@ -3,23 +3,8 @@ // Copyright IBM Corp. 2023 use super::ffi; -use crate::{ - assert_size, - misc::to_u16, - request::MagicValue, - uv::{UvCmd, UvDevice}, - uvsecret::AddSecretMagic, - Error, Result, PAGESIZE, -}; -use byteorder::{BigEndian, ReadBytesExt, WriteBytesExt}; -use serde::{Serialize, Serializer}; -use std::{ - fmt::Display, - io::{Cursor, Read, Seek, Write}, - slice::Iter, - vec::IntoIter, -}; -use zerocopy::{AsBytes, FromBytes, FromZeroes, U16, U32}; +use crate::{request::MagicValue, uv::UvCmd, uvsecret::AddSecretMagic, Error, Result, PAGESIZE}; +use std::io::Read; /// _List Secrets_ Ultravisor command. /// diff --git a/rust/pv_core/src/uvsecret.rs b/rust/pv_core/src/uvsecret.rs index 9ddbbc0d..e9e0cc33 100644 --- a/rust/pv_core/src/uvsecret.rs +++ b/rust/pv_core/src/uvsecret.rs @@ -2,20 +2,14 @@ // // Copyright IBM Corp. 2023 -use crate::{assert_size, static_assert}; +use crate::assert_size; use crate::{ - misc::to_u16, request::{MagicValue, RequestMagic}, - uv::{ListCmd, UvCmd}, Error, Result, }; use byteorder::{BigEndian, ByteOrder}; -use std::{ - fmt::Display, - io::{Cursor, Read, Seek, Write}, - mem::size_of, -}; -use zerocopy::{AsBytes, FromBytes, U16, U32}; +use std::{fmt::Display, mem::size_of}; +use zerocopy::{AsBytes, U16}; /// The magic value used to identify an add-secret request`] ///