From de36fc5259c11b20547aac2bcdfedb1aa7ddda7e Mon Sep 17 00:00:00 2001 From: Alexander Egorenkov Date: Thu, 2 Sep 2021 10:48:28 +0200 Subject: [PATCH] zdump/dfi: Fix format string specifiers in dfi_info_print() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace the incorrect %d format specifier with %u one for unsigned integer types. This issue was found with AFL fuzzing. $ ./zdump/zgetdump -i ~/input.bin General dump info: Dump format........: s390 Version............: -2147483647 System arch........: s390x (64 bit) CPU count (online).: 32768 Dump memory range..: 1 MB Memory map: 0000000000000000 - 00000000000f423f (1 MB) Signed-off-by: Alexander Egorenkov Signed-off-by: Jan Höppner --- zdump/dfi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zdump/dfi.c b/zdump/dfi.c index 9c94c37a..97488917 100644 --- a/zdump/dfi.c +++ b/zdump/dfi.c @@ -236,7 +236,7 @@ void dfi_info_print(void) STDERR("General dump info:\n"); STDERR(" Dump format........: %s\n", l.dfi->name); if (l.attr.dfi_version) - STDERR(" Version............: %d\n", *l.attr.dfi_version); + STDERR(" Version............: %u\n", *l.attr.dfi_version); date_print(); if (l.attr.dump_method) STDERR(" Dump method........: %s\n", l.attr.dump_method); @@ -248,15 +248,15 @@ void dfi_info_print(void) STDERR(" UTS kernel version.: %s\n", l.attr.utsname->version); } if (l.attr.vol_nr) - STDERR(" Volume number......: %d\n", *l.attr.vol_nr); + STDERR(" Volume number......: %u\n", *l.attr.vol_nr); if (l.attr.build_arch) STDERR(" Build arch.........: %s\n", dfi_arch_str(*l.attr.build_arch)); STDERR(" System arch........: %s\n", dfi_arch_str(l.arch)); if (l.cpus.cnt) - STDERR(" CPU count (online).: %d\n", l.cpus.cnt); + STDERR(" CPU count (online).: %u\n", l.cpus.cnt); if (l.attr.real_cpu_cnt) - STDERR(" CPU count (real)...: %d\n", *l.attr.real_cpu_cnt); + STDERR(" CPU count (real)...: %u\n", *l.attr.real_cpu_cnt); if (dfi_mem_range()) STDERR(" Dump memory range..: %lld MB\n", TO_MIB(dfi_mem_range()));