kata-containers/s390-tools
1
0
Fork 0
mirror of https://github.com/ibm-s390-linux/s390-tools.git synced 2026-08-05 02:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

dasdfmt: Check disk type before prompting for blocksize

Browse Source 
Move check_disk() call before user input to fail fast
on unsupported or unavailable devices (FBA, read-only,
in-use, raw-track mode).

Reviewed-by: Jan Höppner <hoeppner@linux.ibm.com>
Signed-off-by: Volkan Unal <vunal@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
This commit is contained in:
Volkan Unal
2026-06-26 19:07:55 +01:00
committed by Jan Höppner
parent c66495888d
commit e4a03c6f71
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dasdfmt/dasdfmt.c
View File

@@ -1566,6 +1566,8 @@ int main(int argc, char *argv[])
g.ese = dasd_sys_ese(g.dev_node); g.ese = dasd_sys_ese(g.dev_node);
eval_format_mode(); eval_format_mode();
check_disk();
/* Either let the user specify the blksize or get it from the kernel */ /* Either let the user specify the blksize or get it from the kernel */
if (!g.blksize_specified) { if (!g.blksize_specified) {
if (!(mode == FULL || if (!(mode == FULL ||
@@ -1587,8 +1589,6 @@ int main(int argc, char *argv[])
error("VOLSER not found on device %s", g.dev_path); error("VOLSER not found on device %s", g.dev_path);
} }
check_disk();
if (check_param(str, ERR_LENGTH, &format_params) < 0) if (check_param(str, ERR_LENGTH, &format_params) < 0)
error("%s", str); error("%s", str);