From e5801900746827d9ddd0b53c767d548f32a79250 Mon Sep 17 00:00:00 2001 From: Marc Hartmayer Date: Fri, 10 Jun 2022 14:53:49 +0200 Subject: [PATCH] common.mak: remove `-rdynamic` since it's a linker flag MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove `-rdynamic` since it's a linker flag. This should not cause any problems because we differentiate between compilation and linking by default. While at it, adapt the `print_backtrace` documentation accordingly. Signed-off-by: Marc Hartmayer Reviewed-by: Alexander Egorenkov Reviewed-by: Peter Oberparleiter Acked-by: Jan Höppner Signed-off-by: Jan Höppner --- common.mak | 2 +- libutil/util_panic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.mak b/common.mak index 945f3898..788717e2 100644 --- a/common.mak +++ b/common.mak @@ -91,7 +91,7 @@ ifneq ("${V}","1") else echocmd= endif -DEFAULT_CFLAGS = -g -rdynamic -fstack-protector-all -W -Wall -Wformat-security +DEFAULT_CFLAGS = -g -fstack-protector-all -W -Wall -Wformat-security ifeq ("${W}","1") DEFAULT_CFLAGS += -Wextra -Wshadow -Wundef -Wuninitialized -Wdouble-promotion -Wconversion endif diff --git a/libutil/util_panic.c b/libutil/util_panic.c index 59a9a9e0..c841c19a 100644 --- a/libutil/util_panic.c +++ b/libutil/util_panic.c @@ -22,7 +22,7 @@ /* * Obtain a backtrace and print it to stderr * - * To get symbols, compile the code with "-rdynamic". + * To get symbols, link the code with "-rdynamic". */ static void print_backtrace(void) {