From eb881c2a396a51f7a5ece96713e205f7a0032316 Mon Sep 17 00:00:00 2001
From: Nikita Dubrovskii <nikita@linux.ibm.com>
Date: Thu, 5 Feb 2026 13:17:43 +0100
Subject: [PATCH] scripts/cpictl: Fix ShellCheck warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix SC2162, SC2166 and SC2181 reported by ShellCheck without changing
script behavior.

Github-ID: https://github.com/ibm-s390-linux/s390-tools/pull/199
Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
Reviewed-by: Marc Hartmayer <marc@linux.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
---
 scripts/cpictl | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/scripts/cpictl b/scripts/cpictl
index 2e906e4d..ab74ce62 100755
--- a/scripts/cpictl
+++ b/scripts/cpictl
@@ -137,7 +137,7 @@ fail_with()
 {
 	echo "$1" >&2
 	echo "Try '$PRG --help' for more information." >&2
-	exit ${2:-$EXIT_FAILURE}
+	exit "${2:-$EXIT_FAILURE}"
 }
 
 cpi_commit()
@@ -435,30 +435,33 @@ if [ $# -le 0 ]; then
 	print_parse_error_and_exit
 fi
 
-opts=$(getopt -o b:ehL:N:S:T:v -l set-bit:,environment,help,level:,name:,sysplex:,type:,commit,dry-run,permit-cpi,show,version -n "$PRG" -- "$@")
-if [ $? -ne 0 ]; then
+if ! opts=$(getopt -o b:ehL:N:S:T:v  \
+			  -l set-bit:,environment,help,level:,name:,sysplex:,type:,commit,dry-run,permit-cpi,show,version \
+			  -n "$PRG" -- "$@") ; then
 	print_parse_error_and_exit
 fi
 
 # This guarantees that only one instance will be running, and will serialize
 # the execution of multiple instances
-[ -e "$CPI_LOCK" -a ! -w "$CPI_LOCK" ] &&
+if [[ -e "$CPI_LOCK" && ! -w "$CPI_LOCK" ]] ; then
 	fail_with "$PRG: Cannot access lock file: $CPI_LOCK"
-[ ! -w "${CPI_LOCK%/*}" ] &&
+fi
+if [[ ! -w "${CPI_LOCK%/*}" ]] ; then
 	fail_with "$PRG: Cannot access lock file: $CPI_LOCK"
+fi
 
 exec 9<> "$CPI_LOCK"
 flock -x 9
 
 # Get current values from sys/firmware
-read LEVEL < "$SYSTEM_LEVEL_PATH"
-read TYPE < "$SYSTEM_TYPE_PATH"
-read NAME < "$SYSTEM_NAME_PATH"
-read SYSPLEX < "$SYSPLEX_NAME_PATH"
+read -r LEVEL < "$SYSTEM_LEVEL_PATH"
+read -r TYPE < "$SYSTEM_TYPE_PATH"
+read -r NAME < "$SYSTEM_NAME_PATH"
+read -r SYSPLEX < "$SYSPLEX_NAME_PATH"
 
 # Parse command line options: Use eval to remove getopt quotes
-eval set -- $opts
-while [ -n $1 ]; do
+eval set -- "$opts"
+while [ -n "$1" ]; do
 	case "$1" in
 	--help|-h)
 		print_help_and_exit