Files
s390-tools/ziomon/ziorep_utilization.cpp
Fedor Loshakov e5c2fba0a8 ziomon/ziorep_utilization: introduce parameter for reports separation
The output of ziorep_utilization tool currently contains reports for both
the physical and the virtual adapter. As binding of physical and virtual
adapter reports together can be confusing for evaluation of results, introduce
--fcp-device tool parameter for reports separation. This parameter was
introduced to mark virtual adapter report as it represents utilization report
of FCP devices.

So, if --fcp-device was specified by the user, virtual adapter report is
printed. Otherwise physical adapter report is printed.

Parameter --fcp-device has no influence on CSV format report printing.

Refactor also print_reports() function for both reports for better
--fcp-device parameter handling.

Add clarification messages on how to use --fcp-device parameter.

Delete empty separator line between former two reports.

Add description of --fcp-device parameter to man pages.

Add examples for using of ziorep_utilization tool to man pages.

Signed-off-by: Fedor Loshakov <loshakov@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Sakshi Singh <005c7w@linux.ibm.com>
Reviewed-by: M Nikhil <nikh1092@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
2024-12-13 16:26:35 +01:00

409 lines
10 KiB
C++

/*
* FCP report generators
*
* Utilization report program
*
* Copyright IBM Corp. 2008, 2024
*
* s390-tools is free software; you can redistribute it and/or modify
* it under the terms of the MIT license. See LICENSE for details.
*/
#include <stdio.h>
#include <stdlib.h>
#include <getopt.h>
#include <linux/types.h>
#define __STDC_LIMIT_MACROS
#include <stdint.h>
#include <assert.h>
#include <limits.h>
#include <list>
#include "lib/zt_common.h"
#include "ziorep_framer.hpp"
#include "ziorep_printers.hpp"
#include "ziorep_frameset.hpp"
#include "ziorep_utils.hpp"
#include "ziorep_collapser.hpp"
extern "C" {
#include "ziomon_msg_tools.h"
}
using std::list;
const char *toolname = "ziorep_utilization";
int verbose=0;
struct options {
__u64 begin;
__u64 end;
__u32 interval;
list<__u32> chpids;
__u64 topline;
char* filename;
bool print_summary;
bool csv_export;
bool fcp_device;
};
static void init_opts(struct options *opts)
{
opts->begin = 0;
opts->end = UINT64_MAX;
opts->interval = UINT32_MAX;
opts->topline = 0;
opts->filename = NULL;
opts->print_summary = false;
opts->csv_export = false;
opts->fcp_device = false;
}
static const char help_text[] =
"Usage: ziorep_utilization [-V] [-v] [-h] [-b <begin>] [-e <end>] [-i <time>]\n"
" [-x] [-s] [-c <chpid>] [-t <num>] <filename>\n\n"
"-h, --help Print usage information and exit.\n"
"-v, --version Print version information and exit.\n"
"-V, --verbose Be verbose.\n"
"-b, --begin <begin> Do not consider data earlier than 'begin'.\n"
" Defaults to begin of available data.\n"
" Format is YYYY-MM-DD HH:MM[:SS],\n"
" e.g. '-b \"2008-03-21 09:08\"\n"
"-e, --end <end> Do not consider data later than 'end'.\n"
" Defaults to end of available data.\n"
" Format is YYYY-MM-DD HH:MM[:SS],\n"
" e.g. '-e \"2008-03-21 09:08:57\"\n"
"-i, --interval <time> Set aggregation interval to 'time' in seconds.\n"
" Must be a multiple of the interval size of the source\n"
" data.\n"
" Set to 0 to aggregate over all data.\n"
"-s, --summary Show a summary of the data.\n"
"-c, --chpid <chpid> Select physical adapter in hex.\n"
" E.g. '-c 32a'\n"
"-f, --fcp-device Print utilization report for FCP device scope.\n"
" Otherwise for FCP channel scope.\n"
"-x, --export-csv Export data to files in CSV format.\n"
"-t, --topline <num> Repeat topline after every 'num' frames.\n"
" 0 for no repeat (default).\n";
static void print_help()
{
printf("%s", help_text);
}
static void print_version()
{
printf("%s: Utilization report generator version %s\n"
"Copyright IBM Corp. 2008, 2024\n", toolname, RELEASE_STRING);
}
static int parse_params(int argc, char **argv, struct options *opts)
{
int c;
int index;
int rc;
__u32 tmp;
long tmpl;
static struct option long_options[] = {
{ "version", no_argument, NULL, 'v'},
{ "help", no_argument, NULL, 'h'},
{ "verbose", no_argument, NULL, 'V'},
{ "begin", required_argument, NULL, 'b'},
{ "end", required_argument, NULL, 'e'},
{ "interval", required_argument, NULL, 'i'},
{ "summary", no_argument, NULL, 's'},
{ "chpid", required_argument, NULL, 'c'},
{ "export-csv", no_argument, NULL, 'x'},
{ "topline", required_argument, NULL, 't'},
{ "fcp-device", no_argument, NULL, 'f'},
{ 0, 0, 0, 0 }
};
if (argc < 2) {
print_help();
return 1;
}
assert(sizeof(long long int) == sizeof(__u64));
while ((c = getopt_long(argc, argv, "b:e:i:c:t:xshvVf",
long_options, &index)) != EOF) {
switch (c) {
case 'V':
verbose++;
break;
case 'h':
print_help();
return 1;
case 'v':
print_version();
return 1;
case 'b':
if (get_datetime_val(optarg, &opts->begin))
return -1;
break;
case 'e':
if (get_datetime_val(optarg, &opts->end))
return -1;
break;
case 'i':
if (sscanf(optarg, "%lu", &tmpl) != 1) {
fprintf(stderr, "%s: Cannot parse %s as an integer value."
" Please correct and try again.\n", toolname,
optarg);
return -1;
}
if (tmpl < 0) {
fprintf(stderr, "%s: Argument %s must be greater than or"
" equal to 0.", toolname, optarg);
return -1;
}
opts->interval = tmpl;
break;
case 's':
opts->print_summary = true;
break;
case 'c':
rc = sscanf(optarg, "%x", &tmp);
if (rc != 1) {
fprintf(stderr, "Error: Could not read chpid"
" %s\n", optarg);
return -1;
}
opts->chpids.push_back(tmp);
break;
case 'x':
opts->csv_export = true;
break;
case 't':
if (parse_topline_arg(optarg, &opts->topline))
return -1;
break;
case 'f':
opts->fcp_device = true;
break;
default:
fprintf(stderr, "%s: Try '%s --help' for"
" more information.\n", toolname, toolname);
return -1;
}
}
if (optind == argc - 1)
opts->filename = argv[optind];
if (optind < argc - 1) {
fprintf(stderr, "%s: Multiple filenames"
" specified. Specify only a single one at a time.\n", toolname);
return -1;
}
return 0;
}
static int check_opts(struct options *opts, ConfigReader **cfg)
{
int rc = 0;
// check filename
if (!opts->filename) {
fprintf(stderr, "%s: No filename"
" specified.\n", toolname);
return -2;
}
else {
if (strncmp(opts->filename + strlen(opts->filename)
- strlen(DACC_FILE_EXT_LOG), DACC_FILE_EXT_LOG,
strlen(DACC_FILE_EXT_LOG)) == 0) {
verbose_msg("Filename carries " DACC_FILE_EXT_LOG
" extension - stripping\n");
opts->filename[strlen(opts->filename)
- strlen(DACC_FILE_EXT_LOG)] = '\0';
}
if (strncmp(opts->filename + strlen(opts->filename)
- strlen(DACC_FILE_EXT_AGG), DACC_FILE_EXT_AGG,
strlen(DACC_FILE_EXT_AGG)) == 0) {
verbose_msg("Filename carries " DACC_FILE_EXT_AGG
" extension - stripping\n");
opts->filename[strlen(opts->filename)
- strlen(DACC_FILE_EXT_AGG)] = '\0';
}
verbose_msg("Filename is %s\n", opts->filename);
}
// check config
*cfg = new ConfigReader(&rc, opts->filename);
if (rc)
return -1;
// check optional chpids
for (list<__u32>::const_iterator i = opts->chpids.begin();
i != opts->chpids.end(); ++i) {
if (!(*cfg)->verify_chpid(*i)) {
fprintf(stderr, "Error: Could not find chpid %x in"
" configuration.\n", *i);
rc = -2;
}
}
if (opts->csv_export && opts->topline > 0) {
fprintf(stderr, "%s: Warning: Both, topline"
" repeat and CSV export activated, deactivating"
" topline repeat.\n", toolname);
opts->topline = 0;
}
if (!opts->print_summary
&& adjust_timeframe(opts->filename, &opts->begin, &opts->end,
&opts->interval))
rc = -3;
return rc;
}
static int print_reports(struct options *opts, ConfigReader &cfg)
{
int rc = 0;
PhysAdapterPrinter physPrnt(&cfg, opts->csv_export);
VirtAdapterPrinter virtPrnt(&cfg, opts->csv_export);
Aggregator agg = devno;
StagedDeviceFilter dev_filt;
NoopCollapser noop_col;
list<__u32> devnos;
list<__u32> chpids;
list<MsgTypes> type_flt;
AggregationCollapser *col = NULL;
FILE *fp;
if (opts->chpids.size())
chpids = opts->chpids;
else
cfg.get_unique_chpids(chpids);
cfg.get_unique_mms(devnos);
// add all HBAs and all devices connected to them
for (list<__u32>::const_iterator i = chpids.begin();
i != chpids.end(); ++i) {
cfg.get_devnos_by_chpid(devnos, *i);
for (list<__u32>::const_iterator j = devnos.begin();
j != devnos.end(); ++j)
dev_filt.stage_devno(*j);
}
dev_filt.finish(cfg, false);
col = new AggregationCollapser(cfg, agg, dev_filt, &rc);
type_flt.push_back(utilization);
// physical adapter report
if (opts->csv_export) {
fp = open_csv_output_file(opts->filename,
"_util_phys_adpt.csv", &rc);
if (!fp)
goto out;
} else {
fp = stdout;
}
if (!opts->fcp_device || opts->csv_export) {
rc = print_report(fp, opts->begin, opts->end,
opts->interval, opts->filename, opts->topline,
&type_flt, dev_filt, noop_col, physPrnt);
if (rc < 0) {
rc = -3;
goto out1;
} else if (rc == 0) {
fprintf(stderr, "%s: No eligible data found.\n",
toolname);
}
if (!opts->csv_export)
fprintf(stderr,
"%s: The FCP channel utilization report was "
"printed. To print the FCP device utilization "
"report, use the -f/--fcp-device option.\n",
toolname);
}
// virtual adapter report
if (opts->csv_export) {
fclose(fp);
fp = open_csv_output_file(opts->filename,
"_util_virt_adpt.csv", &rc);
if (!fp)
goto out;
} else {
fp = stdout;
}
if (opts->fcp_device || opts->csv_export) {
rc = print_report(fp, opts->begin, opts->end, opts->interval,
opts->filename, opts->topline, NULL, dev_filt,
*col, virtPrnt);
if (rc < 0) {
rc = -4;
goto out1;
} else if (rc == 0) {
fprintf(stderr, "%s: No eligible data found.\n",
toolname);
}
if (!opts->csv_export)
fprintf(stderr,
"%s: The FCP device utilization report was "
"printed. To print the FCP channel utilization "
"report, omit the -f/--fcp-device option.\n",
toolname);
}
out1:
if (opts->csv_export)
fclose(fp);
out:
delete col;
return rc;
}
int main(int argc, char **argv)
{
int rc;
struct options opts;
ConfigReader *cfg = NULL;
verbose = 0;
init_opts(&opts);
if ( (rc = parse_params(argc, argv, &opts)) ) {
if (rc == 1)
rc = 0;
goto out;
}
if ( (rc = check_opts(&opts, &cfg)) )
goto out;
if (opts.print_summary)
rc = print_summary_report(stdout, opts.filename, *cfg);
else
rc = print_reports(&opts, *cfg);
out:
delete cfg;
return rc;
}