refactor: no need defer in closeAll

Signed-off-by: Michael Wan <zirenwan@gmail.com>
2018-11-19 09:41:38 -05:00 · 2018-11-19 09:41:38 -05:00 · 9639db5522
commit 9639db5522
parent e1383c3d23
1 changed files with 4 additions and 4 deletions
--- a/events/exchange/exchange.go
+++ b/events/exchange/exchange.go
@ -138,10 +138,10 @@ func (e *Exchange) Subscribe(ctx context.Context, fs ...string) (ch <-chan *even
 	)

 	closeAll := func() {
-		defer close(errq)
-		defer e.broadcaster.Remove(dst)
-		defer queue.Close()
-		defer channel.Close()
+		channel.Close()
+		queue.Close()
+		e.broadcaster.Remove(dst)
+		close(errq)
 	}

 	ch = evch