github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #8667 from djdongjin/premarshal-empty-resp

Browse Source 
Save marshalled empty response in streaming service
This commit is contained in:
Phil Estes
2023-06-16 17:05:24 -04:00
committed by GitHub
parent b8bd27a14e e26c97cb8b
commit 96de54db43
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
services/streaming/service.go
View File

@@ -31,7 +31,16 @@ import (
"google.golang.org/grpc"
)
var emptyResponse typeurl.Any
func init() {
// save marshalled empty response to avoid marshaling everytime
var err error
emptyResponse, err = typeurl.MarshalAny(&ptypes.Empty{})
if err != nil {
panic(err)
}
plugin.Register(&plugin.Registration{
Type: plugin.GRPCPlugin,
ID: "streaming",
@@ -69,12 +78,6 @@ func (s *service) Stream(srv api.Streaming_StreamServer) error {
return err
}
// TODO: Save this response to avoid marshaling everytime
response, err := typeurl.MarshalAny(&ptypes.Empty{})
if err != nil {
return err
}
cc := make(chan struct{})
ss := &serviceStream{
s: srv,
@@ -87,7 +90,7 @@ func (s *service) Stream(srv api.Streaming_StreamServer) error {
}
// Send response packet after registering stream
if err := srv.Send(protobuf.FromAny(response)); err != nil {
if err := srv.Send(protobuf.FromAny(emptyResponse)); err != nil {
return err
}