github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Reword Windows file related TODO

Browse Source 
https://github.com/golang/go/issues/32088 was never accepted or implemented
in 1.14.

Signed-off-by: Danny Canter <danny@dcantah.dev>
This commit is contained in:
Danny Canter 2023-06-23 05:42:44 -07:00
parent 13498a3258
commit dfd7ad8b37
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/cri/sbserver/helpers_windows.go
View File

@ -28,7 +28,10 @@ import (
// openLogFile opens/creates a container log file. // openLogFile opens/creates a container log file.
// It specifies `FILE_SHARE_DELETE` option to make sure // It specifies `FILE_SHARE_DELETE` option to make sure
// log files can be rotated by kubelet. // log files can be rotated by kubelet.
// TODO(windows): Use golang support after 1.14. (https://github.com/golang/go/issues/32088) //
// Unfortunately this needs to be maintained as Go doesn't
// have a way to set FILE_SHARE_DELETE for os.OpenFile.
// https://github.com/golang/go/issues/32088
func openLogFile(path string) (*os.File, error) { func openLogFile(path string) (*os.File, error) {
path = fixLongPath(path) path = fixLongPath(path)
if len(path) == 0 { if len(path) == 0 {

5
pkg/cri/server/helpers_windows.go
View File

@ -28,7 +28,10 @@ import (
// openLogFile opens/creates a container log file. // openLogFile opens/creates a container log file.
// It specifies `FILE_SHARE_DELETE` option to make sure // It specifies `FILE_SHARE_DELETE` option to make sure
// log files can be rotated by kubelet. // log files can be rotated by kubelet.
// TODO(windows): Use golang support after 1.14. (https://github.com/golang/go/issues/32088) //
// Unfortunately this needs to be maintained as Go doesn't
// have a way to set FILE_SHARE_DELETE for os.OpenFile.
// https://github.com/golang/go/issues/32088
func openLogFile(path string) (*os.File, error) { func openLogFile(path string) (*os.File, error) {
path = fixLongPath(path) path = fixLongPath(path)
if len(path) == 0 { if len(path) == 0 {