github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
8,739 Commits 3 Branches 4 Tags
07f1df4541d6a81c205d194f4f6ea3a6a95c3e29
Commit Graph

8739 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yohei Ueda
07f1df4541 cri: set default masked/readonly paths to empty paths 
Fixes #5029.

Signed-off-by: Yohei Ueda <yohei@jp.ibm.com>
 2021-02-24 23:50:40 +09:00
Phil Estes
af4c55fa4a Merge pull request #5078 from AkihiroSuda/fix-5077 
CI: fix "ls: cannot access '/etc/cni/net.d': Permission denied"
 2021-02-24 09:01:39 -05:00
Akihiro Suda
b4ef1e9dc7 CI: fix "ls: cannot access '/etc/cni/net.d': Permission denied" 
The CI host was probably updated recently and the permission bits of the
directory was changed.

Fix 5077

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2021-02-24 19:11:10 +09:00
Phil Estes
757be0a090 Merge pull request #5017 from AkihiroSuda/parse-cap 
oci.WithPrivileged: set the current caps, not the known caps
 2021-02-23 09:10:57 -05:00
Mike Brown
9173d3e929 Merge pull request #5021 from wzshiming/fix/signal_repeatedly 
Fix repeated sending signal
 2021-02-22 09:45:56 -06:00
Phil Estes
08d765af95 Merge pull request #5028 from Iceber/runtime-spec 
oci: fix the file mode of the device
 2021-02-22 09:25:56 -05:00
Fu, Wei
096e99fe7e Merge pull request #5057 from estesp/moar-time 
Tune test timeouts for GH Actions
 2021-02-20 10:17:24 +08:00
Phil Estes
13f904cde2 Tune test timeouts for GH Actions 
We have enough failures these days; getting timed out when tests are
almost done is the last thing we need :)

On avg. the Linux integration tests are taking 15-17 min, but sometimes
they end up at 20 or a bit over and get canceled. I've seen rare cases
where the Vagrant setup+build+test runs gets very close to 40 min as
well.

Signed-off-by: Phil Estes <estesp@amazon.com>
 2021-02-19 16:27:43 -05:00
Phil Estes
e58be59cbd Merge pull request #5054 from jterry75/fix_env_windows 
cri: append envs from image config to empty slice to avoid env lost
 2021-02-18 20:40:44 -05:00
Justin Terry (SF)
06e4e09567 cri: append envs from image config to empty slice to avoid env lost 
Signed-off-by: Justin Terry (SF) <juterry@microsoft.com>
 2021-02-18 16:39:28 -08:00
Phil Estes
c32ccdf8be Merge pull request #5024 from yadzhang/deepcopy-imageconfig 
cri: append envs from image config to empty slice to avoid env lost
 2021-02-18 12:51:51 -05:00
Phil Estes
d30a6c005f Merge pull request #5045 from wzshiming/fix/file-not-closed 
FIx file is not closed
 2021-02-18 12:45:19 -05:00
Shiming Zhang
5e4acc0436 Fix file is not closed 
Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
 2021-02-18 21:38:44 +08:00
Akihiro Suda
746cef0bc2 Merge pull request #5044 from wzshiming/fix/empty-error-warpping 
Fix empty error warpping
 2021-02-18 13:47:13 +09:00
zhangyadong.0808
08318b1ab9 cri: append envs from image config to empty slice to avoid env lost 
Signed-off-by: Yadong Zhang <yadzhang@gmail.com>
 2021-02-18 11:37:41 +08:00
Shiming Zhang
59db8a10e0 Fix empty error warpping 
Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
 2021-02-18 11:06:59 +08:00
Phil Estes
a98c83c2d4 Merge pull request #5033 from chrisfregly/master 
Fix TestRuntimeHandler logging
 2021-02-17 21:53:17 -05:00
Chris Fregly
80e1d98f6b fix: issue #5032 
Signed-off-by: Chris Fregly <cfregly@ibm.com>
 2021-02-17 18:21:17 -08:00
Justin
0cc3991387 Merge pull request #4912 from dcantah/dcantah/wcow-sandbox-size 
Scratch size customization and UVM scratch creation for WCOW snapshotter
 2021-02-17 15:19:19 -08:00
Shiming Zhang
dc6f5ef3b9 Fix repeated sending signal 
Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
 2021-02-17 21:33:49 +08:00
Michael Crosby
41e3057cc6 Merge pull request #5025 from jeremyje/win20h2 
Add references to Windows 20H2 test images.
 2021-02-12 11:58:49 -05:00
Maksym Pavlenko
88d97362b3 Merge pull request #5027 from kevpar/config-check 
Improve error detection when loading config
 2021-02-10 14:37:31 -08:00
Phil Estes
2adb2ea64c Merge pull request #4973 from lorenz/move-netns-into-statedir 
Allow moving netns directory into StateDir
 2021-02-10 13:08:50 -05:00
Lorenz Brun
36d0bc1f2b Allow moving netns directory into StateDir 
Signed-off-by: Lorenz Brun <lorenz@nexantic.com>
 2021-02-10 18:33:14 +01:00
Mike Brown
e288feacf3 Merge pull request #5026 from crosbymichael/cni-anno 
[cri] add pod annotations to CNI call
 2021-02-10 09:21:58 -06:00
Akihiro Suda
51f985cb1f oci: move cap UT to _linux_test.go 
No substantial code change

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2021-02-10 17:42:18 +09:00
Iceber Gu
d08aa4b681 oci: fix the file mode of the device 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
 2021-02-10 16:37:12 +08:00
Akihiro Suda
a2d1a8a865 oci.WithPrivileged: set the current caps, not the known caps 
This change is needed for running the latest containerd inside Docker
that is not aware of the recently added caps (BPF, PERFMON, CHECKPOINT_RESTORE).

Without this change, containerd inside Docker fails to run containers with
"apply caps: operation not permitted" error.

See kubernetes-sigs/kind 2058

NOTE: The caller process of this function is now assumed to be as
privileged as possible.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2021-02-10 17:14:17 +09:00
Kevin Parsons
5f051c1d71 Improve error detection when loading config 
Previously we simply ignored any not found error when loading the
containerd config. This created unintuitive behavior:

- If the user specified a path that didn't exist via --config, we would
  silently ignore the error.
- If a config specified an import that didn't exist, we would silently
  ignore the error.

In either of these cases, it appears we would end up using a potentially
corrupted config, as it would contain any files that were merged into it
before the not found error was hit.

However, we can't just remove the check for !os.IsNotExist(err),
as we shouldn't throw an error when --config is not passed, but the
default config doesn't exist.

This change updates the logic to only attempt to load the config if
we know it exists, or the user passed --config.

Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
 2021-02-09 16:21:32 -08:00
Michael Crosby
e874e2597e [cri] add pod annotations to CNI call 
Signed-off-by: Michael Crosby <michael@thepasture.io>
 2021-02-09 13:24:01 -05:00
Jeremy Edwards
1c81071d39 Add references to Windows 20H2 test images. 
Signed-off-by: Jeremy Edwards <1312331+jeremyje@users.noreply.github.com>
 2021-02-09 16:25:36 +00:00
Derek McGowan
ddcc431c11 Merge pull request #5016 from thaJeztah/bump_cgroups 
go.mod: containerd/cgroups 8a68de567b68b30602948417a7a8e99ccf00ee9b
 2021-02-07 18:09:40 -08:00
Sebastiaan van Stijn
6be7c9f4e2 go.mod: containerd/cgroups 8a68de567b68b30602948417a7a8e99ccf00ee9b 
full diff: 0b889c03f1...8a68de567b

- utils: export RunningInUserNS()
- Support updates for net_cls (adds netclsController.Update())
- Only append Hugetlb in Subsystems list when available
- dependency updates (for compatibility with recent Go versions):
    - go.mod: github.com/cilium/ebpf v0.2.0
    - go.mod: github.com/coreos/go-systemd v22.1.0
    - go.mod: sirupsen/logrus v1.7.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-02-06 13:10:35 +01:00
Derek McGowan
cfa842c278 Merge pull request #5003 from dmcgowan/prepare-1.5.0-beta.1 
Prepare release notes for 1.5.0-beta.1
 2021-02-05 13:51:32 -08:00
Derek McGowan
a2973c70a5 Prepare release notes for 1.5.0-beta.1 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2021-02-05 08:28:54 -08:00
Derek McGowan
b3f2402062 Merge pull request #5002 from crosbymichael/anno-image-name 
[cri] add image-name annotation
 2021-02-05 08:27:41 -08:00
Akihiro Suda
e908be5b58 Merge pull request #5001 from kzys/no-lint-upgrade 2021-02-06 00:40:38 +09:00
Akihiro Suda
d05f7bdf02 Merge pull request #5011 from thaJeztah/setup_go_v2 2021-02-06 00:39:31 +09:00
Akihiro Suda
25e42e702c Merge pull request #5004 from thaJeztah/bump_golang 2021-02-06 00:38:48 +09:00
Sebastiaan van Stijn
129c67dc85 GHA: use setup-go@v2 
https://github.com/actions/setup-go/tree/v2.1.3#v2

The V2 offers:

- Adds GOBIN to the PATH
- Proxy Support
- stable input
- Bug Fixes (including issues around version matching and semver)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-02-05 15:39:07 +01:00
Sebastiaan van Stijn
ec7d905f4e Update to go 1.15.8 
go1.15.8 (released 2021/02/04) includes fixes to the compiler, linker, runtime,
the go command, and the net/http package. See the Go 1.15.8 milestone on the
issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.15.8+label%3ACherryPickApproved

full diff: https://github.com/golang/go/compare/go1.15.7...go1.15.8

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-02-05 12:53:25 +01:00
Akihiro Suda
5f2d02adc5 Merge pull request #4717 from thaJeztah/reduce_libcontainer_use 2021-02-05 14:28:05 +09:00
Derek McGowan
ccbeb550ba Merge pull request #4991 from kzys/no-auto-clear 
mount: setupLoop() doesn't work with with Autoclear
 2021-02-04 15:00:52 -08:00
Michael Crosby
e9e3b1d6fd Merge pull request #5000 from kzys/fix-assert-check 
test: fix assert.Check's argumets to show its parameters correctly
 2021-02-04 16:11:24 -05:00
Kazuyoshi Kato
07db46ee23 lint: update nolint syntax for golangci-lint 
Newer golangci-lint needs explicit `//` separator. Otherwise it treats
the entire line (`staticcheck deprecated ... yet`) as a name.

https://golangci-lint.run/usage/false-positives/#nolint

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
 2021-02-04 11:59:55 -08:00
Kazuyoshi Kato
b14ccd2053 ci/gha: upgrade golangci-lint from v1.29.0 to v1.36.0 
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
 2021-02-04 11:59:51 -08:00
Phil Estes
aa5e55ad98 Merge pull request #4980 from thaJeztah/prevent_cio_npe 
cio: prevent NPE when closing, and fix pipes potentially not being closed on Windows
 2021-02-04 14:24:10 -05:00
Phil Estes
e178af2d36 Merge pull request #4999 from thaJeztah/retry_fedora 
ci/gha/fedora: retry vagrant up
 2021-02-04 14:11:36 -05:00
Kazuyoshi Kato
05a2e280ac mount: make setupLoop() work with with Autoclear 
setupLoop()'s Autoclear (LO_FLAGS_AUTOCLEAR) will destruct the
loopback device when all associated file descriptors are closed.

However this behavior didn't work before since setupLoop() was
returning a file name. The looppack device was destructed at
the end of the function when LoopParams had Autoclear = true.

Fixes #4969.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
 2021-02-04 11:04:04 -08:00
Kazuyoshi Kato
2ac33d79fe test: fix assert.Check's argumets to show its parameters correctly 
The change I made at db6075fc2 didn't show its parameters correctly.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
 2021-02-04 10:56:58 -08:00