Commit Graph

14070 Commits

Author SHA1 Message Date
Maksym Pavlenko
4c6d0ef1d5
Merge pull request #9833 from dmcgowan/update-1.7-release-timeline
Update 1.7 support timeline
2024-02-21 20:33:58 +00:00
dependabot[bot]
04c37d5659
build(deps): bump the k8s group with 5 updates
Bumps the k8s group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.1` | `0.29.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.1` | `0.29.2` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.29.1` | `0.29.2` |
| [k8s.io/klog/v2](https://github.com/kubernetes/klog) | `2.110.1` | `2.120.1` |
| [k8s.io/kubelet](https://github.com/kubernetes/kubelet) | `0.29.1` | `0.29.2` |


Updates `k8s.io/apimachinery` from 0.29.1 to 0.29.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.29.1...v0.29.2)

Updates `k8s.io/client-go` from 0.29.1 to 0.29.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.29.1...v0.29.2)

Updates `k8s.io/component-base` from 0.29.1 to 0.29.2
- [Commits](https://github.com/kubernetes/component-base/compare/v0.29.1...v0.29.2)

Updates `k8s.io/klog/v2` from 2.110.1 to 2.120.1
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes/klog/compare/v2.110.1...v2.120.1)

Updates `k8s.io/kubelet` from 0.29.1 to 0.29.2
- [Commits](https://github.com/kubernetes/kubelet/compare/v0.29.1...v0.29.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s
- dependency-name: k8s.io/kubelet
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-21 19:33:00 +00:00
Phil Estes
b6ee1add7c
Merge pull request #9845 from dcantah/prometheus-middleware-deprecated
Replace go-grpc-prometheus with go-grpc-middleware/providers/prometheus
2024-02-21 18:55:34 +00:00
Phil Estes
b93409cf72
Merge pull request #9848 from akhilerm/update-crun-version
ci: update crun version to 1.14.3
2024-02-21 18:53:08 +00:00
Phil Estes
8ce402c24c
Merge pull request #9787 from AkihiroSuda/cri-rro-kep-3857
KEP-3857: Recursive Read-only (RRO) mounts
2024-02-21 18:52:43 +00:00
Derek McGowan
b8654e36f4
Merge pull request #8379 from jedevc/docker-pusher-concurrency
Fix various timing issues with docker pusher
2024-02-21 17:59:56 +00:00
Akhil Mohan
bd48104159
ci: update crun version to 1.14.3
Changes:
https://github.com/containers/crun/compare/1.14...1.14.3

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
2024-02-21 18:46:02 +05:30
Derek McGowan
50d0de96a8
Update 1.7 support timeline
Tie the 1.7 support timeline to 1.6.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2024-02-20 14:32:27 -08:00
Brian Goff
4fbc9842d5 Changes to configuring otel from env only
These are standard environment variables described by the otel spec in
https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/.

The old config options are removed

Also since otel will by default try to connect to https://localhost:4318
if no endpoint is set, this will also just disable the otlp plugin when
there is no endpoint so we don't have otel continuously trying to
connect to the default endpoint, littering the logs with connection
failure messages and collecting traces that won't go anywhere.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2024-02-20 21:59:45 +00:00
Brian Goff
753a525b3b Deprecate otel configs
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2024-02-20 21:59:42 +00:00
Maksym Pavlenko
4510ca3db1
Merge pull request #9789 from dmcgowan/update-restart-plugin-type
Add container monitor plugin type for restart
2024-02-20 21:56:37 +00:00
Maksym Pavlenko
d32dc0e76d
Merge pull request #9847 from akhilerm/replace-prestart-oci-hook
replace deprecated Prestart to CreateRuntime hook
2024-02-20 21:51:02 +00:00
Maksym Pavlenko
16da4deddc
Merge pull request #9843 from containerd/dependabot/go_modules/github.com/opencontainers/image-spec-1.1.0
build(deps): bump github.com/opencontainers/image-spec from 1.1.0-rc6 to 1.1.0
2024-02-20 21:48:50 +00:00
Akhil Mohan
0693b936d2
replace deprecated Prestart to CreateRuntime hook
Prestart Hook is deprecated and can be replaced with CreateRuntime hook

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
2024-02-20 21:54:47 +05:30
Danny Canter
6a21c96b55 Replace go-grpc-prometheus with go-grpc-middleware/providers/prometheus
Fixes #9806

go-grpc-prometheus is deprecated. The new location it was moved to also introduced
an entirely new api, but afaict this matches what we have at the moment.

Signed-off-by: Danny Canter <danny@dcantah.dev>
2024-02-20 02:01:57 -08:00
Fu Wei
4612201f87
Merge pull request #9635 from Burning1020/fix-cri-mounts
cri: Stat host sandbox files before adding them
2024-02-20 09:54:16 +00:00
dependabot[bot]
567e56a206
build(deps): bump github.com/opencontainers/image-spec
Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec) from 1.1.0-rc6 to 1.1.0.
- [Release notes](https://github.com/opencontainers/image-spec/releases)
- [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md)
- [Commits](https://github.com/opencontainers/image-spec/compare/v1.1.0-rc6...v1.1.0)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/image-spec
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-19 23:15:19 +00:00
Austin Vazquez
6a759713ad
Update golangci-lint to v1.56.1
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
2024-02-19 15:15:01 +00:00
Austin Vazquez
f44d90be4a
Rename variables and snapshotter option to resolve lint warnings
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
2024-02-19 15:14:00 +00:00
Zhang Tianyang
5611db5309 cri: Make sure host sandbox files exist before adding them to mounts
As `setupSandboxFiles` was done in sandbox controller, it is difficult
here to know if the sandbox controller has done and where the host path
in. Make sure the host path exists before adding them to linux container
mounts, otherwise, the container would generate some unnecessary mounts.

Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
2024-02-19 20:40:24 +08:00
Akihiro Suda
9077d13728
KEP-3857: Recursive Read-only (RRO) mounts
See kubernetes/enhancements issue 3857 (PR 3858).

Replaces PR 9713 `cri: make read-only mounts recursively read-only`

Unlike PR 9713, this PR does not automatically upgrade RO mounts to RRO.

Test depends on:
- kubernetes-sigs/cri-tools PR 1344

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-19 00:42:50 +09:00
Akihiro Suda
83ad4367d1
script/test/utils.sh: readiness_check: print daemon log
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-17 23:56:38 +09:00
Samuel Karp
b87d78f456
Merge pull request #9765 from AkihiroSuda/remove-schema1
Disable the support for Schema 1 images
2024-02-17 09:20:15 +00:00
Phil Estes
1641c7571f
Merge pull request #9809 from dereknola/urfave_v2
Migrate Urfave CLI from v1 to v2
2024-02-16 16:13:37 +00:00
Phil Estes
0f5586ee09
Merge pull request #9748 from fuweid/upgrade-testcase
test: update upgrade test suite in integration
2024-02-16 16:11:25 +00:00
Fu Wei
dc88cdea1b
Merge pull request #9829 from mxpv/fp
Run failpoints tests only for runc
2024-02-16 06:10:08 +00:00
Derek McGowan
c36950d64e
Merge pull request #9831 from mxpv/status
Workaround "required job statuses" job list
2024-02-16 06:09:34 +00:00
Derek McGowan
d346aeebdf
Merge pull request #9746 from neoaggelos/fix/config-glob
Fix config import relative path glob
2024-02-16 06:08:17 +00:00
Derek McGowan
f8f1e5f7a6
Add container monitor plugin type for restart
Adds a plugin type for container monitor.
Rename the task monitor type to avoid confusion.
Add config migration for new plugin types to pass existing migration
tests.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2024-02-15 21:54:40 -08:00
Wei Fu
c86c8a16f0 integration: add case related to ContainerStats in upgrade suite
It's used to check new release containerd can parse metric data from existing
shim created by previous release.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
acec60f554 integration: update recover case for upgrade
The new release containerd should detect dead shim during recover.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
e659cd2752 integration: connect to shim by bridge client
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
51689b6618 integration: introduce hook for upgrade test suite
We can inject failpoint in beforeUpgradeHookFunc.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
a95c8ed591 integration: check data dir after delete container or pod
The new release containerd should cleanup old pod's data dir after
RemovePodSandbox.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
ec759f5be4 integration/*: extend Runtime.Status response
CRI Runtime Status contains `Info` and it can help us check current
configuration.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
401d4b491f integration: add some helper function to release upgrade cases
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:30 +08:00
Maksym Pavlenko
7cf8a00c77
Run failpoints tests only for runc
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-15 12:19:31 -08:00
Maksym Pavlenko
a890c8e537
Add job to report statuses from matrix jobs
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-15 12:13:58 -08:00
Derek Nola
132485adb0
Convert CLI to urfave v2
Followed the Migration Guide at https://cli.urfave.org/migrate-v1-to-v2/
The major changes not pointed out in the migration guide are:
- context.Args() no longer produces a []slice, so context.Args().Slice()
  in substitued
- All cli.Global***** are deprecated (the migration guide is somewhat
  unclear on this)

Signed-off-by: Derek Nola <derek.nola@suse.com>

Vendor in urfave cli/v2

Signed-off-by: Derek Nola <derek.nola@suse.com>

Fix NewStringSlice calls

Signed-off-by: Derek Nola <derek.nola@suse.com>
2024-02-15 09:48:04 -08:00
Phil Estes
00fe7a4974
Merge pull request #9827 from dmcgowan/move-config-version
Move config version to version package
2024-02-15 14:58:04 +00:00
Kirill A. Korinsky
c8766123d9
Prevent GC from schedule itself with 0 period.
On startup `gcTimeSum` might work fast and return `0`, so on this case
the algorithm turns in infinity loop which simple consume CPU on timer
which fires without any interval.

Use `5ms` as fallback to have interval `245ms` for that case.

Closes: https://github.com/containerd/containerd/issues/5089

Signed-off-by: Kirill A. Korinsky <kirill@korins.ky>
2024-02-15 11:32:53 +01:00
Derek McGowan
a086125ae3
Move config version to version package
Signed-off-by: Derek McGowan <derek@mcg.dev>
2024-02-14 21:09:44 -08:00
Akihiro Suda
99721c27e1
Disable the support for Schema 1 images
Schema 1 (`application/vnd.docker.distribution.manifest.v1+prettyjws`) has been
officially deprecated since containerd v1.7 (PR 6884).

We have planned to remove the support for Schema 1 in containerd v2.0, but this
removal may still surprise some users.
So, in containerd v2.0 we will just disable it by default.

The support for Schema 1 can be still enabled by setting an environment variable
`CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1`, however, this workaround
will be completely removed in containerd v2.1.

Schema 2 was introduced in Docker 1.10 (Feb 2016), so most users should
have been already using Schema 2 or OCI.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-15 11:11:35 +09:00
Mike Brown
f1a3c3705f
Merge pull request #9815 from kiashok/updateCRIServicePull
Pass runtimehandler from CRI to pull image request
2024-02-15 00:38:40 +00:00
Mike Brown
97f86f18ae
Merge pull request #9788 from kiashok/criRemoveImage
Add CRIImageService.RemoveImage()
2024-02-14 23:49:07 +00:00
Kirtana Ashok
b9dfba5b80 Add CRIImageService.RemoveImage()
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-14 13:49:39 -08:00
Kirtana Ashok
4c775fcfbf Pass runtimehandler from CRI pull image request
Starting with k8s cri-api v0.29.1, CRI supports new runtime handler flag

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-14 13:31:23 -08:00
Akihiro Suda
32169d591d
Merge pull request #9807 from AkihiroSuda/ctr-print-deprecations
ctr: print deprecation warnings on every invocation
2024-02-14 05:48:52 +00:00
Akihiro Suda
a2cf4fb9ba
Merge pull request #9817 from kiashok/moveToTraceLogs
Move high volume event logs to Trace level
2024-02-14 05:42:44 +00:00
Kirtana Ashok
4dcf089fa3 Move high volume event logs to Trace level
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-13 20:05:50 -08:00