github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #63588 from jsafrane/remove-fsgroup-feature-test

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 63588, 63806). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Run FSGroup tests by default.

There is no special feature flag for FSGroup and the tests can run in all test suites. They're reasonably fast too.

**Release note**:

```release-note
NONE
```

cc: @jeffvance
This commit is contained in:
Kubernetes Submit Queue
2018-05-14 11:26:15 -07:00
committed by GitHub
parent f5a91f4173 b1ae20fdab
commit 13f846f71a
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/e2e/common/configmap_volume.go
View File

@@ -51,7 +51,7 @@ var _ = Describe("[sig-storage] ConfigMap", func() {
doConfigMapE2EWithoutMappings(f, 0, 0, &defaultMode)
})
It("should be consumable from pods in volume as non-root with defaultMode and fsGroup set [Feature:FSGroup]", func() {
It("should be consumable from pods in volume as non-root with defaultMode and fsGroup set", func() {
defaultMode := int32(0440) /* setting fsGroup sets mode to at least 440 */
doConfigMapE2EWithoutMappings(f, 1000, 1001, &defaultMode)
})
@@ -65,7 +65,7 @@ var _ = Describe("[sig-storage] ConfigMap", func() {
doConfigMapE2EWithoutMappings(f, 1000, 0, nil)
})
It("should be consumable from pods in volume as non-root with FSGroup [Feature:FSGroup]", func() {
It("should be consumable from pods in volume as non-root with FSGroup", func() {
doConfigMapE2EWithoutMappings(f, 1000, 1001, nil)
})
@@ -97,7 +97,7 @@ var _ = Describe("[sig-storage] ConfigMap", func() {
doConfigMapE2EWithMappings(f, 1000, 0, nil)
})
It("should be consumable from pods in volume with mappings as non-root with FSGroup [Feature:FSGroup]", func() {
It("should be consumable from pods in volume with mappings as non-root with FSGroup", func() {
doConfigMapE2EWithMappings(f, 1000, 1001, nil)
})

4
test/e2e/common/downwardapi_volume.go
View File

@@ -83,7 +83,7 @@ var _ = Describe("[sig-storage] Downward API volume", func() {
})
})
It("should provide podname as non-root with fsgroup [Feature:FSGroup]", func() {
It("should provide podname as non-root with fsgroup", func() {
podName := "metadata-volume-" + string(uuid.NewUUID())
uid := int64(1001)
gid := int64(1234)
@@ -97,7 +97,7 @@ var _ = Describe("[sig-storage] Downward API volume", func() {
})
})
It("should provide podname as non-root with fsgroup and defaultMode [Feature:FSGroup]", func() {
It("should provide podname as non-root with fsgroup and defaultMode", func() {
podName := "metadata-volume-" + string(uuid.NewUUID())
uid := int64(1001)
gid := int64(1234)

10
test/e2e/common/projected.go
View File

@@ -419,7 +419,7 @@ var _ = Describe("[sig-storage] Projected", func() {
doProjectedConfigMapE2EWithoutMappings(f, 0, 0, &defaultMode)
})
It("should be consumable from pods in volume as non-root with defaultMode and fsGroup set [Feature:FSGroup]", func() {
It("should be consumable from pods in volume as non-root with defaultMode and fsGroup set", func() {
defaultMode := int32(0440) /* setting fsGroup sets mode to at least 440 */
doProjectedConfigMapE2EWithoutMappings(f, 1000, 1001, &defaultMode)
})
@@ -433,7 +433,7 @@ var _ = Describe("[sig-storage] Projected", func() {
doProjectedConfigMapE2EWithoutMappings(f, 1000, 0, nil)
})
It("should be consumable from pods in volume as non-root with FSGroup [Feature:FSGroup]", func() {
It("should be consumable from pods in volume as non-root with FSGroup", func() {
doProjectedConfigMapE2EWithoutMappings(f, 1000, 1001, nil)
})
@@ -466,7 +466,7 @@ var _ = Describe("[sig-storage] Projected", func() {
doProjectedConfigMapE2EWithMappings(f, 1000, 0, nil)
})
It("should be consumable from pods in volume with mappings as non-root with FSGroup [Feature:FSGroup]", func() {
It("should be consumable from pods in volume with mappings as non-root with FSGroup", func() {
doProjectedConfigMapE2EWithMappings(f, 1000, 1001, nil)
})
@@ -904,7 +904,7 @@ var _ = Describe("[sig-storage] Projected", func() {
})
})
It("should provide podname as non-root with fsgroup [Feature:FSGroup]", func() {
It("should provide podname as non-root with fsgroup", func() {
podName := "metadata-volume-" + string(uuid.NewUUID())
uid := int64(1001)
gid := int64(1234)
@@ -918,7 +918,7 @@ var _ = Describe("[sig-storage] Projected", func() {
})
})
It("should provide podname as non-root with fsgroup and defaultMode [Feature:FSGroup]", func() {
It("should provide podname as non-root with fsgroup and defaultMode", func() {
podName := "metadata-volume-" + string(uuid.NewUUID())
uid := int64(1001)
gid := int64(1234)