github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Promote RetryGenerateName to beta

Browse Source
This commit is contained in:
Joe Betz
2024-05-01 20:34:21 -04:00
parent bf454d7c59
commit 1b59f3678f
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/features/kube_features.go
View File

@@ -1045,7 +1045,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // lock to default and remove after v1.22 based on KEP #1972 update
RetryGenerateName: {Default: false, PreRelease: featuregate.Alpha},
RetryGenerateName: {Default: true, PreRelease: featuregate.Beta},
GracefulNodeShutdown: {Default: true, PreRelease: featuregate.Beta},

2
staging/src/k8s.io/apiserver/pkg/features/kube_features.go
View File

@@ -335,7 +335,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
RemainingItemCount: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.32
RetryGenerateName: {Default: false, PreRelease: featuregate.Alpha},
RetryGenerateName: {Default: true, PreRelease: featuregate.Beta},
SeparateCacheWatchRPC: {Default: true, PreRelease: featuregate.Beta},

4
staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store_test.go
View File

@@ -399,7 +399,6 @@ func (m *sequentialNameGenerator) GenerateName(base string) string {
}
func TestStoreCreateWithRetryNameGenerate(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, true)
namedObj := func(id int) *example.Pod {
return &example.Pod{
@@ -448,6 +447,7 @@ func TestStoreCreateWithRetryNameGenerate(t *testing.T) {
}
func TestStoreCreateWithRetryNameGenerateFeatureDisabled(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
namedObj := func(id int) *example.Pod {
return &example.Pod{
ObjectMeta: metav1.ObjectMeta{Name: fmt.Sprintf("prefix-%d", id), Namespace: "test"},
@@ -2973,6 +2973,8 @@ func (p *predictableNameGenerator) GenerateName(base string) string {
}
func TestStoreCreateGenerateNameConflict(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.RetryGenerateName, false)
// podA will be stored with name foo12345
podA := &example.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "foo1", Namespace: "test"},