github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clean up unused var containerCache

Browse Source
This commit is contained in:
RyderXia 2020-07-21 16:57:36 +08:00
parent adabcc31f0
commit 2214117cd1
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/kubelet/metrics/metrics.go
View File

@ -29,7 +29,6 @@ import (
utilfeature "k8s.io/apiserver/pkg/util/feature"
"k8s.io/klog/v2"
"k8s.io/kubernetes/pkg/features"
kubecontainer "k8s.io/kubernetes/pkg/kubelet/container"
)
// This const block defines the metric names for the kubelet metrics.
@ -369,7 +368,7 @@ var (
var registerMetrics sync.Once
// Register registers all metrics.
func Register(containerCache kubecontainer.RuntimeCache, collectors ...metrics.StableCollector) {
func Register(collectors ...metrics.StableCollector) {
// Register the metrics.
registerMetrics.Do(func() {
legacyregistry.MustRegister(NodeName)

4
pkg/kubelet/pleg/generic_test.go
View File

@ -650,9 +650,7 @@ func TestRelistIPChange(t *testing.T) {
}
func TestRunningPodAndContainerCount(t *testing.T) {
fakeRuntime := &containertest.FakeRuntime{}
runtimeCache, _ := kubecontainer.NewRuntimeCache(fakeRuntime)
metrics.Register(runtimeCache)
metrics.Register()
testPleg := newTestGenericPLEG()
pleg, runtime := testPleg.pleg, testPleg.runtime