github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scheduler-perf: inject "benchmark" as name into JSON result filename

Browse Source 
This is required because an empty name is no longer supported: the
perf-dashboard is run with --allow-parsers-matching-all-tests=false with causes
perfdash to skip current configuration for BenchmarkPerfResults as it does not
have name
set (4674704f45/perfdash/metrics-downloader.go (L165-L167)).

The perf-dash config needs to be updated accordingly.
This commit is contained in:
Patrick Ohly
2023-05-22 08:01:20 +02:00
parent b9c7726046
commit 2db577a560
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/integration/scheduler_perf/README.md
View File

@@ -48,7 +48,7 @@ as "fast":
make test-integration WHAT=./test/integration/scheduler_perf ETCD_LOGLEVEL=warn KUBE_TEST_VMODULE="''" KUBE_TEST_ARGS="-run=^$$ -benchtime=1ns -bench=BenchmarkPerfScheduling -perf-scheduling-label-filter=performance,-fast"
```
Once the benchmark is finished, JSON file with metrics is available in the current directory (test/integration/scheduler_perf). Look for `BenchmarkPerfScheduling_YYYY-MM-DDTHH:MM:SSZ.json`.
Once the benchmark is finished, JSON file with metrics is available in the current directory (test/integration/scheduler_perf). Look for `BenchmarkPerfScheduling_benchmark_YYYY-MM-DDTHH:MM:SSZ.json`.
You can use `-data-items-dir` to generate the metrics file elsewhere.
In case you want to run a specific test in the suite, you can specify the test through `-bench` flag:

2
test/integration/scheduler_perf/scheduler_perf_test.go
View File

@@ -724,7 +724,7 @@ func BenchmarkPerfScheduling(b *testing.B) {
}
})
}
if err := dataItems2JSONFile(dataItems, b.Name()); err != nil {
if err := dataItems2JSONFile(dataItems, b.Name()+"_benchmark"); err != nil {
b.Fatalf("unable to write measured data %+v: %v", dataItems, err)
}
}