github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #100741 from mengjiao-liu/fix-test-err

Browse Source 
Fix  incorrect test code in pkg/volume/csi/csi_attacher_test.go file
This commit is contained in:
Kubernetes Prow Robot
2021-06-08 08:33:12 -07:00
committed by GitHub
parent 0322d34a3e 1d764952da
commit 8b787f3a22
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/volume/csi/csi_attacher_test.go
View File

@@ -754,7 +754,7 @@ func TestAttacherWaitForVolumeAttachment(t *testing.T) {
if tc.shouldFail && err == nil {
t.Error("expecting failure, but err is nil")
}
if tc.initAttachErr != nil {
if tc.initAttachErr != nil && err != nil {
if tc.initAttachErr.Message != err.Error() {
t.Errorf("expecting error [%v], got [%v]", tc.initAttachErr.Message, err.Error())
}
@@ -1268,7 +1268,7 @@ func TestAttacherMountDevice(t *testing.T) {
}
return
}
if err == nil && tc.shouldFail {
if tc.shouldFail {
t.Errorf("test should fail, but no error occurred")
}
@@ -1440,7 +1440,7 @@ func TestAttacherMountDeviceWithInline(t *testing.T) {
}
return
}
if err == nil && tc.shouldFail {
if tc.shouldFail {
t.Errorf("test should fail, but no error occurred")
}
@@ -1585,7 +1585,7 @@ func TestAttacherUnmountDevice(t *testing.T) {
}
return
}
if err == nil && tc.shouldFail {
if tc.shouldFail {
t.Errorf("test should fail, but no error occurred")
}