Merge pull request #35862 from madhusudancs/federation-kubefed-init-05
Automatic merge from submit-queue [Federation][init-05] Separate the notions of controller manager name and federation name in the controller manager deployment spec. Please review only the last commit here. This is based on PR #35861 which will be reviewed independently. Design Doc: PR #34484 cc @kubernetes/sig-cluster-federation @nikhiljindal
This commit is contained in:
		| @@ -196,7 +196,7 @@ func initFederation(cmdOut io.Writer, config util.AdminConfig, cmd *cobra.Comman | ||||
| 	} | ||||
|  | ||||
| 	// 7. Create federation controller manager | ||||
| 	_, err = createControllerManager(hostClientset, initFlags.FederationSystemNamespace, cmName, cmKubeconfigName, dnsZoneName) | ||||
| 	_, err = createControllerManager(hostClientset, initFlags.FederationSystemNamespace, initFlags.Name, cmName, cmKubeconfigName, dnsZoneName) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| @@ -456,10 +456,10 @@ func createAPIServer(clientset *client.Clientset, namespace, name, credentialsNa | ||||
| 	return clientset.Extensions().Deployments(namespace).Create(dep) | ||||
| } | ||||
|  | ||||
| func createControllerManager(clientset *client.Clientset, namespace, name, kubeconfigName, dnsZoneName string) (*extensions.Deployment, error) { | ||||
| func createControllerManager(clientset *client.Clientset, namespace, name, cmName, kubeconfigName, dnsZoneName string) (*extensions.Deployment, error) { | ||||
| 	dep := &extensions.Deployment{ | ||||
| 		ObjectMeta: api.ObjectMeta{ | ||||
| 			Name:      name, | ||||
| 			Name:      cmName, | ||||
| 			Namespace: namespace, | ||||
| 			Labels:    componentLabel, | ||||
| 		}, | ||||
| @@ -467,7 +467,7 @@ func createControllerManager(clientset *client.Clientset, namespace, name, kubec | ||||
| 			Replicas: 1, | ||||
| 			Template: api.PodTemplateSpec{ | ||||
| 				ObjectMeta: api.ObjectMeta{ | ||||
| 					Name:   name, | ||||
| 					Name:   cmName, | ||||
| 					Labels: controllerManagerPodLabels, | ||||
| 				}, | ||||
| 				Spec: api.PodSpec{ | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Kubernetes Submit Queue
					Kubernetes Submit Queue