Add unit test to portallocator storage
Add unit test for the portallocator storage based on the ipallocator ones. pkg/registry/core/service/ipallocator/storage/storage_test.go
This commit is contained in:
Antonio Ojea
parent
1aa2c99a27
commit
cb87793d57
@ -47,6 +47,7 @@ filegroup(
|
||||
srcs = [
|
||||
":package-srcs",
|
||||
"//pkg/registry/core/service/portallocator/controller:all-srcs",
|
||||
"//pkg/registry/core/service/portallocator/storage:all-srcs",
|
||||
],
|
||||
tags = ["automanaged"],
|
||||
)
|
||||
|
||||
45
pkg/registry/core/service/portallocator/storage/BUILD
Normal file
45
pkg/registry/core/service/portallocator/storage/BUILD
Normal file
@ -0,0 +1,45 @@
|
||||
package(default_visibility = ["//visibility:public"])
|
||||
|
||||
load(
|
||||
"@io_bazel_rules_go//go:def.bzl",
|
||||
"go_library",
|
||||
"go_test",
|
||||
)
|
||||
|
||||
go_test(
|
||||
name = "go_default_test",
|
||||
srcs = ["storage_test.go"],
|
||||
embed = [":go_default_library"],
|
||||
deps = [
|
||||
"//pkg/apis/core:go_default_library",
|
||||
"//pkg/apis/core/install:go_default_library",
|
||||
"//pkg/registry/core/service/allocator:go_default_library",
|
||||
"//pkg/registry/core/service/allocator/storage:go_default_library",
|
||||
"//pkg/registry/core/service/portallocator:go_default_library",
|
||||
"//pkg/registry/registrytest:go_default_library",
|
||||
"//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library",
|
||||
"//staging/src/k8s.io/apiserver/pkg/registry/generic:go_default_library",
|
||||
"//staging/src/k8s.io/apiserver/pkg/storage:go_default_library",
|
||||
"//staging/src/k8s.io/apiserver/pkg/storage/etcd3/testing:go_default_library",
|
||||
"//staging/src/k8s.io/apiserver/pkg/storage/storagebackend/factory:go_default_library",
|
||||
],
|
||||
)
|
||||
|
||||
go_library(
|
||||
name = "go_default_library",
|
||||
srcs = ["storage.go"],
|
||||
importpath = "k8s.io/kubernetes/pkg/registry/core/service/portallocator/storage",
|
||||
)
|
||||
|
||||
filegroup(
|
||||
name = "package-srcs",
|
||||
srcs = glob(["**"]),
|
||||
tags = ["automanaged"],
|
||||
visibility = ["//visibility:private"],
|
||||
)
|
||||
|
||||
filegroup(
|
||||
name = "all-srcs",
|
||||
srcs = [":package-srcs"],
|
||||
tags = ["automanaged"],
|
||||
)
|
||||
19
pkg/registry/core/service/portallocator/storage/storage.go
Normal file
19
pkg/registry/core/service/portallocator/storage/storage.go
Normal file
@ -0,0 +1,19 @@
|
||||
/*
|
||||
Copyright 2020 The Kubernetes Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package storage
|
||||
|
||||
// Keep CI happy; it is unhappy if a directory only contains tests
|
||||
184
pkg/registry/core/service/portallocator/storage/storage_test.go
Normal file
184
pkg/registry/core/service/portallocator/storage/storage_test.go
Normal file
@ -0,0 +1,184 @@
|
||||
/*
|
||||
Copyright 2020 The Kubernetes Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package storage
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
utilnet "k8s.io/apimachinery/pkg/util/net"
|
||||
"k8s.io/apiserver/pkg/registry/generic"
|
||||
"k8s.io/apiserver/pkg/storage"
|
||||
etcd3testing "k8s.io/apiserver/pkg/storage/etcd3/testing"
|
||||
"k8s.io/apiserver/pkg/storage/storagebackend/factory"
|
||||
api "k8s.io/kubernetes/pkg/apis/core"
|
||||
_ "k8s.io/kubernetes/pkg/apis/core/install"
|
||||
"k8s.io/kubernetes/pkg/registry/core/service/allocator"
|
||||
allocatorstore "k8s.io/kubernetes/pkg/registry/core/service/allocator/storage"
|
||||
"k8s.io/kubernetes/pkg/registry/core/service/portallocator"
|
||||
"k8s.io/kubernetes/pkg/registry/registrytest"
|
||||
)
|
||||
|
||||
const (
|
||||
basePortRange = 30000
|
||||
sizePortRange = 2768
|
||||
)
|
||||
|
||||
func newStorage(t *testing.T) (*etcd3testing.EtcdTestServer, portallocator.Interface, allocator.Interface, storage.Interface, factory.DestroyFunc) {
|
||||
etcdStorage, server := registrytest.NewEtcdStorage(t, "")
|
||||
|
||||
serviceNodePortRange := utilnet.PortRange{Base: basePortRange, Size: sizePortRange}
|
||||
var backing allocator.Interface
|
||||
storage, err := portallocator.NewPortAllocatorCustom(serviceNodePortRange, func(max int, rangeSpec string) (allocator.Interface, error) {
|
||||
mem := allocator.NewAllocationMap(max, rangeSpec)
|
||||
backing = mem
|
||||
etcd, err := allocatorstore.NewEtcd(mem, "/ranges/servicenodeports", api.Resource("servicenodeportallocations"), etcdStorage)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return etcd, nil
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("unexpected error creating etcd: %v", err)
|
||||
}
|
||||
s, d, err := generic.NewRawStorage(etcdStorage)
|
||||
if err != nil {
|
||||
t.Fatalf("Couldn't create storage: %v", err)
|
||||
}
|
||||
destroyFunc := func() {
|
||||
d()
|
||||
server.Terminate(t)
|
||||
}
|
||||
return server, storage, backing, s, destroyFunc
|
||||
}
|
||||
|
||||
func validNewRangeAllocation() *api.RangeAllocation {
|
||||
portRange := fmt.Sprintf("%d-%d", basePortRange, basePortRange+sizePortRange-1)
|
||||
return &api.RangeAllocation{
|
||||
Range: portRange,
|
||||
}
|
||||
}
|
||||
|
||||
func key() string {
|
||||
return "/ranges/servicenodeports"
|
||||
}
|
||||
|
||||
// TestEmpty fails to allocate ports if the storage wasn't initialized with a servicenodeport range
|
||||
func TestEmpty(t *testing.T) {
|
||||
_, storage, _, _, destroyFunc := newStorage(t)
|
||||
defer destroyFunc()
|
||||
if err := storage.Allocate(31000); !strings.Contains(err.Error(), "cannot allocate resources of type servicenodeportallocations at this time") {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
// TestAllocate fails to allocate ports out of the valid port range
|
||||
func TestAllocate(t *testing.T) {
|
||||
_, storage, _, si, destroyFunc := newStorage(t)
|
||||
defer destroyFunc()
|
||||
if err := si.Create(context.TODO(), key(), validNewRangeAllocation(), nil, 0); err != nil {
|
||||
t.Fatalf("unexpected error: %v", err)
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
port int
|
||||
errMsg string
|
||||
}{
|
||||
{
|
||||
name: "Allocate base port",
|
||||
port: basePortRange,
|
||||
errMsg: "",
|
||||
},
|
||||
{
|
||||
name: "Allocate maximum from the port range",
|
||||
port: basePortRange + sizePortRange - 1,
|
||||
errMsg: "",
|
||||
},
|
||||
{
|
||||
name: "Allocate invalid port: base port minus 1",
|
||||
port: basePortRange - 1,
|
||||
errMsg: fmt.Sprintf("provided port is not in the valid range. The range of valid ports is %d-%d", basePortRange, basePortRange+sizePortRange-1),
|
||||
},
|
||||
{
|
||||
name: "Allocate invalid port: maximum port from the port range plus 1",
|
||||
port: basePortRange + sizePortRange,
|
||||
errMsg: fmt.Sprintf("provided port is not in the valid range. The range of valid ports is %d-%d", basePortRange, basePortRange+sizePortRange-1),
|
||||
},
|
||||
{
|
||||
name: "Allocate invalid port",
|
||||
port: -2,
|
||||
errMsg: fmt.Sprintf("provided port is not in the valid range. The range of valid ports is %d-%d", basePortRange, basePortRange+sizePortRange-1),
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
tt := tt // NOTE: https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
err := storage.Allocate(tt.port)
|
||||
if (err == nil) != (tt.errMsg == "") {
|
||||
t.Fatalf("Error expected %v, received %v", tt.errMsg, err)
|
||||
}
|
||||
if err != nil && err.Error() != tt.errMsg {
|
||||
t.Fatalf("Error message expected %v, received %v", tt.errMsg, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
// TestReallocate test that we can not allocate a port already allocated until it is released
|
||||
func TestReallocate(t *testing.T) {
|
||||
_, storage, backing, si, destroyFunc := newStorage(t)
|
||||
defer destroyFunc()
|
||||
if err := si.Create(context.TODO(), key(), validNewRangeAllocation(), nil, 0); err != nil {
|
||||
t.Fatalf("unexpected error: %v", err)
|
||||
}
|
||||
|
||||
// Allocate a port inside the valid port range
|
||||
if err := storage.Allocate(30100); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Try to allocate the same port in the local bitmap
|
||||
// The local bitmap stores the offset of the port
|
||||
// offset = port - base (30100 - 30000 = 100)
|
||||
ok, err := backing.Allocate(100)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// It should not allocate the port because it was already allocated
|
||||
if ok {
|
||||
t.Fatal("Expected allocation to fail")
|
||||
}
|
||||
// Try to allocate the port again should fail
|
||||
if err := storage.Allocate(30100); err != portallocator.ErrAllocated {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Release the port
|
||||
if err := storage.Release(30100); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Try to allocate the port again should succeed because we've released it
|
||||
if err := storage.Allocate(30100); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
}
|
||||
Loading…
Reference in New Issue
Block a user