kubeadm: remove function pointer comparison in phase test
TestBindToCommandArgRequirements has a .Pointer() comparison that is not guaranteed to pass given the reflected functions are closures. This test is consistently failing on Go 1.21 rc1. Remove said comparison from the test.
This commit is contained in:
@@ -401,14 +401,8 @@ func TestBindToCommandArgRequirements(t *testing.T) {
|
||||
continue
|
||||
}
|
||||
|
||||
// Ensure it is the expected function
|
||||
if reflect.ValueOf(cCmd.Args).Pointer() != reflect.ValueOf(args.args).Pointer() {
|
||||
t.Error("The function pointers where not equal.")
|
||||
}
|
||||
|
||||
// Test passing argument set
|
||||
err := cCmd.Args(cCmd, args.pass)
|
||||
|
||||
if err != nil {
|
||||
t.Errorf("command %s should validate the args: %v\n %v", cCmd.Name(), args.pass, err)
|
||||
}
|
||||
|
Reference in New Issue
Block a user