Commit Graph

3647 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
aa343fa632
Merge pull request #108628 from RomanBednar/attach-detach-message
csi_attacher: improve attach/detach timeout message
2022-03-16 11:05:15 -07:00
Konstantin Misyutin
4ba98a8610 cleanup: remove unnecessary import aliases 2022-03-16 15:43:09 +08:00
Konstantin Misyutin
1d7cefe9c4 Move volume helpers to "k8s.io/component-helpers/storage/volume".
This patch aims to simplify decoupling "pkg/scheduler/framework/plugins"
from internal "k8s.io/kubernetes" packages. More described in
issue #89930 and PR #102953.

Some helpers from "k8s.io/kubernetes/pkg/controller/volume/persistentvolume"
package moved to "k8s.io/component-helpers/storage/volume" package:

- IsDelayBindingMode
- GetBindVolumeToClaim
- IsVolumeBoundToClaim
- FindMatchingVolume
- CheckVolumeModeMismatches
- CheckAccessModes
- GetVolumeNodeAffinity

Also "CheckNodeAffinity" from "k8s.io/kubernetes/pkg/volume/util"
package moved to "k8s.io/component-helpers/storage/volume" package
to prevent diamond dependency conflict.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
2022-03-16 15:43:09 +08:00
Kubernetes Prow Robot
9642a1f84b
Merge pull request #108662 from dobsonj/issue89290
CSI inline volumes should support fsGroup
2022-03-14 09:34:10 -07:00
Roman Bednar
f17f00363b csi_attacher: improve attach/detach timeout message
If we time out waiting for volume to be attached the message given
to user is not informative enough:

"Attach timeout for volume vol-123"

It would be better if we provide more information on what's going on
and even include name of the driver that's causing the problem, e.g.:

"timed out waiting for external-attacher of ebs.csi.aws.com CSI driver to attach volume vol-123"
2022-03-14 11:00:22 +01:00
Jonathan Dobson
88a1962e56 CSI inline volumes should support fsGroup 2022-03-11 16:14:06 -07:00
Hemant Kumar
7fe33bfb7c Remove needless checks for nodestage during expansion 2022-03-10 09:55:06 -05:00
Hemant Kumar
e24219d27b Remove support for previously deprecated nodeExpand call
between staging and publish
2022-03-09 14:50:18 -05:00
Davanum Srinivas
91ade9f318
Switch pv-recycler container image to debian-base
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-03-03 13:37:17 -05:00
Kubernetes Prow Robot
e9ba9dc4e4
Merge pull request #107201 from pacoxu/add-metrics-volume-stats-cal
add VolumeStatCalDuration metrics for fsquato monitoring benchmark
2022-02-28 16:07:46 -08:00
Kubernetes Prow Robot
06e107081e
Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount
kubelet: Remove the deprecated flag `--experimental-check-node-capabilities-before-mount`
2022-02-24 07:56:30 -08:00
Kubernetes Prow Robot
eacbf87bfe
Merge pull request #108156 from jsafrane/rename-selinuxsupport
Rename SupportsSELinux to SELinuxRelabel
2022-02-22 20:12:20 -08:00
Kubernetes Prow Robot
37a0b1a321
Merge pull request #108066 from marseel/dont_check_type_in_hostvolule_in_kubemark
Turn off volumehost type check in kubemark clusters
2022-02-18 00:38:24 -08:00
Jan Safranek
525b8e5cd6 Rename SupportsSELinux to SELinuxRelabel
The field in fact says that the container runtime should relabel a volume
when running a container with it, it does not say that the volume supports
SELinux. For example, NFS can support SELinux, but we don't want NFS
volumes relabeled, because they can be shared among several Pods.
2022-02-16 10:54:08 +01:00
Kubernetes Prow Robot
4033355d29
Merge pull request #107909 from sebastiansterk/master
🤓 simple grammar fix
2022-02-15 12:15:18 -08:00
Kubernetes Prow Robot
1659924a97
Merge pull request #108070 from jsafrane/remove-selinux
Remove util/selinux package
2022-02-11 18:19:47 -08:00
Kubernetes Prow Robot
1f041ccd54
Merge pull request #107887 from bertinatto/fix-panic-kubelet
Fix panic in Kubelet
2022-02-11 12:58:07 -08:00
Jan Safranek
77aa06d0c8 Remove util/selinux package
The package says:

> the libcontainer SELinux package is only built for Linux, so it is
> necessary to have a NOP wrapper which is built for non-Linux platforms

This is not true, Kubernetes now imports
github.com/opencontainers/selinux/go-selinux and it has proper
multiplatform support (i.e. NOOP on non-Linux platforms).

Removing the whole package and calling go-selinux directly.
2022-02-11 15:20:35 +01:00
Marcel Zięba
66ab60dcf6 Turn off volumehost type check in kubemark clusters 2022-02-11 11:45:33 +00:00
Cheng Xing
b152fa9b6c Remove verult from OWNERS files 2022-02-10 18:25:38 -08:00
Kubernetes Prow Robot
6a5b3da1d8
Merge pull request #107236 from cyclinder/fix_bug_WaitForAttach
GCEPD: fix incorrect return value in WaitForAttach
2022-02-08 09:59:02 -08:00
Hemant Kumar
4b589dfd7a fix flake in detach tests 2022-02-02 17:28:13 -05:00
Sebastian Sterk
8e9ea7b481
simple grammar fix 2022-02-02 00:04:35 +01:00
Fabio Bertinatto
eb2adaa32f Fix panic in Kubelet
Currently, the Kubelet panics when it's started with the
`enable-controller-attach-detach=false` option set and a
volume is attached to a node.

This patch adds a check that prevents the Kubelet from trying to attach
or detach CSI volumes and report a proper error warning the user that this
use case is not supported.
2022-01-31 17:29:25 -03:00
Hemant Kumar
ff765210d5 Mark device as uncertain if unmount device succeeds
If unmount device succeeds but somehow unmount operation
fails because device was in-use elsewhere, we should mark the
device mount as uncertain because we can't use the global
mount point at this point.
2022-01-26 07:49:49 -05:00
Monokaix
96702a89b2 replace filepath.Walk with filepath.WalkDir in doCleanSubPaths 2022-01-25 09:56:32 +08:00
Kubernetes Prow Robot
c175418281
Merge pull request #107065 from saikat-royc/fix-node-stage-path
change node staging path for csi driver to PV agnostic
2022-01-21 01:31:58 -08:00
Saikat Roychowdhury
80e0501e89 change staging path for csi driver to pv agnostic 2022-01-20 22:59:29 +00:00
-e
3967f03bb1 set metric_source to du or fsquota accordingly 2022-01-20 10:56:02 +08:00
Paco Xu
6611c36372 add volume type and seperated histogram for volume stat collection 2022-01-19 22:33:37 +08:00
Kubernetes Prow Robot
874ce66d19
Merge pull request #107279 from NikhilSharmaWe/pathCheck
added devicePath check for fcDisk
2022-01-18 03:05:08 -08:00
Kubernetes Prow Robot
3bd422dc76
Merge pull request #107293 from dims/jan-1-owners-cleanup
Cleanup OWNERS files - Jan 2021 Week 1
2022-01-13 10:30:30 -08:00
Kubernetes Prow Robot
42436c877e
Merge pull request #107462 from dims/next-step-in-csi-migration-for-openstack-take-2
Next step in CSI migration for openstack
2022-01-12 19:57:07 -08:00
Kubernetes Prow Robot
e22ec17057
Merge pull request #99441 from CKchen0726/csi-client
migrate volume/csi/csi-client.go logs to structured logging
2022-01-12 11:52:13 -08:00
Patrick Ohly
9eaa2dc554 avoid klog Info calls without verbosity
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Davanum Srinivas
7fd97433f0
Next step in CSI migration for openstack
delete/modify tests that use intree cinder as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 22:07:44 -05:00
Davanum Srinivas
9682b7248f
OWNERS cleanup - Jan 2021 Week 1
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 08:14:29 -05:00
Kubernetes Prow Robot
475644ccd8
Merge pull request #106073 from ping035627/k8s-21110202
Cleanup FindPluginByName() in VolumePluginMgr
2022-01-07 07:52:29 -08:00
Nikhil Sharma
4eaa533777 added devicePath check for fcDisk 2022-01-07 20:10:03 +05:30
Kubernetes Prow Robot
d1a5513cb0
Merge pull request #107006 from gnufied/add-total-mount-time-metrics
Add metric for reporting total end-to-end mount time
2022-01-07 06:19:31 -08:00
Hemant Kumar
c9177f3083 rename volume_mount to overall_volume_mount for total metric time 2022-01-06 12:51:05 -05:00
Mengjiao Liu
beda4cafb6 kubelet: Remove the deprecated flag --experimental-check-node-capabilities-before-mount 2022-01-06 11:47:11 +08:00
Kubernetes Prow Robot
31898fc504
Merge pull request #101856 from prateekpandey14/fix-staticcheck
fix static check of importing the same package multiple times
2022-01-05 14:55:47 -08:00
Kubernetes Prow Robot
4f35d80f4e
Merge pull request #107302 from pacoxu/fix/empty-dir-quota-monitoring
assignQuota checks if the underlying medium supports quotas and if so setting it
2022-01-05 09:23:18 -08:00
Kubernetes Prow Robot
0f5e3d14bd
Merge pull request #106421 from houjun41544/20211115-volume
Fix the wrong log
2022-01-04 23:03:05 -08:00
PingWang
075adb308d Cleanup FindPluginByName() in VolumePluginMgr
Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update typo

Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update import

Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2022-01-05 11:42:26 +08:00
Paco Xu
3946e6c8c2 assignQuota checks if the underlying medium supports quotas and if so, sets 2022-01-05 09:33:07 +08:00
cyclinder
3ff8a86f20 GCEPD: fix incorrect return value in WaitForAttach
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
2021-12-28 09:48:35 +08:00
Kubernetes Prow Robot
f0dbc32ed9
Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse
When volume is not marked in-use, do not backoff
2021-12-22 19:46:37 -08:00
Hemant Kumar
7989f27044 use node informer to check volumes attachment status before backoff
fix unit tests
2021-12-20 11:57:05 -05:00
Kubernetes Prow Robot
489fb9bee3
Merge pull request #107025 from jsafrane/remove-attach-match
Remove AttachID matching from Detach
2021-12-17 18:41:24 -08:00
Kubernetes Prow Robot
1426587e08
Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year
Cleanup OWNERS files (No Activity in the last year)
2021-12-15 12:07:51 -08:00
Kubernetes Prow Robot
66931c9b8f
Merge pull request #106703 from scottnice/patch-1
Fixed skipping valid volume plugins when another plugin has an error
2021-12-15 09:53:50 -08:00
Davanum Srinivas
497e9c1971
Cleanup OWNERS files (No Activity in the last year)
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-15 10:34:02 -05:00
Scott Nice
d9cbe5d314 Added unit test for flex volume probe and updated DynamicPluginProber Probe() interface description 2021-12-14 10:48:51 -05:00
Jan Safranek
516633d67f Remove AttachID matching from Detach
Detach() always gets CSI volume unique ID and never attachment ID. Related
code has been removed from Kubernetes in
129f15328b.
2021-12-14 15:37:17 +01:00
prateekpandey14
f9cf14f3f6 fix static check of importing the same package multiple times
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
2021-12-14 11:06:44 +05:30
Hemant Kumar
55b5e6dc33 Add metric for reporting total end-to-end mount time
This metric includes time spent in waiting for devices to be attached,
any RPC calls and performing recursive chown etc.
2021-12-13 16:23:01 -05:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Scott Nice
5183513661 Fix gofmt verify 2021-12-09 09:18:22 -05:00
Kubernetes Prow Robot
8174b0923c
Merge pull request #105127 from astraw99/fix-dup-kubeClient
Fix duplicate CSI kube client
2021-12-07 17:25:30 -08:00
Hemant Kumar
5b7b2e2f6c When volume is not marked in-use, do not backoff 2021-12-07 11:50:15 -05:00
Scott Nice
1070eb7428
Fixed issue in plugin.go for bug #106696
Fixed issue in plugin.go where valid plugin events would be skipped if any plugin had an error. This meant that valid plugins would never be installed if another was in an error state as the events fired only once.
2021-11-27 15:07:19 -05:00
Hanna Lee
07a883d8e6 Remove //lint:ignore pragmas that aren't being used anymore 2021-11-17 08:56:54 +01:00
Hanna Lee
c8fde197f5 Add more //nolint:staticcheck for failures caught in PR tests 2021-11-17 08:56:02 +01:00
Kubernetes Prow Robot
8d9e424f73
Merge pull request #103447 from trierra/csi-translation-portworx
Csi translation portworx
2021-11-16 17:43:53 -08:00
houjun
7458399f77 Fix the wrong log 2021-11-17 09:07:07 +08:00
Oksana Naumov
3af11fc12d Add support for Portworx to csi-translation lib
Signed-off-by: Oksana Naumov <trierra.dev@gmail.com>
2021-11-16 13:26:09 -08:00
Kubernetes Prow Robot
f151a40d8d
Merge pull request #106154 from gnufied/recover-expansion-failure-123
Recover expansion failure
2021-11-16 13:21:34 -08:00
Hemant Kumar
1ddd598d31 Implement controller and kubelet changes for recovery from resize
failures
2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
66c342ba63
Merge pull request #95361 from humblec/rbd-migration
RBD in-tree plugin migration to CSI driver using migration translation lib
2021-11-15 19:53:25 -08:00
Humble Chirammal
7c40eb9ae0 Add support for rbd plugin to csi-translation-lib
In support of csi-migration proposal here:
https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree RBD plugin ( kubernetes.io/rbd)
to RBD CSI driver ( rbd.csi.ceph.com ).

Fixes https://github.com/kubernetes/enhancements/issues/2923

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-11-15 23:46:29 +05:30
Neha Lohia
fa1b6765d5
move pkg/util/node to component-helpers/node/util (#105347)
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
2021-11-12 07:52:27 -08:00
Kubernetes Prow Robot
7b9f4f18fe
Merge pull request #105135 from astraw99/fix-nil-mergeMap
Fix nil check in map merge
2021-11-12 02:26:27 -08:00
Kubernetes Prow Robot
ba944971f6
Merge pull request #105512 from gnufied/add-subpath-mount-source-check
Fix check for subpath source
2021-11-11 04:43:51 -08:00
astraw99
9fe2c30609 fix nil merge map 2021-11-11 10:56:55 +08:00
Kubernetes Prow Robot
dcf0a031e9
Merge pull request #105885 from gnufied/move-configurable-fsgroup-ga
Move configurable fsgroup to GA
2021-11-10 13:53:27 -08:00
Hemant Kumar
27d1e9a4e2 Remove all references to ConfigurableFSGroupPolicy feature gate 2021-11-10 14:24:08 -05:00
Hemant Kumar
467bcd8b89 Add tests for checking bind mounts 2021-11-10 11:52:55 -05:00
Hemant Kumar
7a73168a59 Check subpath file 2021-11-09 16:05:04 -05:00
Hemant Kumar
06e040de40 Add check for subpaths 2021-11-09 16:05:03 -05:00
Kubernetes Prow Robot
6d9008b1b0
Merge pull request #105934 from jsafrane/dont-ignore-selinux
Don't guess SELinux support on error
2021-11-05 12:44:51 -07:00
Jonathan Dobson
082cb15648 Move CSIVolumeFSGroupPolicy feature to GA 2021-11-02 15:22:33 -06:00
Jan Safranek
bc0c1bf1c5 Fixed unit test SELinux support
Previously, an error from GetSELinuxSupport was treated as a filesystem did
not support SELinux. Now the error is treated separately.
2021-11-01 15:11:40 +01:00
Jan Safranek
7b07b1ef0e Add shortcut for SELinux detection
Skip parsing of /proc/mounts if SELinux is disabled on the machine.
2021-11-01 14:32:48 +01:00
Jan Safranek
186810eb47 Don't guess SELinux support on error
When GetSELinuxSupport() fails, don't assume a mounted filesystem does not
support SELinux at all. Try again instead in the next SetUp retry.

This may hurt performance a bit, since kubelet will call NodePublishVolume
again, but it's better than providing wrong information to the container
runtime that will then skip relabeling of the volume.
2021-10-27 12:00:07 +02:00
Kubernetes Prow Robot
10988997f2
Merge pull request #102801 from CKchen0726/remove_storage_metrics_in_1.21_release
remove storageOperationErrorMetric and storageOperationStatusMetric in release 1.21
2021-10-27 01:21:26 -07:00
Hemant Kumar
481068c0d2 rename volume_fsgroup_recursive_apply metric to volume_apply_access_control 2021-10-25 12:27:53 -04:00
Kubernetes Prow Robot
30a32a39a4
Merge pull request #105136 from astraw99/fix-csi-mount-log
Fix CSI `mounter.TearDownAt` log msg
2021-10-14 11:54:55 -07:00
CKchen0726
f1c523cfa6 remove storageOperationErrorMetric and storageOperationStatusMetric in 1.21 release 2021-10-14 12:03:58 +08:00
astraw99
5e789f157c fix CSI mount log 2021-10-14 10:27:50 +08:00
Kubernetes Prow Robot
debd6c1e9e
Merge pull request #104526 from jingxu97/aug/volumeattach
Fix issue in node status updating VolumeAttached list
2021-10-05 17:30:32 -07:00
Jing Xu
69b9f9b1f0 Fix issue in node status updating VolumeAttached list
During volume detach, the following might happen in reconciler

1. Pod is deleting
2. remove volume from reportedAsAttached, so node status updater will
update volumeAttached list
3. detach failed due to some issue
4. volume is added back in reportedAsAttached
5. reconciler loops again the volume, remove volume from
reportedAsAttached
6. detach will not be trigged because exponential back off, detach call
will fail with exponential backoff error
7. another pod is added which using the same volume on the same node
8. reconciler loops and it will NOT try to tigger detach anymore

At this point, volume is still attached and in actual state, but
volumeAttached list in node status does not has this volume anymore, and
will block volume mount from kubelet.

The fix in first round is to add volume back into the volume list that
need to reported as attached at step 6 when detach call failed with
error (exponentical backoff). However this might has some performance
issue if detach fail for a while. During this time, volume will be keep
removing/adding back to node status which will cause a surge of API
calls.

So we changed to logic to check first whether operation is safe to retry which
means no pending operation or it is not in exponentical backoff time
period before calling detach. This way we can avoid keep removing/adding
volume from node status.

Change-Id: I5d4e760c880d72937d34b9d3e904ecad125f802e
2021-10-05 09:44:35 -07:00
Kubernetes Prow Robot
7d76d519ca
Merge pull request #105374 from xing-yang/update_volume_csi_owners
Bubble up to pkg/volume/OWNERS file
2021-09-30 21:17:21 -07:00
Kubernetes Prow Robot
e136faa1c4
Merge pull request #105379 from pohly/volume-util-owners
pkg/volume/util: remove out-dated OWNERS
2021-09-30 18:33:45 -07:00
Kubernetes Prow Robot
cab54856f1
Merge pull request #104933 from vikramcse/automate_mockery
conversion of tests from mockery to mockgen
2021-09-30 18:33:21 -07:00
Patrick Ohly
07f6571a49 pkg/volume/util: remove out-dated OWNERS
There is no reason for having separate owners for this folder. The parent
folder has a much better OWNERS file with references to the SIG-Storage
aliases.
2021-09-30 17:54:46 +02:00
xing-yang
2833aee8ff Bubble up to pkg/volume/OWNERS file 2021-09-30 14:01:28 +00:00
vikram Jadhav
0de4397490 mockery to mockgen conversion 2021-09-25 16:15:08 +00:00
astraw99
f24e7ccf6a fix duplicate kube client 2021-09-19 11:30:15 +08:00
CKchen0726
6505b41f25 migrate csi/csi_client.go logs to structured logging 2021-09-18 09:57:55 +08:00
wojtekt
d9b08c611d Migrate to k8s.io/utils/clock 2021-09-17 15:19:08 +02:00
Kubernetes Prow Robot
c91287c7b9
Merge pull request #104747 from kinvolk/invidian/typos
Fix typos in files which are used for generating OpenAPI
2021-09-09 18:04:57 -07:00
Kubernetes Prow Robot
1dc7de0366
Merge pull request #100185 from drigz/extra-log
Remove EXTRA from log messages
2021-09-05 04:02:28 -07:00
Mateusz Gozdek
d7768519ee
Fix typo assigment -> assignment
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
2021-09-04 11:55:26 +02:00
Stephen Augustus
481cf6fbe7
generated: Run hack/update-gofmt.sh
Signed-off-by: Stephen Augustus <foo@auggie.dev>
2021-08-24 15:47:49 -04:00
Antonio Ojea
0cd75e8fec run hack/update-netparse-cve.sh 2021-08-20 10:42:09 +02:00
Kubernetes Prow Robot
1f8b1b84fb
Merge pull request #102886 from gnufied/add-local-expansion
Add support for expanding local volumes
2021-08-12 11:55:50 -07:00
Hemant Kumar
593eda4ad3 Add unit tests for local volume expansion 2021-08-12 12:17:01 -04:00
Kubernetes Prow Robot
3ca0145f20
Merge pull request #104253 from mauriciopoppe/subpath-additional-mount-flag
Pass additional flags to subpath mount to avoid flakes in certain conditions
2021-08-11 02:08:58 -07:00
Kubernetes Prow Robot
61b6233235
Merge pull request #104148 from markusthoemmes/structured-logging-2
Add the pod field to all volumeToMount info level logs
2021-08-10 03:19:18 -07:00
Mauricio Poppe
296b30f143 Pass additional flags to subpath mount to avoid flakes in certain conditions 2021-08-09 22:15:35 +00:00
Kubernetes Prow Robot
a7af9f6e0e
Merge pull request #101475 from ash2k/ash2k/stop-timer
Stop timer and correctly drain it
2021-08-09 09:35:31 -07:00
Kubernetes Prow Robot
95d3360467
Merge pull request #97642 from claudiubelu/subatomic-symlinks
subatomic: Creates the symlinks to user-visible files later
2021-08-05 23:18:22 -07:00
Markus Thömmes
ff0e1f4fe9 Add the pod field to all volumeToMount info level logs 2021-08-05 12:29:56 +02:00
Rodrigo Queiro
363c0e3eb2 Remove EXTRA from log messages
This cleans up a log message that looks like:

I0312 14:36:50.280018   12866 operation_generator.go:869] UnmountDevice succeeded for volume "my-volume" %!(EXTRA string=UnmountDevice succeeded for volume "my-volume" (UniqueName: "kubernetes.io/csi/smb.csi.k8s.io^my-volume") on node "my-node")
2021-08-05 09:05:08 +02:00
Kubernetes Prow Robot
2da4d48e6d
Merge pull request #100567 from jingxu97/mar/mark
Mark volume mount as uncertain in case of volume expansion fails
2021-07-13 22:20:26 -07:00
Kubernetes Prow Robot
dab6f6a43d
Merge pull request #102344 from smarterclayton/keep_pod_worker
Prevent Kubelet from incorrectly interpreting "not yet started" pods as "ready to terminate pods" by unifying responsibility for pod lifecycle into pod worker
2021-07-08 16:48:53 -07:00
Jing Xu
0fa01c371c Mark volume mount as uncertain in case of volume expansion fails
should mark volume mount in actual state even if volume expansion fails so that
reconciler can tear down the volume when needed. To avoid pods start
using it, mark volume as uncertain instead of mounted.

Will add unit test after the logic is reviewed.

Change-Id: I5aebfa11ec93235a87af8f17bea7f7b1570b603d
2021-07-08 16:00:34 -07:00
Li Bo
c3d9b10ca8 feature: support Memory QoS for cgroups v2 2021-07-08 09:26:46 +08:00
Kubernetes Prow Robot
36a7426aa5
Merge pull request #99144 from bart0sh/PR0094-promote-HugePageStorageMediumSize-to-GA
promote huge page storage medium size to GA
2021-07-07 18:09:05 -07:00
Clayton Coleman
3eadd1a9ea
Keep pod worker running until pod is truly complete
A number of race conditions exist when pods are terminated early in
their lifecycle because components in the kubelet need to know "no
running containers" or "containers can't be started from now on" but
were relying on outdated state.

Only the pod worker knows whether containers are being started for
a given pod, which is required to know when a pod is "terminated"
(no running containers, none coming). Move that responsibility and
podKiller function into the pod workers, and have everything that
was killing the pod go into the UpdatePod loop. Split syncPod into
three phases - setup, terminate containers, and cleanup pod - and
have transitions between those methods be visible to other
components. After this change, to kill a pod you tell the pod worker
to UpdatePod({UpdateType: SyncPodKill, Pod: pod}).

Several places in the kubelet were incorrect about whether they
were handling terminating (should stop running, might have
containers) or terminated (no running containers) pods. The pod worker
exposes methods that allow other loops to know when to set up or tear
down resources based on the state of the pod - these methods remove
the possibility of race conditions by ensuring a single component is
responsible for knowing each pod's allowed state and other components
simply delegate to checking whether they are in the window by UID.

Removing containers now no longer blocks final pod deletion in the
API server and are handled as background cleanup. Node shutdown
no longer marks pods as failed as they can be restarted in the
next step.

See https://docs.google.com/document/d/1Pic5TPntdJnYfIpBeZndDelM-AbS4FN9H2GTLFhoJ04/edit# for details
2021-07-06 15:55:22 -04:00
Cheng Xing
c50b3074fe Moved VOLUME_MOUNT_GROUP capability check from NodeStageVolume to MountDevice; added log message in SetupAt to indicate FSGroup is delegated to driver 2021-07-03 16:29:42 -07:00
Cheng Xing
794a925a85 Pass FsGroup to NodeStageVolume 2021-07-03 16:29:42 -07:00
Cheng Xing
0e315355df Pass FsGroup to MountDevice 2021-07-03 16:29:42 -07:00
Cheng Xing
ae5668edef Pass FsGroup to NodePublishVolume 2021-07-03 16:29:42 -07:00
Cheng Xing
65db13a3a5 Combine capability check implementations 2021-07-03 16:29:42 -07:00
Chris Henzie
b7d732d3d6 Map PV access modes to CSI access modes 2021-06-28 21:25:38 -07:00
Chris Henzie
8db83c89aa CSI client helpers for NodeGetCapabilities 2021-06-28 21:25:37 -07:00
Chris Henzie
2b98f8edc7 Enforce ReadWriteOncePod access mode during mount 2021-06-28 21:25:37 -07:00
Chris Henzie
83e3ee780a Rename access mode contains helper method
So it is consistent with other methods performing the same check (one
for internal and external types)
2021-06-28 21:24:56 -07:00
Kubernetes Prow Robot
a0f9c8c277
Merge pull request #103001 from zshihang/csi
CSIServiceAccountToken ga
2021-06-26 19:31:23 -07:00
Kubernetes Prow Robot
55c0d318bb
Merge pull request #103127 from PushkarJ/pkg-vol-csi-non-root-test-fix
Fix panic in pkg/volume/csi tests
2021-06-25 06:38:44 -07:00
Pushkar Joglekar
1e250610b2 Fix panic in pkg/volume/csi tests
When run as non-root user, TestAttacherMountDevice fails, because of missing
nil check that induces a panic. Fixed by doing err nil check
before using the returned user value from user.Current()
2021-06-24 10:14:20 -07:00
Davanum Srinivas
5feff280e1
remove fakefs to drop spf13/afero dependency
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-06-24 09:51:34 -04:00
Kubernetes Prow Robot
7f4abd897e
Merge pull request #102414 from divyenpatel/use-ga-topology-labels-for-vsphere
Update vSphere volume topology label to GA
2021-06-21 18:13:57 -07:00
Shihang Zhang
8231a3e921 CSIServiceAccountToken ga 2021-06-21 11:35:24 -07:00
Divyen Patel
518844fd25 use GA topology labels for vsphere 2021-06-21 10:37:31 -07:00
Kubernetes Prow Robot
53bc4c13c1
Merge pull request #96115 from ncopa/disk-usage
Get inodes and disk usage via pure go
2021-06-18 20:30:50 -07:00
Kubernetes Prow Robot
4afb72a863
Merge pull request #100183 from jsafrane/fix-unstage-retry
Mark volume as uncertain after Unmount* fails
2021-06-18 11:04:06 -07:00
Jan Safranek
f4b41c0a17 Fix UnmountDevice error cases
When UnmountDevice fails, kubelet treat the volume mount as uncertain,
because it does not know at which stage UnmountDevice failed. It may be
already partially unmonted / destroyed.

As result, MountDevice will be performer when a new Pod is started on the
node after UnmountDevice faiure.
2021-06-16 18:39:04 +02:00
Hemant Kumar
a0e8a98bcb Add support for expanding local volumes
Fix path and stuff
2021-06-15 13:00:47 -04:00
Kubernetes Prow Robot
278f856144
Merge pull request #102653 from wzshiming/fix/npe
Fix NPE for CSI mounter
2021-06-09 10:17:26 -07:00
Kubernetes Prow Robot
8b787f3a22
Merge pull request #100741 from mengjiao-liu/fix-test-err
Fix  incorrect test code in pkg/volume/csi/csi_attacher_test.go file
2021-06-08 08:33:12 -07:00
Kubernetes Prow Robot
0322d34a3e
Merge pull request #100937 from mengjiao-liu/fix-metrics-nil-pointer
Fix csi_client_test.go metrics nil pointer dereference
2021-06-08 07:27:14 -07:00
Shiming Zhang
1eb8060dd6 Add test for CSI mounter 2021-06-08 18:42:31 +08:00
Shiming Zhang
c065d7c7b3 Fix NPE for CSI mounter 2021-06-08 10:29:46 +08:00
Kubernetes Prow Robot
dff5940ac3
Merge pull request #97534 from heqg/typo01
fix Spelling error for klog
2021-06-06 22:24:39 -07:00
Kubernetes Prow Robot
29a8105cec
Merge pull request #101272 from Jiawei0227/deprecateflag
Remove CSIMigrationvSphereComplete flag
2021-06-05 10:40:38 -07:00
Hemant Kumar
f5739a15d1 The test was not very useful and required elevated access 2021-06-04 15:48:35 -04:00
Kubernetes Prow Robot
38783bfeb7
Merge pull request #102059 from jsafrane/fix-consistentread
Retry reading /proc/mounts when unable to get a consistent read
2021-06-03 21:59:37 -07:00
Kubernetes Prow Robot
807e70c46f
Merge pull request #101605 from njuptlzf/flexvloume_test
cleanup: delete tempDir correctly after flexvloume_test is executed
2021-06-01 19:48:33 -07:00
Jan Safranek
f9a04f3bc4 Move error reporting to volume plugins
Move reporting of GetReliableMountRefs error to the volume plugins that
have more context about severity of the error.
2021-05-27 18:30:17 +02:00
Kubernetes Prow Robot
81e159f0b0
Merge pull request #101862 from jsafrane/fix-fc-detach-retry
Retry detaching FibreChannel volume few times
2021-05-27 07:14:23 -07:00
Kubernetes Prow Robot
f7e62dc5bb
Merge pull request #100746 from mengjiao-liu/fix-nil-call
Fixed a possible nil pointer dereference caused by variable `plug`
2021-05-26 14:49:38 -07:00
Jan Safranek
a95842095e Retry reading /proc/mounts indifinetly in FC and iSCSI volume reconstruction
iSCSI and FC volume plugins do not implement real 3rd party attach/detach.
If reconstruction fails with an error on a FC or iSCSI volume, it will not
be unmounted from the volume global dir and at the same time it will be
marked as unused, to be available to be mounted on another node.

The volume can then be mounted on several nodes, resulting in volume
corruption.

The other block based volume plugins implement attach/detach that either
makes the volume stuck (can't be detached) or will be force-detached from a
node before attaching it somewhere else.
2021-05-26 23:08:19 +02:00
Jan Safranek
64e8396e30 Retry detaching FibreChannel volume few times
When UnmountDevice() of a FibreChannel volume fails after unmounting the
device and before the device is fully cleaned up, subsequent
UnmountDevice() retry won't find the device mounted and return without
retrying the device cleanup.

Therefore implement its own retry inside UnmountDevice() to make sure that
the volume devices are either fully cleaned or the error is serius enough
that even 1 minute of trying does not help.
2021-05-26 23:05:06 +02:00
刁浩 10284789
5908cd0d90 simplify returning boolean expression in /pkg/volume
Signed-off-by: 刁浩 10284789 <diao.hao@zte.com.cn>
2021-05-25 02:39:55 +00:00
Kubernetes Prow Robot
f545438bd3
Merge pull request #101587 from nixpanic/in-tree/block-metrics
Fix a panic for in-tree drivers that partialy support Block volume metrics
2021-05-24 16:18:47 -07:00
Kubernetes Prow Robot
f803daaca7
Merge pull request #101510 from huchengze/patch-12
migrate log in pkg/volume/plugins.go
2021-05-20 21:14:57 -07:00
mengjiao.liu
c24b87b133 Fixed a possible nil pointer dereference caused by variable plug 2021-05-21 10:17:04 +08:00
Niels de Vos
b997e0e4d6 Add SupportsMetrics() for Block-mode volumes
Volumes that are provisioned with `VolumeMode: Block` often have a
MetrucsProvider interface declared in their type. However, the
MetricsProvider should implement a GetMetrics() function. In the cases
where the storage drivers do not implement GetMetrics(), a panic can
occur.

Usual type-assertions are not sufficient in this case. All assertions
assume the interface is present. There is no straight forward way to
verify that a valid GetMetrics() function is provided.

By adding SupportsMetrics(), storage driver implementations require
careful reviewing for metrics support.
2021-05-20 17:10:23 +02:00
Niels de Vos
e7dedc5cd1 Support Capacity metric for block PVCs for in-tree drivers
PR #97972 added support for gathering metrics for Block PVCs provided by
CSI drivers. The in-tree drivers can support at leas the most basic
metric; Capacity.
2021-05-20 16:37:12 +02:00
Niels de Vos
2b9c81b87d Add helper functions for Block volume Capacity detection
Similar to how NewMetricsStatFS() works, the new NewMetricsBlock()
provides the GetMetrics() interface for Block volumes.

Additional metrics for Block volumes are difficult to gather. There is
no guarantee that there is a filesystem on the volume, which makes most
of the volume metrics useless.

Advanced storage might be able to detect the actual consumption (when
thin-provisioned) vs the capacity. However, this is out of the scope for
a standard helper function and requires intimate knowledge of the used
storage system.
2021-05-20 16:37:12 +02:00
Jiawei Wang
94db1e18ba Remove scaleio from volume plugins 2021-05-19 10:35:21 -07:00
Kubernetes Prow Robot
d01a5cae9c
Merge pull request #97965 from chymy/fix-spell
Fix some case issue
2021-05-16 06:31:59 -07:00
Kubernetes Prow Robot
6768ac8115
Merge pull request #100894 from clickyotomy/sk/loop-dev-sysfs
Handle invalid `losetup' options
2021-05-12 05:05:39 -07:00
Ed Bartosh
c12aa0f6b7 promote HugePageStorageMediumSize to GA 2021-05-10 15:57:55 +03:00
Kubernetes Prow Robot
160cdbbdca
Merge pull request #101534 from kassarl/issue-98281
Use GA topology labels for Azuredisk
2021-05-07 13:32:00 -07:00
Kubernetes Prow Robot
c9bd08a3c4
Merge pull request #101046 from lojies/fixbrokenlink
fix broken link in some files
2021-05-07 13:31:34 -07:00
Kubernetes Prow Robot
c08526c7f7
Merge pull request #100216 from yangjunmyfm192085/run-test29
Fix misspelling of condition.
2021-05-07 00:21:02 -07:00
Jiawei Wang
ce87fc97a1 DAdd some soon-to-be-removed plugins to deprecated volume plugin list 2021-05-06 18:41:37 -07:00
Kubernetes Prow Robot
4ad08fa5b6
Merge pull request #101115 from wangyx1992/capital-log
cleanup: fix log capitalization in volume package
2021-05-06 03:51:16 -07:00
Jiawei Wang
fa1a4100c6 Remove CSIMigrationVSphereComplete flag 2021-05-04 21:38:47 -07:00
Srinidhi Kaushik
be63462f93
Handle invalid "losetup" options
The non "util-linux" versions of "losetup" don't seem to have
options like "-j" ("--associated") which lists the loop devices
associated with the file, or "--show" which  displays the name
of the assigned loop device for a file.

For instance, when "-j" is used, "GetLoopDevice()" fails with:

    $ losetup -j /path/to/file
    losetup: unrecognized option: j
    BusyBox v1.32.1 () multi-call binary.

Add a fallback option to lookup the device from "sysfs" in cases
where "losetup" fails for an invalid option. This can be done by
reading the backing file from "/sys/block/loop*/loop/backing_file"
for each of the devices listed there.

Signed-off-by: Srinidhi Kaushik <shrinidhi.kaushik@gmail.com>
2021-05-02 20:02:51 +05:30
Kubernetes Prow Robot
dfc91819b7
Merge pull request #101067 from Elbehery/fix-nfs-storage-ipv6_add_square_brackets
Fix mounting NFS resources in IPv6 bare-metal environment #101066
2021-05-01 20:58:00 -07:00
njuptlzf
2335547a9c cleanup: delete tempDir after flexvloume_test is executed 2021-04-29 17:20:58 +08:00
Kubernetes Prow Robot
7f8539ff20
Merge pull request #101441 from dobsonj/101332-deprecate-mount-path-removal
Deprecate removal of CSI nodepublish path by kubelet (#101332)
2021-04-28 10:32:50 -07:00
elbehery
859fe6899c add expectedDevice as arg for testing 2021-04-28 17:25:09 +02:00
elbehery
f9befb90a4 add pointer mutation review 2021-04-28 17:25:09 +02:00
elbehery
e05a8403c8 fix ipv6 test case 2021-04-28 17:25:09 +02:00
elbehery
124b71bd11 add test for ipv4 literal 2021-04-28 17:25:09 +02:00
elbehery
5b52146614 fix-nfs-storage-ipv6_add_square_brackets 2021-04-28 17:25:09 +02:00
Jonathan Dobson
260426bf44 clarify deprecation comment 2021-04-27 17:52:40 -06:00
Jonathan Dobson
75a7966414 move deprecation comment to TearDownAt function 2021-04-27 11:40:12 -06:00
Jonathan Dobson
e92dc8d9be Deprecate removal of CSI nodepublish path by kubelet (#101332) 2021-04-27 08:41:47 -06:00
huccshen
45ec665142
migrate log in pkg/volume/plugins.go 2021-04-27 14:37:25 +08:00
Laila Kassar
c3b8f242a5 Updated topology labels for Azure
Modified to use v1 labels
2021-04-26 07:35:10 +00:00
Mikhail Mazurskiy
5b42681840
Correctly drain timer 2021-04-26 15:13:09 +10:00
Niels de Vos
de3a4429d9 Make type BlockVolume a MetricsProvider 2021-04-22 08:36:20 +02:00
Niels de Vos
e99ced3114 Add support for gethering metrics from CSI block-mode volumes 2021-04-22 08:36:20 +02:00
Kubernetes Prow Robot
7ed02d61d1
Merge pull request #101235 from andyzhangx/azurefile-inline-ns-translation
fix: azure file inline volume namespace issue in csi migration translation
2021-04-21 19:15:44 -07:00
Kubernetes Prow Robot
a5a155aaab
Merge pull request #101072 from gavinfish/volume-log
Fix log format in flexvolume
2021-04-21 18:11:41 -07:00
Kubernetes Prow Robot
3e6f244851
Merge pull request #100999 from lojies/cispkgcleanup
code cleanup for pkg volume csi
2021-04-20 00:42:33 -07:00
andyzhangx
e10d3948f5 fix: azure file namespace issue in csi translation
fix build failure

fix comments
2021-04-20 07:23:09 +00:00
Kubernetes Prow Robot
a0e6e491e9
Merge pull request #99069 from phantooom/master
kubelet: fix raw block mode CSI NodePublishVolume stage miss pod info
2021-04-15 14:47:00 -07:00
phantooom
82c2266f25 chore: make csi getPodInfoAttrs func private 2021-04-15 20:51:51 +08:00
Kubernetes Prow Robot
80085be866
Merge pull request #101000 from lojies/ominilcheckforlen
code cleanup: Omit redundant nil check on slices
2021-04-14 07:02:43 -07:00
wangyx1992
7fe934a72d cleanup: fix log capitalization in volume package
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn>
2021-04-14 21:58:56 +08:00
Kubernetes Prow Robot
d21753e417
Merge pull request #100775 from mengjiao-liu/fix-nil-order
Fix nil pointer dereference by changing code order
2021-04-14 01:32:42 -07:00
Kubernetes Prow Robot
3c20c5aa2f
Merge pull request #100177 from wangyx1992/wrapped-error
fix errors in wrapped format
2021-04-13 23:24:42 -07:00
drfish
63b249b84b Fix log format in flexvolume 2021-04-13 21:42:07 +08:00
卢振兴10069964
b29a5fb074 fix broken link in some files 2021-04-13 08:46:24 +08:00
卢振兴10069964
a36c5f08f4 code cleanup: Omit redundant nil check on slices 2021-04-12 09:00:36 +08:00
卢振兴10069964
b3fea118dc code cleanup for pkg volume csi 2021-04-12 08:36:53 +08:00
Kubernetes Prow Robot
ac3f11f73f
Merge pull request #99928 from changshuchao/spell-error-unmount
fix Spelling error for Unmounter
2021-04-11 10:18:01 -07:00
Kubernetes Prow Robot
a55bd63172
Merge pull request #100731 from kassarl/azurefile-InvalidCharacter-issue
Normalize share name to not include capital letters
2021-04-09 05:20:58 -07:00
Kubernetes Prow Robot
4959cd6339
Merge pull request #100671 from Niekvdplas/spelling-mistakes
Fixed several spelling mistakes
2021-04-09 05:19:45 -07:00
Kubernetes Prow Robot
77e73ffbee
Merge pull request #100500 from jsafrane/aws-nvme-partitions
Fix mounting partitions on NVMe devices
2021-04-08 22:10:24 -07:00
Kubernetes Prow Robot
67820edf18
Merge pull request #100404 from gnufied/reduce-vsphere-volume-length
reduce volume length for vsphere volumes
2021-04-08 22:08:49 -07:00
Mengjiao Liu
8725c96014 Fix csi_client_test.go metrics nil pointer dereference 2021-04-09 10:15:56 +08:00
Kubernetes Prow Robot
b15859b301
Merge pull request #100100 from maxlaverse/fix_pv_provisioning
fix rounding of volume storage requests
2021-04-08 17:12:04 -07:00
Kubernetes Prow Robot
bb0906dcb2
Merge pull request #99929 from lala123912/lint_clean
Remove unused/dead code
2021-04-08 16:00:34 -07:00
Kubernetes Prow Robot
669016067d
Merge pull request #99566 from huchengze/patch-6
migrate log in pkg/volume/volume_linux.go
2021-04-08 14:28:43 -07:00
Mengjiao Liu
5fa7f288ce Fix nil pointer dereference by changing code order 2021-04-07 10:29:53 +08:00
Natanael Copa
79126376f0 Add test for counting inodes correct with hardlinks 2021-04-06 14:19:35 +02:00
Natanael Copa
d45ba645a8 Get inodes and disk usage via pure go
Fix inode usage calculation to use filepath.Walk instead of executing an
external find. Also calculate the disk usage while at it so we also get
rid of the external dependency of `nice` and `du`. (#95172)

This is similar to what cadvisor does since commit
046818d64c

This solves three problems:
- Counts number of inodes correct when there are hardlinks (#96114)
- Makes kubelet work without GNU findutils (#95186)
- Makes kubelet work without GNU coreutils (#95172)
2021-04-06 14:19:35 +02:00
Christian Huffman
3bcf407d2f Addresses nitpicks for FSGroupPolicy 2021-04-05 15:45:40 -04:00
mengjiao.liu
1d764952da Fix incorrect test code in pkg/volume/csi/csi_attacher_test.go file 2021-04-01 15:18:07 +08:00
Laila Kassar
a5fdad260f
Update pkg/volume/azure_file/azure_provision.go
Co-authored-by: Shiming Zhang <wzshiming@foxmail.com>
2021-03-31 22:54:21 -05:00
Laila Kassar
7514ad4467 Normalize share name to not include capital letters 2021-03-31 23:52:36 +00:00
Niekvdplas
fec272a7b2 Fixed several spelling mistakes 2021-03-30 23:02:09 +02:00
wangyx1992
34c2b2360b fix errors in wrapped format
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn>
2021-03-26 14:57:55 +08:00
Michelle Au
9c169a2122 Revert "fix azure file secret not found issue"
This reverts commit 8d43976b74.

Change-Id: Iefaa0e76489883830ba1c9bdcbc3101bcc33082c
2021-03-25 09:28:50 -07:00
Jan Safranek
408d67dcc5 Fix mounting partitions on NVMe devices 2021-03-23 19:01:47 +01:00
Hemant Kumar
0c9138a204 reduce volume length for vsphere volumes further 2021-03-23 13:43:51 -04:00
JUN YANG
6c566f6dfa Fix misspelling of condition.
Signed-off-by: JUN YANG <yang.jun22@zte.com.cn>
2021-03-19 16:27:53 +08:00
changshuchao
383744c849 fix Spelling error for Unmounter 2021-03-12 00:19:54 +08:00
huchengze
334b31faf6 migrate log in pkg/volume/volume_linux.go 2021-03-11 09:16:03 +08:00
Maxime Lagresle
ce7a7bbf9b
fix rounding of volume storage requests 2021-03-10 21:09:46 +01:00
Kubernetes Prow Robot
4b6e3e164f
Merge pull request #99221 from jsturtevant/windows-host-stats-provider
Get filesystem stats for files on Windows
2021-03-10 11:09:23 -08:00
Kubernetes Prow Robot
dcb3c56957
Merge pull request #99284 from fengzixu/support-external-health-monitor
feature: add CSIVolumeHealth feature and gate
2021-03-09 16:07:50 -08:00
Kubernetes Prow Robot
5155865ae2
Merge pull request #99326 from sunpa93/fs_resize_fix
fix: use pv annotation to trigger filesystem resize when necessary
2021-03-09 11:05:18 -08:00
fengzixu
edc1c62471 feature: add CSIVolumeHealth feature and gate
1. add EventRecorder to ResourceAnalyzer
2. add CSIVolumeHealth feature and gate
2021-03-10 01:16:37 +09:00
Sung Jun Park
5f69cf74d8 fix: when newly binding pvc to a pv, adjust pvc.status.capacity to pv's annotation that denotes the pre-resize capacity of the original pvc that pv was bound to if it has one
test: confirm that pvc's status capacity is adjusted if pv has a pre-resize capacity annotation
2021-03-09 07:55:10 +00:00
lala123912
127b675a15 Remove unused/dead code 2021-03-09 09:34:37 +08:00
James Sturtevant
c9eff4e906 Get filesystem stats for files on Windows 2021-03-08 12:50:23 -08:00
Jan Safranek
219cbc818a Refactor CSI migration plugin manager to get featureGates as a parameter
This allows caller to provide fake ones for testing of various corner cases
(migration on A/D controller disabled while enabled on kubelet).
2021-03-08 13:50:01 +01:00
JunYang
2d9b27047f Fix misspelling of success.
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
2021-03-05 20:19:00 +08:00
Shintaro Murakami
fe7a862c2d Unify determination of whether a volume is ephemeral 2021-03-05 14:49:09 +09:00
Kubernetes Prow Robot
cdd80af120
Merge pull request #99719 from jsafrane/cinder-label-ga
Promote Cinder topology labels to GA
2021-03-04 00:29:55 -08:00
Jan Safranek
334c7dfe74 Promote Cinder topology labels to GA 2021-03-03 20:05:12 +01:00
Supriya Premkumar
e52e5e486c
Adds ineffassign to GO linter script.
Changes:
 - Enables ineffassign check in the verify scripts.
 - Fixes lint errs.
2021-03-03 08:28:10 -08:00
Kubernetes Prow Robot
5404b5a28a
Merge pull request #98762 from wzshiming/ut/speed-up-csi
Speed up pkg/volume/csi unit tests
2021-03-01 10:57:25 -08:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
wzshiming
bc3d9252bc Speed up pkg/volume/csi unit tests 2021-02-27 14:09:38 +08:00
Kubernetes Prow Robot
29c661bd2f
Merge pull request #97834 from chrishenzie/volume-attachment-informer
Update CSI attacher to fetch VolumeAttachments from lister
2021-02-26 13:58:15 -08:00
Kubernetes Prow Robot
c200a8f9b7
Merge pull request #98433 from damemi/remove-helper-from-volume-zone
Move GetPersistentVolumeClaimClass to component-helpers
2021-02-26 12:38:15 -08:00
Kubernetes Prow Robot
d2edd33ae5
Merge pull request #98171 from pandaamanda/remove_duplicate_import
Remove duplicate package import in empty_dir_test.go
2021-02-26 10:40:16 -08:00
Kubernetes Prow Robot
525e397a48
Merge pull request #98546 from divyenpatel/deprecate-vcp-paramters
deprecating in-tree vsphere volume diskformat parameters, vsphere less than 67u3, vm hardware less than 15 and multi vCenter support
2021-02-25 13:52:15 -08:00