Commit Graph

431 Commits

Author SHA1 Message Date
Chris Henzie
b7d732d3d6 Map PV access modes to CSI access modes 2021-06-28 21:25:38 -07:00
Chris Henzie
8db83c89aa CSI client helpers for NodeGetCapabilities 2021-06-28 21:25:37 -07:00
Kubernetes Prow Robot
a0f9c8c277 Merge pull request #103001 from zshihang/csi
CSIServiceAccountToken ga
2021-06-26 19:31:23 -07:00
Pushkar Joglekar
1e250610b2 Fix panic in pkg/volume/csi tests
When run as non-root user, TestAttacherMountDevice fails, because of missing
nil check that induces a panic. Fixed by doing err nil check
before using the returned user value from user.Current()
2021-06-24 10:14:20 -07:00
Shihang Zhang
8231a3e921 CSIServiceAccountToken ga 2021-06-21 11:35:24 -07:00
Kubernetes Prow Robot
278f856144 Merge pull request #102653 from wzshiming/fix/npe
Fix NPE for CSI mounter
2021-06-09 10:17:26 -07:00
Kubernetes Prow Robot
8b787f3a22 Merge pull request #100741 from mengjiao-liu/fix-test-err
Fix  incorrect test code in pkg/volume/csi/csi_attacher_test.go file
2021-06-08 08:33:12 -07:00
Kubernetes Prow Robot
0322d34a3e Merge pull request #100937 from mengjiao-liu/fix-metrics-nil-pointer
Fix csi_client_test.go metrics nil pointer dereference
2021-06-08 07:27:14 -07:00
Shiming Zhang
1eb8060dd6 Add test for CSI mounter 2021-06-08 18:42:31 +08:00
Shiming Zhang
c065d7c7b3 Fix NPE for CSI mounter 2021-06-08 10:29:46 +08:00
Kubernetes Prow Robot
dff5940ac3 Merge pull request #97534 from heqg/typo01
fix Spelling error for klog
2021-06-06 22:24:39 -07:00
刁浩 10284789
5908cd0d90 simplify returning boolean expression in /pkg/volume
Signed-off-by: 刁浩 10284789 <diao.hao@zte.com.cn>
2021-05-25 02:39:55 +00:00
Niels de Vos
b997e0e4d6 Add SupportsMetrics() for Block-mode volumes
Volumes that are provisioned with `VolumeMode: Block` often have a
MetrucsProvider interface declared in their type. However, the
MetricsProvider should implement a GetMetrics() function. In the cases
where the storage drivers do not implement GetMetrics(), a panic can
occur.

Usual type-assertions are not sufficient in this case. All assertions
assume the interface is present. There is no straight forward way to
verify that a valid GetMetrics() function is provided.

By adding SupportsMetrics(), storage driver implementations require
careful reviewing for metrics support.
2021-05-20 17:10:23 +02:00
Kubernetes Prow Robot
4ad08fa5b6 Merge pull request #101115 from wangyx1992/capital-log
cleanup: fix log capitalization in volume package
2021-05-06 03:51:16 -07:00
Kubernetes Prow Robot
7f8539ff20 Merge pull request #101441 from dobsonj/101332-deprecate-mount-path-removal
Deprecate removal of CSI nodepublish path by kubelet (#101332)
2021-04-28 10:32:50 -07:00
Jonathan Dobson
260426bf44 clarify deprecation comment 2021-04-27 17:52:40 -06:00
Jonathan Dobson
75a7966414 move deprecation comment to TearDownAt function 2021-04-27 11:40:12 -06:00
Jonathan Dobson
e92dc8d9be Deprecate removal of CSI nodepublish path by kubelet (#101332) 2021-04-27 08:41:47 -06:00
Niels de Vos
de3a4429d9 Make type BlockVolume a MetricsProvider 2021-04-22 08:36:20 +02:00
Niels de Vos
e99ced3114 Add support for gethering metrics from CSI block-mode volumes 2021-04-22 08:36:20 +02:00
Kubernetes Prow Robot
3e6f244851 Merge pull request #100999 from lojies/cispkgcleanup
code cleanup for pkg volume csi
2021-04-20 00:42:33 -07:00
Kubernetes Prow Robot
a0e6e491e9 Merge pull request #99069 from phantooom/master
kubelet: fix raw block mode CSI NodePublishVolume stage miss pod info
2021-04-15 14:47:00 -07:00
phantooom
82c2266f25 chore: make csi getPodInfoAttrs func private 2021-04-15 20:51:51 +08:00
wangyx1992
7fe934a72d cleanup: fix log capitalization in volume package
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn>
2021-04-14 21:58:56 +08:00
卢振兴10069964
a36c5f08f4 code cleanup: Omit redundant nil check on slices 2021-04-12 09:00:36 +08:00
卢振兴10069964
b3fea118dc code cleanup for pkg volume csi 2021-04-12 08:36:53 +08:00
Mengjiao Liu
8725c96014 Fix csi_client_test.go metrics nil pointer dereference 2021-04-09 10:15:56 +08:00
Christian Huffman
3bcf407d2f Addresses nitpicks for FSGroupPolicy 2021-04-05 15:45:40 -04:00
mengjiao.liu
1d764952da Fix incorrect test code in pkg/volume/csi/csi_attacher_test.go file 2021-04-01 15:18:07 +08:00
fengzixu
edc1c62471 feature: add CSIVolumeHealth feature and gate
1. add EventRecorder to ResourceAnalyzer
2. add CSIVolumeHealth feature and gate
2021-03-10 01:16:37 +09:00
Kubernetes Prow Robot
5404b5a28a Merge pull request #98762 from wzshiming/ut/speed-up-csi
Speed up pkg/volume/csi unit tests
2021-03-01 10:57:25 -08:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
wzshiming
bc3d9252bc Speed up pkg/volume/csi unit tests 2021-02-27 14:09:38 +08:00
Chris Henzie
f36fec997a Poll for VolumeAttachments in CSI attacher
The CSI attacher that runs inside of the AttachDetachController has
access to a VolumeAttachment lister. By polling this lister for the
status of VolumeAttachments, we can save threads on the API server by
not using watches.
2021-02-23 16:54:18 -08:00
Chris Henzie
12e85e0e1c Extend test CSI plugin constructor to support multiple volume host types 2021-02-23 16:54:18 -08:00
phantooom
0017b602be test: add csi raw block mode wiht podinfo ut 2021-02-21 23:47:21 +08:00
phantooom
31aa15284f kubelet: fix raw block mode CSI NodePublishVolume stage miss pod info 2021-02-21 23:46:50 +08:00
drfish
d7fbf44361 Remove CSIDriverRegistry, BlockVolume and CSIBlockVolume feature flags 2021-02-19 23:40:28 +08:00
Jiawei Wang
43bc6fa806 Add csi_operations_seconds metrics on kubelet 2021-02-17 13:38:27 -08:00
Kubernetes Prow Robot
f5fb1c93db Merge pull request #96021 from huffmanca/dont-remove-volume
Dont remove volumes when saveVolumeData fails
2021-02-04 18:20:51 -08:00
pacoxu
a10bdfed09 fix all keps links 404 for kep folder migration
Signed-off-by: pacoxu <paco.xu@daocloud.io>
2021-02-01 19:41:59 +08:00
Christian Huffman
15da65d9ae Include unit test 2021-01-19 16:10:51 -05:00
Christian Huffman
df3119e815 Adjust defer to correctly call 2021-01-19 16:08:25 -05:00
fankangbest
b9afd2d34a do not remove volume dir when saveVolumeData fails 2021-01-19 15:53:10 -05:00
Chris Henzie
736b7e15b7 Remove duplicate test CSI plugin constructor logic 2021-01-06 16:32:41 -08:00
Chris Henzie
359b9e3383 Ensure CSI test plugin informers are synced before returning
This way of syncing informers ensures all informers generated from these
factories are synced. Informers are lazy loaded, and only created once a
user calls .Informer() (which was why the .PollImmediate() worked).
Asserting the number of synced types to ensure everything is set up
correctly.
2021-01-06 16:11:50 -08:00
Chris Henzie
257704b30d Remove setupInformer argument from test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
70eddfefec Ensure goroutines exit in CSI attacher tests
The reason for adding an expectedVolumeHost field is to prevent a
channel read from hanging when a test fails prior to creating the
VolumeAttachment watch.
2021-01-06 16:11:50 -08:00
Chris Henzie
f098ada9d1 Extract watch reactor out of test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
195a5af23b Make volume attachment watch timeout configurable for csiAttacher 2021-01-06 16:11:39 -08:00