Commit Graph

8791 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
93e76f5081
Merge pull request #92442 from tedyu/grace-period-with-map
Respect grace period when removing mirror pod
2020-07-10 17:49:23 -07:00
Kubernetes Prow Robot
26da0ea91e
Merge pull request #92794 from klueska/upstream-more-tests-get-preferred-allocation
Add more tests for device plugin's GetPreferredAllocation() API
2020-07-10 15:42:21 -07:00
Kubernetes Prow Robot
0cb7e320a5
Merge pull request #92784 from pohly/generic-ephemeral-inline-volumes
generic ephemeral inline volumes
2020-07-10 15:41:46 -07:00
Kubernetes Prow Robot
a6378d8b12
Merge pull request #92779 from fisherxu/patch-2
Return err when create ContainerLogsDir failed
2020-07-10 15:41:37 -07:00
Ali Farah
373e0f09bd Add unittest coverage for boottime_util_linux.go 2020-07-11 04:11:01 +10:00
DeliangFan
0b80c43f76 Set the oom_score_adj of guaranteed pod to -997
When oom happens, the sandbox maybe killed first, so set the oom score of guaranteed pod to -997.
2020-07-10 15:13:15 +08:00
Patrick Ohly
ff3e5e06a7 GenericEphemeralVolume: initial implementation
The implementation consists of
- identifying all places where VolumeSource.PersistentVolumeClaim has
  a special meaning and then ensuring that the same code path is taken
  for an ephemeral volume, with the ownership check
- adding a controller that produces the PVCs for each embedded
  VolumeSource.EphemeralVolume
- relaxing the PVC protection controller such that it removes
  the finalizer already before the pod is deleted (only
  if the GenericEphemeralVolume feature is enabled): this is
  needed to break a cycle where foreground deletion of the pod
  blocks on removing the PVC, which waits for deletion of the pod

The controller was derived from the endpointslices controller.
2020-07-09 23:29:24 +02:00
David Ashpole
1f70708f6c update cAdvisor to v0.37.0 2020-07-09 10:23:10 -07:00
Kubernetes Prow Robot
70e09f2c24
Merge pull request #88842 from angao/fit-arg
add args for NodeResourcesFit plugin
2020-07-09 05:04:10 -07:00
Giuseppe Scrivano
0d2a493a8f
kubelet: skip setting the devices cgroup
use the new libcontainer feature of skipping setting the devices
cgroup.  This is necessary on cgroup v2 to avoid leaking a eBPF
program every time the cgroup is re-configured.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-07-09 09:37:46 +02:00
Kubernetes Prow Robot
1e3eeba9fa
Merge pull request #91577 from knabben/kubelet-bootstrap
kubelet: remove the --bootstrap-checkpoint-path feature
2020-07-09 00:03:41 -07:00
Kubernetes Prow Robot
4ee555252c
Merge pull request #83710 from edwardstudy/ed/typo
Fix comment typos in pkg/kubelet/prober
2020-07-09 00:02:58 -07:00
Paulo Gomes
b451563560
Add seccomp least privilege for kuberuntime 2020-07-08 22:03:29 +01:00
Ted Yu
a76a959294 Respect grace period when removing mirror pod
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-07-08 13:38:24 -07:00
Joel Smith
f34b586d01 Include pod /etc/hosts in ephemeral storage calculation for eviction 2020-07-08 12:58:11 -06:00
Anthony ARNAUD
056d73b1a1
Add deviceManager in windows container manager 2020-07-08 18:22:16 +02:00
Kubernetes Prow Robot
5afc42de95
Merge pull request #78373 from tedyu/sort-init-container
Sort init container statuses using non-nested loop
2020-07-07 09:13:58 -07:00
Quan Tian
b2b082f54f Don't create a new sandbox for pod with RestartPolicyOnFailure if all containers succeeded
The kubelet would attempt to create a new sandbox for a pod whose
RestartPolicy is OnFailure even after all container succeeded. It caused
unnecessary CRI and CNI calls, confusing logs and conflicts between the
routine that creates the new sandbox and the routine that kills the Pod.

This patch checks the containers to start and stops creating sandbox if
no container is supposed to start.
2020-07-07 22:49:48 +08:00
Kubernetes Prow Robot
7e75a5ef43
Merge pull request #87273 from SaranBalaji90/kubelet-log-file
Add support for disabling /logs endpoint in kubelet
2020-07-07 04:09:58 -07:00
Kevin Klues
26cb650655 Remove unnecessary union after call to GetPreferredAllocation()
There is no need to try and allocate already-allocated devices again.
2020-07-07 06:35:57 +00:00
Kevin Klues
67ecc11c44 Harden callGetPreferredAllocationIfAvailable() return value
Previously, we didn't check the contents of the result after calling out
to the plugin endpoint. This could have resulted in errors if the plugin
returned either 'nil' or an empty result. This patch fixes this.
2020-07-07 06:35:57 +00:00
Kevin Klues
d87365494a Fix bug in call to callGetPreferredAllocationIfAvailable()
Previously, we were passing the variable 'devices' to this function,
when we should have been passing 'allocated'. This bug crept in due to a
variable name change that didn't propogate its way through the entire
function. The tests added in the previous commit would have caught this.
2020-07-07 06:35:57 +00:00
Kevin Klues
d551ab1e78 Add tests to check paramaters passed to GetPreferredAllocation()
These tests uncovered some small bugs that will be fixed in a subsequent
set of commits.
2020-07-07 06:35:57 +00:00
Fei Xu
34826c82be Return err when create ContainerLogsDir failed 2020-07-07 09:36:35 +08:00
Sergey Kanzhelev
933a2ca634 SIG node owner files clean up 2020-07-07 00:22:05 +00:00
Kubernetes Prow Robot
a26e5881d8
Merge pull request #92786 from answer1991/feature/enhance-bootstrap-certificate
make Kubelet bootstrap certificate signal aware
2020-07-06 09:52:52 -07:00
Sri Saran Balaji Vellore Rajakumar
05240c9218 Add support for disabling /logs endpoint in kubelet 2020-07-06 07:52:30 -07:00
chenjun.cj
db71941775 make Kubelet bootstrap certificate signal aware 2020-07-06 22:30:27 +08:00
Paulo Gomes
8976e3620f
Add seccomp enforcement and validation based on new GA fields
Adds seccomp validation.

This ensures that field and annotation values must match when present.

Co-authored-by: Sascha Grunert <sgrunert@suse.com>
2020-07-06 09:13:25 +01:00
Kubernetes Prow Robot
efb56da4a5
Merge pull request #92665 from klueska/upstream-add-get-preferred-allocation-api
Add GetPreferredAllocation() call to the v1beta1 device plugin API
2020-07-03 20:31:16 -07:00
Kevin Klues
5bd0db0b1f Add new test cases for GetPreferredAllocation() in allocation path 2020-07-03 13:01:32 +00:00
Kevin Klues
83f18d9975 Remove unnecessary field from TestTopologyAlignedAllocation() test cases 2020-07-03 13:01:32 +00:00
Kevin Klues
bb08fd1135 Add a simple endpoint test for GetPreferredAllocation()
More extensive tests that exercise the allocation logic are to follow.
2020-07-03 13:01:32 +00:00
Kevin Klues
cbd405d85c Update existing tests in support of GetPreferredallocation() 2020-07-03 13:01:32 +00:00
Kevin Klues
a780ccff5b Updates logic in devicesToAllocate() to call GetPreferredAllocation() 2020-07-02 22:07:27 +00:00
Kevin Klues
bb56a09133 Add callGetPreferredAllocationIfAvailable() function in devicemanager
This function mimics what is already done for the conditional call to
PreStartContainer() via the callPreStartContainerIfNeeded() function.
2020-07-02 22:07:27 +00:00
Kevin Klues
abf87c99c6 Add GetPreferredAllocation() as a supported device plugin endpoint 2020-07-02 15:15:50 +00:00
Kevin Klues
32c047a52e Update device plugin stub with new GetPreferredAllocation() call 2020-07-02 15:15:48 +00:00
Kevin Klues
c45f1317eb Fix some whitespacing and comments in devicemanager 2020-07-02 15:15:44 +00:00
Kubernetes Prow Robot
13a4a71e99
Merge pull request #91532 from afrouzMashaykhi/log-flag-kubelet
add --logging-format flag to kubelet
2020-07-02 06:40:46 -07:00
Kubernetes Prow Robot
ce5c89a144
Merge pull request #91896 from aojea/bumpcni
bump cni library version to v0.8.0
2020-07-01 23:12:16 -07:00
amash
b92b04e7cd add default for loggingconfiguration struct 2020-07-01 22:28:27 +04:30
Antonio Ojea
6f79600e73 bump cni library version to v0.8.0
last CNI library release is 0.7.1 from Jun 11, 2019.
Since then, there was introduced new feature and bugfixes.

Currently, this library is only being used by dockershim,
the other CRI plugins are vendoring it directly

However, this will help also to mitigate some of the issues with the
CI jobs that are still using dockershim.

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2020-07-01 18:09:19 +02:00
amash
3ab25f1876 add LoggingConfiguration struct to component-base/config 2020-07-01 20:07:01 +04:30
amash
ac8d2e8978 add loggingConfig struct to kubelet config 2020-07-01 20:07:01 +04:30
amash
ba8189a4f2 add --logging-format flag to kubelet 2020-07-01 20:07:01 +04:30
Kubernetes Prow Robot
2e91b56af0
Merge pull request #87909 from alena1108/feb6cleanup
Removed unnecessary not nil check in node registration process
2020-07-01 07:10:49 -07:00
Kubernetes Prow Robot
dcdeed97cd
Merge pull request #91499 from lo24/intf-fix
fix a regression that TestValidateNodeIPParam never actually works
2020-06-30 02:52:05 -07:00
Kubernetes Prow Robot
850080c41f
Merge pull request #91867 from yan-dblinf/fix_golint_failures_pkg_kubelet_lifecycle
Fix golint failures in pkg/kubelet/lifecycle
2020-06-30 00:02:42 -07:00
Kubernetes Prow Robot
677dfbab3c
Merge pull request #91360 from liuxu623/fix-emptyDir-sizeLimit
Fix if don't set ephemeral-storage limit emptyDir's sizeLimit doesn't work
2020-06-29 18:33:58 -07:00
Kubernetes Prow Robot
a03db636da
Merge pull request #91366 from giuseppe/cgroupfs-cgroupv2
vendor: update google/cadvisor and opencontainers/runc
2020-06-26 04:17:31 -07:00
Kubernetes Prow Robot
14c69640d0
Merge pull request #87166 from jingxu97/Jan/mountcheckfix
Fix issue in kubelet getMountedVolumePathListFromDisk
2020-06-25 09:45:39 -07:00
Kubernetes Prow Robot
4a91ecb976
Merge pull request #91863 from knabben/kubelet-memcg-notification
Moving Kubelet kernel-memgc-notification to configuration file
2020-06-25 00:20:37 -07:00
Kubernetes Prow Robot
9a3276548b
Merge pull request #91956 from kinvolk/rata/fix-kubelet-log-on-kill
kubelet: Fix log typo when killing a container
2020-06-24 13:30:38 -07:00
Kubernetes Prow Robot
b0e974e1aa
Merge pull request #92239 from matthyx/more-tests
Add tests covering startup probe without readiness
2020-06-24 10:32:13 -07:00
Giuseppe Scrivano
5d6dc8d19c
cadvisor: add Disk metrics with LocalStorageCapacityIsolation
needed for cadvisor commit e3affc1b79faa2901d7210948e92a5416166eb28

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-06-24 18:39:52 +02:00
Giuseppe Scrivano
e94aebf4cb
pkg/kubelet: adapt to new libcontainer API
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-06-24 18:39:51 +02:00
Kubernetes Prow Robot
14d9b5d758
Merge pull request #92325 from brianpursley/sync-pod-log
Add pod and container name in log message when container fails to start
2020-06-24 04:55:18 -07:00
Amim Knabben
c39cf28ed3 Moving Kubelet kernel-memgc-notification to configuration file 2020-06-24 06:44:00 -04:00
Brian Pursley
2afc8e0eab Add pod and container name in log message when container fails to start 2020-06-23 12:59:53 -04:00
RainbowMango
168c695e1a Update two metrics name to make promlint happy. 2020-06-23 15:16:18 +08:00
Li Zhijian
02eaa4f354 cleanup tempfiles in unit test
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-23 11:47:18 +08:00
Jing Xu
7012994a61 Fix issue in kubelet getMountedVolumePathListFromDisk
This PR fixes issue #74650. It adds the extra check for /mount dir under
pod volume dir. It also adds the unit test for this function
2020-06-22 10:00:43 -07:00
Yan Yao
cef7876952 Fix golint failures in pkg/kubelet/lifecycle
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-06-20 18:44:54 -07:00
Kubernetes Prow Robot
e24a42f07b
Merge pull request #88268 from mattjmcnaughton/mattjmcnaughton/delete-image-manager-TODO
Delete TODO in `image_gc_manager`
2020-06-20 17:12:38 -07:00
Rodrigo Campos
82856541fb kubelet: Fix log typo when killing a container
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
2020-06-20 20:15:27 -03:00
Kubernetes Prow Robot
628102d038
Merge pull request #85390 from xiaoanyunfei/bugfix/plegTestRelisting
fix pleg TestRelisting
2020-06-20 14:40:38 -07:00
Kubernetes Prow Robot
86ad0df820
Merge pull request #92203 from sjenning/add-sjenning-node-approver
Add sjenning as kubelet approver
2020-06-19 21:52:02 -07:00
Kubernetes Prow Robot
3b466d1c48
Merge pull request #91971 from SergeyKanzhelev/renamesInContainer
fix linter issues for pkg/kubelet/container
2020-06-19 21:51:32 -07:00
Kubernetes Prow Robot
d81ff3864c
Merge pull request #91945 from zhipengzuo/master
add namespaces info for logPrefix
2020-06-19 21:51:22 -07:00
Kubernetes Prow Robot
86ab25f038
Merge pull request #91716 from kadisi/append_mutations_kubelet
fix unexpected append mutations about pkg/kubelet package
2020-06-19 21:51:08 -07:00
Kubernetes Prow Robot
3d78928820
Merge pull request #91563 from SataQiu/fix-kubelet-20200529
Add duration to image pulling event
2020-06-19 21:50:39 -07:00
Kubernetes Prow Robot
cd5cdd6efa
Merge pull request #92120 from farah/farah/fix-typo
Fix typo in util_linux.go
2020-06-19 11:37:03 -07:00
Kubernetes Prow Robot
907a526919
Merge pull request #91699 from twosigma/hostnamefqdn_kubelet
Allow setting FQDN in hostname
2020-06-19 11:36:29 -07:00
Seth Jennings
45d2b98aa8 add sjenning as kubelet approver 2020-06-19 13:00:55 -05:00
Sergey Kanzhelev
ee53488f19 fix golint issues in pkg/kubelet/container 2020-06-19 15:48:08 +00:00
Kubernetes Prow Robot
2f2923fc33
Merge pull request #86802 from Aresforchina/fix-staticcheck-test04
make kubelet sysctl constants private
2020-06-19 04:37:59 -07:00
Kubernetes Prow Robot
677e8d6871
Merge pull request #86223 from dashpole/owners_changes
Add dashpole as kubelet approver
2020-06-18 22:59:58 -07:00
Matthias Bertschy
681202abd0 Add tests covering startup probe without readiness 2020-06-18 22:13:20 +02:00
xiaofei.sun
ddf1c5d3e9 fix pleg TestRelisting 2020-06-18 21:46:55 +08:00
Tim Hockin
64d4254217 Pods which have not "started" can not be "ready"
Before this commit, containers which have both a `startupProbe` and a
`readinessProbe` are marked as `ready=false` during stratup, but
containers which have only a `startupProbe` are marked `ready=true`.
This doesn't make sense.

This commit only considers readiness if the container is considered to
have "started", which leaves `ready=false` while starting up.
2020-06-16 21:34:51 -07:00
Morgan Bauer
cb4b67a886
basic regression test of runDockershim
- added basic regression test to ensure an error is raised in the
   case of an unconfigured runtime, and the case of asking for a docker
   runtime when compiled dockerless

Signed-off-by: Morgan Bauer <mbauer@us.ibm.com>
2020-06-16 10:08:22 -07:00
Ali Farah
81b91563e4 Fix typo in util_linux.go 2020-06-17 02:04:15 +10:00
Kubernetes Prow Robot
73fa63a86d
Merge pull request #92035 from danwinship/unmark-before-masq
kubelet, kube-proxy: unmark packets before masquerading them
2020-06-16 00:50:03 -07:00
Dan Winship
c12534d8b4 kubelet, kube-proxy: unmark packets before masquerading them
It seems that if you set the packet mark on a packet and then route
that packet through a kernel VXLAN interface, the VXLAN-encapsulated
packet will still have the mark from the original packet. Since our
NAT rules are based on the packet mark, this was causing us to
double-NAT some packets, which then triggered a kernel checksumming
bug. But even without the checksum bug, there are reasons to avoid
double-NATting, so fix the rules to unmark the packets before
masquerading them.
2020-06-15 18:45:38 -04:00
Javier Diaz-Montes
3538936587 Adding Bazel deps 2020-06-15 08:58:02 -04:00
Javier Diaz-Montes
9743cda4a7 Adding Kubelet changes to enable SetHostnameAsFQDN feature
These changes allow to set FQDN as hostname of pods for pods
that set the new PodSpec field setHostnameAsFQDN to true. The PodSpec
new field was added in related PR.

This is PART2 (last) of the changes to enable KEP #1797 and addresses #91036
2020-06-14 21:26:27 -04:00
Kubernetes Prow Robot
0adf8a48e0
Merge pull request #91789 from MHBauer/raise-dockershim-error
show error when running dockershim
2020-06-12 10:48:10 -07:00
Kubernetes Prow Robot
bc9c5afaf0
Merge pull request #90853 from kumarvin123/feature/IPv6DualStackProxy
KubeProxy and DockerShim changes for Ipv6 dual stack support on Windows
2020-06-11 19:07:55 -07:00
Kubernetes Prow Robot
983395fb85
Merge pull request #91885 from iamchuckss/test-throttling-image-service
Add test coverage for throttledImageService
2020-06-10 17:14:08 -07:00
Kubernetes Prow Robot
9089568465
Merge pull request #91780 from liggitt/csr-v1-rotate-kubelet-client
CSR v1 - promote RotateKubeletClientCertificate to GA
2020-06-10 17:13:24 -07:00
Morgan Bauer
38a1d34401
show error when running dockershim
The error returned when running the dockershim is not checked.
When running dockerless, we should show the existing error.
2020-06-10 17:07:48 -07:00
Vinod K L Swamy
ac3f87346f
KubeProxy and DockerShim changes for Ipv6 dual stack support on Windows
Signed-off-by: Vinod K L Swamy <vinodko@microsoft.com>
2020-06-10 15:36:48 -07:00
Kubernetes Prow Robot
507cc20404
Merge pull request #91754 from liggitt/csr-v1-client-go-manager
CSR v1 - switch client-go certificate manager utility to v1 by default
2020-06-10 04:39:52 -07:00
Kubernetes Prow Robot
4c5167a152
Merge pull request #88306 from YuikoTakada/fix_non_aschii_kubelet_qos
Fix non-ascii characters in pkg/kubelet/qos/doc.go
2020-06-10 04:38:08 -07:00
Jordan Liggitt
a298c14f18 Switch cert manager to v1 CSR API by default, falling back to v1beta1 2020-06-10 02:30:54 -04:00
Wen Gao
b21b298074 add arg for noderesourcesfit plugin to support ignore a group of extended resources 2020-06-10 10:52:54 +08:00
Kubernetes Prow Robot
e50a46459b
Merge pull request #91303 from SergeyKanzhelev/fixLinterInKebeletContainer
Fix golint failures for kubelet/container
2020-06-09 14:48:18 -07:00
Amim Knabben
0ed41c3f10 Deprecating --bootstrap-checkpoint-path flag 2020-06-09 15:27:01 -04:00
zhipengzuo
bc1e7c6958 add namespaces info for logPrefix 2020-06-09 20:36:09 +08:00
iamchuckss
2ff95f0d6a Add test coverage for throttledImageService 2020-06-09 07:36:40 +08:00
Jordan Liggitt
71d77b54fd Promote RotateKubeletClientCertificate to GA 2020-06-05 18:45:01 -04:00
Kubernetes Prow Robot
8ce1b535ee
Merge pull request #80831 from odinuge/hugetlb-pagesizes-cleanup
Add support for removing unsupported huge page sizes
2020-06-04 23:41:43 -07:00
Kubernetes Prow Robot
860837c81e
Merge pull request #91624 from hase1128/migrate-kubelet-infos
Migrate klog to klog.InfoS in pkg/kubelet
2020-06-04 13:52:27 -07:00
kadisi
a75323c76b fix unexpected append mutations about pkg/kubelet package
Signed-off-by: kadisi <iamkadisi@163.com>
Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2020-06-03 13:36:57 +08:00
Kubernetes Prow Robot
dcbdf1a7e1
Merge pull request #91275 from knabben/kubelet-node-status-image
Moving Kubelet --node-status-max-images flag to configuration
2020-06-02 18:10:45 -07:00
Amim Knabben
ef6a731b42 Adding tests for Kubelet pod update functions 2020-06-02 12:28:56 -04:00
Jin Hase
e6c1935355 Change status to status.Phase for removing unnecessary status information 2020-06-02 18:07:37 +09:00
Kubernetes Prow Robot
7bd4c53b27
Merge pull request #91630 from liggitt/kube-apiserver-kubelet-https
Mark --kubelet-https deprecated, unconditionally use https for apiserver->kubelet connections
2020-06-02 02:02:14 -07:00
Kubernetes Prow Robot
5fb9e35e57
Merge pull request #90191 from liggitt/csr-status
CSR condition status, lastTransitionTime, versioned validation
2020-06-01 23:34:15 -07:00
Jordan Liggitt
2e8461a5bc Mark --kubelet-https deprecated, unconditionally use https for apiserver->kubelet connections 2020-06-01 20:54:49 -04:00
Kubernetes Prow Robot
5bcc33ee94
Merge pull request #91569 from squeed/block-localnet
kubelet: block non-forwarded packets from crossing the localhost boundary
2020-06-01 13:10:28 -07:00
Jin Hase
573e5c6b2f Migrate klog to klog.InfoS in pkg/kubelet 2020-06-01 19:36:55 +09:00
Kubernetes Prow Robot
1d566466cf
Merge pull request #91500 from deads2k/guarantee-service
reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST
2020-05-29 15:21:33 -07:00
David Eads
4da0e64bc1 reduce race risk in kubelet for missing KUBERNETES_SERVICE_HOST 2020-05-29 17:11:19 -04:00
Casey Callendrello
8bed088224 kubelet: block non-forwarded packets from crossing the localhost boundary
We set route_localnet so that host-network processes can connect to
<127.0.0.1:NodePort> and it still works. This, however, is too
permissive.

So, block martians that are not already in conntrack.

See: #90259
Signed-off-by: Casey Callendrello <cdc@redhat.com>
2020-05-29 17:35:50 +02:00
SataQiu
f1729b06d7 add duration to image pulling event 2020-05-29 15:01:02 +08:00
Kubernetes Prow Robot
99c50dfd3c
Merge pull request #85225 from DataDog/eric.mountain/cleanup_refmanager_master
Removes container RefManager
2020-05-28 16:37:15 -07:00
Jordan Liggitt
94fd1d76ca Switch issued check to inspect certificate length 2020-05-28 12:20:40 -04:00
lo24
cda593e822 fix TestValidateNodeIPParam: break was being used instead of continue 2020-05-28 13:47:33 +00:00
Kubernetes Prow Robot
03cd30b9d7
Merge pull request #90494 from knabben/kubelet-provider
Migrating Kubelet --enable-server and --provider-id flags to config
2020-05-26 19:12:42 -07:00
Kubernetes Prow Robot
0e37bcce2c
Merge pull request #88385 from tallclair/node-reviews
Remove tallclair from some OWNERS files
2020-05-24 20:23:11 -07:00
zvier
d43817b5ec fix golint errors for pkg/kubelet/dockershim
Signed-off-by: zvier <zvier20@gmail.com>
2020-05-24 23:45:17 +08:00
liuxu
2367569f13 fix if don't set ephemeral-storage limit emptyDir's sizeLimit doesn't work 2020-05-23 13:36:56 +08:00
Kubernetes Prow Robot
cdbd07f64e
Merge pull request #90282 from gaurav1086/kubelet_nodestatus_remove_check
[kubelet] nodestatus: remove map nil check
2020-05-21 22:42:38 -07:00
Amim Knabben
f6246aba6e Moving Kubelet --node-status-max-images flag to configuration 2020-05-21 22:37:01 -04:00
Kubernetes Prow Robot
b98d9407cf
Merge pull request #91207 from iamchuckss/fixed-width-log-timestamps
Fix log timestamps to maintain a fixed width
2020-05-21 18:20:37 -07:00
Jordan Liggitt
591e0043c8 Revert "Merge pull request 89667 from kmala/kubelet"
This reverts commit fa785a5706, reversing
changes made to cf13f8d994.
2020-05-21 13:30:14 -04:00
Kubernetes Prow Robot
c579a3279f
Merge pull request #86005 from grnhse/raise-kubelet-node-status-verbosity
Fix kubelet_node_status log spam
2020-05-20 22:46:35 -07:00
Sergey Kanzhelev
a4bfc732f7 minor correction in comments 2020-05-21 04:15:44 +00:00
Sergey Kanzhelev
4e94144d1e Fix golint failures for kubelet/container 2020-05-20 19:01:23 +00:00
Davanum Srinivas
c7e79d2048
fix import restrictions and BUILD
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-20 10:57:47 -04:00
Davanum Srinivas
e049e594cd
Copy util directory for use in cri/remote package
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-20 10:57:47 -04:00
Davanum Srinivas
0608e8be25
update bazel BUILD files
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-20 10:57:47 -04:00
Davanum Srinivas
5692926914
Move packages for slightly better UX for consumers
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-20 10:57:46 -04:00
Kubernetes Prow Robot
fa785a5706
Merge pull request #89667 from kmala/kubelet
Check for sandboxes before deleting the pod from apiserver
2020-05-19 23:40:18 -07:00
iamchuckss
b5a02c4190 Fix log timestamps to be displayed in fixed width 2020-05-19 13:07:56 +08:00
Kubernetes Prow Robot
036fcda230
Merge pull request #89412 from coderanger/fix-kubelet-method-metrics
Apply the same style of fix as #87913 but for HTTP methods too.
2020-05-18 17:43:36 -07:00
Kubernetes Prow Robot
f4112710f5
Merge pull request #90061 from marosset/runtimehandler-image-spec-annotations
Add annotations to CRI ImageSpec objects
2020-05-18 16:29:36 -07:00
Kubernetes Prow Robot
55d71532c0
Merge pull request #81165 from johscheuer/update-traffic-shaping-docs
Update internal traffic shaping docs
2020-05-17 03:01:35 -07:00
Kubernetes Prow Robot
5bace30840
Merge pull request #91148 from liggitt/kubelet-client-metric
Add kubelet_certificate_manager_client_ttl_seconds gauge
2020-05-16 19:00:24 -07:00
Kubernetes Prow Robot
b170451caa
Merge pull request #90183 from dims/update-kubernetes-to-klog-v2
Update kubernetes to klog v2
2020-05-16 18:59:51 -07:00
Kubernetes Prow Robot
f011430e85
Merge pull request #84599 from mrobson/log-destroy
Errors from cgroup destroy are swallowed. Log error at warning level.
2020-05-16 18:59:36 -07:00
Amim Knabben
8459c9b6f4 Moving enable-server and provider-id 2020-05-16 21:34:13 -04:00
Kubernetes Prow Robot
cb493760d8
Merge pull request #89730 from saschagrunert/sprintf
Remove unnecessary sprintf in node status tests
2020-05-16 16:09:50 -07:00
Kubernetes Prow Robot
42fa1c081f
Merge pull request #88568 from RainbowMango/pr_cleanup_resource_metrics_ut
Clean up duplicate code and remove import cycle.
2020-05-16 16:09:36 -07:00
Kubernetes Prow Robot
9769e0f5da
Merge pull request #90008 from gavinfish/scheduler-utilparsers
Scheduler: remove direct import to /pkg/util/parsers
2020-05-16 07:35:49 -07:00
Kubernetes Prow Robot
ac5a6aced2
Merge pull request #89681 from iobuf/cleanup-kubelet
[pkg/kubelet]: make func a little comfortable
2020-05-16 07:35:36 -07:00
Davanum Srinivas
07d88617e5
Run hack/update-vendor.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:33 -04:00
Davanum Srinivas
442a69c3bd
switch over k/k to use klog v2
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:27 -04:00
Davanum Srinivas
9006b2db69
Fix for API change in cadvisor
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:53:03 -04:00
Kubernetes Prow Robot
e5b8e3ae19
Merge pull request #91106 from RobbinBaauw/fix-fsstats-tag
Add inline tag to FsStats
2020-05-15 23:02:32 -07:00
Jordan Liggitt
2408d8101f Fix kubelet client certificate gauge 2020-05-15 12:57:34 -04:00
Kubernetes Prow Robot
8a9206c9b2
Merge pull request #91046 from wawa0210/remove-beta-os-label
kubelet no longer registers "beta.kubernetes.io/os" and "beta.kubernetes.io/arch" node labels to apiserver
2020-05-15 02:48:58 -07:00
Kubernetes Prow Robot
96e13de777
Merge pull request #88980 from tedyu/evict-delay-sorting
Delay sorting of evictUnits slice in kuberuntime_gc
2020-05-14 21:24:58 -07:00
Kubernetes Prow Robot
2b00dd8536
Merge pull request #90409 from rphillips/fixes/add_logging_around_pod_container_deletor
add logging around pod_container_deletor DeleteContainer
2020-05-14 13:38:58 -07:00
Robbin Baauw
77a2a72541
Add inline tag to FsStats
Co-authored-by: Victor Roest <victor@xirion.net>
2020-05-14 14:23:36 +02:00
Kubernetes Prow Robot
dc1934e078
Merge pull request #90477 from rphillips/feat/add_tracing_to_remote_runtime
kubelet: add remote_runtime tracing at log level 10
2020-05-14 00:46:22 -07:00
Kubernetes Prow Robot
f975b4b0df
Merge pull request #91066 from rphillips/fixes/exec-probe_log
kubelet: tweak exec-probe log statement to be more concise
2020-05-13 22:14:35 -07:00
Kubernetes Prow Robot
0d0c400715
Merge pull request #91004 from cwdsuzhou/May/relplace_log
Use klog to replace log to keep them in consistence
2020-05-13 15:59:33 -07:00
Kubernetes Prow Robot
4339ac30a0
Merge pull request #90554 from vboulineau/vboulineau/fix_win_stats_init_containers
kubelet: fix `/stats/summary` endpoint on Windows when init-containers are present on the node
2020-05-13 15:58:51 -07:00
Kubernetes Prow Robot
2ca3347dc0
Merge pull request #90499 from knabben/kubelet-testing-flags
Deprecating Kubelet not used testing flags
2020-05-13 15:58:37 -07:00
Ryan Phillips
348d9941b1 kubelet: tweak exec-probe log statement to be more concise 2020-05-13 11:42:43 -05:00
wawa0210
54c0f8b677
Remove the 'beta' version of the node label (os and arch types) 2020-05-13 22:51:52 +08:00
Kubernetes Prow Robot
fb3009c3c0
Merge pull request #86034 from tahsinrahman/kubeletconfig-tests
Add tests for KubeletConfig
2020-05-13 00:18:26 -07:00
caiweidong
5ed8fb690c Use klog to replace log to keep them in consistence 2020-05-12 13:49:10 +08:00
Kubernetes Prow Robot
e26af96b8e
Merge pull request #90951 from mattjmcnaughton/mattjmcnaughton/clarify-dockershim-no-docker-error-message
Clarify `kubelet_dockershim_nodocker` error message
2020-05-11 18:08:42 -07:00
Kubernetes Prow Robot
751fe16b93
Merge pull request #90927 from BenTheElder/unit-shmunit
remove oom TestStartingWatcher ""unit"" test
2020-05-11 18:08:28 -07:00
Tim Allclair
029a144ae9 Remove tallclair from some OWNERS files 2020-05-11 11:44:38 -07:00
mattjmcnaughton
1a63e6fead
Clarify kubelet_dockershim_nodocker error message
Clarify the error message returned when trying to use the docker runtime
on a Kubelet that was compiled without Docker.

We removed the "w/" and "w/o", which can be confusing abbreviations, and
also add slightly more detail on the actual error.
2020-05-10 10:22:56 -04:00
Kubernetes Prow Robot
ba35704b51
Merge pull request #81443 from mikedanese/socks5
rest.Config: support configuring an explict proxy URL
2020-05-10 06:05:50 -07:00
Paulo Gomes
6db5b5c50f
Add seccomp least privilege for docker sandbox 2020-05-10 11:52:42 +01:00
Kubernetes Prow Robot
423c17d859
Merge pull request #90086 from rvillablanca/fix/handle-error-parseform
Handling error returned by request.Request.ParseForm()
2020-05-09 22:07:50 -07:00
Benjamin Elder
c6c68a73e1 remove oom TestStartingWatcher ""unit"" test 2020-05-08 23:25:28 -07:00
Md Tahsin Rahman
ea15f60328 Add tests for KubeletConfig 2020-05-09 00:06:16 +08:00
mattjmcnaughton
49fc82f7ab
Ensure we only run the cadvisor/docker init in !dockerless
We do not want to run the `cadvisor/docker` init when we are using the
dockerless build tags. We can ensure this by isolating into a separate
file with the proper build tag constraints.
2020-05-07 17:18:51 -04:00
mattjmcnaughton
29fa1f4566
Fix the verify job
Small changes to fix the verify job. Add the proper headers, fix lint
errors, etc...
2020-05-07 17:18:50 -04:00
mattjmcnaughton
b36f637f0d
Add dockerless tags to all files in dockershim
As the final step, add the `dockerless` tags to all files in the
dockershim. Using `-tags=dockerless` in `go build`, we can compile
kubelet without the dockershim.

Once cadvisor no longer depends on `docker/docker`, compiling with
`-tags=dockerless` should be sufficient to compile the Kubelet w/o a
dependency on `docker/docker`.
2020-05-07 17:18:50 -04:00
mattjmcnaughton
7fb6c51822
Move DockerLegacyService interface out of pkg/kubelet/dockershim
DockerLegacyService interface is used throughout `pkg/kubelet`.
It used to live in the `pkg/kubelet/dockershim` package. While we
would eventually like to remove it entirely, we need to give users some form
of warning.

By including the interface in
`pkg/kubelet/legacy/logs.go`, we ensure the interface is
available to `pkg/kubelet`, even when we are building with the `dockerless`
tag (i.e. not compiling the dockershim).
While the interface always exists, there will be no implementations of the
interface when building with the `dockerless` tag. The lack of
implementations should not be an issue, as we only expect `pkg/kubelet` code
to need an implementation of the `DockerLegacyService` when we are using
docker. If we are using docker, but building with the `dockerless` tag, than
this will be just one of many things that breaks.

`pkg/kubelet/legacy` might not be the best name for the package... I'm
very open to finding a different package name or even an already
existing package.
2020-05-07 17:18:49 -04:00
mattjmcnaughton
34c8f51dcb
Remove all uses of dockershim from cmd/kubelet
We can remove all uses of `dockershim` from `cmd/kubelet`, by just
passing the docker options to the kubelet in their pure form, instead of
using them to create a `dockerClientConfig` (which is defined in
dockershim). We can then construct the `dockerClientConfig` only when we
actually need it.
2020-05-07 17:18:49 -04:00
mattjmcnaughton
e0e6d54cdf
Extract running Dockershim into own file
Extract a `runDockershim` function into a file outside of `kubelet.go`.
We can use build tags to compile two separate functions... one which
actually runs dockershim and one that is a no-op.
2020-05-07 17:18:48 -04:00
mattjmcnaughton
53adde65ce
Remove ExperimentalDockershim from kubelet
Remove one of two uses of Dockershim in `cmd/kubelet`. The other is for
creating a docker client which we pass to the Kubelet... we will handle
that refactor in a separate diff.

I'm fairly confident, though need to double check, that no one is
actually using this experimental dockershim behavior. If they are, I
think we will want to find a new way to support it (that doesn't require
using the Kubelet only to launch Dockershim).
2020-05-07 17:18:48 -04:00
Mike Danese
652a48d2e7 wire up proxier in spdy transport
and delete useless function
2020-05-07 09:13:58 -07:00
Kubernetes Prow Robot
dc6c640a12
Merge pull request #90375 from cici37/removeConfigz
move pkg/util/configz to k8s.io/component-base
2020-05-04 13:46:09 -07:00
Vincent Boulineau
3bff11244b
kubelet: fix /stats/summary endpoint on Windows when init-containers are present on the node
Following changes in #87730, Kubelet is directly hcsshim to gather stats.
However, unlike `docker stats` API that was used before, hcsshim does not
keep information about exited containers.

When the Kubelet lists containers (`docker_container.go:ListContainers()`),
it sets `All: true`, retrieving non-running containers.

When docker stats is called with such container id, it'll return a valid JSON
with all values set to 0. The non-running containers are filtered later on in the process.

When the hcsshim is called with such container id, it'll return an error, effectively
stopping the stats retrieval for all containers.
2020-05-04 14:42:02 +02:00
Kubernetes Prow Robot
f372c5417b
Merge pull request #90628 from liggitt/pod-ip-status
Fix podIP validation
2020-04-30 19:30:07 -07:00
Amim Knabben
fe9eb1ba46 Migrating Kubelet testing flags to configuration 2020-04-30 22:12:39 -04:00
Jordan Liggitt
23e9fb1bb5 Fix podIP validation 2020-04-30 19:49:45 -04:00
cici37
7f4d19167e Move pkg/util/configz to k8s.io/component-base 2020-04-29 12:17:25 -07:00
Kubernetes Prow Robot
961a5ed144
Merge pull request #90380 from spiffxp/import-boss-test-files
Update import-boss files to yaml, include test files in CI job
2020-04-28 15:58:24 -07:00
Kubernetes Prow Robot
f7907083c2
Merge pull request #89160 from tedyu/symlink-first-seen
Remove potentially unhealthy symlink only for dead containers
2020-04-28 09:58:07 -07:00
Aaron Crickenberger
a7af20922f use forbiddenPrefixes instead of allowedPrefixes 2020-04-28 08:41:36 -07:00
Aaron Crickenberger
f306a0dbb4 convert .import-restrictions to yaml
yaml has comments, so we can explain why we have certain rules or
certain prefixes

for those files that weren't already commented yaml, I converted them to
yaml and took a best guess at comments based on the PRs that introduced
or updated them
2020-04-28 08:41:36 -07:00
Kubernetes Prow Robot
7fdc1275d9
Merge pull request #90377 from cbf123/container_cpuset_fixup_2
Fix exclusive CPU allocations being deleted at container restart
2020-04-27 13:40:04 -07:00
Kubernetes Prow Robot
561b2aba94
Merge pull request #90419 from klueska/upstream-update-reusable-cpus-strategy
Update strategy used to reuse CPUs from init containers in CPUManager
2020-04-27 12:09:23 -07:00
Chris Friesen
ab5870d808 Fix exclusive CPU allocations being deleted at container restart
The expectation is that exclusive CPU allocations happen at pod
creation time. When a container restarts, it should not have its
exclusive CPU allocations removed, and it should not need to
re-allocate CPUs.

There are a few places in the current code that look for containers
that have exited and call CpuManager.RemoveContainer() to clean up
the container.  This will end up deleting any exclusive CPU
allocations for that container, and if the container restarts within
the same pod it will end up using the default cpuset rather than
what should be exclusive CPUs.

Removing those calls and adding resource cleanup at allocation
time should get rid of the problem.

Signed-off-by: Chris Friesen <chris.friesen@windriver.com>
2020-04-27 11:36:54 -06:00
drfish
0b715ea690 Scheduler: remove direct import to /pkg/util/parsers 2020-04-26 23:41:52 +08:00
Ryan Phillips
aecddc9f13 kubelet: add remote_runtime tracing at log level 10 2020-04-24 17:37:27 -05:00
Kubernetes Prow Robot
7297fbd0ce
Merge pull request #90413 from PurelyApplied/nil-expiry
Improve error message when refresh token expiry is nil.
2020-04-24 15:32:07 -07:00
Kubernetes Prow Robot
f8297af392
Merge pull request #90284 from wawa0210/kubelet-nodename-clean
Remove duplicate calculation nodename、hostname、hostnameOverridden when kubelet is initialized
2020-04-24 12:15:34 -07:00
Kubernetes Prow Robot
30cefca5a6
Merge pull request #89128 from vincent178/move-runonce-kubeletconfiguration
move runonce from flag to config
2020-04-23 17:20:07 -07:00
wawa0210
40da2c521a
Remove duplicate calculation nodename 、hostname 、hostnameOverridden 2020-04-24 07:49:33 +08:00
Patrick Rhomberg
5ea1cef4c5 gofmt fix. 2020-04-23 23:32:04 +00:00
Patrick Rhomberg
a262b2762a Improve error message when refresh token expiry is nil.
Add test coverage for this case.
2020-04-23 20:52:58 +00:00
Kevin Klues
751b9f3e13 Update strategy used to reuse CPUs from init containers in CPUManager
With the old strategy, it was possible for an init container to end up
running without some of its CPUs being exclusive if it requested more
guaranteed CPUs than the sum of all guaranteed CPUs requested by app
containers. Unfortunately, this case was not caught by our unit tests
because they didn't validate the state of the defaultCPUSet to ensure
there was no overlap with CPUs assigned to containers. This patch
updates the strategy to reuse the CPUs assigned to init containers
across into app containers, while avoiding this edge case. It also
updates the unit tests to now catch this type of error in the future.
2020-04-23 20:27:43 +00:00
Ryan Phillips
a464299e97 add logging around pod_container_deletor DeleteContainer 2020-04-23 09:54:01 -05:00
Kubernetes Prow Robot
3e2ae631b4
Merge pull request #90209 from ZP-AlwaysWin/dev
Repair description
2020-04-23 03:57:59 -07:00
Kubernetes Prow Robot
168686a0ab
Merge pull request #90314 from tangcong/fix-kubelet-staticcheck-err
fix kubelet stats staticcheck error
2020-04-21 20:56:05 -07:00
Ted Yu
18e9f33fc6 Remove unhealthy symlink only for dead containers
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-21 12:30:51 -07:00
Kubernetes Prow Robot
13561c94e5
Merge pull request #90289 from tanjunchen/fix-comment-20200420
pkg/kubelet/remote/remote_runtime.go:fix the incorrect klog comment
2020-04-21 09:17:27 -07:00
tangcong
2b984b3e3a fix kubelet stats staticcheck error 2020-04-21 07:16:58 +08:00
Kubernetes Prow Robot
d92fdebd85
Merge pull request #89897 from giuseppe/test-e2e-node
kubelet: fix e2e-node cgroups test on cgroup v2
2020-04-20 15:54:12 -07:00
marosset
90367729a3 Adding/updating kubelet/kuberuntime tests 2020-04-20 22:25:05 +00:00
tanjunchen
21039d5bd3 pkg/kubelet/remote/remote_runtime.go:fix the incorrect klog comment 2020-04-20 09:55:40 +08:00
Gaurav Singh
5ed70c66e8 [kubelet] nodestatus: remove slice nil check 2020-04-19 11:16:21 -04:00
marosset
03479e4d12 kubelet - adding pod annotations to various image calls to get runtime-handler info to CRI 2020-04-17 23:57:09 +00:00
ZP-AlwaysWin
5796b7a32e Repair description 2020-04-17 09:36:38 +08:00
Rodrigo Villablanca
1014d307a5 After run ./hack/update-bazel.sh 2020-04-15 09:24:54 -04:00
Kubernetes Prow Robot
d0183703cb
Merge pull request #90059 from ahg-g/ahg-nodeinfo2
Cleanup obsolete NodeInfo methods
2020-04-14 17:32:04 -07:00
Kubernetes Prow Robot
6c499314cd
Merge pull request #88480 from savitharaghunathan/kubelet_flag_migration_1
Kubelet flag migration - Part 1
2020-04-14 12:33:39 -07:00
Abdullah Gharaibeh
d6522e0e74 rename framework pkg with schedulerframework for all instances under pkg/kubelet 2020-04-14 14:24:07 -04:00
Kubernetes Prow Robot
105c0c6951
Merge pull request #88970 from mysunshine92/correct-NodeAllocatableRoot
fix function NodeAllocatableRoot
2020-04-14 11:04:13 -07:00
Kubernetes Prow Robot
342d328064
Merge pull request #89934 from tedyu/unregister-plugin
Simplify the unregistration of csiplugin
2020-04-13 16:21:11 -07:00
Ted Yu
1001be85ad Simplify unregistration of csiplugin
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-13 15:04:52 -07:00
vincent178
745b742de5 move runonce from flag to config 2020-04-14 06:00:43 +08:00
Keerthan Reddy,Mala
9b9cf33771 fake remote runtime should call correct method on remove pod sandbox 2020-04-13 14:36:35 -07:00
Keerthan Reddy,Mala
70e2559aca use runtime sandbox status instead of calling cri 2020-04-13 14:36:34 -07:00
Keerthan Reddy,Mala
c24349e9f2 update the build file for bazel 2020-04-13 14:36:34 -07:00
Keerthan Reddy,Mala
1e42737e58 add unit tests 2020-04-13 14:36:34 -07:00
Keerthan Reddy,Mala
aae8a2847a Check for sandboxes before deleting the pod from apiserver 2020-04-13 14:36:34 -07:00
Rodrigo Villablanca
ae603b8ef1 Add some testing 2020-04-13 12:47:07 -04:00
Rodrigo Villablanca
0972c9ba4d Improvements 2020-04-13 12:47:07 -04:00
Rodrigo Villablanca
a68482290d Handling error returned by request.Request.ParseForm() 2020-04-13 12:47:07 -04:00
Kubernetes Prow Robot
6239abe698
Merge pull request #89225 from andrewsykim/apparmor-api
move apparmor annotation constants to k8s.io/api/core/v1
2020-04-12 19:11:50 -07:00
Abdullah Gharaibeh
bed9b2f23b Cleanup obsolete NodeInfo methods 2020-04-12 18:13:46 -04:00
Tim Hockin
9551ecb7c3 Cleanup: Change "Ip" to "IP" in func and var names 2020-04-10 15:29:50 -07:00
Tim Hockin
efb24d44c6 Rename iptables IsIpv6 to IsIPv6 2020-04-10 15:29:50 -07:00
Tim Hockin
ef934a2c5e Add Protocol() method to iptables
Enables simpler printing of which IP family the iptables interface is
managing.
2020-04-10 15:29:49 -07:00
Giuseppe Scrivano
26d94ad628
kubelet: do not configure the device cgroup
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-09 16:18:06 +02:00
Giuseppe Scrivano
a9772b2290
kubelet: adapt cgroup_manager to cgroup v2
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-09 16:18:04 +02:00
Giuseppe Scrivano
6d16fee229
kubelet: cpu hard capping is supported on cgroup v2
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-09 16:18:03 +02:00
Kubernetes Prow Robot
a34b914e82
Merge pull request #89921 from fromanirh/cpumanager-checkpoint
cpumanager: drop old custom file backend
2020-04-08 13:37:58 -07:00
Kubernetes Prow Robot
7061dddf26
Merge pull request #88521 from mattjmcnaughton/mattjmcnaughton/add-error-testing-image-service
Add error path testing to image handling by `kubeGenericRuntimeManager`
2020-04-07 22:45:43 -07:00
Francesco Romani
623587ec8b cpumanager: test: add missing helper
add back the missing AssertStateEqual helper;
it is needed by some tests we still want to run.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2020-04-07 16:59:07 +02:00
Francesco Romani
be0fe3df9b cpumanager: drop old custom file backend
The cpumanager file-based state backend was obsoleted since few
releases, aving the cpumanager moved to the checkpointmanager common
infrastructure.
The old test checking compatibility to/from the old format is
also no longer needed, because the checkpoint format is stable
(see
https://github.com/kubernetes/kubernetes/tree/master/pkg/kubelet/checkpointmanager).

Signed-off-by: Francesco Romani <fromani@redhat.com>
2020-04-07 13:24:48 +02:00
Kubernetes Prow Robot
037db1cb6c
Merge pull request #89687 from dims/update-docker-dependency
Update docker dependency and remove deprecated method use
2020-04-06 15:42:14 -07:00
Kubernetes Prow Robot
8cdf21ab4c
Merge pull request #86409 from sshukun/fix-golint
Fix go-lint issues in package pkg/kubelet/checkpointmanager/testing/example_checkpoint_formats/v1
2020-04-06 15:42:01 -07:00
Kubernetes Prow Robot
0d8b4b5df4
Merge pull request #85994 from coderanger/patch-1
Tiny typo in a comment.
2020-04-06 15:41:47 -07:00
Kubernetes Prow Robot
9441df3aad
Merge pull request #89808 from fuweid/close-resize-chan
remotecommand: close resize channel for notification
2020-04-06 13:47:46 -07:00
Wei Fu
d2b59f10c5 remotecommand: close resize channel for notification
Remotecommand package should notify executor by closing resizeChan.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2020-04-06 23:32:23 +08:00