Commit Graph

8791 Commits

Author SHA1 Message Date
Sergey Kanzhelev
1c379b1281 allow to map the same container port to different host ports 2020-09-03 22:21:18 +00:00
Kubernetes Prow Robot
48d5d204c3
Merge pull request #92614 from tnqn/onfailure-recreate
Don't create a new sandbox for pod with RestartPolicyOnFailure if all containers succeeded
2020-09-03 14:57:40 -07:00
David Ashpole
296f7c91bb consistently use double quotes in proto files 2020-09-03 13:50:03 -07:00
Daniel Smith
a86afc12df update scripts 2020-09-02 10:49:40 -07:00
Daniel Smith
75f835aa08 move port definitions to a common location 2020-09-02 10:48:25 -07:00
Kubernetes Prow Robot
90723ebbae
Merge pull request #93985 from MHBauer/fixes-93905
update test to match validation filter of pods
2020-09-02 09:03:21 -07:00
Kubernetes Prow Robot
81bf1f8789
Merge pull request #90980 from AlexeyPerevalov/GetNUMANodeInfo
Avoid using socket for hints in generateCPUTopologyHints
2020-09-02 03:41:06 -07:00
Kubernetes Prow Robot
f19118eea8
Merge pull request #94111 from giuseppe/fix-cgroup-v2-cgroupfs-path
kubelet, cgroupv2: do not create /sys/fs/cgroup/sys with cgroupfs
2020-09-01 19:41:33 -07:00
Kubernetes Prow Robot
db10d8c942
Merge pull request #93773 from knight42/fix/kubelet-concurrent-map-writes
fix(kubelet): protect `containerCleanupInfos` from concurrent map writes
2020-09-01 18:43:27 -07:00
Kubernetes Prow Robot
a0eb9d146a
Merge pull request #94272 from RainbowMango/pr_remove_deprecated_endpoint
remove deprecated kubelet endpoint /metrics/resource/v1alpha1
2020-09-01 16:35:34 -07:00
Kubernetes Prow Robot
e23d83eead
Merge pull request #93710 from Jiawei0227/attachable2non
Detect volume attach-ability in the middle of attaching
2020-08-31 17:39:50 -07:00
Morgan Bauer
7de68309d4
update test to match validation filter of pods
invalid pod filter changed to name only

changed for k8s v1.9 in 811447ea0a PR#53194
2020-08-31 09:14:49 -07:00
Kubernetes Prow Robot
0decea31a1
Merge pull request #93124 from gaurav1086/InjectImageInspects_fix_range_issue
[kubelet/dockershim] : fix range iterator copy issue in InjectImageInspects
2020-08-29 20:04:21 -07:00
Kubernetes Prow Robot
3e8bc58cce
Merge pull request #91970 from SergeyKanzhelev/criLinterIssuesFix
fix linter issues for kubelet/cri/remote and ri-api/pkg/apis/testing
2020-08-28 10:39:49 -07:00
Kubernetes Prow Robot
617f17f238
Merge pull request #93704 from SergeyKanzhelev/PodReasonUnschedulableIsNotAType
PodReasonUnschedulable is not a pod condition type
2020-08-28 08:04:31 -07:00
Kubernetes Prow Robot
9ff9e8798a
Merge pull request #93498 from luigibk/use-ebtables-from-utils
Update k8s.io/utils dependency and use ebtables from there
2020-08-28 06:37:21 -07:00
Kubernetes Prow Robot
dce91dece3
Merge pull request #93283 from runzexia/cleanup-unused-container-cache
clean up unused var containerCache
2020-08-28 06:36:33 -07:00
Kubernetes Prow Robot
9b46d76d5e
Merge pull request #93180 from FreeZhang61/unittest/add_GetAddressAndDialer_unit_test
add  unit test for GetAddressAndDialer
2020-08-28 06:36:04 -07:00
Sergey Kanzhelev
df2f67daf8 fix linter issues for pkg/kubelet/cri/remote and staging/src/k8s.io/cri-api/pkg/apis/testing 2020-08-28 04:15:39 +00:00
Kubernetes Prow Robot
481830b396
Merge pull request #92847 from SergeyKanzhelev/sigNodeOwnersCleanUp
SIG node owner files clean up
2020-08-27 19:07:40 -07:00
Kubernetes Prow Robot
ecfcd5fe59
Merge pull request #92760 from farah/farah/unit-test
Add unit test coverage for boottime_util_linux.go
2020-08-27 19:06:43 -07:00
RainbowMango
3c7caff44d remove deprecated kubelet endpoint /metrics/resource/v1alpha1 2020-08-28 09:16:56 +08:00
Kubernetes Prow Robot
2e59a17dc1
Merge pull request #92288 from zhijianli88/cleanup-tempfiles
Cleanup tempfiles
2020-08-27 17:56:54 -07:00
Kubernetes Prow Robot
fe1aeff2d2
Merge pull request #92013 from MHBauer/dockershim-error-test
basic regression test of runDockershim
2020-08-27 17:55:55 -07:00
Kubernetes Prow Robot
9d6e10231c
Merge pull request #91333 from knabben/kubelet-types-tests
Adding tests for Kubelet pod update functions
2020-08-27 17:54:59 -07:00
Kubernetes Prow Robot
5ec83bc973
Merge pull request #91181 from zvier/master
fix golint errors for `pkg/kubelet/dockershim`
2020-08-27 17:54:45 -07:00
Kubernetes Prow Robot
69d5d620a4
Merge pull request #93723 from ynqa/add-testcases-kubelet-getters
add testcases for kubelet getters
2020-08-27 16:06:58 -07:00
Kubernetes Prow Robot
1bb55ae55d
Merge pull request #93681 from gireeshpunathil/typo
fix a typo in the comment
2020-08-27 16:06:39 -07:00
Kubernetes Prow Robot
274e33b691
Merge pull request #93581 from SergeyKanzhelev/nameOfPortMappingIsNotNeeded
Clean up in port mapping functionality
2020-08-27 16:06:11 -07:00
Kubernetes Prow Robot
7b55facc29
Merge pull request #93431 from ESWZY/add-test
Add test for `pkg/kubelet/util/util_windows_test.go#GetAddressAndDialer`
2020-08-27 16:05:43 -07:00
Kubernetes Prow Robot
597eb78b25
Merge pull request #94160 from matthyx/startupprobe-ga
Remove StartupProbe featuregate and related logic
2020-08-27 06:42:49 -07:00
brianpursley
6d001ebb68 Add logging if container or pod fails to be killed 2020-08-25 20:37:49 -04:00
Jiawei Wang
a6d8e6c5c2 Detect change of volume attachability in the middle of attaching
- Add Unit tests for both volumemanager and attach/detach controller
- Add E2E test
2020-08-24 17:15:11 -07:00
Derek Carr
6f2153986a Promote PidLimits to GA 2020-08-24 13:57:48 -04:00
knight42
cfeddcf654
test(kuberuntime): deflake TestRemoveContainer
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-08-24 11:14:02 +08:00
Matthias Bertschy
ea14585500 Remove StartupProbe featuregate and related logic 2020-08-22 15:09:52 +02:00
Kubernetes Prow Robot
6da73aa572
Merge pull request #93333 from loburm/fix-logrotate
Fix an issue when rotated logs of dead containers are not removed.
2020-08-20 03:27:23 -07:00
Derek Carr
02daa3ec23 Cleanup kubelet TODOs that are no longer pertinent. 2020-08-19 16:40:54 -04:00
Giuseppe Scrivano
49cbf91fce
kubelet, cgroupv2: do not create /sys/fs/cgroup/sys with cgroupfs
Closes: https://github.com/kubernetes/kubernetes/issues/94104

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-08-19 22:29:38 +02:00
ynqa
7d58ead809 delete tests which use container manager stub 2020-08-19 10:07:36 +09:00
Kubernetes Prow Robot
fd74333a97
Merge pull request #93622 from knight42/test/plugin-register-timeout
Fix race condition in pluginWatcher
2020-08-17 19:03:32 -07:00
knight42
de46e81e74
fix(pluginwatcher): watch socket dir before traversing it
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-08-14 12:07:04 +08:00
ESWZY
9ce4dfe6d2 Add test for pkg/kubelet/util/util_windows_test.go#GetAddressAndDialer 2020-08-13 01:17:00 +08:00
SataQiu
ad1739f8bc kubelet: assume that swap is disabled when /proc/swaps does not exist 2020-08-12 22:43:58 +08:00
knight42
ebf60155bf
test(kubelet): add a regression test to verify kubelet would not panic 2020-08-07 17:50:22 +08:00
knight42
a471843246
fix(kubelet): protect containerCleanupInfos from concurrent map writes
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-08-07 16:55:56 +08:00
ynqa
4357551ae3 add testcases for kubelet getters 2020-08-07 00:03:42 +09:00
Gireesh Punathil
fdbfbaac33 fix a typo in the comment 2020-08-06 07:57:12 +05:30
Jordan Liggitt
b181c76cbd Deflake TestUpdateNodeStatusWithLease - guard cached machineInfo 2020-08-05 10:00:36 -04:00
Sergey Kanzhelev
a84834fdcf PodReasonUnschedulable is not a pod condition type 2020-08-05 03:06:37 +00:00
Kubernetes Prow Robot
8b7d8cd299
Merge pull request #93403 from hex108/remove_err_msg
Remove unuseful error message about updating pod conditions not owned…
2020-08-04 11:46:22 -07:00
Rodrigo Campos
e6c67c32e1 Fix kubelet log message when starting a container
This code can be called not only when a container is dead and restarted,
but when is started for the first time too. For example, any pod with
initContainer and containers will exhibit this behaviour. The reason is
that in that case, the "if createPodSandbox" path will return the
initContainers only and on the next call to this function this code is
executed to start the containers for the fist time.

In that case, it is wrong to log that the container is dead and will be
restarted, as it was never started. In fact, the restart count will not
be increased.

This commit just changes this to say that the container is not in the
desired state and should be started. In the end, the kubelet is a state
machine and that is all we really care about.

No tests are added, as the behaviour was correct and tests don't check
logs messages.

Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
2020-08-04 14:58:27 -03:00
ravisantoshgudimetla
cd8686bc57 Strip unnecessary security contexts on Windows
As of now, the kubelet is passing the security context to container runtime even
if the security context has invalid options for a particular OS. As a result,
the pod fails to come up on the node. This error is particularly pronounced on
the Windows nodes where kubelet is allowing Linux specific options like SELinux,
RunAsUser etc where as in [documentation](https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#v1-container),
we clearly state they are not supported. This PR ensures that the kubelet strips
the security contexts of the pod, if they don't make sense on the Windows OS.
2020-08-03 23:43:31 -04:00
Kubernetes Prow Robot
11c6d72e37
Merge pull request #93478 from sjenning/fixup-helper-test
kubelet: eviction: remove unexpected output from TestGetReclaimableThreshold
2020-08-02 10:07:40 -07:00
Jordan Liggitt
7335770670 Make toKubeContainerImageSpec deterministic 2020-07-31 14:41:11 -04:00
xiaofei.sun
a724481f5c fix metrics kubelet_running_pod_count 2020-07-31 16:35:53 +08:00
Sergey Kanzhelev
3af652f2f2 revert auto-completed package names 2020-07-31 03:47:04 +00:00
Sergey Kanzhelev
d20fd40884 remove legacy leftovers of portmapping functionality that was moved to CNI 2020-07-30 23:12:16 +00:00
Luigi Bitonti
19793bd3fa Update k8s.io/utils dependency and use ebtables from there 2020-07-30 08:58:21 +01:00
Seth Jennings
a4f043a980 kubelet: eviction: remove noise from TestGetReclaimableThreshold test output 2020-07-27 13:53:55 -05:00
Jordan Liggitt
f33dc28094 generated: hack/update-hack-tools.sh && hack/update-vendor.sh 2020-07-25 16:45:02 -04:00
Jordan Liggitt
124a5ddf72 Fix int->string casts 2020-07-24 16:23:12 -04:00
Alexey Perevalov
a047e8aa1b move to cadvisor.MachineInfo
This patch removes GetNUMANodeInfo, cadvisor.MachineInfo will be used
instead of it. GetNUMANodeInfo was introduced due to difference of meaning of
MachineInfo.Topology. On the arm it was NUMA nodes, but on the x86 it
represents sockets (since reading from /proc/cpuinfo). Now it unified
and MachineInfo.Topology represents NUMA node.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-07-24 09:29:41 -04:00
wawa0210
ccde63b9c1
fix windows container root validate 2020-07-24 19:59:58 +08:00
Marian Lobur
5d1b3e26af Fix an issue when rotated logs of dead containers are not removed. 2020-07-24 10:06:24 +02:00
Jun Gong
454f9acc24 Remove unuseful error message about updating pod conditions not owned by kubelet 2020-07-24 09:56:03 +08:00
zhangsheng02
dadc2ad385 add more testing cases
Signed-off-by: zhangsheng02 <sheng.zhang@daocloud.io>
2020-07-24 09:32:34 +08:00
Keerthan Reddy,Mala
acac15c20e fix bazel build file 2020-07-22 14:12:27 -07:00
Keerthan Reddy,Mala
872859b422 correct the sandboxId attribute in unit tests 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
851d778531 address review comments 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
90cc954eed add sandbox deletor to delete sandboxes on pod delete event 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
d4325f42fb Check for sandboxes before deleting the pod from apiserver 2020-07-22 11:54:56 -07:00
Kubernetes Prow Robot
ae7dce72ce
Merge pull request #91930 from RenaudWasTaken/DisableAcceleratorUsageMetrics
Add DisableAcceleratorUsageMetrics Feature Gate
2020-07-22 09:16:06 -07:00
Alexey Perevalov
e33ba9e974 Avoid using socket for hints
Sockets don't affect performance as NUMA node does, since NUMA
node has dedicated memory controller, but socket it's physical
extension point.
Socket it's only cpu specific thing and it's strange to merge bitmask of
deviceplugin's and cpu manager, when cpu manager takes into account
socket.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
2020-07-22 05:14:34 -04:00
RyderXia
b20ceaa85d regen 2020-07-22 10:53:11 +08:00
RyderXia
d76c2cc94c update build 2020-07-22 09:36:55 +08:00
Jordan Liggitt
d195fc2ec8 Ensure runtimeCache contains all observed started containers on pod delete 2020-07-21 15:54:29 -04:00
Kubernetes Prow Robot
b6174e605f
Merge pull request #93189 from klueska/upstream-fix-bug-topology-manager
Fix a bug whereby reusable CPUs and devices were not being honored
2020-07-21 04:35:17 -07:00
RyderXia
136df8ce53 update 2020-07-21 17:00:49 +08:00
RyderXia
2214117cd1 clean up unused var containerCache 2020-07-21 16:57:36 +08:00
Kubernetes Prow Robot
1fdd8fb213
Merge pull request #93263 from liggitt/windows
Fix windows kubelet startup
2020-07-20 19:51:57 -07:00
wawa0210
aea228f5dd fix no-new-privileges on windows 2020-07-20 16:14:52 -04:00
Jordan Liggitt
886727a4c0 Revert "Add deviceManager in windows container manager"
This reverts commit 056d73b1a1.
2020-07-20 16:13:53 -04:00
Giuseppe Scrivano
ef935bd991
kubelet: clamp cpu shares to max allowed
clamp the max cpu.shares to the maximum value allowed by the kernel.

It is not an issue when using cgroupfs, as the kernel will
anyway make sure the value is not out of range and automatically clamp
it, systemd has an additional check that prevents the cgroup creation.

Closes: https://github.com/kubernetes/kubernetes/issues/92855

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-07-20 17:18:03 +02:00
Kevin Klues
00df26a985 Fix a bug whereby reusable CPUs and devices were not being honored
Previously, it was possible for reusable CPUs and reusable devices (i.e.
those previously consumed by init containers) to not be reused by
subsequent init containers or app containers if the TopologyManager was
enabled. This would happen because hint generation for the
TopologyManager was not considering the reusable devices when it made
its hint calculation.

As such, it would sometimes:
1) Generate a hint for a differnent NUMA node, causing the CPUs and
devices to be allocated from that node instead of the one where the
reusable devices live; or
2) End up thinking there were not enough CPUs or devices to allocate and
throw a TopologyAffinity admission error

This patch fixes this by ensuring that reusable CPUs and devices are
considered as part of TopologyHint generation. This frunctionality is
difficult to unit test since it spans multiple components, but an e2e
test will be added in a subsequent patch to test this functionality.
2020-07-20 11:41:13 +00:00
Kevin Klues
74fe9364c3 Simplify logic in devicemanager TopologyHint generation 2020-07-20 11:41:13 +00:00
Kevin Klues
9f5f401d60 Add AnySet() to topologymanager bitmask API 2020-07-20 11:41:13 +00:00
zhangsheng02
14d2440b87 add GetAddressAndDialer unit test
Signed-off-by: zhangsheng02 <sheng.zhang@daocloud.io>
2020-07-20 18:16:58 +08:00
Gaurav Singh
0fb9b12153 [kubelet/dockershim] : Use local copy for range iterator
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-07-18 12:52:23 -04:00
Kubernetes Prow Robot
242f3d9dce
Merge pull request #80917 from aarnaud/windows-devicemanager
Port deviceManager to windows container manager to enable GPU access
2020-07-17 21:04:50 -07:00
Anish Shah
0ffe89ed0b kubelet: add operations count and error count metrics to network plugin manager 2020-07-15 12:41:35 -07:00
Kubernetes Prow Robot
d9c3d15018
Merge pull request #92986 from gnufied/fix-in-use-errors
Handle volume-in-use error during volume expansion
2020-07-15 00:30:37 -07:00
Kubernetes Prow Robot
428b500c5a
Merge pull request #90949 from pjbgf/seccomp-least-priv-kuberuntime
Add seccomp least privilege for kuberuntime
2020-07-14 04:35:21 -07:00
Kubernetes Prow Robot
3f8f9998b0
Merge pull request #90948 from pjbgf/seccomp-least-priv-dockershim
Add seccomp least privilege for docker sandbox
2020-07-14 02:23:22 -07:00
Renaud Gaubert
34dc785c0b Add the DisableAcceleratorUsageMetrics feature gate
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
2020-07-13 20:52:06 +00:00
Giuseppe Scrivano
79be8be10e
kubelet, cgroupv2: make hugetlb optional
make the hugetlb controller optional when cgroup v2 is used.

Closes: https://github.com/kubernetes/kubernetes/issues/92933

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-07-13 09:40:55 +02:00
Kubernetes Prow Robot
6b5dc37708
Merge pull request #92919 from dashpole/update_cadvisor
Update cAdvisor to v0.37.0
2020-07-12 06:59:55 -07:00
Kubernetes Prow Robot
8398bc3b53
Merge pull request #92916 from joelsmith/count-etc-hosts
Include pod /etc/hosts in ephemeral storage calculation for eviction
2020-07-12 06:59:36 -07:00
Kubernetes Prow Robot
63926cf8e7
Merge pull request #92862 from giuseppe/cgroup-fix-leaks
vendor: update github.com/opencontainers/runc
2020-07-11 20:57:11 -07:00
Hemant Kumar
b8c0435bc2 Handle volume-in-use error 2020-07-11 09:02:58 -04:00
Kubernetes Prow Robot
93e76f5081
Merge pull request #92442 from tedyu/grace-period-with-map
Respect grace period when removing mirror pod
2020-07-10 17:49:23 -07:00
Kubernetes Prow Robot
26da0ea91e
Merge pull request #92794 from klueska/upstream-more-tests-get-preferred-allocation
Add more tests for device plugin's GetPreferredAllocation() API
2020-07-10 15:42:21 -07:00
Kubernetes Prow Robot
0cb7e320a5
Merge pull request #92784 from pohly/generic-ephemeral-inline-volumes
generic ephemeral inline volumes
2020-07-10 15:41:46 -07:00
Kubernetes Prow Robot
a6378d8b12
Merge pull request #92779 from fisherxu/patch-2
Return err when create ContainerLogsDir failed
2020-07-10 15:41:37 -07:00
Ali Farah
373e0f09bd Add unittest coverage for boottime_util_linux.go 2020-07-11 04:11:01 +10:00
DeliangFan
0b80c43f76 Set the oom_score_adj of guaranteed pod to -997
When oom happens, the sandbox maybe killed first, so set the oom score of guaranteed pod to -997.
2020-07-10 15:13:15 +08:00
Patrick Ohly
ff3e5e06a7 GenericEphemeralVolume: initial implementation
The implementation consists of
- identifying all places where VolumeSource.PersistentVolumeClaim has
  a special meaning and then ensuring that the same code path is taken
  for an ephemeral volume, with the ownership check
- adding a controller that produces the PVCs for each embedded
  VolumeSource.EphemeralVolume
- relaxing the PVC protection controller such that it removes
  the finalizer already before the pod is deleted (only
  if the GenericEphemeralVolume feature is enabled): this is
  needed to break a cycle where foreground deletion of the pod
  blocks on removing the PVC, which waits for deletion of the pod

The controller was derived from the endpointslices controller.
2020-07-09 23:29:24 +02:00
David Ashpole
1f70708f6c update cAdvisor to v0.37.0 2020-07-09 10:23:10 -07:00
Kubernetes Prow Robot
70e09f2c24
Merge pull request #88842 from angao/fit-arg
add args for NodeResourcesFit plugin
2020-07-09 05:04:10 -07:00
Giuseppe Scrivano
0d2a493a8f
kubelet: skip setting the devices cgroup
use the new libcontainer feature of skipping setting the devices
cgroup.  This is necessary on cgroup v2 to avoid leaking a eBPF
program every time the cgroup is re-configured.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-07-09 09:37:46 +02:00
Kubernetes Prow Robot
1e3eeba9fa
Merge pull request #91577 from knabben/kubelet-bootstrap
kubelet: remove the --bootstrap-checkpoint-path feature
2020-07-09 00:03:41 -07:00
Kubernetes Prow Robot
4ee555252c
Merge pull request #83710 from edwardstudy/ed/typo
Fix comment typos in pkg/kubelet/prober
2020-07-09 00:02:58 -07:00
Paulo Gomes
b451563560
Add seccomp least privilege for kuberuntime 2020-07-08 22:03:29 +01:00
Ted Yu
a76a959294 Respect grace period when removing mirror pod
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-07-08 13:38:24 -07:00
Joel Smith
f34b586d01 Include pod /etc/hosts in ephemeral storage calculation for eviction 2020-07-08 12:58:11 -06:00
Anthony ARNAUD
056d73b1a1
Add deviceManager in windows container manager 2020-07-08 18:22:16 +02:00
Kubernetes Prow Robot
5afc42de95
Merge pull request #78373 from tedyu/sort-init-container
Sort init container statuses using non-nested loop
2020-07-07 09:13:58 -07:00
Quan Tian
b2b082f54f Don't create a new sandbox for pod with RestartPolicyOnFailure if all containers succeeded
The kubelet would attempt to create a new sandbox for a pod whose
RestartPolicy is OnFailure even after all container succeeded. It caused
unnecessary CRI and CNI calls, confusing logs and conflicts between the
routine that creates the new sandbox and the routine that kills the Pod.

This patch checks the containers to start and stops creating sandbox if
no container is supposed to start.
2020-07-07 22:49:48 +08:00
Kubernetes Prow Robot
7e75a5ef43
Merge pull request #87273 from SaranBalaji90/kubelet-log-file
Add support for disabling /logs endpoint in kubelet
2020-07-07 04:09:58 -07:00
Kevin Klues
26cb650655 Remove unnecessary union after call to GetPreferredAllocation()
There is no need to try and allocate already-allocated devices again.
2020-07-07 06:35:57 +00:00
Kevin Klues
67ecc11c44 Harden callGetPreferredAllocationIfAvailable() return value
Previously, we didn't check the contents of the result after calling out
to the plugin endpoint. This could have resulted in errors if the plugin
returned either 'nil' or an empty result. This patch fixes this.
2020-07-07 06:35:57 +00:00
Kevin Klues
d87365494a Fix bug in call to callGetPreferredAllocationIfAvailable()
Previously, we were passing the variable 'devices' to this function,
when we should have been passing 'allocated'. This bug crept in due to a
variable name change that didn't propogate its way through the entire
function. The tests added in the previous commit would have caught this.
2020-07-07 06:35:57 +00:00
Kevin Klues
d551ab1e78 Add tests to check paramaters passed to GetPreferredAllocation()
These tests uncovered some small bugs that will be fixed in a subsequent
set of commits.
2020-07-07 06:35:57 +00:00
Fei Xu
34826c82be Return err when create ContainerLogsDir failed 2020-07-07 09:36:35 +08:00
Sergey Kanzhelev
933a2ca634 SIG node owner files clean up 2020-07-07 00:22:05 +00:00
Kubernetes Prow Robot
a26e5881d8
Merge pull request #92786 from answer1991/feature/enhance-bootstrap-certificate
make Kubelet bootstrap certificate signal aware
2020-07-06 09:52:52 -07:00
Sri Saran Balaji Vellore Rajakumar
05240c9218 Add support for disabling /logs endpoint in kubelet 2020-07-06 07:52:30 -07:00
chenjun.cj
db71941775 make Kubelet bootstrap certificate signal aware 2020-07-06 22:30:27 +08:00
Paulo Gomes
8976e3620f
Add seccomp enforcement and validation based on new GA fields
Adds seccomp validation.

This ensures that field and annotation values must match when present.

Co-authored-by: Sascha Grunert <sgrunert@suse.com>
2020-07-06 09:13:25 +01:00
Kubernetes Prow Robot
efb56da4a5
Merge pull request #92665 from klueska/upstream-add-get-preferred-allocation-api
Add GetPreferredAllocation() call to the v1beta1 device plugin API
2020-07-03 20:31:16 -07:00
Kevin Klues
5bd0db0b1f Add new test cases for GetPreferredAllocation() in allocation path 2020-07-03 13:01:32 +00:00
Kevin Klues
83f18d9975 Remove unnecessary field from TestTopologyAlignedAllocation() test cases 2020-07-03 13:01:32 +00:00
Kevin Klues
bb08fd1135 Add a simple endpoint test for GetPreferredAllocation()
More extensive tests that exercise the allocation logic are to follow.
2020-07-03 13:01:32 +00:00
Kevin Klues
cbd405d85c Update existing tests in support of GetPreferredallocation() 2020-07-03 13:01:32 +00:00
Kevin Klues
a780ccff5b Updates logic in devicesToAllocate() to call GetPreferredAllocation() 2020-07-02 22:07:27 +00:00
Kevin Klues
bb56a09133 Add callGetPreferredAllocationIfAvailable() function in devicemanager
This function mimics what is already done for the conditional call to
PreStartContainer() via the callPreStartContainerIfNeeded() function.
2020-07-02 22:07:27 +00:00
Kevin Klues
abf87c99c6 Add GetPreferredAllocation() as a supported device plugin endpoint 2020-07-02 15:15:50 +00:00
Kevin Klues
32c047a52e Update device plugin stub with new GetPreferredAllocation() call 2020-07-02 15:15:48 +00:00
Kevin Klues
c45f1317eb Fix some whitespacing and comments in devicemanager 2020-07-02 15:15:44 +00:00
Kubernetes Prow Robot
13a4a71e99
Merge pull request #91532 from afrouzMashaykhi/log-flag-kubelet
add --logging-format flag to kubelet
2020-07-02 06:40:46 -07:00
Kubernetes Prow Robot
ce5c89a144
Merge pull request #91896 from aojea/bumpcni
bump cni library version to v0.8.0
2020-07-01 23:12:16 -07:00
amash
b92b04e7cd add default for loggingconfiguration struct 2020-07-01 22:28:27 +04:30
Antonio Ojea
6f79600e73 bump cni library version to v0.8.0
last CNI library release is 0.7.1 from Jun 11, 2019.
Since then, there was introduced new feature and bugfixes.

Currently, this library is only being used by dockershim,
the other CRI plugins are vendoring it directly

However, this will help also to mitigate some of the issues with the
CI jobs that are still using dockershim.

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2020-07-01 18:09:19 +02:00
amash
3ab25f1876 add LoggingConfiguration struct to component-base/config 2020-07-01 20:07:01 +04:30
amash
ac8d2e8978 add loggingConfig struct to kubelet config 2020-07-01 20:07:01 +04:30
amash
ba8189a4f2 add --logging-format flag to kubelet 2020-07-01 20:07:01 +04:30
Kubernetes Prow Robot
2e91b56af0
Merge pull request #87909 from alena1108/feb6cleanup
Removed unnecessary not nil check in node registration process
2020-07-01 07:10:49 -07:00
Kubernetes Prow Robot
dcdeed97cd
Merge pull request #91499 from lo24/intf-fix
fix a regression that TestValidateNodeIPParam never actually works
2020-06-30 02:52:05 -07:00
Kubernetes Prow Robot
850080c41f
Merge pull request #91867 from yan-dblinf/fix_golint_failures_pkg_kubelet_lifecycle
Fix golint failures in pkg/kubelet/lifecycle
2020-06-30 00:02:42 -07:00
Kubernetes Prow Robot
677dfbab3c
Merge pull request #91360 from liuxu623/fix-emptyDir-sizeLimit
Fix if don't set ephemeral-storage limit emptyDir's sizeLimit doesn't work
2020-06-29 18:33:58 -07:00