github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
95,536 Commits 1 Branch 31 Tags 1,019 MiB
23ef9b51a8
Commit Graph

40294 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
b1b6464ea4
Merge pull request #94581 from knabben/remote-external-policy-gate 
LockToDefault the ExternalPolicyForExternalIP feature gate
 2020-09-16 12:35:20 -07:00
David Ashpole
0ffc149ccc move dashpole to emeritus in kubelet 2020-09-16 11:52:35 -07:00
Amim Knabben
a18e5de51a LockToDefault the ExternalPolicyForExternalIP feature gate 2020-09-16 13:16:33 -04:00
Jordan Liggitt
71fcc2298d Fix resource location for ipv6 pods 2020-09-16 11:24:07 -04:00
Kubernetes Prow Robot
e5202ef433
Merge pull request #94553 from knight42/fix/TestRestoreAllWaitOldIptablesRestore 
Deflake TestRestoreAllWaitOldIptablesRestore
 2020-09-16 07:45:34 -07:00
Rob Scott
de02323a9d
Ensuring EndpointSlices are recreated after Service recreation 
This fixes a bug that occurred when a Service was rapidly recreated.
This relied on an unfortunate series of events:

1. When the Service is deleted, the EndpointSlice controller removes it
from the EndpointSliceTracker along with any associated EndpointSlices.
2. When the Service is recreated, the EndpointSlice controller sees that
there are still appropriate EndpointSlices for the Service and does
nothing. (They have not yet been garbage collected).
3. When the EndpointSlice is deleted, the EndpointSlice controller
checks with the EndpointSliceTracker to see if it thinks we should have
this EndpointSlice. This check was intended to ensure we wouldn't
requeue a Service every time we delete an EndpointSlice for it.

This adds a check in reconciler to ensure that EndpointSlices it is
working with are owned by a Service with a matching UID. If not, it will
mark those EndpointSlices for deletion (assuming they're about to be
garbage collected anyway) and create new EndpointSlices.
 2020-09-15 21:37:15 -07:00
Kubernetes Prow Robot
965137a992
Merge pull request #94692 from alculquicondor/wrap_errors_min 
Wrap errors from VolumeBinding and DefaultBinder plugins
 2020-09-15 18:27:34 -07:00
Kubernetes Prow Robot
ea5ca74195
Merge pull request #94807 from ksubrmnn/winoverlay_beta 
Graduate WinOverlay to Beta
 2020-09-15 15:15:33 -07:00
Kalya Subramanian
747e1e7466 Graduate WinOverlay to Beta 2020-09-15 13:11:14 -07:00
Kubernetes Prow Robot
e7b9453972
Merge pull request #93537 from timuthy/enhancement.move-resourcequota 
Move ResourceQuota admission to k8s.io/apiserver lib
 2020-09-15 12:26:58 -07:00
Kubernetes Prow Robot
983265aeaa
Merge pull request #94739 from knight42/fix/TestExpectationsOnRecreate 
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
 2020-09-15 11:18:07 -07:00
Kubernetes Prow Robot
fd9828b02a
Merge pull request #92632 from RenaudWasTaken/move-podresources-api 
Move external facing podresources apis to staging
 2020-09-15 10:04:07 -07:00
Kubernetes Prow Robot
33c58af0f0
Merge pull request #94510 from pacoxu/fix/94500 
remove DefaultIngressClass feature gate for 1.20
 2020-09-15 08:58:07 -07:00
Kubernetes Prow Robot
b14fcc544b
Merge pull request #92846 from Huang-Wei/rm-pvcLister 
Remove pvcLister from genericScheduler
 2020-09-15 07:54:07 -07:00
Renaud Gaubert
4eadf40448 Run gofmt 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
 2020-09-15 06:22:44 -07:00
Renaud Gaubert
ba95a8c641 run hack/update-vendor.sh 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
 2020-09-15 05:13:33 -07:00
Renaud Gaubert
60304452ff Move podresources api to k8s.io/kubelet/pkg/apis 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
 2020-09-15 05:13:33 -07:00
Jimmy Zhang
1f0bcc8f5d optimize the use of informer for scheduler 2020-09-15 18:21:40 +08:00
wawa0210
995d654167
ingore apparmor on non Linux operating systems. 2020-09-15 17:30:44 +08:00
knight42
e89e72b637
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-09-15 16:02:35 +08:00
wojtekt
fbd65a265a Pipe newFunc to etcd3 storage layer 2020-09-15 08:19:12 +02:00
Eric Weber
5cd63097ba Don't attempt to detach an FC device if we don't know its name 2020-09-14 14:32:00 -05:00
Kubernetes Prow Robot
54df1fdc90
Merge pull request #94090 from deads2k/podpreset 
remove pod presets
 2020-09-14 10:43:13 -07:00
Kubernetes Prow Robot
73dda0af5d
Merge pull request #92355 from wawa0210/fix-91482 
fix windows container root validate
 2020-09-14 10:42:59 -07:00
Kubernetes Prow Robot
11793434da
Merge pull request #94712 from droslean/cred-leak 
[credentialprovider] avoid potential secret leaking while reading .dockercfg
 2020-09-14 09:41:36 -07:00
Nikolaos Moraitis
b907f9e118 avoid potential secret leaking while reading .dockercfg 
There are a lot of scenarios where an invalid .dockercfg file
will still contain secrets. This commit removes logging of the
contents to avoid any potential leaking and manages the actual error
by printing to the user the actual location of the invalid file.

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
 2020-09-14 15:39:05 +02:00
David Eads
c0c033b12f generated 2020-09-14 09:24:41 -04:00
David Eads
c7911a384c remove pod presets 2020-09-14 09:24:40 -04:00
auxten
611ddc10b0 Fix misusage of RLock in timeCache lru.Cache.Get() 2020-09-13 21:08:19 +08:00
knight42
ce0a423ef7
test(iptables): deflake TestRestoreAllWaitOldIptablesRestore 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-09-12 22:43:44 +08:00
knight42
b25af8e3c9
feat(iptables): be able to override iptables-1.4-compatible lock path 2020-09-12 22:43:43 +08:00
Kubernetes Prow Robot
2cb951d78a
Merge pull request #91921 from mtaufen/said-beta 
Graduate ServiceAccountIssuerDiscovery to beta
 2020-09-11 23:30:57 -07:00
Kubernetes Prow Robot
a33f6b44e9
Merge pull request #94687 from karan/cfs-flag-warn 
Non-zero cfs quota period duration requires feature flag
 2020-09-11 22:28:57 -07:00
Mike Danese
94f4f06d13 test flake: fix data race in csi_test.go 
The attach goroutine can currently t.Log/t.Error during or after the
subtest completion. This causes races like:

```
==================
WARNING: DATA RACE
Read at 0x00c000e90ac3 by goroutine 1231:
  testing.(*common).logDepth()
      GOROOT/src/testing/testing.go:736 +0xa9
  testing.(*common).log()
      GOROOT/src/testing/testing.go:729 +0x8f
  testing.(*common).Logf()
      GOROOT/src/testing/testing.go:775 +0x21
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21.1()
      pkg/volume/csi/csi_test.go:313 +0x1a4
Previous write at 0x00c000e90ac3 by goroutine 875:
  testing.tRunner.func1()
      GOROOT/src/testing/testing.go:1113 +0x484
  testing.tRunner()
      GOROOT/src/testing/testing.go:1131 +0x22a
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 1231 (running) created at:
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21()
      pkg/volume/csi/csi_test.go:307 +0xf05
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 875 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1178 +0x796
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll()
      pkg/volume/csi/csi_test.go:223 +0xb2c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
==================
```

See also this comment:

07c1788357/src/testing/testing.go (L1141-L1142)

Noticed in:

https://github.com/kubernetes/kubernetes/pull/94449
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/94449/pull-kubernetes-bazel-test/1304519003330318337
 2020-09-11 22:19:42 -07:00
Wei Huang
185ba08fcd
Move podPassesBasicChecks() to VolumeBinding plugin 2020-09-11 13:54:02 -07:00
Wei Huang
42cfda2f94
Remove pvcLister from genericScheduler 
PVCLister can be fetched from sharedInformerFactory.
 2020-09-11 13:54:01 -07:00
Michael Taufen
4f850f97de Graduate ServiceAccountIssuerDiscovery to beta 2020-09-11 12:01:47 -07:00
Kubernetes Prow Robot
77f349ea17
Merge pull request #94704 from lavalamp/big-rename 
rename some files
 2020-09-11 09:50:22 -07:00
Karan Goel
a49760bfce Non-zero cfs quota period duration requires feature flag 2020-09-11 08:00:05 -07:00
Kubernetes Prow Robot
119c94214c
Merge pull request #93931 from SataQiu/fix-kubelet-swap-20200812 
kubelet: assume that swap is disabled when /proc/swaps does not exist
 2020-09-11 04:20:14 -07:00
Kubernetes Prow Robot
d39214ade1
Merge pull request #94603 from wojtek-t/migrate_leader_election_to_leases_todos 
Migrate scheduler, controller-manager and cloud-controller-manager to use LeaseLock
 2020-09-11 00:08:14 -07:00
Kubernetes Prow Robot
bd39d3933b
Merge pull request #94701 from Huang-Wei/rm-disablePreemption 
Remove field disablePreemption from internal scheduler codebase
 2020-09-10 22:14:14 -07:00
Kubernetes Prow Robot
f5a42d69c9
Merge pull request #93475 from ravisantoshgudimetla/fix-kubelet-scc 
Strip unnecessary security contexts on Windows
 2020-09-10 18:14:14 -07:00
Daniel Smith
5a4ba227af rename some files 2020-09-10 16:34:05 -07:00
Kubernetes Prow Robot
c7d6f796fe
Merge pull request #94144 from gnufied/prevent-stale-pv-read 
Reduce offline volume expansion flake
 2020-09-10 14:22:31 -07:00
Kubernetes Prow Robot
0d723d41c5
Merge pull request #92682 from Huang-Wei/preemptor-from-informer 
Preemption plugin to fetch pod from informer cache
 2020-09-10 14:22:16 -07:00
Aldo Culquicondor
7fb40fc03c Wrap errors on VolumeBinding plugin 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I23053528ac6857124fddd7f9fa26e122202ff4bd
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-09-10 16:22:16 -04:00
Aldo Culquicondor
94985e28ac Wrap errors on DefaultBinder plugin 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I2e3c8aa2c1a2a5102e9110b6cff91d66a79a90f1
 2020-09-10 16:22:16 -04:00
Aldo Culquicondor
aefcfcc627 Wrap errors when running Bind plugins 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I29f8d3ea219a5cf667cf718545e8dfff971ca6ec
 2020-09-10 16:22:15 -04:00
Aldo Culquicondor
a482d7ef8e Wrap errors when running PreBind plugins 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I31bf35d7e96b1cebb285cf03ffad310d83224d9c
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-09-10 16:22:12 -04:00
Wei Huang
eb3d2de543
Remove field disablePreemption from internal scheduler codebase 2020-09-10 13:06:42 -07:00
Kubernetes Prow Robot
6085d90897
Merge pull request #92064 from roycaihw/storage-version/serve-api 
Serve storage-versions API in kube-apiserver
 2020-09-10 10:45:48 -07:00
ialidzhikov
88fadb24c1 Fix staging/src/k8s.io/apimachinery/pkg/labels golint findings 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2020-09-10 18:55:17 +03:00
Lee Verberne
bf0a33d1de Use EphemeralContainers for storage validation 
When updating ephemeral containers, convert Pod to EphemeralContainers
in storage validation. This resolves a bug where admission webhook
validation fails for ephemeral container updates because the webhook
client cannot perform the conversion.

Also enable the EphemeralContainers feature gate for the admission
control integration test, which would have caught this bug.
 2020-09-10 17:24:52 +02:00
Aldo Culquicondor
34102140e2 Hold error in framework's Status 
To allow obtaining and comparing the original error.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: Ibcef89f7b876a273ecc24548f8d204966e0e6059
 2020-09-10 10:52:36 -04:00
Kubernetes Prow Robot
88512be213
Merge pull request #92817 from kmala/kubelet 
Check for sandboxes before deleting the pod from apiserver
 2020-09-10 07:27:45 -07:00
Hemant Kumar
bad8a51b9a Read PV object from apiserver to prevent flake 2020-09-10 10:03:08 -04:00
wojtekt
805c1753cd Migrate scheduler, controller-manager and cloud-controller-manager to lease lock. 2020-09-10 11:57:18 +02:00
tangwz
a143803066 remove feature gate SupportIPVSProxyMode. 2020-09-10 09:03:00 +08:00
Kubernetes Prow Robot
5566dc93c4
Merge pull request #94508 from andrewsykim/remove-cni-alpha 
kubelet: remove alpha warnings for CNI flags
 2020-09-09 09:07:08 -07:00
Kubernetes Prow Robot
30a9b8b126
Merge pull request #94389 from pacoxu/fix/94378 
add lock for csi node update
 2020-09-09 06:36:07 -07:00
Kubernetes Prow Robot
293a53f2c0
Merge pull request #94140 from derekwaynecarr/pid-ga 
Promote PidLimits to GA
 2020-09-09 06:35:52 -07:00
Kubernetes Prow Robot
dafc4a80d9
Merge pull request #94620 from liggitt/quota-round 
Count storage requests as whole byte values in quota
 2020-09-09 01:11:52 -07:00
Haowei Cai
07506ab384 generated 2020-09-08 19:14:36 -07:00
Chao Xu
86dd4ce3b5 Let kube-apiserver host the storage version API 
Co-authored-by: Haowei Cai <haoweic@google.com>
 2020-09-08 19:14:36 -07:00
Wei Huang
4f7ae54f3e
fixup: add podLister as a member field of DefaultPreemption 2020-09-08 18:27:23 -07:00
Wei Huang
52bf6ba8ba
Preemption plugin to fetch pod from informer cache 2020-09-08 18:27:23 -07:00
Kubernetes Prow Robot
3cf80090f0
Merge pull request #93044 from Huang-Wei/rm-sched-podInformer 
Initialize scheduler's podInformer in sharedInformerFactory
 2020-09-08 17:49:52 -07:00
Haowei Cai
769f057004 generated 2020-09-08 14:34:55 -07:00
Haowei Cai
d7ff169552 fix import paths 2020-09-08 14:34:55 -07:00
Haowei Cai
b71252a0ab add internal.apiserver.k8s.io/v1alpha1 to known gvs 2020-09-08 14:34:55 -07:00
Haowei Cai
096f32d1b3 update doc.go and register.go 2020-09-08 14:34:55 -07:00
Haowei Cai
1f4a4e9040 move apiserverinternal types to kube-apiserver 
move versioned types to k8s.io/api;
cleanup generated files
 2020-09-08 14:34:55 -07:00
Wei Huang
d8def59871
Initialize scheduler's podInformer in sharedInformerFactory 
Scheduler's specific podInfomer is now initialized inside the sahredInformerFactory.
 2020-09-08 12:57:17 -07:00
Kubernetes Prow Robot
8728450be1
Merge pull request #94179 from ddymko/golint-fix-azuredd 
fix golint for pkg/volume/azure_dd
 2020-09-08 12:29:53 -07:00
Kubernetes Prow Robot
4c1caeb3ab
Merge pull request #94610 from soltysh/94112_followup 
Remove pkg/api/endpoints
 2020-09-08 11:29:16 -07:00
Jordan Liggitt
9ee6b7f63f Count storage requests as whole byte values in quota 2020-09-08 11:33:05 -04:00
Kubernetes Prow Robot
44ecd80cf1
Merge pull request #91557 from chendave/cleanup 
cleanup: remove useless methods
 2020-09-08 06:27:44 -07:00
Kubernetes Prow Robot
d239cdfbc0
Merge pull request #94059 from ahg-g/ahg-anti-affinity 
Track pods with required anti-affinity
 2020-09-08 04:54:12 -07:00
Maciej Szulik
ed9f4ac9fc
Remove pkg/api/endpoints 2020-09-08 10:59:33 +02:00
Kubernetes Prow Robot
6b388f0684
Merge pull request #94187 from chendave/avoid_apicall 
Avoid the API call to update pod if nothing is changed
 2020-09-07 15:01:44 -07:00
Kubernetes Prow Robot
62d46b8b8b
Merge pull request #94573 from siadat/double-pointer 
Remove unnecessary double-pointer
 2020-09-07 14:02:07 -07:00
Kubernetes Prow Robot
b837699f74
Merge pull request #94125 from soulxu/only_includes_all_nodes_for_preferred 
Only process all nodes when incoming pod has no preferred affinity
 2020-09-07 14:01:58 -07:00
Kubernetes Prow Robot
2481e88485
Merge pull request #93473 from Nordix/sched-fix-mael 
Change nodeInfolist building logic in scheduler
 2020-09-07 14:01:44 -07:00
Kubernetes Prow Robot
4e9bdd481e
Merge pull request #94471 from kshitijcode/kubelet-taint-fix-93608 
Added support for register-with-taints setting #93608
 2020-09-07 01:33:41 -07:00
auxten
a9c1acc044 Fix staticchecks ST1005,S1002,S1008,S1039 in pkg/kubelet 2020-09-07 10:53:43 +08:00
Sina Siadat
6b18ff81a5 Remove unnecessary double-pointer 2020-09-06 16:22:06 +04:30
Kubernetes Prow Robot
22772d06a8
Merge pull request #94549 from knight42/fix/TestRecordOperation 
test(kuberuntime): deflake TestRecordOperation
 2020-09-05 08:11:41 -07:00
David Dymko
cda0070f28 fix golint for pkg/volume/azure_dd 2020-09-05 09:44:27 -04:00
knight42
c6f9b402fb
test(kuberuntime): deflake TestRecordOperation 
Avoid using hard-coded port

Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-09-05 13:36:26 +08:00
Kubernetes Prow Robot
1f708f6e62
Merge pull request #94112 from damemi/sort-endpoints 
Remove canonicalization of endpoints by endpoints controller for better comparison
 2020-09-04 22:13:40 -07:00
Kubernetes Prow Robot
60c421b6f6
Merge pull request #94541 from liggitt/deflake-cpucheckpoint 
Deflake cpumanager checkpoint unit tests
 2020-09-04 18:47:40 -07:00
Kubernetes Prow Robot
a84419f027
Merge pull request #94543 from liggitt/deflake-client-portforward 
Deflake port forward tests to avoid hard-coded local ports
 2020-09-04 15:41:54 -07:00
Kubernetes Prow Robot
c4cf7d331f
Merge pull request #94539 from liggitt/deflake-cmdevice 
Use unique socket name per cm test
 2020-09-04 15:41:41 -07:00
Stephen Solka
203679cc61 prefer NoError/Error over Nil/NotNil 2020-09-04 18:35:52 -04:00
Kubernetes Prow Robot
4dabc3ddc0
Merge pull request #94534 from knight42/fix/TestRestoreAllGrabOldLock 
test(iptables): deflake TestRestoreAllGrabOldLock
 2020-09-04 12:39:40 -07:00
Jordan Liggitt
fcea950405 Deflake port forward tests to avoid hard-coded local ports 2020-09-04 15:33:43 -04:00
Jordan Liggitt
7268b1d557 Deflake cpumanager checkpoint unit tests 2020-09-04 15:06:04 -04:00
Jordan Liggitt
803da10d8b Use unique socket name per cm test 2020-09-04 14:55:23 -04:00
knight42
f6f0f7922a
test(iptables): deflake TestRestoreAllGrabOldLock 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-09-05 01:07:46 +08:00
Jordan Liggitt
fdf9cab843 Deflake TestHTTPProbeProxy 2020-09-04 11:22:11 -04:00
Andrew Sy Kim
76386cf3c3 kubelet: remove alpha warnings for CNI flags 
CNI is no longer alpha and is widely used by almost every Kubernetes cluster, we should remove the alpha warnings that were originally added from the early days of CNI

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
 2020-09-04 09:35:34 -04:00
Tim Usner
cc0b86fa3c Add more tests for LRU cache lookup 2020-09-04 15:09:03 +02:00
Tim Usner
70d440bc7e Move ResourceQuota admission to k8s.io/apiserver 2020-09-04 14:53:52 +02:00
Antonio Ojea
0004b199d5 do not mutate endpoints in the apiserver 
the endpoints API handler was using the Canonicalize() method to
reorder the endpoints, however, due to differences with the
endpoint controller RepackSubsets(), the controller was considering
the endpoints different despite they were not, generating unnecessary
updates evert resync period.
 2020-09-04 08:42:45 -04:00
Kubernetes Prow Robot
1d1daaa044
Merge pull request #94084 from brianpursley/kubernetes-93925-logging 
Add logging when fail to kill container or pod
 2020-09-04 03:32:23 -07:00
Kubernetes Prow Robot
217d89a59f
Merge pull request #93843 from soulxu/fast_path_podaffinity 
Fast return when no any matched anti-affinity terms
 2020-09-04 03:31:55 -07:00
Kubernetes Prow Robot
6a9500ed70
Merge pull request #92940 from yuanchen8911/patch-2 
Fix naming inconsistency in scheduler plugin interface comments
 2020-09-04 03:31:41 -07:00
pacoxu
291b36e00b remove DefaultIngressClass feature gate for 1.20 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
 2020-09-04 14:15:43 +08:00
Kubernetes Prow Robot
4ad3018ac3
Merge pull request #94491 from dashpole/consistent_quoting 
Consistently use double quotes in proto files
 2020-09-03 20:09:40 -07:00
Kubernetes Prow Robot
a1b4b29ac0
Merge pull request #94492 from elweb9858/updateOwners 
Updating winkernel kube-proxy OWNERS file
 2020-09-03 18:57:51 -07:00
Kubernetes Prow Robot
608c0265a8
Merge pull request #94488 from liggitt/deflake-port-allocation 
Deflake TestServiceRegistryExternalTrafficHealthCheckNodePortUserAllocation
 2020-09-03 18:57:42 -07:00
Sergey Kanzhelev
1c379b1281 allow to map the same container port to different host ports 2020-09-03 22:21:18 +00:00
Kubernetes Prow Robot
48d5d204c3
Merge pull request #92614 from tnqn/onfailure-recreate 
Don't create a new sandbox for pod with RestartPolicyOnFailure if all containers succeeded
 2020-09-03 14:57:40 -07:00
elweb9858
b29379687f Updating winkernel kube-proxy OWNERS file 2020-09-03 14:55:09 -07:00
David Ashpole
296f7c91bb consistently use double quotes in proto files 2020-09-03 13:50:03 -07:00
Jordan Liggitt
68dd0b7f27 Deflake TestServiceRegistryExternalTrafficHealthCheckNodePortUserAllocation 2020-09-03 16:31:03 -04:00
Kubernetes Prow Robot
6ee74bf600
Merge pull request #94031 from knight42/fix/TestAttacherWithCSIDriver 
test(csi): deflake TestAttacherWithCSIDriver
 2020-09-03 11:13:55 -07:00
Kshitij Sharma
e4dee9cff3 Added support for register-with-taints setting #93608 2020-09-03 22:23:20 +05:30
knight42
469f59a52a
test(csi): deflake TestAttacherWithCSIDriver 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-09-03 22:39:40 +08:00
Mike Dame
44d1976f8d Remove HeadlessService label in endpoints controller before comparing 2020-09-03 09:55:18 -04:00
Kubernetes Prow Robot
8296643fad
Merge pull request #94371 from bbyrne5/bmb-resourcequota-staticcheck-errorfix 
fix staticcheck errors in resourcequota
 2020-09-03 03:41:41 -07:00
Dave Chen
4b2c054e59 Enhancement on the testcase to cover more possibilities 
This change enriches the testcase of `TestPriorityQueue_MoveAllToActiveOrBackoffQueue`
to cover the case that pods in the unschedulableQ could be moved to activeQ after the
backing off.

Signed-off-by: Dave Chen <dave.chen@arm.com>
 2020-09-03 14:04:03 +08:00
Kubernetes Prow Robot
adac1bfb8b
Merge pull request #93176 from yuzhiquan/fix-hostpath-test 
Fix for host path test case
 2020-09-02 22:57:40 -07:00
Kubernetes Prow Robot
b2cba08217
Merge pull request #93979 from dcbw/userspace-proxy-test-waitgroups 
proxy/userspace: use waitgroups instead of sketchy atomic ops in testcases
 2020-09-02 17:05:40 -07:00
Dan Williams
0cb5e55409 proxy/userspace: clean up and consolidate testcase setup 2020-09-02 16:20:13 -05:00
Dan Williams
1372bd94fe proxy/userspace: use waitgroups instead of sketchy atomic ops in testcases 
Instead of relying on atomic ops to increment/decrement at the right time
just use waitgroups to provide hard synchronization points.
 2020-09-02 16:20:13 -05:00
Daniel Smith
a86afc12df update scripts 2020-09-02 10:49:40 -07:00
Daniel Smith
7bf2adade8 fix doc file 2020-09-02 10:48:26 -07:00
Daniel Smith
15e0e3e90e rename 2020-09-02 10:48:26 -07:00
Daniel Smith
1f0305fe1b partial 2020-09-02 10:48:26 -07:00
Daniel Smith
75f835aa08 move port definitions to a common location 2020-09-02 10:48:25 -07:00
Kubernetes Prow Robot
cc14d5f3a1
Merge pull request #94338 from JeremyShih/fix-golint-error-in-admissionregistration 
fixed golint error in pkg/apis/admissionregistration/validation
 2020-09-02 10:37:19 -07:00
Kubernetes Prow Robot
90723ebbae
Merge pull request #93985 from MHBauer/fixes-93905 
update test to match validation filter of pods
 2020-09-02 09:03:21 -07:00
Matthew Fenwick
d407129cf7 modify DNS-1123 error messages to indicate that RFC 1123 is not followed exactly 2020-09-02 08:04:04 -04:00
Kubernetes Prow Robot
81bf1f8789
Merge pull request #90980 from AlexeyPerevalov/GetNUMANodeInfo 
Avoid using socket for hints in generateCPUTopologyHints
 2020-09-02 03:41:06 -07:00
Kubernetes Prow Robot
5f79e91221
Merge pull request #94340 from ialidzhikov/fix/max-data-disk-count 
Update max data disk count with new instance types
 2020-09-02 02:38:08 -07:00
Kubernetes Prow Robot
d2a0b6f2b8
Merge pull request #90014 from jacobmarble/aws-max-total-iops 
AWS: remove volume IOPS limit
 2020-09-02 00:41:20 -07:00
Dave Chen
77056e89e4 Avoid the API call to update pod if nothing is changed 
Signed-off-by: Dave Chen <dave.chen@arm.com>
 2020-09-02 14:38:11 +08:00
Kubernetes Prow Robot
f19118eea8
Merge pull request #94111 from giuseppe/fix-cgroup-v2-cgroupfs-path 
kubelet, cgroupv2: do not create /sys/fs/cgroup/sys with cgroupfs
 2020-09-01 19:41:33 -07:00
Kubernetes Prow Robot
dd6c53d035
Merge pull request #93946 from alexzimmer96/68026-pkg-controller-resourcequota 
Refactor pkg/controllers/resourcequota to fix golint errors
 2020-09-01 19:41:06 -07:00
Kubernetes Prow Robot
163504e9ae
Merge pull request #94107 from robscott/kube-proxy-source-ranges-fix 
Updating kube-proxy to trim space from loadBalancerSourceRanges
 2020-09-01 18:43:51 -07:00
Kubernetes Prow Robot
db10d8c942
Merge pull request #93773 from knight42/fix/kubelet-concurrent-map-writes 
fix(kubelet): protect `containerCleanupInfos` from concurrent map writes
 2020-09-01 18:43:27 -07:00
Kubernetes Prow Robot
a0eb9d146a
Merge pull request #94272 from RainbowMango/pr_remove_deprecated_endpoint 
remove deprecated kubelet endpoint /metrics/resource/v1alpha1
 2020-09-01 16:35:34 -07:00
Kubernetes Prow Robot
82475c3186
Merge pull request #94126 from andyzhangx/windows-azurefile-mountoptions 
fix: use sensitiveOptions on Windows mount
 2020-09-01 16:35:20 -07:00
Kubernetes Prow Robot
6e7086d7ca
Merge pull request #93638 from sbangari/refcountfix3 
Avoid dereferencing same endpoint twice on the deletion or update of a service
 2020-09-01 16:35:06 -07:00
Kubernetes Prow Robot
ea7cd3b354
Merge pull request #92796 from andyxning/code_clean_for_podgc 
code clean for podgc
 2020-09-01 15:35:06 -07:00
pacoxu
2360f228ab add lock for csi node update 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
 2020-09-01 15:52:04 +08:00
Kubernetes Prow Robot
e23d83eead
Merge pull request #93710 from Jiawei0227/attachable2non 
Detect volume attach-ability in the middle of attaching
 2020-08-31 17:39:50 -07:00
Yuan Chen
f6f9bf3e76 Update comments in pkg/scheduler/framework/v1alpha1/interface.go 2020-08-31 15:51:42 -07:00
Kubernetes Prow Robot
fe67e85bbf
Merge pull request #93457 from ymmt2005/aware-deleting-pvc 
Do not create StatefulSet pods when PVC is being deleted
 2020-08-31 14:47:50 -07:00
Brian Byrne
a820a82785 fix staticcheck errors in resourcequota 2020-08-31 12:27:23 -04:00
Morgan Bauer
7de68309d4
update test to match validation filter of pods 
invalid pod filter changed to name only

changed for k8s v1.9 in 811447ea0a PR#53194
 2020-08-31 09:14:49 -07:00
Jeremy Shih
4ee5cdc838 fixed golint error in pkg/apis/admissionregistration 2020-08-31 09:43:51 +08:00
ialidzhikov
2327e32839 Update max data disk count with new instance types 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2020-08-30 21:52:41 +03:00
Kubernetes Prow Robot
0decea31a1
Merge pull request #93124 from gaurav1086/InjectImageInspects_fix_range_issue 
[kubelet/dockershim] : fix range iterator copy issue in InjectImageInspects
 2020-08-29 20:04:21 -07:00
Kubernetes Prow Robot
3e8bc58cce
Merge pull request #91970 from SergeyKanzhelev/criLinterIssuesFix 
fix linter issues for kubelet/cri/remote and ri-api/pkg/apis/testing
 2020-08-28 10:39:49 -07:00
Kubernetes Prow Robot
617f17f238
Merge pull request #93704 from SergeyKanzhelev/PodReasonUnschedulableIsNotAType 
PodReasonUnschedulable is not a pod condition type
 2020-08-28 08:04:31 -07:00
Kubernetes Prow Robot
5ce93a2ab5
Merge pull request #93673 from zhouya0/pv_controller_test_add_time_out 
Cleanup wait forever loops in pv_controller_test.go
 2020-08-28 08:04:17 -07:00
Kubernetes Prow Robot
eae3294b8d
Merge pull request #93101 from yiduyangyi/fix-golint 
fix golint failures in pkg/kubeapiserver/options
 2020-08-28 08:03:50 -07:00
Kubernetes Prow Robot
9ff9e8798a
Merge pull request #93498 from luigibk/use-ebtables-from-utils 
Update k8s.io/utils dependency and use ebtables from there
 2020-08-28 06:37:21 -07:00
Kubernetes Prow Robot
dce91dece3
Merge pull request #93283 from runzexia/cleanup-unused-container-cache 
clean up unused var containerCache
 2020-08-28 06:36:33 -07:00
Kubernetes Prow Robot
2382628f16
Merge pull request #93246 from lixiaobing1/lxb-remove-algorithm 
remove some notes about scheduler/algorithm
 2020-08-28 06:36:18 -07:00
Kubernetes Prow Robot
9b46d76d5e
Merge pull request #93180 from FreeZhang61/unittest/add_GetAddressAndDialer_unit_test 
add  unit test for GetAddressAndDialer
 2020-08-28 06:36:04 -07:00
Kubernetes Prow Robot
7abc47d315
Merge pull request #93136 from donggangcj/fix-static-check-error 
fix(staticcheck): fix static error of package `/pkg/volume/gcepd`
 2020-08-28 06:35:21 -07:00
Kubernetes Prow Robot
72350a3cf7
Merge pull request #93083 from Huang-Wei/dupe-import-alias 
Remove duplicate path imports
 2020-08-28 04:34:53 -07:00
Kubernetes Prow Robot
24ec90d23c
Merge pull request #93015 from gnufied/remove-resize-map 
Remove resize map code - unused code
 2020-08-28 00:46:53 -07:00
Sergey Kanzhelev
df2f67daf8 fix linter issues for pkg/kubelet/cri/remote and staging/src/k8s.io/cri-api/pkg/apis/testing 2020-08-28 04:15:39 +00:00
Kubernetes Prow Robot
0a1aa394b7
Merge pull request #92987 from nikhita/cleanup-owners-apimachinery 
apimachinery: remove inactive members from OWNERS
 2020-08-27 19:08:33 -07:00
Kubernetes Prow Robot
215d2c6bce
Merge pull request #92983 from iotty/csr.clean 
[pkg/controller/certificates]: remove staled func comments
 2020-08-27 19:08:23 -07:00
Kubernetes Prow Robot
27c9bd4fd4
Merge pull request #92939 from yuanchen8911/patch-1 
Fix an error in PreBindPlugin comment
 2020-08-27 19:08:04 -07:00
Kubernetes Prow Robot
5760cef7a4
Merge pull request #92878 from jvanz/issue90293 
cleanup: print warning message only if the function does not finish within 30 seconds
 2020-08-27 19:07:55 -07:00
Kubernetes Prow Robot
481830b396
Merge pull request #92847 from SergeyKanzhelev/sigNodeOwnersCleanUp 
SIG node owner files clean up
 2020-08-27 19:07:40 -07:00
Kubernetes Prow Robot
a4103dfeaf
Merge pull request #92819 from chendave/cleanup_machine 
Change the node name from "machine" to "node"
 2020-08-27 19:06:57 -07:00
Kubernetes Prow Robot
ecfcd5fe59
Merge pull request #92760 from farah/farah/unit-test 
Add unit test coverage for boottime_util_linux.go
 2020-08-27 19:06:43 -07:00
RainbowMango
3c7caff44d remove deprecated kubelet endpoint /metrics/resource/v1alpha1 2020-08-28 09:16:56 +08:00
Kubernetes Prow Robot
67a7509ef3
Merge pull request #92430 from wangkai1994/fix/garbagecollector-staticcheck 
Fix staticcheck failures for pkg/controller/garbagecollector/garbagecollector_test.go
 2020-08-27 17:57:22 -07:00
Kubernetes Prow Robot
2e59a17dc1
Merge pull request #92288 from zhijianli88/cleanup-tempfiles 
Cleanup tempfiles
 2020-08-27 17:56:54 -07:00
Kubernetes Prow Robot
fe1aeff2d2
Merge pull request #92013 from MHBauer/dockershim-error-test 
basic regression test of runDockershim
 2020-08-27 17:55:55 -07:00
Kubernetes Prow Robot
9d6e10231c
Merge pull request #91333 from knabben/kubelet-types-tests 
Adding tests for Kubelet pod update functions
 2020-08-27 17:54:59 -07:00
Kubernetes Prow Robot
5ec83bc973
Merge pull request #91181 from zvier/master 
fix golint errors for `pkg/kubelet/dockershim`
 2020-08-27 17:54:45 -07:00
Kubernetes Prow Robot
9062c43b76
Merge pull request #94211 from soulxu/cleanup_candidates 
Initialize candidate directly instead of iterating the array of candidates
 2020-08-27 16:08:06 -07:00
Kubernetes Prow Robot
9bba0390ed
Merge pull request #94083 from soulxu/shrink_lock_scope 
Only lock statuses map when status isn't successful
 2020-08-27 16:07:57 -07:00
Kubernetes Prow Robot
90b8163b32
Merge pull request #93808 from zhouya0/seperate_registry_and_feature_gates 
Scheduler ListAlgorithmProviders function return providers directly
 2020-08-27 16:07:28 -07:00
Kubernetes Prow Robot
2fbde4f5d2
Merge pull request #93739 from mrkm4ntr/pv-class-name 
Use v1helper.GetPersistentVolumeClass for compatibility
 2020-08-27 16:07:17 -07:00
Kubernetes Prow Robot
69d5d620a4
Merge pull request #93723 from ynqa/add-testcases-kubelet-getters 
add testcases for kubelet getters
 2020-08-27 16:06:58 -07:00
Kubernetes Prow Robot
a5160414e0
Merge pull request #93706 from SimpCosm/fix/scheduler-plugin-comment 
Fix an error in NodeUnschedulable plugin comment
 2020-08-27 16:06:48 -07:00
Kubernetes Prow Robot
1bb55ae55d
Merge pull request #93681 from gireeshpunathil/typo 
fix a typo in the comment
 2020-08-27 16:06:39 -07:00
Kubernetes Prow Robot
19064f4738
Merge pull request #93669 from Mr-Linus/patch-1 
Remove unnecessary conversion
 2020-08-27 16:06:25 -07:00
Kubernetes Prow Robot
274e33b691
Merge pull request #93581 from SergeyKanzhelev/nameOfPortMappingIsNotNeeded 
Clean up in port mapping functionality
 2020-08-27 16:06:11 -07:00
Kubernetes Prow Robot
7b55facc29
Merge pull request #93431 from ESWZY/add-test 
Add test for `pkg/kubelet/util/util_windows_test.go#GetAddressAndDialer`
 2020-08-27 16:05:43 -07:00
Kubernetes Prow Robot
35942f6570
Merge pull request #94177 from iotty/fix.godoc 
[pkg/registry/admissionregistration]: fixup wrong copy&paste godoc
 2020-08-27 13:29:24 -07:00
He Jie Xu
0e8bd4c550 Initialize candidate directly instead of iterating the array of candidates 
Using existing victimsMap to get the victims, then it is easy to build candidate
directly.
 2020-08-27 23:29:36 +08:00
Kubernetes Prow Robot
597eb78b25
Merge pull request #94160 from matthyx/startupprobe-ga 
Remove StartupProbe featuregate and related logic
 2020-08-27 06:42:49 -07:00
Kubernetes Prow Robot
b9c461afe5
Merge pull request #93852 from nikhita/cleanup-vsphere-owners 
vsphere: remove inactive members from OWNERS
 2020-08-27 06:42:21 -07:00
Kubernetes Prow Robot
008708d036
Merge pull request #93966 from Miciah/verify-that-an-ingress-with-empty-TLS-is-valid 
Verify that an ingress with empty TLS is valid
 2020-08-27 04:48:57 -07:00
Kubernetes Prow Robot
1814612d34
Merge pull request #87919 from SomtochiAma/update-api-docs 
Adds additional documentation for job status
 2020-08-27 01:19:02 -07:00
Kubernetes Prow Robot
1364a6028d
Merge pull request #92759 from kumarvin123/master 
Updating the Reviewers / Approvers for WinKernel Proxier
 2020-08-27 00:07:16 -07:00
Kubernetes Prow Robot
3703004a95
Merge pull request #94214 from knight42/fix/TestSyncEndpoints 
test(endpointslice): deflake TestSyncEndpoints
 2020-08-26 20:51:27 -07:00
Kubernetes Prow Robot
06eb495a0f
Merge pull request #93896 from alculquicondor/speed-up-volume-binding-test 
Improve running time of TestSchedulerWithVolumeBinding
 2020-08-26 19:41:10 -07:00
brianpursley
6d001ebb68 Add logging if container or pod fails to be killed 2020-08-25 20:37:49 -04:00
He Jie Xu
ccd8eb3b1b Only process all nodes when incoming pod has no preferred affinity 
Currently, in interpodaffinty plugin, it only processes all nodes when the incoming
pod with affinity. Actually, it only cares about all nodes when the incoming pod
with preferred affinity. Then it will reduces the number of nodes need to be
processed.
 2020-08-25 16:13:17 +08:00
knight42
02236580a6
test(endpointslice): deflake TestSyncEndpoints 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-08-25 15:40:29 +08:00
Linus Lee 李俊江
e55856048d Remove unnecessary conversion 
Update framework.go

Update framework.go

Update framework.go

remove unnecessary conversion

remove unnecessary conversion

remove unnecessary conversion

remove unnecessary conversion
 2020-08-25 10:07:11 +08:00
Kubernetes Prow Robot
4db3a096ce
Merge pull request #94171 from robscott/endpointslicemirroring-fix 
Updating EndpointSliceMirroring controller to listen for Service changes
 2020-08-24 18:44:16 -07:00
Jiawei Wang
a6d8e6c5c2 Detect change of volume attachability in the middle of attaching 
- Add Unit tests for both volumemanager and attach/detach controller
- Add E2E test
 2020-08-24 17:15:11 -07:00
Rob Scott
3c804502d7
Updating EndpointSliceMirroring controller to listen for Service changes 
This fixes a bug that could occur if a custom Endpoints resource was
created before a Service was created.
 2020-08-24 17:09:42 -07:00
Derek Carr
6f2153986a Promote PidLimits to GA 2020-08-24 13:57:48 -04:00
knight42
cfeddcf654
test(kuberuntime): deflake TestRemoveContainer 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-08-24 11:14:02 +08:00
Zhou Peng
d253551e89 [pkg/registry/admissionregistration]: fixup wrong copy&paste godoc 
This was introduced at commit: fc5a613c17

Signed-off-by: Zhou Peng <p@ctriple.cn>
 2020-08-23 00:48:55 +08:00
Matthias Bertschy
ea14585500 Remove StartupProbe featuregate and related logic 2020-08-22 15:09:52 +02:00
Kubernetes Prow Robot
1c93be24ee
Merge pull request #93629 from cofyc/93009 
fix flaky TestVolumeBinding unit test
 2020-08-21 08:33:40 -07:00
Abdullah Gharaibeh
a8873e1a43 Track pods with required anti-affinity 
This is a performance optimization that reduces the overhead of inter-pod affinity PreFilter calculaitons. Basically
eliminates that overhead when no pods in the cluster use required pod anti-affinity. This offered 20% improvement on 5k clusters for preferred anti-affinity benchmarks.
 2020-08-21 10:09:21 -04:00
Rob Scott
c382c79f60
Updating kube-proxy to trim space from loadBalancerSourceRanges 
Before this fix, a Service with a loadBalancerSourceRange value that
included a space would cause kube-proxy to crashloop. This updates
kube-proxy to trim any space from that field.
 2020-08-20 18:19:52 -07:00
Alexander Zimmermann
86dc0364f4
Refactored pkg/controllers/resourcequota 
* Fixed golint issues
* Removed redundant package import names
* Improved some variables and names

Co-authored-by: Mike Danese <mikedanese@gmail.com>
 2020-08-20 14:37:27 +02:00
Kubernetes Prow Robot
6da73aa572
Merge pull request #93333 from loburm/fix-logrotate 
Fix an issue when rotated logs of dead containers are not removed.
 2020-08-20 03:27:23 -07:00
andyzhangx
1b213c9053 fix: use sensitiveOptions on Windows mount 2020-08-20 07:31:07 +00:00
Derek Carr
02daa3ec23 Cleanup kubelet TODOs that are no longer pertinent. 2020-08-19 16:40:54 -04:00
Giuseppe Scrivano
49cbf91fce
kubelet, cgroupv2: do not create /sys/fs/cgroup/sys with cgroupfs 
Closes: https://github.com/kubernetes/kubernetes/issues/94104

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2020-08-19 22:29:38 +02:00
ynqa
7d58ead809 delete tests which use container manager stub 2020-08-19 10:07:36 +09:00
Kubernetes Prow Robot
bdb99c8e09
Merge pull request #93906 from aojea/flakeSvc 
Deflake TestServiceRegistryUpdateDryRun test
 2020-08-18 15:45:10 -07:00
Antonio Ojea
b276b4775f Deflake TestServiceRegistryUpdateDryRun test 
The test suite was using a /24 cluster network for the allocator.
The ip allocator, if no ip is specified when creating the cluster,
picks one randomly, that means that we had 1/256 chances of
collision.

The TestServiceRegistryUpdateDryRun was creating a service without
a ClusterIP, the ip allocator assigned one random, and it was
never deleting it. The same test was checking later if one
specific IP was not allocated, not taking into consideration
that the same ip may have allocated to the first Service.

To avoid any randomness, we create the first Service with a specific
IP address.
 2020-08-18 22:02:55 +02:00
Rob Scott
9180cf2346
Updating EndpointSlice controller to wait for all caches to be synced 
Previously the EndpointSlice controller was not waiting for
EndpointSlices or Nodes to be synced.
 2020-08-18 12:11:44 -07:00
He Jie Xu
dc52b69ddc Only lock statuses map when status isn't successful 
Determine the status successful or not first, that will reduce the chance
of lock contention.
 2020-08-18 22:40:15 +08:00
maelk
fc5edb8c12
Change nodeInfolist building logic in scheduler 
This commit transforms the next() function of the scheduler node
tree into a listNodes() function that directly returns a list of
nodes, going through the zones in a round-robin fashion. This
removes the flawed logic of the next() function.
 2020-08-18 11:35:14 +03:00
Kubernetes Prow Robot
fd74333a97
Merge pull request #93622 from knight42/test/plugin-register-timeout 
Fix race condition in pluginWatcher
 2020-08-17 19:03:32 -07:00
ymmt
17af029bc5 do not create StatefulSet pods when PVC is being deleted 
Pod with PVC will not be scheduled if the PVC is being deleted.
This can happen when the PVC has finalizers of storage plugins.

Such a pod becomes pending.  Unfortunately, after the finalizer
finishes and PVC is deleted, the pod remains pending forever.
The StatefulSet controller does nothing for this pending pod.

This commit prevents the StatefulSet controller from creating
such pods when PVC is to be deleted.
 2020-08-17 22:50:42 +00:00
Kubernetes Prow Robot
ebbbc57540
Merge pull request #93707 from jingxu97/Aug/subpath 
Fix issue in evaluating symlink path for subpath
 2020-08-16 08:38:17 -07:00
Jing Xu
5aa817ab43 Fix issue in evaluating symlink path for subpath 
This PR tries to fix issue https://github.com/kubernetes/kubernetes/issues/93759
 2020-08-14 19:39:55 -07:00
Kubernetes Prow Robot
fa1a3e0f74
Merge pull request #93665 from dims/emeritus-bgrant0607 
Move bgrant0607 to emeritus status.
 2020-08-14 00:48:22 -07:00
Kubernetes Prow Robot
770a59afc4
Merge pull request #93821 from dims/sign-up-dims-for-additional-review-roles 
Sign up dims for additional review roles
 2020-08-13 21:48:21 -07:00
knight42
de46e81e74
fix(pluginwatcher): watch socket dir before traversing it 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-08-14 12:07:04 +08:00
Kubernetes Prow Robot
5bbc8e10f3
Merge pull request #93954 from Miciah/fix-validation-of-ingress-rules-with-wildcard-host 
Fix validation of ingress rules with wildcard host
 2020-08-13 15:40:21 -07:00
Kubernetes Prow Robot
3647766cbc
Merge pull request #93938 from alculquicondor/revert-node-delete 
Keep track of remaining pods when a node is deleted
 2020-08-13 13:25:41 -07:00
Miciah Masters
e648deca3b Fix validation of ingress rules with wildcard host 
Fix ingress validation so that it validates the rules of an ingress that
specifies a wildcard host.  Commit 60f4fbf4f2
added an inopportune continue statement that caused this validation to be
skipped.  For backwards compatibility, this change restores validation for
v1 of the api but still skips it on v1beta1.

* pkg/apis/networking/validation/validation.go (IngressValidationOptions):
Add AllowInvalidWildcardHostRule field to indicate that validation of rules
should be skipped for ingresses that specify wildcard hosts.
(ValidateIngressCreate): Set AllowInvalidWildcardHostRule to true if the
request is using the v1beta1 API version.
(ValidateIngressUpdate): Set AllowInvalidWildcardHostRule to true if the
request or old ingress is using the v1beta1 API version.
(validateIngressRules): Don't skip validation of the ingress rules unless
the ingress has a wildcard host and AllowInvalidWildcardHostRule is true.
(allowInvalidWildcardHostRule): New helper for ValidateIngressCreate and
ValidateIngressUpdate.
* pkg/apis/networking/validation/validation_test.go
(TestValidateIngressCreate, TestValidateIngressUpdate): Add test cases to
ensure that validation is performed on v1 objects and skipped on v1beta
objects for backwards compatibility.
(TestValidateIngressTLS): Specify PathType so that the test passes.

Co-authored-by: jordan@liggitt.net
 2020-08-13 15:53:17 -04:00
Aldo Culquicondor
dfe9e413d9 Keep track of remaining pods when a node is deleted. 
The apiserver is expected to send pod deletion events that might arrive at a different time. However, sometimes a node could be recreated without its pods being deleted.

Partial revert of https://github.com/kubernetes/kubernetes/pull/86964

Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I51f683e5f05689b711c81ebff34e7118b5337571
 2020-08-13 14:24:01 -04:00
Aldo Culquicondor
16d7ecfa45 Remove direct accesses to cache's node map 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: Iebb22fc816926aaa1ddd1e4b2e52f335a275ffaa
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-08-13 14:22:06 -04:00
Miciah Masters
7ef8fa7207 Verify that an ingress with empty TLS is valid 
Add a test that verifies that an ingress with an empty TLS value or with a
TLS value that specifies an empty list of hosts passes validation.

* pkg/apis/networking/validation/validation_test.go
(TestValidateEmptyIngressTLS): New test.
 2020-08-13 11:55:18 -04:00
Kubernetes Prow Robot
b1b93e3013
Merge pull request #93908 from robscott/endpointslice-err-return 
Updating EndpointSlice controllers to return if error encountered
 2020-08-12 21:26:14 -07:00
lixiaobing1
7920de5b57 remove some notes about scheduler/algorithm 2020-08-13 10:01:54 +08:00
ESWZY
9ce4dfe6d2 Add test for pkg/kubelet/util/util_windows_test.go#GetAddressAndDialer 2020-08-13 01:17:00 +08:00
Rob Scott
4cfe4403b4
Updating EndpointSlice controllers to return if error encountered 
Previously the controllers would proceed with additional creates,
updates, or deletes if 1 failed. That could potentially result in
scenarios where an EndpointSlice create or update failing while a delete
worked. This updates the logic so that removals will not happen if
additions fail.
 2020-08-12 09:58:03 -07:00
SataQiu
ad1739f8bc kubelet: assume that swap is disabled when /proc/swaps does not exist 2020-08-12 22:43:58 +08:00
Jordan Liggitt
f87a846e65 Validate ingress TLS secretName in v1 2020-08-12 10:13:08 -04:00
zhouya0
a1c3ebdffc Seperate registry and feature gates 2020-08-12 09:06:21 +08:00
Kubernetes Prow Robot
4750523bac
Merge pull request #93893 from alculquicondor/fix-scheduler-test 
Sync cache before starting scheduler test
 2020-08-11 15:31:46 -07:00
Aldo Culquicondor
1978866474 Improve running time of TestSchedulerWithVolumeBinding 
Only wait for finished binding or error, but not both

Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I13d16e6c7c45c6527591aa05cc79fc5e96d47a68
 2020-08-11 17:31:29 -04:00
Kubernetes Prow Robot
343817ef93
Merge pull request #93831 from cofyc/fix93830 
scheduler: forget the pod when the reserve plugins fail
 2020-08-11 12:36:17 -07:00
Aldo Culquicondor
24f817a487 Sync cache before starting scheduler test 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I9629e1d6d510607b505b0302e23d67e0ae4a662e
 2020-08-11 13:36:54 -04:00
Yecheng Fu
1176ef9c7d forget the pod when the reserve plugins fail 
and move the metrics function calls before all other functions
 2020-08-11 21:28:33 +08:00
yodarshafrir1
24010022ef Number of failed jobs should exceed the backoff limit and not big equal. 
Remove patch in e2e test of backoff limit due to usage of NumRequeues
 2020-08-11 11:06:09 +03:00
Kubernetes Prow Robot
15a3d46db1
Merge pull request #93030 from swetharepakula/endpoint-tracker 
Requeue Service after Endpoint Deletion
 2020-08-10 18:28:16 -07:00
Bilal Amarni
81867fd1d9 Enable completion for kubectl config delete-context 
This enables shell completion for `delete-context`, which will suggest
context names, similarly to the `use-context` and `rename-context`
subcommands.
 2020-08-10 16:24:36 +02:00
Nikhita Raghunath
53e87ddd15 vsphere: remove inactive members from OWNERS 
As a part of cleaning up inactive members (who haven't been active since
beginning of 2019) from OWNERS files, this commit moves abrarshivani to
emeritus_approvers section.
 2020-08-10 15:23:25 +05:30
He Jie Xu
75ccb90407 Fast return when no any matched anti-affinity terms 
When check the incoming pod's anti-affinity rules, there is change to
return early when there is no any matched anti-affinity terms in the
whole cluster.
 2020-08-10 14:53:10 +08:00
Kubernetes Prow Robot
37cda82c35
Merge pull request #93722 from liggitt/taint-evict 
Do not evict pods which tolerate all NoExecute taints
 2020-08-09 20:42:19 -07:00
houmin
868dd41a96 Fix an error in NodeUnschedulable plugin comment 2020-08-10 11:20:23 +08:00
Davanum Srinivas
3421199494
Sign up dims for additional review roles 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2020-08-08 19:08:38 -04:00
Kubernetes Prow Robot
ec2651cc44
Merge pull request #93790 from liggitt/ns-cleanup-op-cache 
Fix namespace controller cleanup orphaning
 2020-08-08 07:26:19 -07:00
Kubernetes Prow Robot
377287ad37
Merge pull request #93660 from damemi/1.19-affinity-validation 
Add LabelSelector validation in Pod Affinity/AntiAffinity Filter and Score plugins
 2020-08-08 03:40:19 -07:00
Jordan Liggitt
648c591fff Fix namespace controller cleanup orphaning 2020-08-07 13:26:28 -04:00
Mike Dame
012245c5b9 Add LabelSelector validation in Pod Affinity/AntiAffinity Filter and Score plugins 
The lack of this validation on incoming pods causes unpredictable cluster outcomes
when later calculating affinity results against existing pods (see #92714). This fix
quickly addresses the main source where these problems should be caught.

It is unfortunately difficult to add this validation directly to the API server due
to the fact that it may break migrations with existing pods that fail this check. This
is a compromise to address the current issue.
 2020-08-07 12:17:40 -04:00
yodarshafrir1
ca420ddada Fix job's backoff limit for restart policy Never, rely on number of failures instead of number of NumRequeues 2020-08-07 14:22:40 +03:00
knight42
ebf60155bf
test(kubelet): add a regression test to verify kubelet would not panic 2020-08-07 17:50:22 +08:00
knight42
a471843246
fix(kubelet): protect containerCleanupInfos from concurrent map writes 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-08-07 16:55:56 +08:00
lsytj0413
16c13017a2 refactor(*): update pvc quota name typo in comment 2020-08-07 10:36:10 +08:00
Kubernetes Prow Robot
92e51c1901
Merge pull request #93717 from liggitt/deflake-nodestatus 
Deflake TestUpdateNodeStatusWithLease - guard cached machineInfo
 2020-08-06 16:16:19 -07:00
Kubernetes Prow Robot
f5334fad48
Merge pull request #93617 from liggitt/deflake-ds-test 
Deflake TestExpectationsOnRecreate
 2020-08-06 09:35:43 -07:00
ynqa
4357551ae3 add testcases for kubelet getters 2020-08-07 00:03:42 +09:00
Gireesh Punathil
fdbfbaac33 fix a typo in the comment 2020-08-06 07:57:12 +05:30
Shintaro Murakami
b7792711f5 Use v1helper.GetPersistentVolumeClass for compatibility 2020-08-06 09:26:21 +09:00
Kubernetes Prow Robot
382107e6c8
Merge pull request #93441 from robscott/endpointslicemirroring-tracker-fix 
Fixing memory leak in EndpointSliceMirroring EndpointSlice tracker
 2020-08-05 11:54:28 -07:00
Swetha Repakula
23a3353a6a Requeue service after endpoint deletion 
- ensure endpoints that have been deleted and are desired are recreated
 despite a possibly out of date endpoint cache
 2020-08-05 11:50:23 -07:00
Jordan Liggitt
892bdf9a15 Do not evict pods which tolerate all NoExecute taints 2020-08-05 12:50:43 -04:00
Jordan Liggitt
b181c76cbd Deflake TestUpdateNodeStatusWithLease - guard cached machineInfo 2020-08-05 10:00:36 -04:00
Sergey Kanzhelev
a84834fdcf PodReasonUnschedulable is not a pod condition type 2020-08-05 03:06:37 +00:00
Kubernetes Prow Robot
8b7d8cd299
Merge pull request #93403 from hex108/remove_err_msg 
Remove unuseful error message about updating pod conditions not owned…
 2020-08-04 11:46:22 -07:00
Rodrigo Campos
e6c67c32e1 Fix kubelet log message when starting a container 
This code can be called not only when a container is dead and restarted,
but when is started for the first time too. For example, any pod with
initContainer and containers will exhibit this behaviour. The reason is
that in that case, the "if createPodSandbox" path will return the
initContainers only and on the next call to this function this code is
executed to start the containers for the fist time.

In that case, it is wrong to log that the container is dead and will be
restarted, as it was never started. In fact, the restart count will not
be increased.

This commit just changes this to say that the container is not in the
desired state and should be started. In the end, the kubelet is a state
machine and that is all we really care about.

No tests are added, as the behaviour was correct and tests don't check
logs messages.

Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
 2020-08-04 14:58:27 -03:00
Shingo Omura
ef1fab7642
expose Run[Pre]ScorePlugins functions in PluginRunner interface 2020-08-04 22:50:13 +09:00
zhouya0
8724a8ea6b Cleanup wait forever loops in pv_controller_test.go 2020-08-04 16:19:32 +08:00
Kubernetes Prow Robot
9d8a87b5c7
Merge pull request #93442 from robscott/endpointslicemirroring-labels 
Updating EndpointSliceMirroring controller to copy labels from Endpoints
 2020-08-04 01:14:19 -07:00
Kubernetes Prow Robot
1a05ebe2c6
Merge pull request #93655 from liggitt/deflake-test-controller-sync 
Deflake TestControllerSync
 2020-08-03 23:22:18 -07:00
ravisantoshgudimetla
cd8686bc57 Strip unnecessary security contexts on Windows 
As of now, the kubelet is passing the security context to container runtime even
if the security context has invalid options for a particular OS. As a result,
the pod fails to come up on the node. This error is particularly pronounced on
the Windows nodes where kubelet is allowing Linux specific options like SELinux,
RunAsUser etc where as in [documentation](https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#v1-container),
we clearly state they are not supported. This PR ensures that the kubelet strips
the security contexts of the pod, if they don't make sense on the Windows OS.
 2020-08-03 23:43:31 -04:00
Davanum Srinivas
fbca4e3ee9
Move bgrant0607 to emeritus status. 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2020-08-03 21:50:46 -04:00
Vinod K L Swamy
e9719ebc46
Updating the Reviewers / Approvers for WinKernel Proxier 2020-08-03 17:16:22 -07:00
Sravanth Bangari
b96cebf222 fix the remote endpoint cleanup logic 2020-08-03 14:57:44 -07:00
Rob Scott
52894d7bfb
Updating EndpointSliceMirroring controller to copy labels from Endpoints 
The KEP specifies that the controller will "mirror all labels from the
Endpoints resource and all endpoints and ports from the corresponding subset".
I'd missed that in my initial implementation, this should fix that.
 2020-08-03 14:12:30 -07:00
Kubernetes Prow Robot
e4472ca486
Merge pull request #93614 from liggitt/csr-fuzz 
Update CSR fuzzing to match defaulting
 2020-08-03 12:05:41 -07:00
Jordan Liggitt
c4c946d35d Deflake TestControllerSync 2020-08-03 11:56:14 -04:00
Yecheng Fu
96d0408a89 fix TestVolumeBinding unit test 2020-08-03 07:06:06 +08:00
Kubernetes Prow Robot
11c6d72e37
Merge pull request #93478 from sjenning/fixup-helper-test 
kubelet: eviction: remove unexpected output from TestGetReclaimableThreshold
 2020-08-02 10:07:40 -07:00
Kubernetes Prow Robot
c1b772fb33
Merge pull request #93516 from soulxu/fix_node_tree_test 
Create new slice to avoid modify original fake data
 2020-08-01 22:59:39 -07:00
Jordan Liggitt
8e6a8669c0 Deflake TestExpectationsOnRecreate 2020-07-31 18:12:01 -04:00
Jordan Liggitt
1e621ab5d1 Update CSR fuzzing to match defaulting 2020-07-31 15:52:01 -04:00
Jordan Liggitt
7335770670 Make toKubeContainerImageSpec deterministic 2020-07-31 14:41:11 -04:00
xiaofei.sun
a724481f5c fix metrics kubelet_running_pod_count 2020-07-31 16:35:53 +08:00
Kubernetes Prow Robot
b7d44329f3
Merge pull request #93570 from liggitt/deprecate-component-status 
Mark componentstatus as deprecated
 2020-07-30 23:54:12 -07:00
Sergey Kanzhelev
3af652f2f2 revert auto-completed package names 2020-07-31 03:47:04 +00:00
Sergey Kanzhelev
d20fd40884 remove legacy leftovers of portmapping functionality that was moved to CNI 2020-07-30 23:12:16 +00:00
Jordan Liggitt
44a8d72d32 Mark componentstatus as deprecated 2020-07-30 17:25:26 -04:00
Jordan Liggitt
1420b377e4 Add providerless tags 2020-07-30 13:48:40 -04:00
Kubernetes Prow Robot
72a62bcade
Merge pull request #92948 from cheftako/owners 
Adding cheftako to pkg/controller/OWNERS
 2020-07-30 05:56:30 -07:00
Luigi Bitonti
19793bd3fa Update k8s.io/utils dependency and use ebtables from there 2020-07-30 08:58:21 +01:00
Wei Huang
0e71facefe
Hold Pod in cache until all other cleanup work is completed 
- Move "ForgetPod" after "RunReservePluginsUnreserve", so that the cache would hold the pod to
  avoid it's being retried simutaneously until Unreserve is completed.
- Move "assume" ahead of "RunReservePluginsReserve". This is based on the fact that "ForgetPod" is
  the last step of failure path, so "assume" should be reversly treated as the first step. The
  current failure path is like this:
  assume -> reserve -> unreserve -> forgetPod -> recordingFailure
- Make subtests of TestReservePluginUnreserve stateless
 2020-07-29 11:27:19 -07:00
He Jie Xu
33a7e94b6a Create new slices to avoid modify original fake data 
When create fake data for the nodeTree unittests, The 'append' is invoked
on the common fake data set. That makes the unittests is running with unexpected
fake data after that.
 2020-07-29 11:36:47 +08:00
Seth Jennings
a4f043a980 kubelet: eviction: remove noise from TestGetReclaimableThreshold test output 2020-07-27 13:53:55 -05:00
knight42
a3b772b442
test: deflake TestRecycleSlices test 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-07-27 21:41:02 +08:00
Jordan Liggitt
f33dc28094 generated: hack/update-hack-tools.sh && hack/update-vendor.sh 2020-07-25 16:45:02 -04:00
Kubernetes Prow Robot
19caf38665
Merge pull request #93425 from liggitt/string-cast 
Fix int->string casts
 2020-07-24 23:12:16 -07:00
Kubernetes Prow Robot
54e2070722
Merge pull request #93410 from nikhita/apimachinery-triage-labels 
Don't apply triage/needs-information on apimachinery and instrumentation PRs
 2020-07-24 19:08:16 -07:00
Rob Scott
98b63ad3a6
Fixing memory leak in EndpointSliceMirroring EndpointSlice tracker 
This mirrors an earlier fix to the EndpointSlice controller. I'll make a
follow up PR to move this component to a shared package, but that seems
beyond the scope of a bug fix PR.
 2020-07-24 17:21:36 -07:00
Jordan Liggitt
124a5ddf72 Fix int->string casts 2020-07-24 16:23:12 -04:00
Kubernetes Prow Robot
5a50c5c95f
Merge pull request #93355 from Nordix/sched-fix-mael 
Fix scheduler issue with nodetree additions
 2020-07-24 12:10:22 -07:00
Alexey Perevalov
a047e8aa1b move to cadvisor.MachineInfo 
This patch removes GetNUMANodeInfo, cadvisor.MachineInfo will be used
instead of it. GetNUMANodeInfo was introduced due to difference of meaning of
MachineInfo.Topology. On the arm it was NUMA nodes, but on the x86 it
represents sockets (since reading from /proc/cpuinfo). Now it unified
and MachineInfo.Topology represents NUMA node.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
 2020-07-24 09:29:41 -04:00
wawa0210
ccde63b9c1
fix windows container root validate 2020-07-24 19:59:58 +08:00
Marian Lobur
5d1b3e26af Fix an issue when rotated logs of dead containers are not removed. 2020-07-24 10:06:24 +02:00
Nikhita Raghunath
c00dae0607 Revert "Merge pull request #93156 from logicalhan/triage-api-machinery" 
This reverts commit 32438cf269, reversing
changes made to bb6a6aa391.
 2020-07-24 13:01:02 +05:30
Maël Kimmerlin
c2ec8bedbc
Fix scheduler issue with nodetree additions 
When nodes are added in multiple zones at once, the nodeTree next
function does not return a correct list of nodes but repeats some
This commit resets the index before starting to call next() to
prevent this issue

Special thanks to igraecao for the help in finding the bug

Co-authored-by: igraecao <matvej.yolli@outlook.com>
 2020-07-24 09:42:53 +03:00
Jun Gong
454f9acc24 Remove unuseful error message about updating pod conditions not owned by kubelet 2020-07-24 09:56:03 +08:00
zhangsheng02
dadc2ad385 add more testing cases 
Signed-off-by: zhangsheng02 <sheng.zhang@daocloud.io>
 2020-07-24 09:32:34 +08:00
Kubernetes Prow Robot
e884b40e73
Merge pull request #93371 from ahg-g/ahg-volume 
Optimize VolumeRestriction plugin
 2020-07-23 16:10:23 -07:00
Christopher M. Luciano
65ff4e8227
ipvs: log error if scheduler does not exist and fallback to rr 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
 2020-07-23 13:58:02 -04:00
yiduyangyi
e6c4633232 fix golint failures in pkg/kubeapiserver/options, fix some incorrect replace of receiver name 2020-07-23 19:02:07 +08:00
yiduyangyi
0520d75838 fix golint failures in pkg/kubeapiserver/options, rename receiver name of BuiltInAuthorizationOptions to o 2020-07-23 18:52:15 +08:00
yiduyangyi
e441c07fe2 fix golint failures in pkg/kubeapiserver/options, use API Server in commemts instead of APIServer 2020-07-23 18:41:37 +08:00
Abdullah Gharaibeh
5e81a2de98 Optimize VolumeRestrictions scheduler plugin 2020-07-22 23:00:01 -04:00
Keerthan Reddy,Mala
acac15c20e fix bazel build file 2020-07-22 14:12:27 -07:00
Abdullah Gharaibeh
44d9497133 Increase the size of the buckets for PodSchedulingDuration scheduler metric. 2020-07-22 16:42:01 -04:00
Keerthan Reddy,Mala
872859b422 correct the sandboxId attribute in unit tests 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
851d778531 address review comments 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
90cc954eed add sandbox deletor to delete sandboxes on pod delete event 2020-07-22 11:54:58 -07:00
Keerthan Reddy,Mala
d4325f42fb Check for sandboxes before deleting the pod from apiserver 2020-07-22 11:54:56 -07:00
Kubernetes Prow Robot
ae7dce72ce
Merge pull request #91930 from RenaudWasTaken/DisableAcceleratorUsageMetrics 
Add DisableAcceleratorUsageMetrics Feature Gate
 2020-07-22 09:16:06 -07:00
knight42
7a2e5af11d
fix(kubectl): warn users that flags cannot be placed before plugin 
Signed-off-by: knight42 <anonymousknight96@gmail.com>
 2020-07-22 20:34:31 +08:00
Alexey Perevalov
e33ba9e974 Avoid using socket for hints 
Sockets don't affect performance as NUMA node does, since NUMA
node has dedicated memory controller, but socket it's physical
extension point.
Socket it's only cpu specific thing and it's strange to merge bitmask of
deviceplugin's and cpu manager, when cpu manager takes into account
socket.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
 2020-07-22 05:14:34 -04:00
Kubernetes Prow Robot
ff33efc164
Merge pull request #93307 from liggitt/force-delete 
Ensure runtimeCache contains all observed started containers on pod delete
 2020-07-21 22:32:19 -07:00
RyderXia
b20ceaa85d regen 2020-07-22 10:53:11 +08:00
Kubernetes Prow Robot
32438cf269
Merge pull request #93156 from logicalhan/triage-api-machinery 
automatically assign triage labels to api-machinery tagged PRs
 2020-07-21 19:52:34 -07:00
RyderXia
d76c2cc94c update build 2020-07-22 09:36:55 +08:00
Kubernetes Prow Robot
a9f0fcc68c
Merge pull request #93148 from claudiubelu/windows/fixes-subpath-symlink 
Windows: Fixes subpath symlink evaluation
 2020-07-21 15:00:20 -07:00
Jordan Liggitt
d195fc2ec8 Ensure runtimeCache contains all observed started containers on pod delete 2020-07-21 15:54:29 -04:00
Kubernetes Prow Robot
b6174e605f
Merge pull request #93189 from klueska/upstream-fix-bug-topology-manager 
Fix a bug whereby reusable CPUs and devices were not being honored
 2020-07-21 04:35:17 -07:00
RyderXia
136df8ce53 update 2020-07-21 17:00:49 +08:00
RyderXia
2214117cd1 clean up unused var containerCache 2020-07-21 16:57:36 +08:00
Kubernetes Prow Robot
1fdd8fb213
Merge pull request #93263 from liggitt/windows 
Fix windows kubelet startup
 2020-07-20 19:51:57 -07:00
Kubernetes Prow Robot
275eabdf72
Merge pull request #93259 from jpbetz/revert-88936 
Revert nested trace PR#88936
 2020-07-20 19:51:47 -07:00
Kubernetes Prow Robot
b467072a55
Merge pull request #93256 from ahg-g/ahg-metric 
Rename pod_preemption_metrics to preemption_metrics.
 2020-07-20 19:51:37 -07:00
Kubernetes Prow Robot
c09ecf13a5
Merge pull request #93248 from giuseppe/cgroup-set-max-shares 
kubelet: clamp cpu.shares to max allowed
 2020-07-20 19:51:14 -07:00
José Guilherme Vanz
5ebb1c3be2
cleanup: print warning message after timeout 
If a pod has a configmap/secret volume an annoying message shows up
in the log approximately every 70 seconds. This happens because the
desiredStateOfWorldPopulator sync loop always call the
MarkRemountRequired. The function finds the volume plugin and check
if the plugin requires mount. Configmap and secret plugins always
returns true for that. Thus, the reconciler code of the volume manager
remounts the volume every time. This commit change the SetVolumeOwnership
to print the warning only if the function does not finish within 30
seconds.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
 2020-07-20 22:46:11 -03:00
José Guilherme Vanz
08ccbe6f0e
Revert "cleanup: decrease log level from warn to v3" 
This reverts commit ebece49936e635f151fdd8a64fa2b77fd183e817.
 2020-07-20 22:46:11 -03:00
José Guilherme Vanz
9b9dcf3d84
cleanup: decrease log level from warn to v3 
If a pod has a configmap/secret volume an annoying message shows up
in the log approximately every 70 seconds. This happens because the
desiredStateOfWorldPopulator sync loop always call the
MarkRemountRequired. The function finds the volume plugin and check
if the plugin requires mount. Configmap and secret plugins always
returns true for that. Thus, the reconciler code of the volume manager
remounts the volume every time. This commit decrease the log level of
that message in the mount function from warning to V4.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
 2020-07-20 22:46:11 -03:00
Phil Bracikowski
d880a1b78c AWS: increase io1 volume IOPs limit 
Max IOPS for SSD (io1) volumes was increased from 20,000 to 32,000:
https://aws.amazon.com/about-aws/whats-new/2017/12/amazon-ebs-provisioned-iops-ssd--io1--volumes-now-support-32-000-iops-and-500-mbs-per-volume/

and later to 64,000:
https://aws.amazon.com/about-aws/whats-new/2018/11/amazon-elastic-block-store-announces-double-the-performance-of-provisioned-iops-volumes/
 2020-07-20 17:41:13 -07:00
Kubernetes Prow Robot
5a529aa3a0
Merge pull request #91399 from danwinship/endpoint-ipfamily 
multiple IPv6/dual-stack endpoint fixes
 2020-07-20 13:31:14 -07:00
wawa0210
aea228f5dd fix no-new-privileges on windows 2020-07-20 16:14:52 -04:00
Jordan Liggitt
886727a4c0 Revert "Add deviceManager in windows container manager" 
This reverts commit 056d73b1a1.
 2020-07-20 16:13:53 -04:00
Joe Betz
02cf58102a Revert nested trace PR#88936 2020-07-20 09:55:05 -07:00
Abdullah Gharaibeh
6f9794d5e9 Rename pod_preemption_metrics to preemption_metrics. Since this metric's type was changed from Gauge to Histogram, renaming it should make it easier to providers to migrate 2020-07-20 11:44:10 -04:00
Giuseppe Scrivano
ef935bd991
kubelet: clamp cpu shares to max allowed 
clamp the max cpu.shares to the maximum value allowed by the kernel.

It is not an issue when using cgroupfs, as the kernel will
anyway make sure the value is not out of range and automatically clamp
it, systemd has an additional check that prevents the cgroup creation.

Closes: https://github.com/kubernetes/kubernetes/issues/92855

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2020-07-20 17:18:03 +02:00
yuzhiquan
aca107eee5 Fixed potential nil dereference in hostpath unit test 2020-07-20 20:58:36 +08:00
yuzhiquan
a60cbd5535 Fixed error string should not be capitalized 2020-07-20 20:58:06 +08:00
Kevin Klues
00df26a985 Fix a bug whereby reusable CPUs and devices were not being honored 
Previously, it was possible for reusable CPUs and reusable devices (i.e.
those previously consumed by init containers) to not be reused by
subsequent init containers or app containers if the TopologyManager was
enabled. This would happen because hint generation for the
TopologyManager was not considering the reusable devices when it made
its hint calculation.

As such, it would sometimes:
1) Generate a hint for a differnent NUMA node, causing the CPUs and
devices to be allocated from that node instead of the one where the
reusable devices live; or
2) End up thinking there were not enough CPUs or devices to allocate and
throw a TopologyAffinity admission error

This patch fixes this by ensuring that reusable CPUs and devices are
considered as part of TopologyHint generation. This frunctionality is
difficult to unit test since it spans multiple components, but an e2e
test will be added in a subsequent patch to test this functionality.
 2020-07-20 11:41:13 +00:00
Kevin Klues
74fe9364c3 Simplify logic in devicemanager TopologyHint generation 2020-07-20 11:41:13 +00:00
Kevin Klues
9f5f401d60 Add AnySet() to topologymanager bitmask API 2020-07-20 11:41:13 +00:00
zhangsheng02
14d2440b87 add GetAddressAndDialer unit test 
Signed-off-by: zhangsheng02 <sheng.zhang@daocloud.io>
 2020-07-20 18:16:58 +08:00
Gaurav Singh
0fb9b12153 [kubelet/dockershim] : Use local copy for range iterator 
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
 2020-07-18 12:52:23 -04:00
Kubernetes Prow Robot
05f6812c2d
Merge pull request #90822 from deads2k/csr-separate-signer-flags-02 
allow setting different certificates for kube-controller-managed CSR signers
 2020-07-18 03:10:50 -07:00
Kubernetes Prow Robot
242f3d9dce
Merge pull request #80917 from aarnaud/windows-devicemanager 
Port deviceManager to windows container manager to enable GPU access
 2020-07-17 21:04:50 -07:00
Dong Gang
b30f6f30ed fix(staticcheck): fix static error of package /pkg/volume/gcepd 
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
 2020-07-18 10:54:10 +08:00
Ellis Tarn
40d42f26c7 Filters on kubemark nodegroups when selecting node template to enable 
hollow node clusters that contain real nodes.
 2020-07-17 16:02:17 -07:00
Dan Winship
e46572ef4b Improve EndpointController's handling of headless services under dual-stack 
EndpointController was accidentally requiring all headless services to
be IPv4-only in clusters with IPv6DualStack enabled.

This still leaves "legacy" (ie, IPFamily-less) headless services as
always IPv4-only because the controller doesn't currently have easy
access to the information that would allow it to fix that.
(EndpointSliceController had the same problem already, and still
does.) This can be fixed, if needed, by manually setting IPFamily,
and the proposed API for 1.20 will handle this situation better.
 2020-07-17 15:26:21 -04:00
Dan Winship
9023d19c57 Improve EndpointController dual-stack testing 
Rewrite some of the test helpers to better support single-stack IPv4
vs single-stack IPv6 vs dual-stack IPv4 primary vs dual-stack IPv6
primary, and update TestPodToEndpointAddressForService to test some
more cases.
 2020-07-17 15:26:21 -04:00
Dan Winship
9fb6e2ef55 Fix Endpoint/EndpointSlice pod change detection 
The endpoint controllers responded to Pod changes by trying to figure
out if the generated endpoint resource would change, rather than just
checking if the Pod had changed, but since the set of Pod fields that
need to be checked depend on the Service and Node as well, the code
ended up only checking for a subset of the changes it should have.

In particular, EndpointSliceController ended up only looking at IPv4
Pod IPs when processing Pod update events, so when a Pod went from
having no IP to having only an IPv6 IP, EndpointSliceController would
think it hadn't changed.
 2020-07-17 15:22:59 -04:00
Kubernetes Prow Robot
58893f3443
Merge pull request #93052 from andyzhangx/fix-initial-delay 
fix: initial delay in mounting azure disk & file
 2020-07-16 17:27:00 -07:00
Han Kang
9129dbc98b automatically assign triage labels to api-machinery tagged PRs 
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
 2020-07-16 13:13:59 -07:00
Christopher M. Luciano
e2a0eddaf0
ipvs: ensure selected scheduler kernel modules are loaded 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
 2020-07-16 13:21:54 -04:00
Kubernetes Prow Robot
96c057ab48
Merge pull request #92001 from huffmanca/include-csidriver-fsgroup 
Include CSIDriver capability to indicate fsGroup support
 2020-07-16 09:11:42 -07:00
Anish Shah
0ffe89ed0b kubelet: add operations count and error count metrics to network plugin manager 2020-07-15 12:41:35 -07:00
yiduyangyi
e2838df7c7 fix golint failures in pkg/kubeapiserver/options 2020-07-15 16:03:08 +08:00
Kubernetes Prow Robot
d9c3d15018
Merge pull request #92986 from gnufied/fix-in-use-errors 
Handle volume-in-use error during volume expansion
 2020-07-15 00:30:37 -07:00
Wei Huang
bc04d73330
remove duplicate path import 2020-07-14 16:34:09 -07:00
Kubernetes Prow Robot
428b500c5a
Merge pull request #90949 from pjbgf/seccomp-least-priv-kuberuntime 
Add seccomp least privilege for kuberuntime
 2020-07-14 04:35:21 -07:00
Kubernetes Prow Robot
3f8f9998b0
Merge pull request #90948 from pjbgf/seccomp-least-priv-dockershim 
Add seccomp least privilege for docker sandbox
 2020-07-14 02:23:22 -07:00
andyzhangx
82b8b07a2d fix: initial delay in mounting azure disk/file 2020-07-14 07:14:43 +00:00
Kubernetes Prow Robot
209dbdfcc3
Merge pull request #93012 from giuseppe/no-hugetlb-cgroupv2 
kubelet, cgroupv2: make hugetlb optional
 2020-07-13 20:21:20 -07:00
Claudiu Belu
15ccf86e7c Windows: Fixes subpath symlink evaluation 
Paths do not always have Targets, which means that the previously added powershell
command will return an empty string, causing pods with subpath mounts to fail.
 2020-07-13 16:12:01 -07:00
Renaud Gaubert
34dc785c0b Add the DisableAcceleratorUsageMetrics feature gate 
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
 2020-07-13 20:52:06 +00:00
Kubernetes Prow Robot
240a72b5c0
Merge pull request #88936 from jpbetz/http-trace 
Add nested tracing and endpoint filter tracing to apiserver
 2020-07-13 11:27:21 -07:00
Hemant Kumar
2ccd645d71 Remove resize map code 
This code is not used anywhere
 2020-07-13 08:24:10 -04:00
Kubernetes Prow Robot
1bcf42b442
Merge pull request #92328 from jingxu97/June/evalpath 
Replace evalSymlink() with powershell command for subPath_windows.go
 2020-07-13 01:40:35 -07:00
Giuseppe Scrivano
79be8be10e
kubelet, cgroupv2: make hugetlb optional 
make the hugetlb controller optional when cgroup v2 is used.

Closes: https://github.com/kubernetes/kubernetes/issues/92933

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2020-07-13 09:40:55 +02:00
Kubernetes Prow Robot
7625976ad3
Merge pull request #92890 from Huang-Wei/postfilter-impl-6 
Refactor and expose common preemption functions
 2020-07-12 11:36:33 -07:00
Kubernetes Prow Robot
6b5dc37708
Merge pull request #92919 from dashpole/update_cadvisor 
Update cAdvisor to v0.37.0
 2020-07-12 06:59:55 -07:00
Kubernetes Prow Robot
8398bc3b53
Merge pull request #92916 from joelsmith/count-etc-hosts 
Include pod /etc/hosts in ephemeral storage calculation for eviction
 2020-07-12 06:59:36 -07:00
Kubernetes Prow Robot
539b0a5a0f
Merge pull request #92905 from andyzhangx/deprecate-blobdis 
doc: deprecate azure blob disk feature
 2020-07-12 06:59:07 -07:00
Wei Huang
4e8ccf0187
Refactor and expose common preemption functions 2020-07-11 23:17:21 -07:00
Kubernetes Prow Robot
d06ff65943
Merge pull request #92876 from Huang-Wei/pdbLister 
Add pdbLister as a member field of struct DefaultPreemption
 2020-07-11 20:57:42 -07:00
Kubernetes Prow Robot
c23a4b08d7
Merge pull request #92874 from chelseychen/event-api 
Fix a few places where source field is empty when creating events via events/v1
 2020-07-11 20:57:31 -07:00
Kubernetes Prow Robot
11348a38d7
Merge pull request #92871 from liggitt/kube-features 
Move proxy features to kube_features
 2020-07-11 20:57:22 -07:00
Kubernetes Prow Robot
63926cf8e7
Merge pull request #92862 from giuseppe/cgroup-fix-leaks 
vendor: update github.com/opencontainers/runc
 2020-07-11 20:57:11 -07:00
Kubernetes Prow Robot
fa31f9fd26
Merge pull request #92860 from aojea/iptMonitor 
iptables: don't do reverse DNS lookups
 2020-07-11 20:57:02 -07:00