Commit Graph

7435 Commits

Author SHA1 Message Date
Jordan Liggitt
fb0cea22dc stop clearing GOPATH in vendor scripts
if unset, go defaults to $HOME/go, and fails if $GOROOT is also set to the same directory

we were only doing this to be doubly sure that only modules were being used.
just depend on export GO111MODULE=on for that.
2019-04-12 12:56:05 -04:00
Kubernetes Prow Robot
5b434eefc3
Merge pull request #74180 from mrbobbytables/fix-third-party-shellcheck
Fix shellcheck lint errors in third_party/* scripts
2019-04-12 06:14:46 -07:00
SataQiu
9863f26706 fix shellcheck failures of hack/update-codegen.sh 2019-04-12 19:15:56 +08:00
Kubernetes Prow Robot
b2db8c77ad
Merge pull request #76426 from SataQiu/join-hack-20190411
add @SataQiu as a reviewer of hack
2019-04-12 03:23:31 -07:00
Kubernetes Prow Robot
28d5023137
Merge pull request #76244 from cblecker/dep-script-fixups
Couple of dependency script cleanups
2019-04-12 03:23:17 -07:00
SataQiu
4231fa0980 fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh 2019-04-12 16:00:23 +08:00
aaa
7a39c99297 Fix shellcheck failures on test-e2e-node.sh and test-integration.sh 2019-04-11 13:47:34 -04:00
Bob Killen
9e719d8d9c
Fix shellcheck lint errors in third_party/forked/shell2junit/sh2ju.sh 2019-04-11 10:25:41 -07:00
SataQiu
10b52bae28
Merge branch 'master' into fix-hack-2019040903 2019-04-11 23:29:10 +08:00
SataQiu
318af5f45a add @SataQiu as a reviewer of hack 2019-04-11 23:07:48 +08:00
Kubernetes Prow Robot
ef830e2bcf
Merge pull request #76311 from SataQiu/fix-hack-20190409
Fix shellcheck failures of hack/update-vendor-licenses.sh
2019-04-10 22:42:21 -07:00
yue9944882
cabe69faeb clean up unused vars in codegen scripts 2019-04-10 13:14:36 +08:00
Kubernetes Prow Robot
e2091b769a
Merge pull request #71136 from yue9944882/chore/prune-all-kk-internal-clientset
Prune literally all kube-apiserver internal client
2019-04-09 13:58:45 -07:00
aaa
037729b357 update benchmark-dockerized.sh and verify-dockerized.sh
update pull request
2019-04-09 15:07:26 -04:00
Jordan Liggitt
aaeecd86dc make pin-dependency.sh only work at the module level 2019-04-09 11:45:13 -04:00
yue9944882
ced03fb698 remove internal client from udpate-codegen script 2019-04-09 21:43:54 +08:00
SataQiu
67509020ca fix shellcheck failures of hack/update-vendor-licenses.sh 2019-04-09 13:47:30 +08:00
SataQiu
0f09703c48 fix shellcheck failures of hack/update-gofmt.sh hack/update-translations.sh 2019-04-09 12:30:58 +08:00
Kubernetes Prow Robot
fbc28fd15f
Merge pull request #76280 from xichengliudui/fixshellcheck0409
Fix shellcheck failures in update-workspace-mirror.sh
2019-04-08 20:29:18 -07:00
Youbing Li
8a56ebed82 Check the content of WHAT for Makefile's verify target 2019-04-08 22:53:23 -04:00
aaa
961f1621aa Fix shellcheck failures in update-workspace-mirror.sh 2019-04-08 14:40:26 -04:00
aaa
e544da8aae Fix shellcheck failures in test-dockerized.sh and upload-to-gcs.sh
update pull request

update pull request
2019-04-08 14:14:47 -04:00
Kubernetes Prow Robot
8a2f8e69ed
Merge pull request #76197 from liggitt/generated-vendor
Mark staging go module files as generated, add script to lint dependencies
2019-04-08 10:16:51 -07:00
Jordan Liggitt
f250dcf70a Prune unneeded replace directives from staging go.mod files 2019-04-08 09:42:22 -04:00
Jordan Liggitt
fdd241a858 Mark staging go module files as generated, add script to lint dependencies 2019-04-08 09:42:22 -04:00
Mehdy Bohlool
8702550beb Support service port other than 443 for kube-aggregator 2019-04-08 00:19:57 -07:00
Kubernetes Prow Robot
f873d2a056
Merge pull request #75862 from xichengliudui/fixshellcheckfailures
Fix shellcheck failures in bootstrap.sh and create_block.sh
2019-04-07 21:52:24 -07:00
Christoph Blecker
2363136f2c
Remove has_changes logic from vendor scripts 2019-04-07 12:11:18 -07:00
Christoph Blecker
668a288595
Remove unneeded scripts 2019-04-07 12:08:41 -07:00
Kubernetes Prow Robot
06655abd87
Merge pull request #76168 from caesarxuchao/local-up-followup
Follow up of https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758
2019-04-05 07:43:44 -07:00
Kubernetes Prow Robot
5756bfbf8d
Merge pull request #76180 from nikhita/verify-publishing-bot-deps
Show all missing deps when publishing-bot rules has no listed dependencies
2019-04-05 06:27:19 -07:00
Kubernetes Prow Robot
0c32c22b2e
Merge pull request #75546 from fabriziopandini/e2e-kubeadm-first-class
Implement make test-e2e-kubeadm
2019-04-05 04:59:19 -07:00
Nikhita Raghunath
d474631e38 Show all missing deps when publishing-bot has no listed dependencies
Before this, it only showed one dependency in the error message.

Also, replace godeps.json with go.mod in the error message.
2019-04-05 13:08:12 +05:30
Kubernetes Prow Robot
54ba23eec6
Merge pull request #76169 from BenTheElder/hack-the-planet
add bentheelder to hack/ approvers
2019-04-04 23:53:54 -07:00
Kubernetes Prow Robot
470bda42c3
Merge pull request #76153 from liggitt/update-vendor-cleanup
Update vendor cleanup
2019-04-04 23:53:42 -07:00
Kubernetes Prow Robot
87247f5357
Merge pull request #75915 from xichengliudui/fixshellcheckfailures-05
fix shellcheck failures in ./hack/jenkins/...
2019-04-04 22:31:19 -07:00
Benjamin Elder
d3c405c7c3 add bentheelder to hack/ approvers 2019-04-04 15:23:52 -07:00
Chao Xu
ce0cd866c0 followup https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758 2019-04-04 14:38:26 -07:00
Jordan Liggitt
86f29e210b Clean up generated file warnings, add recursive dependency detection 2019-04-04 12:06:45 -04:00
Jordan Liggitt
892ad8b449 Make pin-dependency.sh work with things other than docker 2019-04-04 09:20:55 -04:00
Jordan Liggitt
2ea3cbdcbc Update hack scripts to use go mod 2019-04-03 10:19:39 -04:00
Jordan Liggitt
7f246d461b Remove third_party/forked/godep 2019-04-03 10:19:39 -04:00
SataQiu
b732a53c6b fix shellcheck failures of test/images/pets/redis-installer/on-start.sh 2019-04-03 21:55:05 +08:00
Jordan Liggitt
8ead4b059f Add kubernetes/kubernetes tools.go imports 2019-04-03 09:15:39 -04:00
Kubernetes Prow Robot
658c290ed5
Merge pull request #76063 from Huang-Wei/option-clean-stdout
give users option to suppress detailed output in integration test
2019-04-03 03:24:19 -07:00
Kubernetes Prow Robot
42877480ad
Merge pull request #75747 from msau42/remove-alpha-crd
Remove alpha csi CRD
2019-04-02 22:47:41 -07:00
Kubernetes Prow Robot
28ac3063da
Merge pull request #76050 from caesarxuchao/fix-local-up-cluster
Fix kubelet start in local-up-cluster.sh
2019-04-02 20:11:42 -07:00
Wei Huang
66a3094419
give users option to suppress detailed output in integration test 2019-04-02 17:27:32 -07:00
Kubernetes Prow Robot
b274fb3570
Merge pull request #75984 from umohnani8/e2e
Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh
2019-04-02 15:45:20 -07:00
Chao Xu
1b953aaa59 Fix kubelet start in local-up-cluster.sh 2019-04-02 12:59:32 -07:00
Michelle Au
d2aa8178f2 Remove alpha CRD install 2019-04-02 10:59:11 -07:00
Kubernetes Prow Robot
aa52140928
Merge pull request #75346 from seans3/version-fix
kubectl: removes pkg/version dependency
2019-04-02 10:19:18 -07:00
Urvashi Mohnani
8b96021c67 Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh
The changes to local-cluster-up.sh from #75662 is causing the
CRI-O CI to break since it picks up the --runtime-request-timeout
flag as part of the container-runtime-endpoint flag.
Adding a new env so that we can set the runtime-request-timeout
value for our CI.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2019-04-02 11:25:55 -04:00
Kubernetes Prow Robot
d7d852a3ed
Merge pull request #75994 from mrunalp/fix_unbound_args_array
Fix older bash failing on unbound array variables
2019-04-02 08:22:48 -07:00
Mrunal Patel
8c9b169f17 Fix older bash failing on unbound array variables
Older bash versions fail when trying to expand array variables
when the array is empty.

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
2019-04-01 21:04:48 -07:00
Benjamin Elder
2b7cc095cc enable external sources in verify-shellcheck 2019-04-01 11:03:37 -07:00
Kubernetes Prow Robot
997d5182d0
Merge pull request #75662 from s-ito-ts/shellcheck_local-up-cluster.sh
fix shellcheck failures in hack/local-up-cluster.sh
2019-03-31 18:24:32 -07:00
Kubernetes Prow Robot
72418519ff
Merge pull request #75865 from xichengliudui/fixshellcheckfailure-03
Fix shellcheck failures in godep-save.sh and godep-restore.sh
2019-03-30 15:57:08 -07:00
Kubernetes Prow Robot
66dad3bb09
Merge pull request #75868 from xichengliudui/patch-4
Add @xichengliudui to hack/OWNERS reviewers
2019-03-29 23:53:21 -07:00
Kubernetes Prow Robot
c7a8596a39
Merge pull request #75867 from SataQiu/fix-kubeadm-golint-20190329
Fix golint failures in cmd/kubeadm/app/util/system
2019-03-29 17:33:57 -07:00
Kubernetes Prow Robot
259f706c73
Merge pull request #75834 from jlucktay/golint_pkg/auth/authorizer/abac
Golint pkg/auth/authorizer/abac
2019-03-29 11:48:50 -07:00
Kubernetes Prow Robot
733f2478d3
Merge pull request #75584 from SataQiu/fix-golint-20190322
fix some golint failures in pkg/apis
2019-03-29 10:28:40 -07:00
James Lucktaylor
dbb696508a Enact golint recommendations per issue 68026.
Remove the 'abac' package from the golint exclusion list.
Add/edit comments per golint feedback.
Set PolicyList to be exported, as not exporting was breaking one of
golint's rules around exported funcs returning an unexported type.
Fix a broken test
2019-03-29 12:50:31 +00:00
lIuDuI
6f970d3d70
Update OWNERS 2019-03-29 12:15:39 +08:00
SataQiu
a41c85ea07 fix golint failures in cmd/kubeadm/app/util/system 2019-03-29 12:03:25 +08:00
Sean Sullivan
d4d6e19f1e kubectl: removes pkg/version dependency 2019-03-28 16:08:34 -07:00
fabriziopandini
2cb2a979d4 e2e-kubeadm-first-class 2019-03-28 16:29:56 +01:00
Kubernetes Prow Robot
f6c51d6e99
Merge pull request #75751 from BenTheElder/bash-fun
fix kube::golang::is_instrumented_package
2019-03-26 23:19:01 -07:00
Kubernetes Prow Robot
29353452c4
Merge pull request #75668 from bart0sh/PR0068-hack-lib-golang.sh-fix-mac-build
fix 'make generated_files' build on MacOS
2019-03-26 20:45:01 -07:00
Kubernetes Prow Robot
d24fe8a801
Merge pull request #75735 from andrewsykim/update-install-etcd-link
fix link to etcd install docs for integration tests
2019-03-26 18:11:29 -07:00
Kubernetes Prow Robot
4b3eb60081
Merge pull request #75531 from dims/add-new-staging-repository-for-cri-api
New staging repository for cri-api
2019-03-26 18:10:49 -07:00
Benjamin Elder
0833a9cc38 fix kube::golang::is_instrumented_package 2019-03-26 17:17:16 -07:00
Davanum Srinivas
33081c1f07
New staging repository for cri-api
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb
2019-03-26 18:21:04 -04:00
Kubernetes Prow Robot
2086f81546
Merge pull request #74678 from pmcalpine/lint-bs_cj
Fix some golint failures for pkg/controller
2019-03-26 15:10:16 -07:00
Andrew Sy Kim
e26157df07 fix link to etcd install docs 2019-03-26 13:40:18 -04:00
SataQiu
b1cb58fdf2 fix golint failures in test/e2e_node/builder 2019-03-26 14:12:45 +08:00
Ed Bartosh
3d5d38607d fix 'make generated_files' build on MacOS
Recent change to hack/lib/golang.sh broke the build on MacOS this way:

$ make clean && make generated_files
+++ [0325 13:38:22] Verifying Prerequisites....
+++ [0325 13:38:23] Removing _output directory
k8s.io/kubernetes/vendor/github.com/spf13/pflag
k8s.io/kubernetes/hack/make-rules/helpers/go2make
+++ [0325 13:38:40] Building go targets for darwin/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
can't load package: package k8s.io/kubernetes: no Go files in k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes
!!! [0325 13:38:40] Call tree:
!!! [0325 13:38:40]  1: k8s.io/kubernetes/hack/lib/golang.sh:629 kube::golang::build_some_binaries(...)
!!! [0325 13:38:40]  2: k8s.io/kubernetes/hack/lib/golang.sh:764 kube::golang::build_binaries_for_platform(...)
!!! [0325 13:38:40]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [_output/bin/deepcopy-gen] Error 1
make: *** [generated_files] Error 2

It was caused by 'binaries' array not being declared with 'local -a'.
It looks like MacOS' old bash version makes an array to contain first
empty element if declared this way.

The fix has been tested on MacOS High Sierra and Linux openSUSE 42.3 (x86_64)

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
2019-03-25 17:08:13 +01:00
s-ito-ts
8cc3718e69 fix eliminate shellcheck failures in hack/local-up-cluster.sh 2019-03-25 07:17:06 +00:00
SataQiu
f82fb4059d fix some failures in pkg/apis 2019-03-23 12:20:49 +08:00
Kubernetes Prow Robot
9c53f24012
Merge pull request #75179 from rosti/kill-v1alpha3
kubeadm: remove v1alpha3
2019-03-22 17:02:21 -07:00
Kubernetes Prow Robot
ffd8f3dacb
Merge pull request #73255 from ds-ms/golint
Fix linting issues in pkg/kubectl/cmd/version
2019-03-22 17:02:08 -07:00
Kubernetes Prow Robot
a3bc56fffb
Merge pull request #74746 from oomichi/golint-e2e-framework-gce
Fix golint failures under test/e2e/[..]/gce
2019-03-22 15:46:08 -07:00
Kenichi Omichi
3d64667507 Add check-conformance-test-requirements.go
We have defined requirements of conformance test as [1], and this
adds coding check for one requirement "it works for all providers".

[1]: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements
2019-03-22 21:56:07 +00:00
Kubernetes Prow Robot
fcb102b2a4
Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
Kenichi Omichi
da7c9f70c3 Fix golint failures under test/e2e/[..]/gce
This fixes golint failures under test/e2e/framework/providers/gce/.

Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
  are used at test/e2e/network/firewall.go only. So move them.
2019-03-22 15:59:17 +00:00
Kubernetes Prow Robot
22621ca415
Merge pull request #74739 from moshe010/nokubeproxy
Add nokubeproxy option in START_MODE
2019-03-21 22:50:44 -07:00
Kubernetes Prow Robot
51b5d28c15
Merge pull request #74333 from SataQiu/fix-shell-20190221
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot
4c16fb78b3
Merge pull request #74242 from xichengliudui/fixshellcheck19021903
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
toyoda
a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
Kubernetes Prow Robot
c48ed1c5ac
Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark
Fix golint failures for e2e/[..]/kubemark
2019-03-21 19:26:32 -07:00
Kubernetes Prow Robot
4499275cb9
Merge pull request #72800 from stewart-yu/stewart-component-base
Move config local to every controller in KCM
2019-03-21 19:26:19 -07:00
aaa
64f8f30c07 fix shellcheck failures in ./hack/jenkins/... 2019-03-21 05:30:11 -04:00
aaa
f82870291f Fix shellcheck failures in godep-save.sh and godep-restore.sh
update pull request

update pull request
2019-03-21 05:02:47 -04:00
SataQiu
112af136df update verify-staging-meta-files.sh 2019-03-21 12:44:39 +08:00
Han Kang
a5ddc3943a bump required minimum go version to 1.12.1 (strings package compatibility) 2019-03-20 16:07:07 -07:00
aaa
46799b6dd4 Fix shellcheck failures in bootstrap.sh and create_block.sh 2019-03-20 17:37:50 -04:00
Kubernetes Prow Robot
481de197c0
Merge pull request #75156 from smarterclayton/diff_invalid
Handle nil interface inputs to diff.ObjectReflectDiff
2019-03-20 00:55:01 -07:00
Kubernetes Prow Robot
6a2936dcbf
Merge pull request #74642 from SataQiu/fix-golint-20190227
Fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-19 20:14:54 -07:00
Kubernetes Prow Robot
d261549a1c
Merge pull request #71813 from booxter/make-update-errors-visibility
Expose errors from godep_restored to caller
2019-03-19 19:00:25 -07:00
Peter McAlpine
ac88e13821 Fix lint warnings in pkg/controller/cronjob. 2019-03-19 14:36:26 -04:00