Mike Dame
41fcb95f2f
Wire contexts to Apps controllers
2021-10-13 16:32:13 -04:00
wojtekt
e233feb99b
Migrate to k8s.io/utils/clock in pkg/controller
2021-09-10 11:42:32 +02:00
Raymonder jin
03f9f75e88
fix typo for daemon_controller_test.go
2021-06-28 04:54:09 -07:00
Aldo Culquicondor
d8aad7944c
Remove unused util CreatePods
...
And rename CreatePodsWithControllerRef to simply CreatePods
2021-05-20 20:27:21 +00:00
Kubernetes Prow Robot
9558d0c5c2
Merge pull request #101984 from ravisantoshgudimetla/fix-ds-units
...
[daemonSet]: Fix unit tests
2021-05-18 23:32:51 -07:00
Kubernetes Prow Robot
89e0b2d185
Merge pull request #99398 from tnqn/ds-update-retry
...
Fix DaemonSet status update retry
2021-05-18 22:32:50 -07:00
ravisantoshgudimetla
20f8654259
[daemonSet]: Fix unit tests
...
We need to ensure that `DaemonSetUpdateSurge`
featuregate is both enabled and disabled when
running tests with Rolling update strategy.
2021-05-13 10:31:28 -04:00
Kubernetes Prow Robot
22d120b4d6
Merge pull request #101156 from alculquicondor/unused_create_pod
...
Remove unused CreatePodsOnNode function
2021-05-12 10:41:28 -07:00
ravisantoshgudimetla
6f35e1aea0
Run unit test with DSMaxSurgeFlag enabled and disabled
2021-05-10 16:33:09 -04:00
Aldo Culquicondor
6fc5fc0c86
Remove unused CreatePodsOnNode function
...
Remnant of old daemonset controller
2021-04-15 18:53:36 +00:00
Quan Tian
60bb2a3a6f
Fix DaemonSet status update retry
...
It's easy to get update conflict when processing a DaemonSet
continuously. storeDaemonSetStatus had a retry logic that it gets the
resource from apiserver to update the DaemonSet with the latest resource
version. However, it never really retried because of a wrong check and
always made an useless get call. This patch fixes the logic to allow
the function retry once on update error.
2021-03-09 00:39:25 +08:00
Clayton Coleman
8d8884a907
daemonset: Remove unnecessary error returns in strategy code
...
The nodeShouldRunDaemonPod method does not need to return an error
because there are no scenarios under which it fails. Remove the
error return path for its direct calls as well.
2021-03-01 13:23:18 -05:00
Clayton Coleman
18f43e4120
daemonset: Implement MaxSurge on daemonset update
...
If MaxSurge is set, the controller will attempt to double up nodes
up to the allowed limit with a new pod, and then when the most recent
(by hash) pod is ready, trigger deletion on the old pod. If the old
pod goes unready before the new pod is ready, the old pod is immediately
deleted. If an old pod goes unready before a new pod is placed on that
node, a new pod is immediately added for that node even past the MaxSurge
limit.
The backoff clock is used consistently throughout the daemonset controller
as an injectable clock for the purposes of testing.
2021-03-01 13:21:12 -05:00
Clayton Coleman
8e6f58b0bd
daemonset: Prevent accidental omissions of test condition checks
...
It is too easy to omit checking the return value for the
syncAndValidateDaemonSet test in large suites. Switch the method
type to be a test helper and fatal/error directly. Also rename
a method that referenced the old name 'Rollback' instead of
'RollingUpdate'.
2021-03-01 13:20:58 -05:00
xiaofei.sun
fd62f32125
Scheduler: remove pkg/apis/core/field_constants.go
2021-02-24 18:06:29 +08:00
knight42
e89e72b637
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-15 16:02:35 +08:00
Jordan Liggitt
8e6a8669c0
Deflake TestExpectationsOnRecreate
2020-07-31 18:12:01 -04:00
Tomas Nozicka
5cf3f8b79c
Fix DS expectations on recreate
2020-06-17 09:22:17 +02:00
wojtekt
f624314f91
Fix multiple conversion tests
2020-04-10 17:03:35 +02:00
Kubernetes Prow Robot
62dc3ea6d1
Merge pull request #87368 from 928234269/fix_staticcheck01
...
fix staticcheck errors in pkg/controller/daemon.
2020-03-03 12:15:28 -08:00
taesun_lee
79680b5d9b
Fix pkg/controller typos in some error messages, comments etc
...
- applied review results by LuisSanchez
- Co-Authored-By: Luis Sanchez <sanchezl@redhat.com>
genernal -> general
iniital -> initial
initalObjects -> initialObjects
intentionaly -> intentionally
inforer -> informer
anotother -> another
triger -> trigger
mutli -> multi
Verifyies -> Verifies
valume -> volume
unexpect -> unexpected
unfulfiled -> unfulfilled
implenets -> implements
assignement -> assignment
expectataions -> expectations
nexpected -> unexpected
boundSatsified -> boundSatisfied
externel -> external
calcuates -> calculates
workes -> workers
unitialized -> uninitialized
afater -> after
Espected -> Expected
nodeMontiorGracePeriod -> NodeMonitorGracePeriod
estimateGrracefulTermination -> estimateGracefulTermination
secondrary -> secondary
ShouldRunDaemonPodOnUnscheduableNode -> ShouldRunDaemonPodOnUnschedulableNode
rrror -> error
expectatitons -> expectations
foud -> found
epackage -> package
succesfulJobs -> successfulJobs
namesapce -> namespace
ConfigMapResynce -> ConfigMapResync
2020-02-27 00:15:33 +09:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon.
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags
...
feat: remove several feature gates in 1.18
2020-01-09 13:28:50 -08:00
Abdullah Gharaibeh
041e5b5560
addressed comments
2020-01-04 01:14:24 -05:00
Abdullah Gharaibeh
7d604c318c
Break DS controller on scheduler predicates and predicate errors
2020-01-03 13:05:07 -05:00
draveness
dcea6ff065
fix: remove TaintNodesByCondition feature gate in daemon controller
2019-12-12 18:17:14 +08:00
Wei Huang
dd74205bcf
Move out const strings in pkg/scheduler/api/well_known_labels.go
2019-11-05 20:56:21 -08:00
draveness
dc437a7890
feat: remove suspendedDaemonPods from daemon controller
2019-10-25 09:16:48 +08:00
draveness
35d772e354
feat: graduate ScheduleDaemonSetPods to GA
2019-10-23 21:34:47 +08:00
draveness
1163a1d51e
feat: update taint nodes by condition to GA
2019-10-19 09:17:41 +08:00
draveness
495faa22db
feat: cleanup pod critical pod annotations feature
2019-08-09 08:41:23 +08:00
draveness
d83526d253
Revert "feat: cleanup pod critical pod annotations feature"
...
This reverts commit b6d41ee5cc
.
2019-07-18 13:31:12 +08:00
draveness
b6d41ee5cc
feat: cleanup pod critical pod annotations feature
2019-07-11 08:54:19 +08:00
Andrew Kim
c919139245
update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate
2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
d5245b9563
Merge pull request #74856 from draveness/fix/daemonset-controller-slow-batch-creation
...
fix(daemon): create more expections when skipping pods
2019-05-03 23:33:37 -07:00
draveness
5f8dfdc698
fix(daemon): create more expections when skipping pods
2019-05-04 08:15:49 +08:00
Krzysztof Jastrzebski
9c142cf47b
Delete only unscheduled pods if node doesn't exist anymore.
2019-04-03 00:24:26 +02:00
Krzysztof Jastrzebski
0087af78e2
Deleting pods assigned to not existing nodes only if
...
ScheduleDaemonSetPods is enabled.
2019-01-31 20:34:51 +01:00
Krzysztof Jastrzebski
7186d3ba8b
Delete pods assigned to not existing nodes.
2019-01-28 14:38:09 +01:00
Kubernetes Prow Robot
eb79f8f279
Merge pull request #69615 from k82cn/update_node_ns
...
Fixed node namespace to none.
2018-12-23 23:39:09 -08:00
Wei Huang
ad6e3617d3
update logic of adding default DS pod tolerations
...
- update DS pod default tolerations: add PIDPressure, remove OutOfDisk
- remove useless tolerations testcases
2018-11-29 01:18:32 -08:00
Jordan Liggitt
de8bf9b63d
fix scheduler and kubelet unit tests leaking feature flag changes
2018-11-16 10:52:53 -05:00
k8s-ci-robot
e77e8ffbf5
Merge pull request #69730 from xichengliudui/fix18101204
...
Fix some typo
2018-10-22 23:59:24 -07:00
xichengliudui
ef496320cf
Remove excess 'in'
...
Fix some typo
Fix some typo
2018-10-13 09:12:42 -04:00
tanshanshan
b7c7966b9f
Move pkg/scheduler/algorithm/well_known_labels.go out
2018-10-13 09:10:00 +08:00
Da K. Ma
f6ad347982
Fixed node namespace to none.
...
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
2018-10-10 16:17:15 +08:00
Christoph Blecker
97b2992dc1
Update gofmt for go1.11
2018-10-05 12:59:38 -07:00
ravisantoshgudimetla
b2e92f1ba2
Fix test cases and build files
2018-09-12 14:19:29 -04:00
Da K. Ma
e39b510726
Added unschedulable and network-unavailable toleration.
...
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
2018-09-07 16:53:49 +08:00
Kubernetes Submit Queue
5d8a79f2e1
Merge pull request #67337 from linyouchong/pr-0813-issue67225
...
Automatic merge from submit-queue (batch tested with PRs 67493, 67617, 67582, 67337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md ">here</a>.
Fix bug:DaemonSet didn't create pod after node have enough resource
**What this PR does / why we need it**:
Fix bug:DaemonSet didn't create pod after node have enough resource
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #67225
**Special notes for your reviewer**:
NONE
**Release note**:
```release-note
DaemonSet: Fix bug- daemonset didn't create pod after node have enough resource
```
2018-08-20 20:39:17 -07:00