github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
93,054 Commits 1 Branch 31 Tags 1,019 MiB
479249b3a3
Commit Graph

3015 Commits

Author SHA1 Message Date
chenyaqi01
66be69bb0e replace bytes.Compare() with bytes.Equal() 2019-09-27 10:08:49 +08:00
Kubernetes Prow Robot
67d750bb28
Merge pull request #81916 from hwdef/fix-typo-pkg 
fix typo in pkg
 2019-09-26 08:35:24 -07:00
caiweidong
f30a549eb8 Bugfix: remove PV dir when umount raw block device 2019-09-26 19:46:42 +08:00
Kubernetes Prow Robot
8a106a5714
Merge pull request #82994 from yutedz/rm-persist-vol-mode 
Remove unused func GetPersistentVolumeClaimVolumeMode
 2019-09-25 13:51:04 -07:00
Kubernetes Prow Robot
49bd1defaa
Merge pull request #82991 from yutedz/mk-file-close 
Properly close the file in makeFile
 2019-09-25 13:50:54 -07:00
Kubernetes Prow Robot
71c28e9b87
Merge pull request #82972 from yutedz/high-supported-ver 
Remove unnecessary sorting for highestSupportedVersion
 2019-09-25 13:50:44 -07:00
Kubernetes Prow Robot
6e960ef466
Merge pull request #82964 from yutedz/csi-drv-sync-err 
Check error return from WaitForCacheSync
 2019-09-25 13:50:34 -07:00
Ted Yu
7c26e11d6f Properly close the file in makeFile 2019-09-25 10:14:39 -07:00
Ted Yu
23c7405fe0 Remove unnecessary sorting for highestSupportedVersion 2019-09-24 13:59:25 -07:00
Kubernetes Prow Robot
2e4d02e9ab
Merge pull request #82909 from hwdef/del-unused-var1 
fix(pkg): delete unused var or const
 2019-09-24 13:37:26 -07:00
Kubernetes Prow Robot
ac70f166b1
Merge pull request #82976 from yutedz/clean-rbd-file 
Remove error check which is always false in RBDUtil#cleanOldRBDFile
 2019-09-24 08:58:12 -07:00
Kubernetes Prow Robot
17b3e30c9b
Merge pull request #82974 from yutedz/csi-supp-stage 
Come out of loop when RPC_STAGE_UNSTAGE_VOLUME is found
 2019-09-23 17:32:20 -07:00
Ted Yu
ba45f73c1f Remove unused func GetPersistentVolumeClaimVolumeMode 2019-09-22 08:54:01 -07:00
Ted Yu
2f3e563749 Remove unreachable error check in RBDUtil#cleanOldRBDFile 2019-09-21 19:14:24 -07:00
Ted Yu
44787fe14e Come out of loop when RPC_STAGE_UNSTAGE_VOLUME is found 2019-09-21 14:23:06 -07:00
Ted Yu
384aaad468 Check error return from WaitForCacheSync 2019-09-21 07:02:51 -07:00
hwdef
386f981116 fix(pkg): delete unused var or const 2019-09-21 17:13:13 +08:00
Kubernetes Prow Robot
5f249fecb4
Merge pull request #82363 from yuxiaobo96/k8s-update3 
update spelling mistakes
 2019-09-20 00:08:59 -07:00
smileusd
e5304209ed fix rbd info when return warning information 2019-09-18 16:50:01 +08:00
Kubernetes Prow Robot
3a19f1e80b
Merge pull request #82472 from draveness/feature/remove-feature-gates-in-1-17 
feat: cleanup several GA feature flags which should be removed in 1.17
 2019-09-17 06:58:24 -07:00
Kubernetes Prow Robot
ab88ff2398
Merge pull request #82571 from haoshuwei/fix-ineffassign-in-pkg-controller 
add or fix some errors return statements and ineffassign
 2019-09-16 04:50:37 -07:00
haoshuwei
b752997036 add or fix some errors return statements and ineffassign 
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
 2019-09-14 09:26:17 +08:00
Kubernetes Prow Robot
8126201b73
Merge pull request #82697 from sttts/sttts-TestBlockMapperMapDeviceNotSupportAttach-race 
Fix TestBlockMapperMapDeviceNotSupportAttach informer sync race
 2019-09-13 03:32:29 -07:00
Dr. Stefan Schimanski
79b9cff948 Fix TestBlockMapperMapDeviceNotSupportAttach informer sync race 2019-09-13 10:02:19 +02:00
Kubernetes Prow Robot
ce42bc382e
Merge pull request #82528 from jsafrane/iscsi-exec-logs 
Log all executed iscsiadm commands
 2019-09-11 21:24:52 -07:00
Kubernetes Prow Robot
9586c602f2
Merge pull request #82486 from haoshuwei/fix-ineffassign 
Fix ineffassign
 2019-09-11 21:23:19 -07:00
Kubernetes Prow Robot
d1c6898ab5
Merge pull request #82474 from cwdsuzhou/du_one_file_system 
Add -x to du commands to not traverse other file systems
 2019-09-11 18:29:45 -07:00
Kubernetes Prow Robot
60bc301889
Merge pull request #81613 from tedyu/op-exec-vol-cont 
Continue with remaining volumeAttached's in VerifyVolumesAreAttached
 2019-09-10 14:31:33 -07:00
Kubernetes Prow Robot
494d4cb841
Merge pull request #79005 from cwdsuzhou/June/remove_recursion_detach 
Remove recursion in waitForVolumeDetachmentInternal
 2019-09-10 14:29:01 -07:00
Jan Safranek
894e6795cf Log all executed iscsiadm commands 
We sometimes face issues with iSCSI PVs and it's hard to guess what's going
on without iscsiadm commands logged. Using level 5 (iscsiadm output can be
long sometimes) and explicitly avoiding logging of CHAP passwords.

In addition, log which path failed to appear after timeout, so the admin
can see which portals are not providing devices.
 2019-09-10 14:31:28 +02:00
Ted Yu
8819a4b6b4 Continue with remaining volumeAttached's in VerifyVolumesAreAttached 2019-09-09 15:52:53 -07:00
haoshuwei
89a6533ef6 fix ineffassign 2019-09-09 11:34:21 +08:00
draveness
2c0d6053fa feat: remove PersistentLocalVolumes feature gates 2019-09-09 08:10:27 +08:00
yuxiaobo
f6ce8f5789 update spelling mistakes 2019-09-05 17:59:36 +08:00
Travis Rhoden
935c23f2ad
Move HostUtil to pkg/volume/util/hostutil 
This patch moves the HostUtil functionality from the util/mount package
to the volume/util/hostutil package.

All `*NewHostUtil*` calls are changed to return concrete types instead
of interfaces.

All callers are changed to use the `*NewHostUtil*` methods instead of
directly instantiating the concrete types.
 2019-08-30 10:14:42 -06:00
Kubernetes Prow Robot
96439cc97f
Merge pull request #82028 from codenrhoden/rename-isbind 
Rename mount.IsBind to mount.MakeBindOpts
 2019-08-30 00:43:32 -07:00
Kubernetes Prow Robot
4170a19749
Merge pull request #81437 from jingxu97/Aug/metricfs 
Fix Windows disk usage metric measurement
 2019-08-29 21:21:59 -07:00
Jing Xu
3b7e696c2f Fix Windows disk usage metric measurement 
This PR will fix issue #81088. The current fs_windows utility reports
the whole file system usage instead of specific file path. This PR fix
this and walk the dir tree under the file path and collect the disk
usage.

Change-Id: I502ccf0af4bd07be69b61be043be616660499e4d
 2019-08-29 15:37:25 -07:00
Kubernetes Prow Robot
e0e7fc2201
Merge pull request #80027 from ramineni/staging-openstack-provider 
Move Openstack provider to staging
 2019-08-29 15:35:29 -07:00
Kubernetes Prow Robot
cd9519fe95
Merge pull request #82004 from pohly/ephemeral-beta 
ephemeral inline CSI volumes as beta
 2019-08-29 09:30:25 -07:00
Anusha Ramineni
a75c5bc50b Move Openstack provider to staging 
This commit moves the openstack provider to staging
 2019-08-29 19:09:14 +05:30
Han Kang
6f70f781df add some documentation around the metrics stability migration changes for clarity 2019-08-28 11:17:33 -07:00
Han Kang
3a50917795 migrate kubelet's metrics/probes & metrics endpoint to metrics stability framework 2019-08-28 11:16:38 -07:00
Patrick Ohly
599a9faf8d storage: make tests independent of CSIInlineVolume default 
Some tests assumed instead of ensuring that the CSIInlineVolume
feature is disabled.
 2019-08-28 05:32:44 +02:00
caiweidong
28dc53f727 Remove recursion in waitForVolumeDetachmentInternal 2019-08-28 11:18:23 +08:00
Kubernetes Prow Robot
77277d3abf
Merge pull request #80911 from pivotal-k8s/vsphere-windows-volumes 
Add support for vSphere volume mount/attach on Windows
 2019-08-27 19:37:10 -07:00
Travis Rhoden
ef855c7c08
Rename mount.IsBind to mount.MakeBindOpts 2019-08-27 11:34:42 -06:00
Kubernetes Prow Robot
bc46e8fc53
Merge pull request #81739 from codenrhoden/clarify-mkdir-mkfile-behavior 
Move MakeFile/Dir from HostUtil to host_path vol
 2019-08-27 00:53:24 -07:00
Kubernetes Prow Robot
f789e1e55c
Merge pull request #81730 from codenrhoden/mountpoint-match 
Internalize mount.Interface.IsMountPointMatch
 2019-08-26 20:55:07 -07:00
Kubernetes Prow Robot
087aafc18d
Merge pull request #80568 from pohly/ephemeral-mode-check 
ephemeral mode check
 2019-08-26 11:53:40 -07:00
Travis Rhoden
107039a265
Move MakeFile/Dir from HostUtil to host_path vol 
The MakeFile and MakeDir methods in the HostUtil interface only had one
caller -- the Host Path volume plugin. This patch relocates MakeFile and
MakeDir to the Host Path plugin itself.
 2019-08-26 10:46:08 -06:00
Travis Rhoden
a30ba6197d
Internalize mount.Interface.IsMountPointMatch 
IsMountPointMatch() had no callers outside of the mount package, and has
internal implementation details. This patch makes it no longer be
public.
 2019-08-26 09:47:07 -06:00
Gab Satchi
c7c755a0d1 Add support for vSphere volume mount/attach on Windows 
Signed-off-by: Ben Moss <bmoss@pivotal.io>
 2019-08-26 09:44:15 -04:00
hwdef
9b3f577b1d fix typo in pkg 2019-08-26 09:25:39 +08:00
Kubernetes Prow Robot
f105fef3d5
Merge pull request #81429 from huffmanca/resize_block_volume 
Enables resizing of block volumes.
 2019-08-23 17:59:05 -07:00
Kubernetes Prow Robot
b55f3252e1
Merge pull request #81843 from codenrhoden/remove-nsenter 
Remove nsenter impl from pkg/vol/util
 2019-08-23 15:49:06 -07:00
Travis Rhoden
dde8a6f7f6
Remove nsenter impl from pkg/vol/util 
With the removal of the `--containerized` flag from kubelet, nothing
uses this code anymore.
 2019-08-23 10:09:49 -06:00
Lee Verberne
b465d579de Add ephemeral container to GetPodVolumeNames test 2019-08-23 13:36:22 +00:00
Kubernetes Prow Robot
e232921c1f
Merge pull request #80353 from BenTheElder/tags 
simulate in-tree cloud provider removal with a build tag
 2019-08-23 04:55:31 -07:00
Kubernetes Prow Robot
f1453953b7
Merge pull request #81745 from codenrhoden/mv-hasmountrefs 
mv HasMountRefs from mount pkg to vol/util
 2019-08-23 00:52:13 -07:00
Kubernetes Prow Robot
ffb7573237
Merge pull request #81674 from msau42/use-podutil 
Use VisitContainers instead of directly accessing pod container fields
 2019-08-22 20:08:11 -07:00
Hemant Kumar
9dbe0b3ad8 Fix devicePath for raw block expansion 
Fix tests
 2019-08-22 22:48:46 -04:00
Benjamin Elder
5a3301a59d s/nolegacyproviders/providerless/ 2019-08-22 15:30:56 -07:00
Benjamin Elder
ece112524b hack/update-bazel.sh 2019-08-22 14:53:35 -07:00
Benjamin Elder
93c479793d make it possible to build kubelet without legacy cloud providers 2019-08-22 14:53:35 -07:00
Benjamin Elder
678d3f2841 add build tags to legacy provider code and make it possible to build kube-controller-manager without any legacyproviders or without particular legacy providers 2019-08-22 14:53:35 -07:00
Christian Huffman
7a4cdf5ab2 Included resizing for CSI-based block volumes. 
Perform a no-op when volume is of type raw block

Fix bug with checking volume mounts for readonly
 2019-08-22 15:45:57 -04:00
Kubernetes Prow Robot
5713c22eec
Merge pull request #81631 from tedyu/vol-local-rmdir 
Log the error return from dir removal
 2019-08-22 11:13:28 -07:00
Patrick Ohly
8270fe81e4 bazel update 2019-08-22 08:57:53 +02:00
Travis Rhoden
a7830a2c6e
mv HasMountRefs from mount pkg to vol/util 
HasMountRefs is only used internal to K8s and should not be moved out
with the mount package. move it to pkg/volume/util instead.
 2019-08-21 14:53:34 -06:00
Kubernetes Prow Robot
bfb69dbb8f
Merge pull request #81562 from andyzhangx/azurefile-trim 
fix: trim new line for azure storage account name
 2019-08-21 04:35:17 -07:00
Michelle Au
fa822f3c51 Use VisitContainers instead of directly accessing pod container fields 
Change-Id: I354513683e7b5bf4d1837f567ef0e84b17f6e174
 2019-08-20 11:16:35 -07:00
Kubernetes Prow Robot
d6035f3e0d
Merge pull request #81505 from justaugustus/update-azure-imports 
Update Azure API versions in go imports
 2019-08-20 04:43:32 -07:00
Kubernetes Prow Robot
1719ce7883
Merge pull request #81266 from andyzhangx/fix-detach-azuredisk-issue 
fix: detach azure disk issue using dangling error
 2019-08-20 00:16:33 -07:00
Ted Yu
dad86eb4cb Log the error return from dir removal 2019-08-19 20:51:24 -07:00
andyzhangx
193ad96f21 fix: trim new line for azure storage account name 
fix: comments
 2019-08-20 03:42:46 +00:00
Stephen Augustus
a8ea88960d Update Azure imports to latest API versions 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
 2019-08-19 13:27:27 -04:00
Kubernetes Prow Robot
5df8781ee3
Merge pull request #80904 from fredkan/fix-flexvolume-volumename-issue 
Fix flexvolume volumename issue
 2019-08-19 07:35:32 -07:00
fredkan
11d83dfdc1 change GetVolumeName log level 2019-08-19 17:27:34 +08:00
andyzhangx
1335f6470c fix: detach azure disk issue using dangling error 
fix: unit test failure
 2019-08-18 03:43:16 +00:00
Kubernetes Prow Robot
e319abf274
Merge pull request #81163 from jsafrane/skip-unused-volumes 
Skip unused volumes in VolumeManager
 2019-08-16 17:02:36 -07:00
Kubernetes Prow Robot
4e7fd98763
Merge pull request #81471 from ethan-daocloud/patch-11 
cleanup: fix typos in rbd_util.go
 2019-08-15 23:09:11 -07:00
Kubernetes Prow Robot
d8c8c8eded
Merge pull request #79931 from skarthiksrinivas/vsphere_volume_selectednode 
Provision vSphere volume as per selectedNode
 2019-08-15 11:06:35 -07:00
Guangming Wang
c718ba6871
cleanup: fix typos in rbd_util.go 
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
 2019-08-15 22:39:15 +08:00
Jan Safranek
8d580262f9 Refactor makeMountsMap into GetPodVolumeNames 
The function will be handy in subsequent patches. Also change custom maps
into sets.String.
 2019-08-15 10:48:38 +02:00
Kubernetes Prow Robot
d23b2c7d83
Merge pull request #81215 from zouyee/iscsi 
remove iSCSI volume storage cleartext secrets in logs
 2019-08-14 03:28:38 -07:00
Patrick Ohly
7bbc06fcd4 storage: check CSIDriver.Spec.VolumeLifecycleModes 
Using a "normal" CSI driver for an inline ephemeral volume may have
unexpected and potentially harmful effects when the driver gets a
NodePublishVolume call that it isn't expecting. To prevent that mistake,
driver deployments for a driver that supports such volumes must:
- deploy a CSIDriver object for the driver
- set CSIDriver.Spec.VolumeLifecycleModes such that it contains "ephemeral"

The default for that field is "persistent", so existing deployments
continue to work and are automatically protected against incorrect
usage.

For the E2E tests we need a way to specify the driver mode. The
existing cluster-driver-registrar doesn't support that and also was
deprecated, so we stop using it altogether and instead deploy and
patch a CSIDriver object.
 2019-08-13 23:12:52 +02:00
Kubernetes Prow Robot
0eb2e21352
Merge pull request #81013 from Madhu-1/fix-err 
Fix logging message during unmounting
 2019-08-13 02:28:07 -07:00
Kubernetes Prow Robot
76e19a1619
Merge pull request #81204 from codenrhoden/rename-hu-pathexists 
Rename HostUtils.ExistsPath to PathExists
 2019-08-12 20:12:12 -07:00
Madhu Rajanna
ec5ff52b88 Fix logging message during unmounting 
use errors.New() if formatting is not  required

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-12 09:18:35 +05:30
Kubernetes Prow Robot
37647eb88a
Merge pull request #79978 from cwdsuzhou/July/hostpath_cleanup 
Fix host path test clean up
 2019-08-10 02:59:13 -07:00
Kubernetes Prow Robot
1d812991b6
Merge pull request #81230 from codenrhoden/rename-GetFSGroup 
Rename HostUtils.GetFSGroup to HostUtils.GetOwner
 2019-08-09 23:57:26 -07:00
Travis Rhoden
0e73131ca6
Rename HostUtils.GetFSGroup to HostUtils.GetOwner 
This patch renames GetFSGroup (a process property) to GetOwner (a file
property), returning both the uid and gid of the given pathname. This
method is only used in one place in the k/k codebase, but having
"GetOwner" instead of "GetGroup" seems to have more utility.
 2019-08-09 13:20:35 -06:00
Travis Rhoden
14e25b7c04
Rename HostUtils.ExistsPath to PathExists 2019-08-09 12:40:19 -06:00
Travis Rhoden
4574473753
Rename mount.NewOsExec to mount.NewOSExec 2019-08-09 12:30:56 -06:00
zouyee
b85516bb9a remove iSCSI volume storage cleartext secrets in logs 2019-08-09 15:37:02 +08:00
caiweidong
41bb76bb88 make hostpath configurable for test 2019-08-09 10:59:29 +08:00
Kubernetes Prow Robot
2b7b6713b1
Merge pull request #79137 from qingsenLi/k8s-190618-golint 
fix golint failures for pkg/volume/scaleio and pkg/volume/storageos
 2019-08-07 20:09:28 -07:00
Kubernetes Prow Robot
07afde1559
Merge pull request #80935 from wongma7/initcsinode-error 
Return error returned by CSINode Get if initialization failed
 2019-08-06 23:57:29 -07:00
Kubernetes Prow Robot
e5862e74be
Merge pull request #80321 from Moriadry/feature/vendor-codedellemc 
vender upgrade codedellemc/goscaleio to release v0.1.0
 2019-08-06 21:05:05 -07:00
Kubernetes Prow Robot
521b5c3fed
Merge pull request #80994 from verult/csi-deregistration-loglevel 
Bump log level of CSI driver de-registration to match registration handler
 2019-08-06 06:06:09 -07:00
Kubernetes Prow Robot
345e58b434
Merge pull request #75071 from mkimuram/issue/74552e2e 
Fix volume reconstruction and add e2e tests
 2019-08-06 06:05:55 -07:00
Kubernetes Prow Robot
16d9a659da
Merge pull request #80837 from rmweir/use-default-skuname 
Use default skuname shared Azure Disk
 2019-08-06 03:11:55 -07:00
Eytan Heidingsfeld
6a94d50fb3 Add -s to du commands to not traverse other file systems 2019-08-06 14:59:19 +08:00
Kubernetes Prow Robot
1bc3d1abde
Merge pull request #80866 from ethan-daocloud/dev-ethan-csi-log 
cleanup: remove package csi duplicated error log
 2019-08-05 18:18:19 -07:00
Matthew Wong
bd42e728a8 Return error returned by CSINode Get if initialization failed 2019-08-05 23:01:50 +00:00
Cheng Xing
da64ca0c54 Bumped log level of CSI driver de-registration to match registration handler 2019-08-05 15:55:28 -07:00
ethan
d26e352fe7 cleanup: remove package csi duplicated error log 
return err directly in func; delete new line in error message

cleanup: use errors.New(log()) to uniform error message
 2019-08-05 20:35:28 +08:00
Kubernetes Prow Robot
369b765052
Merge pull request #80446 from hantaowang/test-verify-attach 
Test verify attach
 2019-08-03 15:33:49 -07:00
Kubernetes Prow Robot
5c16a784c6
Merge pull request #80923 from davidz627/fix/pdAttachLimit 
Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk
 2019-08-03 01:27:51 -07:00
Kubernetes Prow Robot
9f6ebf0feb
Merge pull request #79144 from tedyu/csi-x-recur 
Remove recursion in csiAttacher#waitForVolumeAttachmentInternal
 2019-08-03 00:05:51 -07:00
Kubernetes Prow Robot
36391966f2
Merge pull request #78736 from endocrimes/dani/comment-fix 
csi: Fix socket extension comment
 2019-08-02 20:27:53 -07:00
Hantao (Will) Wang
1da12e9435 add unit tests for attacher DisksAreAttached and BulkDisksAreAttached 2019-08-02 14:24:51 -07:00
David Zhu
9ed06e2cf9 Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk 2019-08-02 13:37:10 -07:00
Masaki Kimura
c130b77a48 Move nil check for mapperPlugin earlier in reconstructVolume 2019-08-01 20:36:21 +00:00
Jan Safranek
bab81b809b Don't create mounter when reconstructing block volume 
CSI mounter will create a new directory + json for a filesystem volume,
leading to even more orphaned files/directories.
 2019-08-01 20:04:10 +00:00
Kubernetes Prow Robot
270d9529e0
Merge pull request #80844 from zgfh/patch-7 
cleanup: log message typo fix
 2019-08-01 09:46:51 -07:00
Danielle Lancashire
d4c189d52b
csi: Fix socket extension comment 
The CSI socket has used a sock extension since 179d8e108e. This removes
the stale TODO for updating it.
 2019-08-01 14:52:46 +02:00
Kubernetes Prow Robot
4ce69dd32e
Merge pull request #80848 from cwdsuzhou/Aug/fix_ut 
Fix some unreasonable places int csi ut
 2019-08-01 03:30:14 -07:00
caiweidong
7b5dac03ce Fix some unreasonable places int csi ut 2019-08-01 14:19:11 +08:00
caiweidong
7dee721a3e Fix host path test clean up 2019-08-01 13:58:06 +08:00
Kubernetes Prow Robot
3a4cda9def
Merge pull request #80522 from ethan-daocloud/patch-3 
cleanup: remove duplicated logging error message in csi_mounter.go, also some typos.
 2019-07-31 22:36:39 -07:00
Alan
f0b18f74b7
cleanup: log message typo fix 2019-08-01 12:10:46 +08:00
moriadry
bacda8aaca update codedellemc/goscaleio 
update thecodeteam/goscaleio

fix problem
 2019-08-01 11:49:53 +08:00
ethan
ec2c5dff43 fix some log typos in csi_mounter.go 
cleanup: remove logging duplicated error message
fix error msg, include err in new returned errors.
Signed-off-by: ethan <guangming.wang@daocloud.io>
 2019-08-01 02:39:32 +00:00
rmweir
e543f9b2fe Use default skuname shared Azure Disk 
Shared blob disks are now created with default skuname value if the
referenced storage class possesses empty values for storageaccounttype
and skuname. Prior, the provisioning process would fail if a new
storage account needed to be created. This is because a storage account
may not be created with an empty sotrageaccounttype.
 2019-07-31 18:26:35 -07:00
Kubernetes Prow Robot
fde94e931f
Merge pull request #78941 from jsafrane/fix-iscsi-logout 
Fix iscsi logout issues
 2019-07-31 08:54:23 -07:00
Kubernetes Prow Robot
dcf1eff767
Merge pull request #80612 from AllenZMC/patch-1 
fix typos in csi_attacher.go
 2019-07-30 10:09:18 -07:00
skarthiksrinivas
73271c1970 Provision vSphere volume as per selectedNode 2019-07-28 22:03:02 -07:00
Kubernetes Prow Robot
de73f62336
Merge pull request #80495 from adityadani/update_openstorage_to_v1.0.0 
pkg/volume/portworx: Update vendor for libopenstorage/openstorage to v1.0.0
 2019-07-26 03:23:59 -07:00
AllenZMC
8833e4072c
fix typos in csi_attacher.go 2019-07-26 09:48:51 +08:00
Kubernetes Prow Robot
a3750501b0
Merge pull request #79983 from pohly/persistent-and-ephemeral-csi-volumes 
persistent and ephemeral csi volumes
 2019-07-25 16:01:54 -07:00
Aditya Dani
ab72c09937 Update pkg/volume/portworx OWNERs 2019-07-25 14:39:24 -07:00
Kubernetes Prow Robot
0e3b593ded
Merge pull request #79851 from jparklab/master 
Fix nil pointer dereference error in volume_stat_calculator
 2019-07-25 14:33:58 -07:00
Patrick Ohly
555ff7ef10 CSI: allow drivers that can handle persistent and ephemeral volumes 
The conceptual change is that the mode in which a volume gets handled
is derived from it's spec, not from the ability of the driver. In
practice, that is already how the code worked because it didn't
actually look at CSIDriver.Spec.Mode at all.

Therefore the code change itself is mostly just renaming "driver mode"
to "volume mode". In some places (CanDeviceMount, CanAttach) the
feature check that was used elsewhere seemed to be missing. Now their
code path for ephemeral volumes are also only entered if that feature
is enabled.

The sanity check whether a CSI driver is being used correctly still
needs to be implemented.

Related-to: https://github.com/kubernetes/kubernetes/issues/79624
 2019-07-25 16:45:46 +02:00
Kubernetes Prow Robot
7aa5f9727b
Merge pull request #80347 from humblec/metrics 
Remove unwanted string converstion in metrics errors
 2019-07-25 07:35:55 -07:00
Jan Safranek
cdcd2e2821 Report error when iscsiadm fails during detach 
Kubernetes should retry detaching iSCSI volumes on error. In addition, it
should not report an error when detaching a disk while the disk is already
detached.
 2019-07-25 10:10:01 +02:00
Kubernetes Prow Robot
9c903376f3
Merge pull request #80091 from bertinatto/iscsi_ref_counter 
Add new iSCSI refcounter
 2019-07-24 13:49:52 -07:00
Kubernetes Prow Robot
030274eba3
Merge pull request #80443 from davidz627/fix/verifyMigration 
Add migration shim for verifyvolumeattachment and bulk verify
 2019-07-24 05:30:15 -07:00
Fabio Bertinatto
44d7510ee0 Add unit test for iSCSI refcounter 2019-07-24 14:21:36 +02:00
Fabio Bertinatto
0007c2abd4 Add new refcounter for iSCSI volumes 2019-07-24 13:40:10 +02:00
Kubernetes Prow Robot
da3daf2e8a
Merge pull request #80451 from cwdsuzhou/July/fix_error_override 
Fix error override when saveVolumeData occurs error
 2019-07-24 02:02:15 -07:00
caiweidong
a5bf98a43e Fix error overrided when saveVolumeData occurs error 2019-07-24 10:19:22 +08:00
Kubernetes Prow Robot
60c2d44129
Merge pull request #79552 from wongma7/windows-ebs 
Add support for AWS EBS on windows
 2019-07-23 17:14:28 -07:00
Ted Yu
f4fbfcb46a Remove recursion in csiAttacher#waitForVolumeAttachmentInternal 2019-07-23 14:29:24 -07:00
David Zhu
290a7f12ce Add migration shim for VerifyVolumesAreAttached and BulkVolumeVerify 2019-07-23 12:57:47 -07:00
Matthew Wong
51615f691d Add support for windows to AWS EBS 2019-07-23 19:28:14 +00:00
caiweidong
45c52d1314 Fix potential panic in nodeGetVolumeStatsV1 2019-07-23 13:47:35 +08:00
caiweidong
8789143062 Fix csi attacher unit tests using t.Run() 2019-07-22 15:42:31 +08:00
Hantao (Will) Wang
7ee5861fb9 add ability for gce to bulk verify attached disks 2019-07-19 10:41:46 -07:00
Humble Chirammal
3ccaeef758 Remove unwanted string converstion in metrics errors 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-07-19 11:29:47 +05:30
Kubernetes Prow Robot
748849bbb9
Merge pull request #75805 from brahmaroutu/nfs_metrics 
Adding metrics to nfs driver
 2019-07-18 08:34:13 -07:00
Kubernetes Prow Robot
4b2c96c952
Merge pull request #79977 from bertinatto/fix_iscsi_cleanup 
Fix iSCSI storage plugin cleanup in block volumes
 2019-07-17 12:20:25 -07:00
David Zhu
831cd29f4e Add passthrough for MountOptions for NodeStageVolume for CSI 2019-07-16 16:17:47 -07:00
Fabio Bertinatto
80652c8d37 Fix iSCSI storage plugin cleanup in block volumes 2019-07-16 15:41:11 +02:00
Jeremy Xu
d8fc13791a Avoid RbdDiskManager's DetachDisk never execute again 2019-07-16 18:13:38 +08:00
Kubernetes Prow Robot
10a1d1f5bd
Merge pull request #79920 from cwdsuzhou/July/block_not_support_attach 
Bugfix: csi plugin supporting raw block that does not need attach mounted failed
 2019-07-15 08:39:21 -07:00
caiweidong
0c628e101a Bugfix: csi raw block that does not need attach mounted failed 
Add unit test

fix verify-test-featurefates failed
 2019-07-15 10:34:12 +08:00
Kubernetes Prow Robot
2bf8ab13c4
Merge pull request #80048 from davidz627/fix/tests 
Fixes mount/unmount paths for migrated inline volumes
 2019-07-12 20:19:17 -07:00
Davanum Srinivas
7fa6fc7226 Add explicit warning for deprecation of Cinder and ScaleIO volume providers 
We have had a warning for OpenStack in-tree cloud provider, Here we are
adding more fine grained WARNING for OpenStack cinder volume provider in
addition to that.

Also identified ScaleIO as something that has not had activity or
updates for a while, So we should deprecate that as well
 2019-07-12 10:29:09 -04:00
Kubernetes Prow Robot
b67acd3706
Merge pull request #79415 from choury/patch-2 
Use Join instead of concat it manually in cephfs.
 2019-07-12 06:31:31 -07:00
Kubernetes Prow Robot
9915047d3d
Merge pull request #79113 from tedyu/stop-w-detach 
Close watcher early for volume detachment
 2019-07-12 06:31:18 -07:00
Kubernetes Prow Robot
4423ff5fdd
Merge pull request #79656 from humblec/heketi-error 
If volume in delete request does not exist, return success.
 2019-07-12 05:15:06 -07:00
David Zhu
2820c1d8c8 Add davidz627 (David Zhu) to Approvers for OperationExecutor and GCE PD 2019-07-11 13:14:31 -07:00
David Zhu
93d6356d2f Fixes mount/unmount paths for migrated inline volumes. Some minor fixes for GCE specific inline migrated volumes 2019-07-11 11:51:43 -07:00
Kubernetes Prow Robot
514a157adf
Merge pull request #74691 from cpuguy83/epoll_use_cloexec 
Use EPOLL_CLOEXEC to prevent fd leaks.
 2019-07-10 21:38:55 -07:00
Kubernetes Prow Robot
8a1c9e2b41
Merge pull request #79924 from cwdsuzhou/July/projected_test_cleanup 
Fix projected volume test clean up
 2019-07-10 18:49:44 -07:00
Kubernetes Prow Robot
021ad88ac4
Merge pull request #79894 from odinuge/csi-client-dead-code 
Remove dead code from csi_client
 2019-07-10 06:20:25 -07:00
caiweidong
94a2a42412 Fix projected volume test clean up 2019-07-10 10:14:36 +08:00
Kubernetes Prow Robot
d59a603f1b
Merge pull request #78267 from mucahitkurt/cleanup/operation-generator-migration-scenarios-unit-tests 
unit tests for operationGenerator.GenerateUnmapVolumeFunc
 2019-07-09 18:20:25 -07:00
Brian Goff
0051db89a7 Use O_CLOEXEC for volume subpath util 
This prevents fd's from leaking to subprocesses.
 2019-07-09 10:03:59 -07:00
Humble Chirammal
c22cc06b90 If volume in delete request does not exist, return success. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-07-09 19:43:40 +05:30
Odin Ugedal
542c335fca Remove dead code from csi_client 
When removing a feature flag in
35bc5dc6b6, a few of the lines were
removed, resulting in some dead code.
 2019-07-08 17:53:52 +02:00
Ji-Young Park
528521cfae Return MetricsError with ErrCodeNotSupported code 
GetMetrics function expects MetricsError error
with ErrCodeNotSupported code when driver for the volume
does not support metrics
Updated csi_metrics to return error when underlying csi
driver does not have GET_VOLUME_STATS capability
 2019-07-06 10:49:06 -04:00
Kubernetes Prow Robot
a3be4b6817
Merge pull request #79529 from andyzhangx/change-csi-timeout 
fix: change default timeout value in csi plugin
 2019-07-03 09:12:58 -07:00
Kubernetes Prow Robot
a5e3d74691
Merge pull request #79534 from odinuge/volume-util-fd 
Fix possible fd leak and closing of dirs in doSafeMakeDir
 2019-07-01 15:09:58 -07:00
Kubernetes Prow Robot
92ef26d651
Merge pull request #77795 from nagexiucai/glusterfs--backup-volfile-servers--option-warning 
Remove selected IP from backup-volfile-servers list to avoid warning in mount logs.
 2019-07-01 07:23:21 -07:00
choury
edc21ac27b Use Join instead of concat it manually in cephfs. 2019-07-01 20:09:43 +08:00
Kubernetes Prow Robot
2501a9083d
Merge pull request #68513 from codenrhoden/mount-refactor 
Refactor util/mount interface in prep for moving out of k/k
 2019-06-28 13:57:28 -07:00
Odin Ugedal
626a0f7b4b Fix closing of dirs in doSafeMakeDir 
This fixes the issue where "childFD" from syscall.Openat is assigned to
a local variable inside the for loop, instead of the correct one in the
function scope. This results in that when trying to close the "childFD"
in the function scope, it will be equal to "-1", instead of the correct
value.
 2019-06-28 18:21:12 +02:00
andyzhangx
d8c92f5c09 fix: change timeout value in csi plugin 2019-06-28 14:27:22 +00:00
Kubernetes Prow Robot
22fb6fd174
Merge pull request #77595 from bertinatto/volume_limits 
Volume Scheduling Limits
 2019-06-25 17:01:16 -07:00
Kubernetes Prow Robot
1215aa73d2
Merge pull request #79176 from verb/debug-iterate-containers 
Add helpers for iterating containers in a pod
 2019-06-25 09:32:52 -07:00
Fabio Bertinatto
33c8bacd41 Update nodeinfomanager to store volume limits in CSINode 2019-06-25 16:30:54 +02:00
draveness
35bc5dc6b6 feat: cleanup feature gates for KubeletPluginsWatcher 2019-06-23 16:59:36 +08:00
Lee Verberne
a0b57ad3db Update BUILD files for container helper 2019-06-21 08:32:04 +00:00
Lee Verberne
ee821e2a04 Create helpers for iterating containers in a pod 2019-06-21 08:32:04 +00:00
Ted Yu
005065f8fc Close watcher early for volume detachment 2019-06-17 15:09:43 -07:00
Kubernetes Prow Robot
365283e202
Merge pull request #78532 from cwdsuzhou/simplify_construct_volume_spec 
Simplify func ConstructVolumeSpec
 2019-06-17 11:05:49 -07:00
Kubernetes Prow Robot
e46b9ca656
Merge pull request #78754 from cwdsuzhou/June/csi_attach_close_chan 
Avoid to keep the watcher open for too long
 2019-06-17 04:36:37 -07:00
nagexiucai
63cb1d65ca Remove selected IP from backup-volfile-servers list to avoid warning in mount logs. 2019-06-17 16:36:53 +08:00
Kubernetes Prow Robot
5868ff8973
Merge pull request #78979 from Lah123/patch-1 
Correct a typo 'concurrrent'
 2019-06-15 03:46:36 -07:00
Kubernetes Prow Robot
bde744eb97
Merge pull request #78839 from tedyu/cleaner-err 
Check correct error for cleanup in csiAttacher#MountDevice
 2019-06-14 20:47:01 -07:00
Kubernetes Prow Robot
15c8df161e
Merge pull request #76356 from qingsenLi/k8s190410-fix-coresponding 
fix error 'coresponding'
 2019-06-14 20:46:10 -07:00
qingsenLi
7a0efd326b fix golint failures for pkg/volume/scaleio and pkg/volume/storageos 2019-06-15 10:53:50 +08:00
Kubernetes Prow Robot
9bef69a2b4
Merge pull request #78768 from humblec/cleanup 
Remove unwanted newlines in glusterfs driver
 2019-06-14 15:26:22 -07:00
Travis Rhoden
be7da5052f Refactor pkg/util/mount to be more reusable 
This patch refactors pkg/util/mount to be more usable outside of
Kubernetes. This is done by refactoring mount.Interface to only contain
methods that are not K8s specific. Methods that are not relevant to
basic mount activities but still have OS-specific implementations are
now found in a mount.HostUtils interface.
 2019-06-14 09:35:18 -06:00
Kubernetes Prow Robot
518f16636f
Merge pull request #78593 from RobertKrawitz/ephemeral-storage-quota-cleanup 
Ephemeral storage quota cleanup
 2019-06-14 05:33:18 -07:00
Kubernetes Prow Robot
70b46ca5fb
Merge pull request #78529 from cwdsuzhou/remove_verbose_err 
Remove dead codes
 2019-06-14 04:09:13 -07:00
Kubernetes Prow Robot
3a598d7f92
Merge pull request #75234 from andyzhangx/corrupt-mnt-fix 
fix pod stuck issue due to corrupt mnt point in flexvol plugin
 2019-06-13 20:36:34 -07:00
Srini Brahmaroutu
bbc7ba8f51 Adding metrics to nfs driver 2019-06-13 10:21:20 -07:00
Lah123
c86b6d1ec5
Correct a typo 
From concurrrent to concurrent
 2019-06-13 14:29:11 +02:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios 
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
 2019-06-11 08:32:25 +03:00
Davanum Srinivas
e0821ca3dd
Remove ovirt/cloudstack/photon cloud providers 
Change-Id: Iddb80bdc2a9d75d444b8a3cfe0b142acb78e9097
 2019-06-10 12:50:53 -04:00
Ted Yu
de92897e26 Check correct error for cleanup 2019-06-09 21:29:28 -07:00
Kubernetes Prow Robot
3d4124f2e0
Merge pull request #68108 from wenjun93/iscsiVol 
add lun info when construct iscsi volumeSpec from mountPath
 2019-06-09 20:45:06 -07:00
caiweidong
0508bea9b6 Fix keep the watcher open for too long 2019-06-07 21:40:50 +08:00
Kubernetes Prow Robot
333081e79c
Merge pull request #78595 from gnufied/fix-aws-dangling-volumes 
Add dangling volume as uncertain
 2019-06-06 16:47:59 -07:00
Hemant Kumar
7bcebe98bb Add dangling volume as uncertain 2019-06-06 15:25:10 -04:00
Humble Chirammal
b867f601da Remove unwanted newlines in glusterfs driver 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-06-06 22:03:15 +05:30
caiweidong
4ce2f296f5 Simplify func ConstructVolumeSpec 2019-06-05 10:22:13 +08:00
Kubernetes Prow Robot
304a2b191d
Merge pull request #78522 from croomes/bugfix-78517-storageos-mountref 
StorageOS volume driver: Remove call to clear mount info if already set
 2019-06-04 14:33:50 -07:00
Kubernetes Prow Robot
8657b24d86
Merge pull request #78681 from yuxiangqian/e2efix 
fix label mismatching which broke e2e serial test
 2019-06-04 10:53:21 -07:00
xiangqian
d616c6fb5a fix label mismatching which broke e2e serial test 2019-06-03 23:33:37 -07:00
Hemant Kumar
0f62e3fbe8 Make language of error msgs and func names consistent: ExpandVolumeInUse 
change feature flag
Fix the e2e test for online and offline expansion
 2019-06-03 12:26:56 -04:00
caiweidong
b726db66d2 Remove dead codes 2019-06-03 22:15:53 +08:00
Kubernetes Prow Robot
8362e9c4f9
Merge pull request #78475 from humblec/iscsi-higher-timeout 
Increase device discovery timeout to 30seconds/equal to checker_timeout
 2019-06-01 02:54:30 -07:00
Kubernetes Prow Robot
f14b128ea6
Merge pull request #78276 from zhan849/ebs-get-zone-opt1 
Use zone from node for topology aware aws-ebs volume creation
 2019-05-31 22:03:12 -07:00
Kubernetes Prow Robot
b3c1bbb471
Merge pull request #78061 from yuxiangqian/metrics 
Enhance to record more accurate e2e provision/deletion latency metric
 2019-05-31 20:45:13 -07:00
Kubernetes Prow Robot
b7fa33ec15
Merge pull request #77703 from ddebroy/inline-mig-1 
API changes to support migration of inline in-tree volumes to CSI
 2019-05-31 12:23:19 -07:00
Robert Krawitz
bf1f0fa5d9 Remove pod UID from volumeMount, we can get it elsewhere 2019-05-31 14:25:01 -04:00
Robert Krawitz
10d37bb748 Rename pkg/volume/util/quota -> pkg/volume/util/fsquota 2019-05-31 13:57:44 -04:00
Kubernetes Prow Robot
cf76868b34
Merge pull request #66928 from RobertKrawitz/ephemeral-storage-quota-exp 
Ephemeral storage monitoring via filesystem quotas
 2019-05-30 20:44:26 -07:00
Humble Chirammal
d4ea88f3ce Increase device discovery timeout to 30seconds/equal to checker_timeout. 
At present, iscsi plugin wait for 10seconds for a path to appear for a multipath
device, but at certain scenarios this may not be sufficient for device mapper
to get the path. The default multipath configuration has a configuation
called 'checker_timeout' which specify the timeout to user for path checkers
that issue scsi commands with an explicit timeout, in seconds;
default taken from /sys/block/sd*/device/timeout which is 30s.
This patch lift the timeout value from 10s to 30s.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-30 21:46:06 +05:30
Simon Croome
6d9f4659d8 Remove call to clear mount info if already set 
https://github.com/kubernetes/kubernetes/pull/69782 introduced a change
to register the device attachment (in the StorageOS API) prior to the
volume attachment.  The volume attachment code would clear any mount
info, causing the StorageOS API to register the mount and then
immediately de-register it.

The code to clear the mount info on volume attach is no longer needed.
It was used to force-mount a volume if StorageOS thought it was already
mounted.  In practice it was not needed, and administrators have other
ways of clearing stale mount information if required.
 2019-05-30 14:21:31 +01:00
Deep Debroy
de7be9d613 Populate InlineVolumeSpec in CSI attacher and translation library 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-05-30 09:35:22 +00:00
Kubernetes Prow Robot
ade661c7cb
Merge pull request #78356 from andyzhangx/csi-translation-azurefile 
Add support for Azure File plugin to csi-translation-lib
 2019-05-29 22:54:31 -07:00
Kubernetes Prow Robot
05df640f33
Merge pull request #77994 from gnufied/csi-resize-migration 
Handle CSI volume resize migration.
 2019-05-29 21:28:43 -07:00
andyzhangx
f5b319c088 add azure file CSI translation feature gate 
fix build error

fix gofmt error
 2019-05-30 00:54:39 +00:00
Kubernetes Prow Robot
8d5052eddf
Merge pull request #78330 from andyzhangx/csi-translation-azuredisk 
Add support for Azure Disk to csi-translation-lib
 2019-05-29 17:25:11 -07:00
xiangqian
9688511595 record provision and deletion latency metric 
instead of using provisioner from storage class directly, uses plugin name firstly
 2019-05-29 14:15:30 -07:00
Robert Krawitz
9f4a4d1f49 Log message rather than error if setting quota fails 2019-05-29 15:17:47 -04:00
Robert Krawitz
f8661d6240 Use xfs_quota command to apply quotas 2019-05-29 15:12:28 -04:00
Robert Krawitz
448e0c44c6 Apply quotas via syscalls using cgo. 2019-05-29 15:12:28 -04:00
Robert Krawitz
5b97b2860d Change fsGroup to mounterArgs in volume.SetUp() to allow for future extension. 2019-05-29 15:12:28 -04:00
Kubernetes Prow Robot
38468e4338
Merge pull request #70536 from mysunshine92/golint-hostpath 
fix golint for pkg/volume/host_path
 2019-05-29 11:25:46 -07:00
Kubernetes Prow Robot
cf1ccf1253
Merge pull request #78332 from qingsenLi/k8s-190525 
fix klog format error
 2019-05-29 09:44:51 -07:00
Hemant Kumar
7563b4d01b Address comments about retry in online resizing block 2019-05-29 11:01:45 -04:00
Hemant Kumar
d119899e22 handle review comments 2019-05-28 15:22:41 -04:00
andyzhangx
6f2902e0a3 add feature gate for azure disk 
fix gofmt error
 2019-05-28 15:38:52 +00:00
qingsenLi
9d487d9fd9 spelling error 'doen't' 2019-05-28 17:41:42 +08:00
Harry Zhang
90eb408142 Use zone from node for topology aware volume creation 2019-05-27 17:13:42 -07:00
qingsenLi
62dea14351 fix klog format error 2019-05-27 18:05:09 +08:00
Di Xu
f715d41635 fix bug for regular empty file 2019-05-27 14:35:24 +08:00
Hemant Kumar
4d481a0f29 Fix flake associated with time out volumes 
This test is suspectible to flakes because sometimes
while we verify if volume is attached to a node, reconciler
loop can turn second time and it can confirm the volume as attached.
 2019-05-23 13:33:37 -04:00
Kubernetes Prow Robot
b533613233
Merge pull request #77851 from andyzhangx/azuredisk-max-count 
remove vmsizelist call in azure disk GetVolumeLimits
 2019-05-23 03:28:26 -07:00
Kubernetes Prow Robot
d5876954e1
Merge pull request #76178 from humblec/endpoint 
Create endpoint/service early to avoid unwanted create/delete volume transaction.
 2019-05-22 09:58:09 -07:00
andyzhangx
fb81a28a47 fix flexvol stuck issue due to corrupted mnt point 
fix comments about PathExists

fix comments

revert change in PathExists func
 2019-05-22 08:52:58 +00:00
Hemant Kumar
0ab6bdfa36 Wait for waitforattach goroutine before exiting 
This test suite fails in weird ways without waiting for the
goroutine
 2019-05-21 09:57:47 -04:00
Hemant Kumar
33b95ebddb add some tests for expand controller 
Update bazel file
 2019-05-20 10:55:23 -04:00
andyzhangx
b962361536 remove vmsizelist call in azure disk 
add one comment

add comments

use a new way to generate vm size list
 2019-05-18 03:41:34 +00:00
Kubernetes Prow Robot
fad34e404e
Merge pull request #76188 from humblec/csi-in-m 
csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call
 2019-05-17 20:26:09 -07:00
Hemant Kumar
405d33eae4 Add code to handle in-tree to CSI migration for resizing 2019-05-17 10:57:44 -04:00
Humble Chirammal
c511c90b59 csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call 
and implement Metrics Provider for CSI driver

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-17 17:10:53 +05:30
Kubernetes Prow Robot
da4d6f5829
Merge pull request #77883 from gnufied/mat-expand-workqueue 
Use workqueues for volume expansion
 2019-05-17 02:04:18 -07:00
Hemant Kumar
4886e8782c name the queue properly and use lower case for error message 2019-05-16 21:34:57 -04:00
Hemant Kumar
673773cbde check for pvc objects 2019-05-16 12:23:52 -04:00
Kubernetes Prow Robot
6a9ecf71fd
Merge pull request #77912 from andyzhangx/fix-azuredisk-lun-error 
Fix incorrect azuredisk lun error
 2019-05-16 08:48:54 -07:00
andyzhangx
4213f4d797 fix azure disk lun error 2019-05-15 08:32:03 +00:00
Matthew Wong
c16a555654 Use workqueue model in expand controller 
Add a test for patch creation
 2019-05-14 16:42:06 -04:00
Mike Crute
7d62316f8f Migrate fake cloud provider to staging 2019-05-14 13:32:18 -07:00
Humble Chirammal
e47a7897ea Fail early if driver cant get kubeclient 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-14 10:29:59 +05:30
Ted Yu
2001feead2 Move the array of plugin names to inside the last if block in VolumePluginMgr#FindPluginBySpec 2019-05-14 05:48:24 +08:00
Kubernetes Prow Robot
ed239cefa6
Merge pull request #77483 from andyzhangx/azuredisk-waitforattach 
remove VM API call dependency in azure disk WaitForAttach
 2019-05-08 23:07:01 -07:00
Kubernetes Prow Robot
c2966f7c29
Merge pull request #77537 from cwdsuzhou/use_key_in_lugins 
Use key in probedPlugin
 2019-05-08 20:13:01 -07:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
291f2f863a
Merge pull request #77415 from Fedosin/allow_define_kubeconfig 
Allow to define kubeconfig file for OpenStack cloud provider
 2019-05-07 23:38:32 -07:00
Kubernetes Prow Robot
7aa57df279
Merge pull request #77374 from cheftako/gce-staging 
Staging the GCE Cloud Provider
 2019-05-07 17:52:32 -07:00
Kubernetes Prow Robot
2a7eaa30da
Merge pull request #77385 from humblec/gluster-error 
Avoid duplicate error reporting in glusterfs
 2019-05-07 14:31:28 -07:00
Walter Fender
796097ae40 Staging the GCE Cloud Provider 
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
Staging the GCE Cloud Provider as part of KEP [20190125-removing-in-tree-providers](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md). Staging repo setup here https://github.com/kubernetes/legacy-cloud-providers
Moves the GCE cloud provider implementation to staging.
This is in preparation for moving the cloud provider code out of tree entirely.
However we need it in staging while the code needs to be consumed both in/out of tree.

**Which issue(s) this PR fixes**:
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```
NONE
```

Updated import dependency tracking.
Factored in the cleanup from #77412
Minor fix to go.mod.
 2019-05-07 13:17:52 -07:00
Kubernetes Prow Robot
e332051416
Merge pull request #77433 from cwdsuzhou/common_func_for_ad 
Add common func for NewAttacher and NewDetacher
 2019-05-07 09:51:56 -07:00
Kubernetes Prow Robot
2e6f58ddf8
Merge pull request #77431 from cwdsuzhou/Add_detacher_assert_check 
Add detacher assertion for csiAttacher
 2019-05-07 09:51:44 -07:00
caiweidong
cf1eeed30c Use key in probedPlugin 2019-05-07 18:43:26 +08:00
andyzhangx
9a8f07dd9f remove VM API call dep in azure disk WaitForAttach 
add comment

add unit test for WaitForAttach fnc

add unit test for WaitForAttach Func
 2019-05-07 06:21:44 +00:00
Kubernetes Prow Robot
a8787dac30
Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine 
Do not generate unnecessary goroutines
 2019-05-06 21:31:53 -07:00
Kubernetes Prow Robot
56ceba5e30
Merge pull request #77352 from mcrute/move-aws-provider 
Staging legacy AWS cloud provider
 2019-05-06 15:30:19 -07:00
Kubernetes Prow Robot
e0d39be7b5
Merge pull request #76785 from dims/typo-extra-space-in-fatalf-format-string 
typo - extra space - in Fatalf format string
 2019-05-06 14:01:39 -07:00
Mike Crute
6f5cf1a6e0 Staging legacy AWS cloud provider 2019-05-06 09:34:13 -07:00
danielqsj
bdd5c15dee refer to constant to guarantee constant behavior 2019-05-05 11:17:42 +08:00
Mike Fedosin
bac2291141 Allow to define kubeconfig file for OpenStack cloud provider 
Now, to build a kubernetes client, provider uses only in-cluster config,
but if kubelet is not running as a pod, then it doesn't work.

This commit adds an ability to specify a path to the kubeconfig file if
necessary. If no value was provided, then the provider falls back to
in-cluster config.
 2019-05-05 00:31:14 +02:00
caiweidong
62fe5fe7b8 add common func for NewAttacher and NewDetacher 2019-05-04 11:08:28 +08:00
caiweidong
5d89ab26e9 Add detacher assert for csiAttacher 2019-05-04 10:43:46 +08:00
Jordan Liggitt
63ddfc1db9 Lock GCERegionalPersistentDisk feature on 2019-05-03 14:21:34 -04:00
Humble Chirammal
427df38c6b Avoid duplicate error reporting in glusterfs 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-03 13:42:36 +05:30
Kubernetes Prow Robot
ca21efd1c5
Merge pull request #76983 from humblec/rotate 
Shuffle addresslist for random mount server and cleanup error messages.
 2019-05-03 01:02:47 -07:00
Humble Chirammal
745f12837f Rename createEndpointService() to createOrGetEndpointService() 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-02 21:06:54 +05:30
Kubernetes Prow Robot
b07f311322
Merge pull request #76882 from SataQiu/fix-golint-controller-20190422 
Fix golint failures of pkg/controller/certificates/approver, etc
 2019-05-02 03:16:18 -07:00
Kubernetes Prow Robot
9e52832c52
Merge pull request #77317 from gnufied/fix-block-volume-resizing 
Fix block volume expansion
 2019-05-01 20:42:56 -07:00
SataQiu
d76f1a8fd6 fix golint failures of pkg/volume/util/recyclerclient 2019-05-02 10:27:56 +08:00
Kubernetes Prow Robot
b5c34d0c43
Merge pull request #74734 from codenrhoden/move-mountspath 
Move MountsInGlobalPDPath from mount pkg to volume
 2019-05-01 17:28:18 -07:00
Hemant Kumar
0eb68c5a22 Fix blockvolume expansion 2019-05-01 18:25:54 -04:00
Kubernetes Prow Robot
2b561456ce
Merge pull request #77101 from davidz627/feature/migrationTest 
Add testing infra for checking whether an in-tree plugin is using backend that is shimmed to CSI
 2019-05-01 14:32:30 -07:00
David Zhu
1271237d23 Add migration metrics checking to all test suites 2019-05-01 11:24:03 -07:00
Humble Chirammal
a3c1a6da02 Error message corrections 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-01 13:36:52 +05:30
Kubernetes Prow Robot
9466118e8f
Merge pull request #77229 from tedyu/csi-node-expansion 
Return early when node expansion is determined
 2019-04-30 17:31:25 -07:00
Kubernetes Prow Robot
55a052481d
Merge pull request #76944 from SataQiu/fix-golint-volume-20190423 
Fix golint failures of pkg/volume/nfs
 2019-04-30 17:31:12 -07:00
Kubernetes Prow Robot
a69702e83a
Merge pull request #76755 from ping035627/k8s-190418 
delete some unused code for awsebs
 2019-04-30 07:05:39 -07:00
Ted Yu
ebe499ec80 Remove variable nodeExpandSet 2019-04-30 06:44:29 -07:00
Kubernetes Prow Robot
1a52d4f6fe
Merge pull request #76977 from jingxu97/April/volumelimit 
Update the dynamic volume limit in GCE PD
 2019-04-29 22:49:47 -07:00
Ted Yu
565c88de14 Return early when node expansion is determined 2019-04-29 14:05:08 -07:00
Travis Rhoden
78d109e201 Always use filepath.Join instead of path.Join 
This patch cleans up pkg/util/mount/* and pkg/util/volume/* to always
use filepath.Join instead of path.Join. filepath.Join is preferred
because path.Join can have issues on Windows.
 2019-04-29 09:56:05 -06:00
Travis Rhoden
12b7f1450c Move MountsInGlobalPDPath from mount pkg to volume 
Since pkg/util/mount is going to move out of k/k, this exported constant
that is Kubernetes specific needed to move somewhere else. Made sense to
move it to pkg/volume/util.

Update GetDeviceNameFromMount in the mount interface to now take a
pluginMountDir argument, which is volume plugin dir with the global
mount path appended to it already.
 2019-04-29 09:56:00 -06:00
Stephen Augustus
2f74c90480 Staging the legacy Azure Cloud Provider 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
 2019-04-25 20:03:45 -04:00
David Zhu
213cc99ead Operation generator migration metric fixes and test metrics retrieval code 2019-04-25 16:27:45 -07:00
Jing Xu
9926815246 Update the dynamic volume limit in GCE PD 
Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

Change-Id: Id9dfdbd24763b6b4138935842c246b1803838b78
 2019-04-25 11:08:19 -07:00
Kubernetes Prow Robot
88992ba185
Merge pull request #75986 from mucahitkurt/improvement/reduce-event-spam-for-GenerateAttachVolumeFunc 
Reduce event spam for function GenerateAttachVolumeFunc
 2019-04-24 18:12:44 -07:00
Kubernetes Prow Robot
e4a57b77ec
Merge pull request #76719 from bertinatto/fix_vsphere_size 
Fix Vsphere rouding up of volume size
 2019-04-24 16:50:46 -07:00
yameiwang
f130e48deb fix golint errors in pkg/volume/host_path 2019-04-25 06:46:47 +08:00
Kubernetes Prow Robot
2e96bf597e
Merge pull request #76988 from andyzhangx/azurefile-create 
specify azure file share name in azure file plugin
 2019-04-24 14:21:09 -07:00
Kubernetes Prow Robot
e53118df1b
Merge pull request #76945 from SataQiu/fix-golint-volume-2019042302 
Fix golint failures of pkg/volume/portworx
 2019-04-24 14:20:58 -07:00
Mucahit Kurt
1c1da755dc reduce event spam for function GenerateAttachVolumeFunc 
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
 2019-04-24 23:45:28 +03:00
andyzhangx
ad9d033e50 add shareName param in azure file storage class 
skip create azure file if it exists
 2019-04-24 05:48:58 +00:00
Humble Chirammal
f30b14a408 Shuffle addresslist for random mount server and cleanup error messages. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
 2019-04-24 09:08:15 +05:30
Andrew Sy Kim
a58942625d staging the vsphere cloud provider under k8s.io/legacy-cloud-providers/vsphere 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2019-04-23 22:17:59 -05:00
SataQiu
a37adceadf fix golint failures of pkg/volume/portworx 2019-04-23 23:26:41 +08:00
SataQiu
d6d329b0eb fix golint failures of pkg/volume/nfs 2019-04-23 22:25:46 +08:00
Shintaro Murakami
f8e81337da Do not generate unnecessary goroutine 2019-04-23 16:22:14 +09:00
Kubernetes Prow Robot
b9606bef8d
Merge pull request #76860 from SataQiu/fix-golint-volume-20190420 
Fix golint failures of pkg/volume/local
 2019-04-22 20:44:07 -07:00
Pengfei Ni
c27ff9a11e Upgrade compute API to version 2019-03-01 2019-04-21 18:12:29 +08:00
SataQiu
1f40880615 fix golint failures of pkg/volume/local 2019-04-20 18:18:25 +08:00
Kubernetes Prow Robot
29163600fe
Merge pull request #76796 from dims/remove-unused-methods 
Remove unused code
 2019-04-19 11:09:55 -07:00
Davanum Srinivas
7b8c9acc09
remove unused code 
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
 2019-04-19 08:36:31 -04:00
Kubernetes Prow Robot
64a0441c2b
Merge pull request #76573 from andyzhangx/disk-backoff-refactor 
fix detach azure disk back off issue which has too big lock in failure retry condition
 2019-04-18 23:39:54 -07:00
Kubernetes Prow Robot
10fc2a11a0
Merge pull request #76089 from vladimirvivien/csi-device-mount-skip 
CSI - Skips deviceMounter.MountDevice for ephemeral volumes
 2019-04-18 19:36:09 -07:00
Kubernetes Prow Robot
fc545587e4
Merge pull request #76540 from ialidzhikov/glusterfs-uneffectual-assignment 
Remove ineffectual assignment
 2019-04-18 17:17:55 -07:00
Vladimir Vivien
d564d2e74d CSI - Prevents unsupported device mount with CanMountDevice(spec) check 2019-04-18 19:54:28 -04:00
Davanum Srinivas
22ffdc6063
typo - extra space - in Fatalf format string 
Change-Id: Ifeff0ee29aa6ccdc4c3ebdd2a071cebfafaf937e
 2019-04-18 14:42:21 -04:00
PingWang
64c84aa610 delete some unused code for awsebs 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
 2019-04-18 16:51:29 +08:00
Kubernetes Prow Robot
7e02769736
Merge pull request #75926 from cwdsuzhou/operation_generator_add_attach_detach 
Add operation name for other volume operations
 2019-04-18 00:26:08 -07:00
Kubernetes Prow Robot
32a49828fe
Merge pull request #76456 from codenrhoden/mv-exec-mounter 
Move ExecMount to pkg/volume/util/exec
 2019-04-17 12:16:20 -07:00
Fabio Bertinatto
c2fc91adc7 Fix rounding-up of Vsphere volume size 2019-04-17 14:56:39 +02:00
Humble Chirammal
c86828b74b Cleanup volume, ep/svc if endpoint update failed. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-04-16 11:50:42 +05:30
andyzhangx
6c70ca61be move disk lock process to azure cloud provider 
fix comments

fix import keymux check error

add unit test for attach/detach disk funcs
 2019-04-16 05:31:18 +00:00
Kubernetes Prow Robot
d424bedc9b
Merge pull request #76341 from harsh-px/fix-concurrent-access-master 
Fix concurrent map write access in Portworx create volume call
 2019-04-15 11:46:24 -07:00
ialidzhikov
98c976ae4f Clean ineffectual assignment 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2019-04-13 16:23:07 +03:00
andyzhangx
39c239c308 refactor detach azure disk retry operation 2019-04-13 12:45:32 +00:00
Vladimir Vivien
b138e6d1e2 CSI - Surfaces klog flags; common tests aggregation 2019-04-12 15:38:06 -04:00
caiweidong
7c9e567008 add operation name for other volume operations 2019-04-12 11:09:13 +08:00
Travis Rhoden
96476fd054 Fix linting issues for exec mounter 2019-04-11 13:22:14 -06:00
Travis Rhoden
f38d4938be Move ExecMount to pkg/volume/util/exec 
This patch moves the ExecMounter found in pkg/util/mount to
pkg/volume/util/exec. This is done in preparation for pkg/util/mount to
move out of tree. This specific implemention of mount.Interface is only
used internally to K8s and does not need to move out of tree.
 2019-04-11 12:19:55 -06:00
Humble Chirammal
58e65c053a Resolve merge conflict 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-04-10 20:51:02 +05:30
Humble Chirammal
7544b53693 Create endpoint/service early to avoid unwanted create/delete volume transaction. 
At times, for some reason endpoint/service creation can fail in a setup. As we
currently create endpoint/service after volume creation, later we need rollback
of this volume transaction if endpoint/service creation failed. Considering
endpoint/service creation is light weight, this patch promote endpoint/service
creation to an early stage.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-04-10 19:06:27 +05:30
qingsenLi
f0cef5bd36 fix error 'coresponding' 2019-04-10 17:43:35 +08:00
Kubernetes Prow Robot
a2c200a57a
Merge pull request #76326 from andyzhangx/azuredisk-typo 
fix typo in azure disk logging
 2019-04-09 19:58:12 -07:00
Harsh Desai
17dd5989df Fix concurrent map access in Portworx create volume call 
Fixes #76340

Signed-off-by: Harsh Desai <harsh@portworx.com>
 2019-04-09 12:13:19 -07:00
Kubernetes Prow Robot
454666bca8
Merge pull request #76184 from humblec/pvc 
Use pvc uid in endpoint/service label
 2019-04-09 11:21:14 -07:00
Kubernetes Prow Robot
c62cd6e3a4
Merge pull request #76047 from codenrhoden/mv-nsenter-mount 
Move nsenter mounter to pkg/volume/util/nsenter
 2019-04-09 09:55:59 -07:00
andyzhangx
8d1578370a fix typo in azure disk logging 2019-04-09 09:01:52 +00:00
Vladimir Vivien
cfafde983b Volume AttachablePlugin.CanAttach() now returns both bool and error 2019-04-08 16:53:22 -04:00
Travis Rhoden
2253807760 Fix pkg/volume/util/nsenter linting errors 2019-04-08 10:43:54 -06:00